107967 2013-01-25 11:26:41 -0800 Deleting a button and typing text afterwards applies wrong styling to the typed text 2022-11-17 12:22:41 -0800 1 1 1 Unclassified WebKit HTML Editing 420+ PC All NEW P2 Normal --- 1 andrew.fedoniouk webkit-unassigned ahmad.saleem792 arpitabahuguna rniwa wesley oldest_to_newest 816781 0 184779 andrew.fedoniouk 2013-01-25 11:26:41 -0800 Created attachment 184779 Minimal example to reproduce the issue. Minimal reproducible markup: <div contenteditable> <div>The <input type=button value=button></div> </div> Steps to reproduce: 1. Position caret after the button. 2. Hit {BACKSPACE} to delete the button. 3. Without moving the caret type something at caret location. Note: the text typed is incorrectly wrapped into &lt;span style="white-space:pre;font:..."> and its container gets text-align:center style. Use attached document to reproduce it. 861379 1 wesley 2013-03-22 05:45:28 -0700 I second this. It is something I have been trying to deal with for quite a long time now. Additionally, any font styles that the button had will be copied over into the span tag that will appear. So for example, if your button had white text and you remove that button, any text you will type afterwards will be white as well. 924785 2 arpitabahuguna 2013-09-04 23:00:20 -0700 This has already been fixed in Chrome: http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/DeleteSelectionCommand.cpp?r1=154066&r2=154067& Probably we need to merge these changes. 924788 3 rniwa 2013-09-04 23:04:48 -0700 The fix in Blink is wrong. There is nothing wrong for an anchor element to be an input element. EditingStyle::create needs to be aware of non-legacy Position and obtain the style at the parent of the input element in such a case. 1904226 4 ahmad.saleem792 2022-10-08 00:13:18 -0700 I think Safari Technology Preview 154 have this fix: https://github.com/WebKit/WebKit/commit/c75ccbd4e966b91f06494b79f42403fe3a0bcafb 1904400 5 rniwa 2022-10-09 17:18:19 -0700 The bug still reproduces in STP. 1913258 6 ahmad.saleem792 2022-11-17 12:22:41 -0800 I tried to fix this bug in below PR: Link - https://github.com/WebKit/WebKit/pull/5995 But after discussions with rniwa, I am going to close it and document approach here: __________ 1) Doing 1-1 Blink merge works and it compile but it is not desirable result because of Comment 03 as highlighted. 2) While trying to do it as per rniwa guidance in PR, we get following test failures: editing/deleting/maintain-style-after-delete.html editing/execCommand/underline-selection-containing-image.html, editing/style/5084241.html editing/style/background-color-retained.html editing/style/style-3681552-fix-002.html ____ 1) maintain-style-after-delete.html - we lose font color and span of caret color and this behavior matches with Firefox Nightly 109. Link - https://jsfiddle.net/3Lbw76a4/show 2) underline-selection-containing-image.html - we get new Console Error message "CONSOLE MESSAGE: TypeError: null is not an object (evaluating 'document.querySelector("U").textContent')" - losing styling as intended and get similar behavior to chrome in test case. Link - https://jsfiddle.net/76n3rjf8/ (Look at console error of Chrome) 3) editing/style/5084241.html - We match with Firefox here and loss "Red" font color from the first line of text here. 4) background-color-retained.html - We match with Firefox here and loss "background" color from the text after deletion. Link - https://jsfiddle.net/Lzx97c5u/ 5) style-3681552-fix-002.html - We don't match any browser after this change and we loss italic styling of "xxx" and it can be interop issue. Although, Chrome does not have this test anymore based on search from source.chromium.org. _______ These are findings based on PR and any failure into it. 184779 2013-01-25 11:26:41 -0800 2013-01-25 11:26:41 -0800 Minimal example to reproduce the issue. webkit-bug.htm text/html 420 andrew.fedoniouk PGh0bWw+DQo8Ym9keT4NCg0KPGRpdiBjb250ZW50ZWRpdGFibGU+DQogIDxkaXY+VGhlIDxpbnB1 dCB0eXBlPWJ1dHRvbiB2YWx1ZT1idXR0b24+PC9kaXY+DQo8L2Rpdj4NCjxvbD4NCiAgPGxpPlBv c2l0aW9uIGNhcmV0IGFmdGVyIHRoZSBidXR0b24uPC9saT4NCiAgPGxpPkhpdCB7QkFDS1NQQUNF fSB0byBkZWxldGUgdGhlIGJ1dHRvbi48L2xpPg0KICA8bGk+VHlwZSBzb21ldGhpbmcgYXQgY2Fy ZXQgbG9jYXRpb248L2xpPg0KICA8bGk+Tm90ZTogdGhlIHRleHQgdHlwZWQgaXMgaW5jb3JyZWN0 bHkgd3JhcHBlZCBpbnRvICZsdDtzcGFuIHN0eWxlPSJ3aGl0ZS1zcGFjZTpwcmU7Zm9udDouLi4i PiBhbmQgaXRzIGNvbnRhaW5lciBnZXRzIHRleHQtYWxpZ246Y2VudGVyIHN0eWxlLg0KPC9vbD4N Cg0KPC9ib2R5Pg0KPC9odG1sPg0K