107950 2013-01-25 07:13:21 -0800 [Qt][WK1] Reflect recursion limit and loop checks also for list conversions. 2013-01-29 01:43:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 michael.bruning michael.bruning allan.jensen hausmann webkit.review.bot oldest_to_newest 816570 0 michael.bruning 2013-01-25 07:13:21 -0800 [Qt][WK1] Reflect recursion limit and loop checks als for list conversions. 816578 1 184747 michael.bruning 2013-01-25 07:19:31 -0800 Created attachment 184747 Patch 816581 2 webkit.review.bot 2013-01-25 07:26:12 -0800 Attachment 184747 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bridge/qt/qt_runtime.cpp']" exit_code: 1 Source/WebCore/bridge/qt/qt_runtime.cpp:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 818712 3 184747 allan.jensen 2013-01-29 01:34:23 -0800 Comment on attachment 184747 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184747&action=review Good catch. Lists and objects need to be tracked. > Source/WebCore/ChangeLog:3 > + [Qt][WK1] Reflect recursion limit and loop checks als for list conversions. typo: als->also 818714 4 184747 allan.jensen 2013-01-29 01:34:47 -0800 Comment on attachment 184747 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184747&action=review Good catch. Lists and objects need to be tracked. > Source/WebCore/ChangeLog:3 > + [Qt][WK1] Reflect recursion limit and loop checks als for list conversions. typo: als->also 818724 5 michael.bruning 2013-01-29 01:43:16 -0800 Committed r141085: <http://trac.webkit.org/changeset/141085> 184747 2013-01-25 07:19:31 -0800 2013-01-29 01:34:47 -0800 Patch bug-107950-20130125161621.patch text/plain 4903 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTliZTRjNDU4MGYzNWEy OGZlYTkwYjM2ZGVlOTk5NmEwMDU1MGQ5ZS4uNjU3ZWNmOGY2Mzc4NTEwMzdkYjljYWU3OWY3NGQ5 NzhhOTRjMmQ3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAxLTI1ICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRd W1dLMV0gUmVmbGVjdCByZWN1cnNpb24gbGltaXQgYW5kIGxvb3AgY2hlY2tzIGFscyBmb3IgbGlz dCBjb252ZXJzaW9ucy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNzk1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgYnVnZml4LCBubyBiZWhhdmlvcmFsIGNoYW5nZS4KKworICAg ICAgICBNYWtlIGNvbnZlcnNpb25zIGZyb20gSmF2YXNjcmlwdCB2YWx1ZXMgdG8gUUxpc3RzIHRh a2UgdGhlIG1heGltdW0KKyAgICAgICAgcmVjdXJzaW9uIGRlcHRoIGludG8gY29uc2lkZXJhdGlv biBhbmQgY2hlY2sgZm9yIG9iamVjdHMgdGhhdCB3ZXJlCisgICAgICAgIGFscmVhZHkgdmlzaXRl ZC4gT3RoZXJ3aXNlLCB0aGUgY29udmVyc2lvbiBtYXkgcmVjdXJzZSB1bnRpbCB0aGUKKyAgICAg ICAgc3RhY2sgaXMgZnVsbCBhbmQgdGhlbiBjYXVzZSBhIHNlZ21lbnRhdGlvbiBmYXVsdC4KKwor ICAgICAgICAqIGJyaWRnZS9xdC9xdF9ydW50aW1lLmNwcDoKKyAgICAgICAgKEpTQzo6QmluZGlu Z3M6OmNvbnZlcnRUb0xpc3QpOgorICAgICAgICAoSlNDOjpCaW5kaW5nczo6Y29udmVydFZhbHVl VG9RVmFyaWFudCk6CisKIDIwMTMtMDEtMjQgIEthaSBLb2VobmUgIDxrYWkua29laG5lQGRpZ2lh LmNvbT4KIAogICAgICAgICBbUXRdIFdlYmtpdCBkZWJ1ZyBidWlsZCBsaW5rcyBhZ2FpbnN0IHJl bGVhc2UgYmluYXJpZXMgb2YgQU5HTEUgbGliRUdMLCBsaWJHTEVTdjIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50aW1lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Jy aWRnZS9xdC9xdF9ydW50aW1lLmNwcAppbmRleCBlMmNhNDY1ZGVkNmI5ZDYzZTM4YzFlMTJjMDM1 NWY4M2RmY2M4NGRhLi4yOTQzYjAxNGNhN2RkMTMzNTMyMWE1MzlhMWM2MzRjMmY4NTBmOTU0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcnVudGltZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwCkBAIC0yMzYsNyArMjM2LDcg QEAgc3RhdGljIFFWYXJpYW50TWFwIGNvbnZlcnRWYWx1ZVRvUVZhcmlhbnRNYXAoSlNDb250ZXh0 UmVmIGNvbnRleHQsIEpTT2JqZWN0UmVmIG8KIAogdGVtcGxhdGUgPHR5cGVuYW1lIEl0ZW1UeXBl PgogUUxpc3Q8SXRlbVR5cGU+IGNvbnZlcnRUb0xpc3QoSlNDb250ZXh0UmVmIGNvbnRleHQsIEpT UmVhbFR5cGUgdHlwZSwgSlNPYmplY3RSZWYgb2JqZWN0LAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgSlNWYWx1ZVJlZiB2YWx1ZSwgaW50KiBkaXN0YW5jZSwgSlNWYWx1ZVJlZiogZXhj ZXB0aW9uLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSlNWYWx1ZVJlZiB2YWx1ZSwg aW50KiBkaXN0YW5jZSwgSGFzaFNldDxKU09iamVjdFJlZj4qIHZpc2l0ZWRPYmplY3RzLCBpbnQg cmVjdXJzaW9uTGltaXQsIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbiwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNvbnN0IFFNZXRhVHlwZTo6VHlwZSB0eXBlSWQgPSBzdGF0aWNfY2FzdDxR TWV0YVR5cGU6OlR5cGU+KHFNZXRhVHlwZUlkPEl0ZW1UeXBlPigpKSkKIHsKICAgICBRTGlzdDxJ dGVtVHlwZT4gbGlzdDsKQEAgLTI0OCw3ICsyNDgsNyBAQCBRTGlzdDxJdGVtVHlwZT4gY29udmVy dFRvTGlzdChKU0NvbnRleHRSZWYgY29udGV4dCwgSlNSZWFsVHlwZSB0eXBlLCBKU09iamVjdFJl ZgogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGxlbmd0aDsgKytpKSB7CiAgICAgICAg ICAgICBKU1ZhbHVlUmVmIHZhbHVlID0gSlNPYmplY3RHZXRQcm9wZXJ0eUF0SW5kZXgoY29udGV4 dCwgb2JqZWN0LCBpLCBleGNlcHRpb24pOwogICAgICAgICAgICAgaW50IGl0ZW1EaXN0YW5jZSA9 IC0xOwotICAgICAgICAgICAgUVZhcmlhbnQgdmFyaWFudCA9IGNvbnZlcnRWYWx1ZVRvUVZhcmlh bnQoY29udGV4dCwgdmFsdWUsIHR5cGVJZCwgJml0ZW1EaXN0YW5jZSwgZXhjZXB0aW9uKTsKKyAg ICAgICAgICAgIFFWYXJpYW50IHZhcmlhbnQgPSBjb252ZXJ0VmFsdWVUb1FWYXJpYW50KGNvbnRl eHQsIHZhbHVlLCB0eXBlSWQsICZpdGVtRGlzdGFuY2UsIHZpc2l0ZWRPYmplY3RzLCByZWN1cnNp b25MaW1pdCwgZXhjZXB0aW9uKTsKICAgICAgICAgICAgIGlmIChpdGVtRGlzdGFuY2UgPj0gMCkK ICAgICAgICAgICAgICAgICBsaXN0IDw8IHZhcmlhbnQudmFsdWU8SXRlbVR5cGU+KCk7CiAgICAg ICAgICAgICBlbHNlCkBAIC0yNjAsNyArMjYwLDcgQEAgUUxpc3Q8SXRlbVR5cGU+IGNvbnZlcnRU b0xpc3QoSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTUmVhbFR5cGUgdHlwZSwgSlNPYmplY3RSZWYK ICAgICAgICAgICAgICpkaXN0YW5jZSA9IDU7CiAgICAgfSBlbHNlIHsKICAgICAgICAgaW50IGl0 ZW1EaXN0YW5jZSA9IC0xOwotICAgICAgICBRVmFyaWFudCB2YXJpYW50ID0gY29udmVydFZhbHVl VG9RVmFyaWFudChjb250ZXh0LCB2YWx1ZSwgdHlwZUlkLCAmaXRlbURpc3RhbmNlLCBleGNlcHRp b24pOworICAgICAgICBRVmFyaWFudCB2YXJpYW50ID0gY29udmVydFZhbHVlVG9RVmFyaWFudChj b250ZXh0LCB2YWx1ZSwgdHlwZUlkLCAmaXRlbURpc3RhbmNlLCB2aXNpdGVkT2JqZWN0cywgcmVj dXJzaW9uTGltaXQsIGV4Y2VwdGlvbik7CiAgICAgICAgIGlmIChpdGVtRGlzdGFuY2UgPj0gMCkg ewogICAgICAgICAgICAgbGlzdCA8PCB2YXJpYW50LnZhbHVlPEl0ZW1UeXBlPigpOwogICAgICAg ICAgICAgaWYgKGRpc3RhbmNlKQpAQCAtNDgxLDExICs0ODEsMTEgQEAgUVZhcmlhbnQgY29udmVy dFZhbHVlVG9RVmFyaWFudChKU0NvbnRleHRSZWYgY29udGV4dCwgSlNWYWx1ZVJlZiB2YWx1ZSwg UU1ldGFUeXAKICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgIGNhc2UgUU1ldGFUeXBlOjpR VmFyaWFudExpc3Q6Ci0gICAgICAgICAgICByZXQgPSBRVmFyaWFudChjb252ZXJ0VG9MaXN0PFFW YXJpYW50Pihjb250ZXh0LCB0eXBlLCBvYmplY3QsIHZhbHVlLCAmZGlzdCwgZXhjZXB0aW9uLCBR TWV0YVR5cGU6OlZvaWQpKTsKKyAgICAgICAgICAgIHJldCA9IFFWYXJpYW50KGNvbnZlcnRUb0xp c3Q8UVZhcmlhbnQ+KGNvbnRleHQsIHR5cGUsIG9iamVjdCwgdmFsdWUsICZkaXN0LCB2aXNpdGVk T2JqZWN0cywgcmVjdXJzaW9uTGltaXQsIGV4Y2VwdGlvbiwgUU1ldGFUeXBlOjpWb2lkKSk7CiAg ICAgICAgICAgICBicmVhazsKIAogICAgICAgICBjYXNlIFFNZXRhVHlwZTo6UVN0cmluZ0xpc3Q6 IHsKLSAgICAgICAgICAgIHJldCA9IFFWYXJpYW50KGNvbnZlcnRUb0xpc3Q8UVN0cmluZz4oY29u dGV4dCwgdHlwZSwgb2JqZWN0LCB2YWx1ZSwgJmRpc3QsIGV4Y2VwdGlvbikpOworICAgICAgICAg ICAgcmV0ID0gUVZhcmlhbnQoY29udmVydFRvTGlzdDxRU3RyaW5nPihjb250ZXh0LCB0eXBlLCBv YmplY3QsIHZhbHVlLCAmZGlzdCwgdmlzaXRlZE9iamVjdHMsIHJlY3Vyc2lvbkxpbWl0LCBleGNl cHRpb24pKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKQEAgLTYxNiwxMSArNjE2 LDExIEBAIFFWYXJpYW50IGNvbnZlcnRWYWx1ZVRvUVZhcmlhbnQoSlNDb250ZXh0UmVmIGNvbnRl eHQsIEpTVmFsdWVSZWYgdmFsdWUsIFFNZXRhVHlwCiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAg ICAgICAvLyBOb24gY29uc3QgdHlwZSBpZHMKICAgICAgICAgICAgIGlmIChoaW50ID09IChRTWV0 YVR5cGU6OlR5cGUpIHFNZXRhVHlwZUlkPFFPYmplY3RMaXN0PigpKSB7Ci0gICAgICAgICAgICAg ICAgcmV0ID0gUVZhcmlhbnQ6OmZyb21WYWx1ZShjb252ZXJ0VG9MaXN0PFFPYmplY3QqPihjb250 ZXh0LCB0eXBlLCBvYmplY3QsIHZhbHVlLCAmZGlzdCwgZXhjZXB0aW9uKSk7CisgICAgICAgICAg ICAgICAgcmV0ID0gUVZhcmlhbnQ6OmZyb21WYWx1ZShjb252ZXJ0VG9MaXN0PFFPYmplY3QqPihj b250ZXh0LCB0eXBlLCBvYmplY3QsIHZhbHVlLCAmZGlzdCwgdmlzaXRlZE9iamVjdHMsIHJlY3Vy c2lvbkxpbWl0LCBleGNlcHRpb24pKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAg ICAgIH0KICAgICAgICAgICAgIGlmIChoaW50ID09IChRTWV0YVR5cGU6OlR5cGUpIHFNZXRhVHlw ZUlkPFFMaXN0PGludD4gPigpKSB7Ci0gICAgICAgICAgICAgICAgcmV0ID0gUVZhcmlhbnQ6OmZy b21WYWx1ZShjb252ZXJ0VG9MaXN0PGludD4oY29udGV4dCwgdHlwZSwgb2JqZWN0LCB2YWx1ZSwg JmRpc3QsIGV4Y2VwdGlvbikpOworICAgICAgICAgICAgICAgIHJldCA9IFFWYXJpYW50Ojpmcm9t VmFsdWUoY29udmVydFRvTGlzdDxpbnQ+KGNvbnRleHQsIHR5cGUsIG9iamVjdCwgdmFsdWUsICZk aXN0LCB2aXNpdGVkT2JqZWN0cywgcmVjdXJzaW9uTGltaXQsIGV4Y2VwdGlvbikpOwogICAgICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgaWYgKFF0UGl4bWFw UnVudGltZTo6Y2FuSGFuZGxlKHN0YXRpY19jYXN0PFFNZXRhVHlwZTo6VHlwZT4oaGludCkpKSB7 Cg==