107946 2013-01-25 06:40:56 -0800 Web Inspector: Cleanup console.* API MessageSource/Levels. 2013-01-25 08:32:41 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED WebExposed P2 Normal --- 1 mkwst mkwst apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 816552 0 mkwst 2013-01-25 06:40:56 -0800 I have a few suggestions: * console.timeEnd and console.count should both come from ConsoleAPIMessageSource. * console.count should be DebugMessageLevel (to match console.timeEnd) * console.profile and console.profileEnd should come from ConsoleAPIMessageSource, and be DebugMessageLevel 816566 1 184745 mkwst 2013-01-25 07:06:52 -0800 Created attachment 184745 Patch 816614 2 184745 mkwst 2013-01-25 08:27:08 -0800 Comment on attachment 184745 Patch Thanks, Pavel. 816620 3 184745 webkit.review.bot 2013-01-25 08:32:38 -0800 Comment on attachment 184745 Patch Clearing flags on attachment: 184745 Committed r140830: <http://trac.webkit.org/changeset/140830> 816621 4 webkit.review.bot 2013-01-25 08:32:41 -0800 All reviewed patches have been landed. Closing bug. 184745 2013-01-25 07:06:52 -0800 2013-01-25 08:32:38 -0800 Patch bug-107946-20130125160343.patch text/plain 6371 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWM5MzMxNDZmOTc0M2I4 NGZmOTdmN2QxYzc4NTYxOTY5MWM3YzMwYy4uNDViM2IzNjQ0MTRlMjFjMDZkNDg3ZGRkMmRiNTVh ZmI5NDA5NmY2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTAxLTI1ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xl YW51cCBjb25zb2xlLiogQVBJIE1lc3NhZ2VTb3VyY2UvTGV2ZWxzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3OTQ2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBkb2VzIHNvbWUgbGln aHQgY2xlYW51cCBvbiBzb3VyY2VzIGFuZCBsZXZlbHMgb2YgY29uc29sZS4qCisgICAgICAgIG1l c3NhZ2VzIGFzIHBhcnQgb2YgYSBicm9hZGVyIGVmZm9ydCB0byBvZmZlciBiZXR0ZXIgZmlsdGVy aW5nIG9wdGlvbnMKKyAgICAgICAgaW4gdGhlIGNvbnNvbGUuIFNwZWNpZmljYWxseToKKworICAg ICAgICAtICAgY29uc29sZS50aW1lRW5kIGFuZCBjb25zb2xlLmNvdW50IG5vdyBjb21lIGZyb20K KyAgICAgICAgICAgIENvbnNvbGVBUElNZXNzYWdlU291cmNlLgorICAgICAgICAtICAgY29uc29s ZS5jb3VudCBpcyBub3cgRGVidWdNZXNzYWdlTGV2ZWwgKHRvIG1hdGNoIGNvbnNvbGUudGltZUVu ZCkuCisgICAgICAgIC0gICBjb25zb2xlLnByb2ZpbGUgYW5kIGNvbnNvbGUucHJvZmlsZUVuZCBu b3cgY29tciBmcm9tCisgICAgICAgICAgICBDb25zb2xlQVBJTWVzc2FnZVNvdXJjZSwgYW5kIGFy ZSBEZWJ1Z01lc3NhZ2VMZXZlbC4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb25z b2xlQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29uc29sZUFnZW50Ojpz dG9wVGltaW5nKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnNvbGVBZ2VudDo6Y291 bnQpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JQcm9maWxlckFnZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclByb2ZpbGVyQWdlbnQ6OmFkZFByb2ZpbGVGaW5pc2hl ZE1lc3NhZ2VUb0NvbnNvbGUpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yUHJvZmlsZXJB Z2VudDo6YWRkU3RhcnRQcm9maWxpbmdNZXNzYWdlVG9Db25zb2xlKToKKwogMjAxMy0wMS0yNSAg S2VuIEthbmlhICA8a2thbmlhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBNb3ZlIGRpc3BhdGNoTW91c2VFdmVudCBvcHRpb25hbCBwYXJhbXMgYWZ0ZXIgeCx5CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb25zb2xlQWdlbnQuY3BwCmlu ZGV4IGM5OGU1Zjc4N2M5ODlmZjBlM2Q2ZjY0MzZiNzE3Mjc5ZGQ5YjFhYTkuLjBlNmU1OTMzNzcw YzM3YmViZGZlZGY2Mzc0NmI2MDZiNDI3YzBmZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JDb25zb2xlQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JDb25zb2xlQWdlbnQuY3BwCkBAIC0yMjYsNyArMjI2LDcgQEAg dm9pZCBJbnNwZWN0b3JDb25zb2xlQWdlbnQ6OnN0b3BUaW1pbmcoY29uc3QgU3RyaW5nJiB0aXRs ZSwgUGFzc1JlZlB0cjxTY3JpcHRDYWwKICAgICBkb3VibGUgZWxhcHNlZCA9IG1vbm90b25pY2Fs bHlJbmNyZWFzaW5nVGltZSgpIC0gc3RhcnRUaW1lOwogICAgIFN0cmluZyBtZXNzYWdlID0gdGl0 bGUgKyBTdHJpbmc6OmZvcm1hdCgiOiAlLjNmbXMiLCBlbGFwc2VkICogMTAwMCk7CiAgICAgY29u c3QgU2NyaXB0Q2FsbEZyYW1lJiBsYXN0Q2FsbGVyID0gY2FsbFN0YWNrLT5hdCgwKTsKLSAgICBh ZGRNZXNzYWdlVG9Db25zb2xlKEpTTWVzc2FnZVNvdXJjZSwgVGltaW5nTWVzc2FnZVR5cGUsIERl YnVnTWVzc2FnZUxldmVsLCBtZXNzYWdlLCBsYXN0Q2FsbGVyLnNvdXJjZVVSTCgpLCBsYXN0Q2Fs bGVyLmxpbmVOdW1iZXIoKSk7CisgICAgYWRkTWVzc2FnZVRvQ29uc29sZShDb25zb2xlQVBJTWVz c2FnZVNvdXJjZSwgVGltaW5nTWVzc2FnZVR5cGUsIERlYnVnTWVzc2FnZUxldmVsLCBtZXNzYWdl LCBsYXN0Q2FsbGVyLnNvdXJjZVVSTCgpLCBsYXN0Q2FsbGVyLmxpbmVOdW1iZXIoKSk7CiB9CiAK IHZvaWQgSW5zcGVjdG9yQ29uc29sZUFnZW50Ojpjb3VudChTY3JpcHRTdGF0ZSogc3RhdGUsIFBh c3NSZWZQdHI8U2NyaXB0QXJndW1lbnRzPiBhcmd1bWVudHMpCkBAIC0yNTEsNyArMjUxLDcgQEAg dm9pZCBJbnNwZWN0b3JDb25zb2xlQWdlbnQ6OmNvdW50KFNjcmlwdFN0YXRlKiBzdGF0ZSwgUGFz c1JlZlB0cjxTY3JpcHRBcmd1bWVudHMKICAgICBtX2NvdW50cy5hZGQoaWRlbnRpZmllciwgY291 bnQpOwogCiAgICAgU3RyaW5nIG1lc3NhZ2UgPSB0aXRsZSArICI6ICIgKyBTdHJpbmc6Om51bWJl cihjb3VudCk7Ci0gICAgYWRkTWVzc2FnZVRvQ29uc29sZShKU01lc3NhZ2VTb3VyY2UsIExvZ01l c3NhZ2VUeXBlLCBMb2dNZXNzYWdlTGV2ZWwsIG1lc3NhZ2UsIGNhbGxTdGFjayk7CisgICAgYWRk TWVzc2FnZVRvQ29uc29sZShDb25zb2xlQVBJTWVzc2FnZVNvdXJjZSwgTG9nTWVzc2FnZVR5cGUs IERlYnVnTWVzc2FnZUxldmVsLCBtZXNzYWdlLCBjYWxsU3RhY2spOwogfQogCiB2b2lkIEluc3Bl Y3RvckNvbnNvbGVBZ2VudDo6ZnJhbWVXaW5kb3dEaXNjYXJkZWQoRE9NV2luZG93KiB3aW5kb3cp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUHJvZmlsZXJB Z2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUHJvZmlsZXJBZ2Vu dC5jcHAKaW5kZXggZjBjN2NkNmE2ZGI0ODJmYzUwZjFkMjAzMmZmY2E5ZTQwNDBlMDA0MS4uOThi NWQ3YjViYjJkMTUyNjNmZmIxOWRhMGYzNGMxMDAzNzNjMmQwNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclByb2ZpbGVyQWdlbnQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQcm9maWxlckFnZW50LmNwcApAQCAtMTY2LDcg KzE2Niw3IEBAIHZvaWQgSW5zcGVjdG9yUHJvZmlsZXJBZ2VudDo6YWRkUHJvZmlsZUZpbmlzaGVk TWVzc2FnZVRvQ29uc29sZShQYXNzUmVmUHRyPFNjcmlwCiAgICAgUmVmUHRyPFNjcmlwdFByb2Zp bGU+IHByb2ZpbGUgPSBwcnBQcm9maWxlOwogICAgIFN0cmluZyB0aXRsZSA9IHByb2ZpbGUtPnRp dGxlKCk7CiAgICAgU3RyaW5nIG1lc3NhZ2UgPSBtYWtlU3RyaW5nKCJQcm9maWxlIFwid2Via2l0 LXByb2ZpbGU6Ly8iLCBDUFVQcm9maWxlVHlwZSwgJy8nLCBlbmNvZGVXaXRoVVJMRXNjYXBlU2Vx dWVuY2VzKHRpdGxlKSwgJyMnLCBTdHJpbmc6Om51bWJlcihwcm9maWxlLT51aWQoKSksICJcIiBm aW5pc2hlZC4iKTsKLSAgICBtX2NvbnNvbGVBZ2VudC0+YWRkTWVzc2FnZVRvQ29uc29sZShKU01l c3NhZ2VTb3VyY2UsIExvZ01lc3NhZ2VUeXBlLCBMb2dNZXNzYWdlTGV2ZWwsIG1lc3NhZ2UsIHNv dXJjZVVSTCwgbGluZU51bWJlcik7CisgICAgbV9jb25zb2xlQWdlbnQtPmFkZE1lc3NhZ2VUb0Nv bnNvbGUoQ29uc29sZUFQSU1lc3NhZ2VTb3VyY2UsIExvZ01lc3NhZ2VUeXBlLCBEZWJ1Z01lc3Nh Z2VMZXZlbCwgbWVzc2FnZSwgc291cmNlVVJMLCBsaW5lTnVtYmVyKTsKIH0KIAogdm9pZCBJbnNw ZWN0b3JQcm9maWxlckFnZW50OjphZGRTdGFydFByb2ZpbGluZ01lc3NhZ2VUb0NvbnNvbGUoY29u c3QgU3RyaW5nJiB0aXRsZSwgdW5zaWduZWQgbGluZU51bWJlciwgY29uc3QgU3RyaW5nJiBzb3Vy Y2VVUkwpCkBAIC0xNzQsNyArMTc0LDcgQEAgdm9pZCBJbnNwZWN0b3JQcm9maWxlckFnZW50Ojph ZGRTdGFydFByb2ZpbGluZ01lc3NhZ2VUb0NvbnNvbGUoY29uc3QgU3RyaW5nJiB0aXQKICAgICBp ZiAoIW1fZnJvbnRlbmQpCiAgICAgICAgIHJldHVybjsKICAgICBTdHJpbmcgbWVzc2FnZSA9IG1h a2VTdHJpbmcoIlByb2ZpbGUgXCJ3ZWJraXQtcHJvZmlsZTovLyIsIENQVVByb2ZpbGVUeXBlLCAn LycsIGVuY29kZVdpdGhVUkxFc2NhcGVTZXF1ZW5jZXModGl0bGUpLCAiIzBcIiBzdGFydGVkLiIp OwotICAgIG1fY29uc29sZUFnZW50LT5hZGRNZXNzYWdlVG9Db25zb2xlKEpTTWVzc2FnZVNvdXJj ZSwgTG9nTWVzc2FnZVR5cGUsIExvZ01lc3NhZ2VMZXZlbCwgbWVzc2FnZSwgc291cmNlVVJMLCBs aW5lTnVtYmVyKTsKKyAgICBtX2NvbnNvbGVBZ2VudC0+YWRkTWVzc2FnZVRvQ29uc29sZShDb25z b2xlQVBJTWVzc2FnZVNvdXJjZSwgTG9nTWVzc2FnZVR5cGUsIERlYnVnTWVzc2FnZUxldmVsLCBt ZXNzYWdlLCBzb3VyY2VVUkwsIGxpbmVOdW1iZXIpOwogfQogCiB2b2lkIEluc3BlY3RvclByb2Zp bGVyQWdlbnQ6OmNvbGxlY3RHYXJiYWdlKFdlYkNvcmU6OkVycm9yU3RyaW5nKikKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5 NWIyM2I4NWE1ODVkNDNiNjVkY2I2MDUwZjRjN2IzZGQxNjc4NmU4Li40MWE5YzA0MjIyZDY0ZDI4 NmUxMTBlOGNkOGQ0ODE3ZmQxNjFkMWJlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDEt MjUgIE1pa2UgV2VzdCAgPG1rd3N0QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBDbGVhbnVwIGNvbnNvbGUuKiBBUEkgTWVzc2FnZVNvdXJjZS9MZXZlbHMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc5NDYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9jb25z b2xlL2NvbnNvbGUtdGVzdHMtZXhwZWN0ZWQudHh0OgorCiAyMDEzLTAxLTI1ICBLZWlzaGkgSGF0 dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gUmVzb2x2aW5n IGR1cGxpY2F0ZSBleHBlY3RhdGlvbiBlbnRyaWVzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS10ZXN0cy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLXRlc3RzLWV4cGVjdGVkLnR4dAppbmRleCBiOTBk MDkyYTM5MzJjNTQ3ZjAwNmVhMTJhNjI1ZDEwMDAyYTQzMmJkLi4yOTFiZTRjZDJhOWRlOTAxZWVl OTgwOTIxYzcwNzNmMjVmOGJhOTJlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv Y29uc29sZS9jb25zb2xlLXRlc3RzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNw ZWN0b3IvY29uc29sZS9jb25zb2xlLXRlc3RzLWV4cGVjdGVkLnR4dApAQCAtMjcsOCArMjcsOCBA QCBpbmZvIGNvbnNvbGUtdGVzdHMuaHRtbDoxMSBjb25zb2xlLW1lc3NhZ2UgY29uc29sZS1sb2ct bGV2ZWwKIHdhcm4gY29uc29sZS10ZXN0cy5odG1sOjEyIGNvbnNvbGUtbWVzc2FnZSBjb25zb2xl LXdhcm5pbmctbGV2ZWwKIGVycm9yIGNvbnNvbGUtdGVzdHMuaHRtbDoxMyBjb25zb2xlLW1lc3Nh Z2UgY29uc29sZS1lcnJvci1sZXZlbAogNXJlcGVhdGVkIGNvbnNvbGUtdGVzdHMuaHRtbDoxNSBj b25zb2xlLW1lc3NhZ2UgY29uc29sZS1sb2ctbGV2ZWwgcmVwZWF0ZWQtbWVzc2FnZQotY291bnQ6 IDEgY29uc29sZS10ZXN0cy5odG1sOjE3IGNvbnNvbGUtbWVzc2FnZSBjb25zb2xlLWxvZy1sZXZl bAotY291bnQ6IDIgY29uc29sZS10ZXN0cy5odG1sOjE3IGNvbnNvbGUtbWVzc2FnZSBjb25zb2xl LWxvZy1sZXZlbAorY291bnQ6IDEgY29uc29sZS10ZXN0cy5odG1sOjE3IGNvbnNvbGUtbWVzc2Fn ZSBjb25zb2xlLWRlYnVnLWxldmVsCitjb3VudDogMiBjb25zb2xlLXRlc3RzLmh0bWw6MTcgY29u c29sZS1tZXNzYWdlIGNvbnNvbGUtZGVidWctbGV2ZWwKIGdyb3VwIGNvbnNvbGUtdGVzdHMuaHRt bDoxOCBjb25zb2xlLW1lc3NhZ2UgY29uc29sZS1sb2ctbGV2ZWwgY29uc29sZS1ncm91cC10aXRs ZQogIGNvbnNvbGUtbWVzc2FnZSBjb25zb2xlLWxvZy1sZXZlbAogMSAyIDMgY29uc29sZS10ZXN0 cy5odG1sOjIwIGNvbnNvbGUtbWVzc2FnZSBjb25zb2xlLWxvZy1sZXZlbAo=