107923 2013-01-25 00:12:47 -0800 [EFL][WK2] Use C API inside ewk_security_origin 2013-02-18 13:38:42 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107657 1 cdumez cdumez ap benjamin gyuyoung.kim kenneth kling lucas.de.marchi mikhail.pozdnyakov naginenis rakuco webkit.review.bot oldest_to_newest 816325 0 cdumez 2013-01-25 00:12:47 -0800 As per Bug 107657, we should start using the C API internally to avoid violating layering. 816326 1 184685 cdumez 2013-01-25 00:15:21 -0800 Created attachment 184685 Patch 822629 2 184685 kenneth 2013-02-01 04:46:22 -0800 Comment on attachment 184685 Patch LGTM 822634 3 184685 mikhail.pozdnyakov 2013-02-01 04:51:00 -0800 Comment on attachment 184685 Patch Looks nice. 825298 4 184685 hausmann 2013-02-05 02:19:05 -0800 Comment on attachment 184685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184685&action=review LGTM > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:450 > + RefPtr<EwkSecurityOrigin> origin = EwkSecurityOrigin::create(m_url); Depending on other uses it might make sense to turn m_url into a WKRetainPtr<WKStringRef> perhaps? 825304 5 184685 hausmann 2013-02-05 02:23:42 -0800 Comment on attachment 184685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184685&action=review >> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:450 >> + RefPtr<EwkSecurityOrigin> origin = EwkSecurityOrigin::create(m_url); > > Depending on other uses it might make sense to turn m_url into a WKRetainPtr<WKStringRef> perhaps? To elaborate a bit: What I meant to say was that it depends on in which "direction" m_url is used towards, outside towards the developer using WebKit or inside into the WK2 layer. For the latter in Qt we added an optimization that allows us to create a WTFString practically for free from a QString without a copy. That makes WKStringRef creation from QString in turn also cheaper as it avoids data copying. A similar pattern might (or might not) make sense for Efl :) 831250 6 184685 cdumez 2013-02-12 14:14:51 -0800 Comment on attachment 184685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184685&action=review >>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:450 >>> + RefPtr<EwkSecurityOrigin> origin = EwkSecurityOrigin::create(m_url); >> >> Depending on other uses it might make sense to turn m_url into a WKRetainPtr<WKStringRef> perhaps? > > To elaborate a bit: What I meant to say was that it depends on in which "direction" m_url is used towards, outside towards the developer using WebKit or inside into the WK2 layer. For the latter in Qt we added an optimization that allows us to create a WTFString practically for free from a QString without a copy. That makes WKStringRef creation from QString in turn also cheaper as it avoids data copying. A similar pattern might (or might not) make sense for Efl :) m_url is exposed to the client so we keep it as a char* (which is actually an eina stringshare). This is the only place when m_url is eventually converted into a WKStringRef and this only happens when entering fullscreen with fullscreen API so this does not happen frequently. 835727 7 184685 webkit.review.bot 2013-02-18 13:38:37 -0800 Comment on attachment 184685 Patch Clearing flags on attachment: 184685 Committed r143258: <http://trac.webkit.org/changeset/143258> 835728 8 webkit.review.bot 2013-02-18 13:38:42 -0800 All reviewed patches have been landed. Closing bug. 184685 2013-01-25 00:15:21 -0800 2013-02-18 13:38:37 -0800 Patch 107923_ewk_securityorigin_capi.patch text/plain 3934 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzNTM4MzI1Li4yMTZlODZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDEtMjUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIFVzZSBDIEFQSSBpbnNpZGUgZXdrX3NlY3VyaXR5 X29yaWdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA3OTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXNlIEMgQVBJIGluc2lkZSBld2tfc2VjdXJpdHlfb3JpZ2luIGluc3RlYWQgb2YgYWNjZXNzaW5n CisgICAgICAgIGRpcmVjdGx5IGludGVybmFsIEMrKyBjbGFzc2VzLCB0byBhdm9pZCBicmVha2lu ZyBBUEkKKyAgICAgICAgbGF5ZXJpbmcuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9F d2tWaWV3LmNwcDoKKyAgICAgICAgKEV3a1ZpZXc6OmVudGVyRnVsbFNjcmVlbik6CisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NlY3VyaXR5X29yaWdpbi5jcHA6CisgICAgICAgIChF d2tTZWN1cml0eU9yaWdpbjo6RXdrU2VjdXJpdHlPcmlnaW4pOgorICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZWZsL2V3a19zZWN1cml0eV9vcmlnaW5fcHJpdmF0ZS5oOgorICAgICAgICAoRXdrU2Vj dXJpdHlPcmlnaW46OmNyZWF0ZSk6CisgICAgICAgIChFd2tTZWN1cml0eU9yaWdpbik6CisKIDIw MTMtMDEtMjQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAg ICAgW3drMl0gUGFnZSBvdmVybGF5cyBzaG91bGQgZG8gdGhlaXIgb3duIGFuaW1hdGlvbiwgaW5z dGVhZCBvZiByZWx5aW5nIG9uIGltcGxpY2l0IGFuaW1hdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcAppbmRleCBlNDc4YTg2Li5hZDk2OWEwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcApAQCAtNDQ3LDcg KzQ0Nyw3IEBAIHZvaWQgRXdrVmlldzo6ZW50ZXJGdWxsU2NyZWVuKCkKIHsKICAgICBFd2tfVmll d19TbWFydF9EYXRhKiBzZCA9IHNtYXJ0RGF0YSgpOwogCi0gICAgUmVmUHRyPEV3a1NlY3VyaXR5 T3JpZ2luPiBvcmlnaW4gPSBFd2tTZWN1cml0eU9yaWdpbjo6Y3JlYXRlKEtVUkwoUGFyc2VkVVJM U3RyaW5nLCBTdHJpbmc6OmZyb21VVEY4KG1fdXJsKSkpOworICAgIFJlZlB0cjxFd2tTZWN1cml0 eU9yaWdpbj4gb3JpZ2luID0gRXdrU2VjdXJpdHlPcmlnaW46OmNyZWF0ZShtX3VybCk7CiAKICAg ICBpZiAoIXNkLT5hcGktPmZ1bGxzY3JlZW5fZW50ZXIgfHwgIXNkLT5hcGktPmZ1bGxzY3JlZW5f ZW50ZXIoc2QsIG9yaWdpbi5nZXQoKSkpIHsKICAgICAgICAgRWNvcmVfRXZhcyogZWNvcmVFdmFz ID0gZWNvcmVfZXZhc19lY29yZV9ldmFzX2dldChzZC0+YmFzZS5ldmFzKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZWN1cml0eV9vcmlnaW4uY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NlY3VyaXR5X29yaWdpbi5j cHAKaW5kZXggNjBkOGUzOS4uMTg0YWQyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX3NlY3VyaXR5X29yaWdpbi5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NlY3VyaXR5X29yaWdpbi5jcHAKQEAgLTI4LDcgKzI4 LDcgQEAKIAogI2luY2x1ZGUgIldLQVBJQ2FzdC5oIgogI2luY2x1ZGUgIldLU2VjdXJpdHlPcmln aW4uaCIKLSNpbmNsdWRlICJXZWJTZWN1cml0eU9yaWdpbi5oIgorI2luY2x1ZGUgIldLU3RyaW5n LmgiCiAjaW5jbHVkZSAiZXdrX3NlY3VyaXR5X29yaWdpbl9wcml2YXRlLmgiCiAjaW5jbHVkZSA8 V2ViQ29yZS9TZWN1cml0eU9yaWdpbi5oPgogCkBAIC00MSw4ICs0MSw4IEBAIEV3a1NlY3VyaXR5 T3JpZ2luOjpFd2tTZWN1cml0eU9yaWdpbihXS1NlY3VyaXR5T3JpZ2luUmVmIG9yaWdpblJlZikK ICAgICAsIG1fcHJvdG9jb2woQWRvcHRXSywgV0tTZWN1cml0eU9yaWdpbkNvcHlQcm90b2NvbChv cmlnaW5SZWYpKQogeyB9CiAKLUV3a1NlY3VyaXR5T3JpZ2luOjpFd2tTZWN1cml0eU9yaWdpbihj b25zdCBLVVJMJiB1cmwpCi0gICAgOiBtX3drT3JpZ2luKEFkb3B0V0ssIHRvQVBJKFdlYlNlY3Vy aXR5T3JpZ2luOjpjcmVhdGUoU2VjdXJpdHlPcmlnaW46OmNyZWF0ZSh1cmwpKS5sZWFrUmVmKCkp KQorRXdrU2VjdXJpdHlPcmlnaW46OkV3a1NlY3VyaXR5T3JpZ2luKGNvbnN0IGNoYXIqIHVybCkK KyAgICA6IG1fd2tPcmlnaW4oQWRvcHRXSywgV0tTZWN1cml0eU9yaWdpbkNyZWF0ZUZyb21TdHJp bmcoYWRvcHRXSyhXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyh1cmwpKS5nZXQoKSkpCiAg ICAgLCBtX2hvc3QoQWRvcHRXSywgV0tTZWN1cml0eU9yaWdpbkNvcHlIb3N0KG1fd2tPcmlnaW4u Z2V0KCkpKQogICAgICwgbV9wcm90b2NvbChBZG9wdFdLLCBXS1NlY3VyaXR5T3JpZ2luQ29weVBy b3RvY29sKG1fd2tPcmlnaW4uZ2V0KCkpKQogeyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2VjdXJpdHlfb3JpZ2luX3ByaXZhdGUuaCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZWN1cml0eV9vcmlnaW5fcHJpdmF0ZS5o CmluZGV4IGEyZDNiMzEuLmU4YmQ0YTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a19zZWN1cml0eV9vcmlnaW5fcHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZWN1cml0eV9vcmlnaW5fcHJpdmF0ZS5oCkBA IC0yOSw3ICsyOSw2IEBACiAjaW5jbHVkZSAiV0tFaW5hU2hhcmVkU3RyaW5nLmgiCiAjaW5jbHVk ZSAiV0tTZWN1cml0eU9yaWdpbi5oIgogI2luY2x1ZGUgImV3a19vYmplY3RfcHJpdmF0ZS5oIgot I2luY2x1ZGUgPFdlYkNvcmUvS1VSTC5oPgogI2luY2x1ZGUgPFdlYktpdDIvV0tCYXNlLmg+CiAj aW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KIApAQCAtNDIsNyArNDEsNyBAQCBwdWJsaWM6CiAg ICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgRXdrU2VjdXJpdHlPcmlnaW4ob3JpZ2luUmVmKSk7 CiAgICAgfQogCi0gICAgc3RhdGljIFBhc3NSZWZQdHI8RXdrU2VjdXJpdHlPcmlnaW4+IGNyZWF0 ZShjb25zdCBXZWJDb3JlOjpLVVJMJiB1cmwpCisgICAgc3RhdGljIFBhc3NSZWZQdHI8RXdrU2Vj dXJpdHlPcmlnaW4+IGNyZWF0ZShjb25zdCBjaGFyKiB1cmwpCiAgICAgewogICAgICAgICByZXR1 cm4gYWRvcHRSZWYobmV3IEV3a1NlY3VyaXR5T3JpZ2luKHVybCkpOwogICAgIH0KQEAgLTUzLDcg KzUyLDcgQEAgcHVibGljOgogCiBwcml2YXRlOgogICAgIGV4cGxpY2l0IEV3a1NlY3VyaXR5T3Jp Z2luKFdLU2VjdXJpdHlPcmlnaW5SZWYgb3JpZ2luUmVmKTsKLSAgICBleHBsaWNpdCBFd2tTZWN1 cml0eU9yaWdpbihjb25zdCBXZWJDb3JlOjpLVVJMJiB1cmwpOworICAgIGV4cGxpY2l0IEV3a1Nl Y3VyaXR5T3JpZ2luKGNvbnN0IGNoYXIqIHVybCk7CiAKICAgICBXS1JldGFpblB0cjxXS1NlY3Vy aXR5T3JpZ2luUmVmPiBtX3drT3JpZ2luOwogICAgIFdLRWluYVNoYXJlZFN0cmluZyBtX2hvc3Q7 Cg==