107904 2013-01-24 20:30:35 -0800 Keep a RefPtr<SerializedScriptValue*> when we call serialize()/deserialize() in PopStateEvent 2013-01-30 14:38:02 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth darin inferno japhet webkit.review.bot oldest_to_newest 816126 0 haraken 2013-01-24 20:30:35 -0800 If you use a raw SerializedScriptValue* for serialize()/deserialize(), it can potentially cause a use-after-free. This is because serialize()/deserialize() can destruct a RefPtr of the SerializedScriptValue*, depending on data that is serialized/deserialized. So we should keep a RefPtr<SerializedScriptValue*> when we call serialize()/deserialize(). (See https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.) 816128 1 184645 haraken 2013-01-24 20:32:40 -0800 Created attachment 184645 Patch 816165 2 184645 webkit.review.bot 2013-01-24 21:15:34 -0800 Comment on attachment 184645 Patch Rejecting attachment 184645 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 184645, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: webkit-commit-queue Parsed 4 diffs from patch file(s). patch: **** Can't create file /tmp/ppZyipMf : No space left on device patch: **** Can't create file /tmp/ppR1IG0f : No space left on device patch: **** Can't create file /tmp/pp3cp2Ng : No space left on device patch: **** Can't create file /tmp/ppqaQytg : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Abhishek Arya']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16122087 817077 3 184645 webkit.review.bot 2013-01-25 17:27:38 -0800 Comment on attachment 184645 Patch Clearing flags on attachment: 184645 Committed r140886: <http://trac.webkit.org/changeset/140886> 817078 4 webkit.review.bot 2013-01-25 17:27:41 -0800 All reviewed patches have been landed. Closing bug. 819021 5 184645 darin 2013-01-29 09:35:43 -0800 Comment on attachment 184645 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184645&action=review > Source/WebCore/page/History.cpp:80 > -bool History::isSameAsCurrentState(SerializedScriptValue* state) const > +bool History::isSameAsCurrentState(PassRefPtr<SerializedScriptValue> state) const This change makes no sense and does no good. The other half of the change would have been sufficient, although you’d have to add a get() at some call sites. There is no reason for this function to take a PassRefPtr, which implies that it takes ownership of its argument. Please roll this part of the change out. 819802 6 haraken 2013-01-29 22:19:09 -0800 Reopening to attach new patch. 819803 7 185398 haraken 2013-01-29 22:19:12 -0800 Created attachment 185398 Patch 819804 8 184645 haraken 2013-01-29 22:19:35 -0800 Comment on attachment 184645 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184645&action=review >> Source/WebCore/page/History.cpp:80 >> +bool History::isSameAsCurrentState(PassRefPtr<SerializedScriptValue> state) const > > This change makes no sense and does no good. The other half of the change would have been sufficient, although you’d have to add a get() at some call sites. There is no reason for this function to take a PassRefPtr, which implies that it takes ownership of its argument. Please roll this part of the change out. Thanks, uploaded a patch for fix. 820592 9 185398 webkit.review.bot 2013-01-30 14:37:58 -0800 Comment on attachment 185398 Patch Clearing flags on attachment: 185398 Committed r141315: <http://trac.webkit.org/changeset/141315> 820593 10 webkit.review.bot 2013-01-30 14:38:02 -0800 All reviewed patches have been landed. Closing bug. 184645 2013-01-24 20:32:40 -0800 2013-01-29 22:19:35 -0800 Patch bug-107904-20130125132930.patch text/plain 3277 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNzU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhjNzg3NmM5OTk5MmQ3 YjQ1N2UxZjMyNTkyYjg0OTQ4ZGIwNDUyZS4uODhiMGRjYzgxZDlhNWY2YmMyOGYyODk5Zjg4MTQz ZGVhNTIxODdlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDEzLTAxLTI0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBLZWVwIGEgUmVmUHRy PFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSo+IHdoZW4gd2UgY2FsbCBzZXJpYWxpemUoKS9kZXNlcmlh bGl6ZSgpIGluIFBvcFN0YXRlRXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNzkwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIElmIHlvdSB1c2UgYSByYXcgU2VyaWFsaXplZFNjcmlwdFZhbHVlKiBm b3Igc2VyaWFsaXplKCkvZGVzZXJpYWxpemUoKSwKKyAgICAgICAgaXQgY2FuIHBvdGVudGlhbGx5 IGNhdXNlIGEgdXNlLWFmdGVyLWZyZWUuIFRoaXMgaXMgYmVjYXVzZSBzZXJpYWxpemUoKS8KKyAg ICAgICAgZGVzZXJpYWxpemUoKSBjYW4gZGVzdHJ1Y3QgYSBSZWZQdHIgb2YgdGhlIFNlcmlhbGl6 ZWRTY3JpcHRWYWx1ZSosCisgICAgICAgIGRlcGVuZGluZyBvbiBkYXRhIHRoYXQgaXMgc2VyaWFs aXplZC9kZXNlcmlhbGl6ZWQuIFNvIHdlIHNob3VsZCBrZWVwIGEKKyAgICAgICAgUmVmUHRyPFNl cmlhbGl6ZWRTY3JpcHRWYWx1ZSo+IHdoZW4gd2UgY2FsbCBzZXJpYWxpemUoKS9kZXNlcmlhbGl6 ZSgpLgorICAgICAgICAoU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDc3OTIgZm9yIG1vcmUgZGV0YWlscy4pCisKKyAgICAgICAgTm8gdGVzdHMuIFRoaXMgaXMg anVzdCBhIGp1c3QtaW4tY2FzZSBmaXguCisKKyAgICAgICAgKiBkb20vUG9wU3RhdGVFdmVudC5o OgorICAgICAgICAoV2ViQ29yZTo6UG9wU3RhdGVFdmVudDo6c2VyaWFsaXplZFN0YXRlKToKKyAg ICAgICAgKiBwYWdlL0hpc3RvcnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeTo6aXNT YW1lQXNDdXJyZW50U3RhdGUpOgorICAgICAgICAqIHBhZ2UvSGlzdG9yeS5oOgorICAgICAgICAo SGlzdG9yeSk6CisKKzIwMTMtMDEtMjQgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0u b3JnPgorCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgogCiAgICAgICAgICogcGFnZS9I aXN0b3J5Lmg6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vUG9wU3RhdGVFdmVudC5o IGIvU291cmNlL1dlYkNvcmUvZG9tL1BvcFN0YXRlRXZlbnQuaAppbmRleCAxMGJjMDVjN2U0YjQ1 NTIxN2E2Mjc2YmJiNjNhNjgwMDZkZWY5Zjc3Li5kNWJmOGUwMzQ2NmJhMzkyNDEwOGQ0NjNkNjU2 NzBhZDA1YTQ1YWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vUG9wU3RhdGVFdmVu dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3BTdGF0ZUV2ZW50LmgKQEAgLTQ4LDcgKzQ4 LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFBvcFN0YXRlRXZlbnQ+IGNyZWF0 ZShQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4sIFBhc3NSZWZQdHI8SGlzdG9yeT4p OwogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFBvcFN0YXRlRXZlbnQ+IGNyZWF0ZShjb25zdCBBdG9t aWNTdHJpbmcmLCBjb25zdCBQb3BTdGF0ZUV2ZW50SW5pdCYpOwogCi0gICAgU2VyaWFsaXplZFNj cmlwdFZhbHVlKiBzZXJpYWxpemVkU3RhdGUoKSBjb25zdCB7IHJldHVybiBtX3NlcmlhbGl6ZWRT dGF0ZS5nZXQoKTsgfQorICAgIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBzZXJp YWxpemVkU3RhdGUoKSBjb25zdCB7IHJldHVybiBtX3NlcmlhbGl6ZWRTdGF0ZTsgfQogICAgIGNv bnN0IFNjcmlwdFZhbHVlJiBzdGF0ZSgpIGNvbnN0IHsgcmV0dXJuIG1fc3RhdGU7IH0KICAgICBI aXN0b3J5KiBoaXN0b3J5KCkgY29uc3QgeyByZXR1cm4gbV9oaXN0b3J5LmdldCgpOyB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvSGlzdG9yeS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0hpc3RvcnkuY3BwCmluZGV4IDUzMTQzNGI5NjNiZjZiODEyOWVmNWQwMWM1NjIzNTU3 ZDUzZGE2YjEuLjI2OTU4ZWQzYmE0MTFjMWY5YmYwMjAxMGFiNjlkZTVhYjFkYjJlZDEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvSGlzdG9yeS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9IaXN0b3J5LmNwcApAQCAtNzcsNyArNzcsNyBAQCBib29sIEhpc3Rvcnk6OnN0YXRl Q2hhbmdlZCgpIGNvbnN0CiAgICAgcmV0dXJuIG1fbGFzdFN0YXRlT2JqZWN0UmVxdWVzdGVkICE9 IHN0YXRlSW50ZXJuYWwoKTsKIH0KIAotYm9vbCBIaXN0b3J5Ojppc1NhbWVBc0N1cnJlbnRTdGF0 ZShTZXJpYWxpemVkU2NyaXB0VmFsdWUqIHN0YXRlKSBjb25zdAorYm9vbCBIaXN0b3J5Ojppc1Nh bWVBc0N1cnJlbnRTdGF0ZShQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gc3RhdGUp IGNvbnN0CiB7CiAgICAgcmV0dXJuIHN0YXRlID09IHN0YXRlSW50ZXJuYWwoKTsKIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvSGlzdG9yeS5oIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9IaXN0b3J5LmgKaW5kZXggY2E5NzZhOTZjNzE2MGY0MGZiMzEzMDg0NDQyMmQzYWIzYTY4ZTNj Yi4uNDM1NTRmNjdmOTkwOTNkNmRkZmFkMmNlODk3ZGQxNThjYTcyNDFiNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9IaXN0b3J5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9I aXN0b3J5LmgKQEAgLTU1LDcgKzU1LDcgQEAgcHVibGljOgogICAgIHZvaWQgZ28oU2NyaXB0RXhl Y3V0aW9uQ29udGV4dCosIGludCBkaXN0YW5jZSk7CiAKICAgICBib29sIHN0YXRlQ2hhbmdlZCgp IGNvbnN0OwotICAgIGJvb2wgaXNTYW1lQXNDdXJyZW50U3RhdGUoU2VyaWFsaXplZFNjcmlwdFZh bHVlKikgY29uc3Q7CisgICAgYm9vbCBpc1NhbWVBc0N1cnJlbnRTdGF0ZShQYXNzUmVmUHRyPFNl cmlhbGl6ZWRTY3JpcHRWYWx1ZT4pIGNvbnN0OwogCiAgICAgZW51bSBTdGF0ZU9iamVjdFR5cGUg ewogICAgICAgICBTdGF0ZU9iamVjdFB1c2gsCg== 185398 2013-01-29 22:19:12 -0800 2013-01-30 14:37:57 -0800 Patch bug-107904-20130130151557.patch text/plain 4042 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjMyZTdiNzdlNTdmY2Jh NDIwMWE5ZDhhMzVmMWYyNWQzMDY3ZmI0NS4uMTlkYjkxZGJjMTQxNWQ0YjcyYzNkNWQ4ZDhlYzgz NGM1OWEwYTg5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAxLTI5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBpc1NhbWVBc0N1cnJl bnRTdGF0ZSgpIHNob3VsZCB0YWtlIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSogaW5zdGVhZCBvZiBQ YXNzUmVmUHRyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDc5MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBcHBsaWVkIERhcmluJ3MgY29tbWVudDogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNzkwNCNjNQorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU1BvcFN0YXRlRXZlbnRDdXN0b20uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SlNQb3BTdGF0ZUV2ZW50OjpzdGF0ZSk6CisgICAgICAgICog YmluZGluZ3MvdjgvY3VzdG9tL1Y4UG9wU3RhdGVFdmVudEN1c3RvbS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpWOFBvcFN0YXRlRXZlbnQ6OnN0YXRlQWNjZXNzb3JHZXR0ZXIpOgorICAgICAgICAq IHBhZ2UvSGlzdG9yeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIaXN0b3J5Ojppc1NhbWVBc0N1 cnJlbnRTdGF0ZSk6CisgICAgICAgICogcGFnZS9IaXN0b3J5Lmg6CisgICAgICAgIChIaXN0b3J5 KToKKwogMjAxMy0wMS0yOSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAg ICAgQ2hhbmdlIERhdGFiYXNlQ29udGV4dCBsb29rdXAgdG8gYmUgdGhyZWFkLXNhZmUuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1BvcFN0YXRlRXZlbnRDdXN0b20u Y3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNQb3BTdGF0ZUV2ZW50Q3VzdG9tLmNw cAppbmRleCAzZGUyODA3ZDFjZWM3N2M2M2JkZjc1YTg5ZWFlZDdiODVmZDkxMDE1Li5lZmE2Mjdl ZmZkNmQ5OTBkY2Y4MDhkM2EwNThmMTZiYzEwZTQ0NTFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU1BvcFN0YXRlRXZlbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTUG9wU3RhdGVFdmVudEN1c3RvbS5jcHAKQEAgLTY2LDcgKzY2 LDcgQEAgSlNWYWx1ZSBKU1BvcFN0YXRlRXZlbnQ6OnN0YXRlKEV4ZWNTdGF0ZSogZXhlYykgY29u c3QKICAgICAvLyBUaGUgY3VycmVudCBoaXN0b3J5IHN0YXRlIG9iamVjdCBtaWdodCd2ZSBjaGFu Z2VkIGluIHRoZSBtZWFudGltZSwgc28gd2UgbmVlZCB0byB0YWtlIGNhcmUKICAgICAvLyBvZiB1 c2luZyB0aGUgY29ycmVjdCBvbmUsIGFuZCBhbHdheXMgc2hhcmUgdGhlIHNhbWUgZGVzZXJpYWxp emF0aW9uIHdpdGggaGlzdG9yeS5zdGF0ZS4KIAotICAgIGJvb2wgaXNTYW1lU3RhdGUgPSBoaXN0 b3J5LT5pc1NhbWVBc0N1cnJlbnRTdGF0ZShldmVudC0+c2VyaWFsaXplZFN0YXRlKCkpOworICAg IGJvb2wgaXNTYW1lU3RhdGUgPSBoaXN0b3J5LT5pc1NhbWVBc0N1cnJlbnRTdGF0ZShldmVudC0+ c2VyaWFsaXplZFN0YXRlKCkuZ2V0KCkpOwogICAgIEpTVmFsdWUgcmVzdWx0OwogCiAgICAgaWYg KGlzU2FtZVN0YXRlKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9j dXN0b20vVjhQb3BTdGF0ZUV2ZW50Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOFBvcFN0YXRlRXZlbnRDdXN0b20uY3BwCmluZGV4IGFhMWE2OGU3ZWMxNzk5 OWU5ZTM1YjQ0NGUzMzE5MmVjNjRlZTliMzUuLmZjNTQ5NDQ0Y2RlZDQyMmUyODRmZmRkMGY2ZGRm Yjc1MzE2M2Y1NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOFBvcFN0YXRlRXZlbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOFBvcFN0YXRlRXZlbnRDdXN0b20uY3BwCkBAIC02Nyw3ICs2Nyw3IEBAIHY4 OjpIYW5kbGU8djg6OlZhbHVlPiBWOFBvcFN0YXRlRXZlbnQ6OnN0YXRlQWNjZXNzb3JHZXR0ZXIo djg6OkxvY2FsPHY4OjpTdHJpbmc+CiAgICAgLy8gVGhlIGN1cnJlbnQgaGlzdG9yeSBzdGF0ZSBv YmplY3QgbWlnaHQndmUgY2hhbmdlZCBpbiB0aGUgbWVhbnRpbWUsIHNvIHdlIG5lZWQgdG8gdGFr ZSBjYXJlCiAgICAgLy8gb2YgdXNpbmcgdGhlIGNvcnJlY3Qgb25lLCBhbmQgYWx3YXlzIHNoYXJl IHRoZSBzYW1lIGRlc2VyaWFsaXphdGlvbiB3aXRoIGhpc3Rvcnkuc3RhdGUuCiAKLSAgICBib29s IGlzU2FtZVN0YXRlID0gaGlzdG9yeS0+aXNTYW1lQXNDdXJyZW50U3RhdGUoZXZlbnQtPnNlcmlh bGl6ZWRTdGF0ZSgpKTsKKyAgICBib29sIGlzU2FtZVN0YXRlID0gaGlzdG9yeS0+aXNTYW1lQXND dXJyZW50U3RhdGUoZXZlbnQtPnNlcmlhbGl6ZWRTdGF0ZSgpLmdldCgpKTsKIAogICAgIGlmIChp c1NhbWVTdGF0ZSkgewogICAgICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHY4SGlzdG9yeSA9 IHRvVjgoaGlzdG9yeSwgaW5mby5Ib2xkZXIoKSwgaW5mby5HZXRJc29sYXRlKCkpLkFzPHY4OjpP YmplY3Q+KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0hpc3RvcnkuY3BwIGIv U291cmNlL1dlYkNvcmUvcGFnZS9IaXN0b3J5LmNwcAppbmRleCAyNjk1OGVkM2JhNDExYzFmOWJm MDIwMTBhYjY5ZGU1YWIxZGIyZWQxLi44N2Q4NTA2ZDczNGNmNzk2NjFjMTQ0NDEyZGMxYjA0NjYx NDEzOGU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0hpc3RvcnkuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvSGlzdG9yeS5jcHAKQEAgLTc3LDkgKzc3LDkgQEAgYm9vbCBI aXN0b3J5OjpzdGF0ZUNoYW5nZWQoKSBjb25zdAogICAgIHJldHVybiBtX2xhc3RTdGF0ZU9iamVj dFJlcXVlc3RlZCAhPSBzdGF0ZUludGVybmFsKCk7CiB9CiAKLWJvb2wgSGlzdG9yeTo6aXNTYW1l QXNDdXJyZW50U3RhdGUoUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IHN0YXRlKSBj b25zdAorYm9vbCBIaXN0b3J5Ojppc1NhbWVBc0N1cnJlbnRTdGF0ZShTZXJpYWxpemVkU2NyaXB0 VmFsdWUqIHN0YXRlKSBjb25zdAogewotICAgIHJldHVybiBzdGF0ZSA9PSBzdGF0ZUludGVybmFs KCk7CisgICAgcmV0dXJuIHN0YXRlID09IHN0YXRlSW50ZXJuYWwoKS5nZXQoKTsKIH0KIAogdm9p ZCBIaXN0b3J5OjpiYWNrKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvSGlzdG9y eS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9IaXN0b3J5LmgKaW5kZXggNDM1NTRmNjdmOTkwOTNk NmRkZmFkMmNlODk3ZGQxNThjYTcyNDFiNi4uY2E5NzZhOTZjNzE2MGY0MGZiMzEzMDg0NDQyMmQz YWIzYTY4ZTNjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9IaXN0b3J5LmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9IaXN0b3J5LmgKQEAgLTU1LDcgKzU1LDcgQEAgcHVibGlj OgogICAgIHZvaWQgZ28oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIGludCBkaXN0YW5jZSk7CiAK ICAgICBib29sIHN0YXRlQ2hhbmdlZCgpIGNvbnN0OwotICAgIGJvb2wgaXNTYW1lQXNDdXJyZW50 U3RhdGUoUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+KSBjb25zdDsKKyAgICBib29s IGlzU2FtZUFzQ3VycmVudFN0YXRlKFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSopIGNvbnN0OwogCiAg ICAgZW51bSBTdGF0ZU9iamVjdFR5cGUgewogICAgICAgICBTdGF0ZU9iamVjdFB1c2gsCg==