107887 2013-01-24 17:42:35 -0800 [Gtk] RunLoop::run shuold run current thread's run loop. 2013-02-07 18:43:02 -0800 1 1 1 Unclassified WebKit Platform 525.x (Safari 3.2) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 0 dev webkit-unassigned dev d.nomiyama dongseong.hwang jaepark mario mrobinson skyul webkit.review.bot oldest_to_newest 816027 0 dev 2013-01-24 17:42:35 -0800 When off-the main thread use RunLoop with Timer, Timer doesn't fire callback. 817495 1 184933 dev 2013-01-27 20:55:10 -0800 Created attachment 184933 Patch 817509 2 184936 dev 2013-01-27 21:40:37 -0800 Created attachment 184936 Patch 817629 3 184936 mario 2013-01-28 02:11:51 -0800 Comment on attachment 184936 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184936&action=review > Source/WebCore/ChangeLog:15 > + No new tests. There is no case that uses RunLoop in off the main thread yet. I guess you have some specific use cases for this change already in mind, and also that you probably have tested this manually in some way. If so, would you mind sharing those use cases / manual tests here? Also, I really think it would be worth trying to provide some kind of test along with this patch (probably an unit test). I don't have much experience with this part of the code besides the implementation of modal dialogs in WebKit2GTK+, which I remember used this part of the code to control "modality" of the dialogs, so that's where my interest comes from. 817653 4 dev 2013-01-28 02:48:52 -0800 (In reply to comment #3) Now my team is developing threaded model of coordinated graphics in Gtk (https://bugs.webkit.org/show_bug.cgi?id=100341). And RunLoop is needed in compositor thread. I'll share prototype sometime this week. 817657 5 mario 2013-01-28 03:03:18 -0800 (In reply to comment #4) > (In reply to comment #3) > > Now my team is developing threaded model of coordinated graphics in Gtk (https://bugs.webkit.org/show_bug.cgi?id=100341). > And RunLoop is needed in compositor thread. > I'll share prototype sometime this week. Thanks for the clarification and for sharing that prototype, that will be really useful to properly understand this in a better way. BTW, I'm also adding Denis Nomiyama to CC here as he's working in something quite related to this and so he might be interested, I guess. 820984 6 dev 2013-01-30 19:24:02 -0800 I uploaded the prototype at https://github.com/DorothyBrowser/webkit/tree/threaded-compositor. I welcome your comments. Thank you. 821535 7 184936 mrobinson 2013-01-31 08:07:33 -0800 Comment on attachment 184936 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184936&action=review Looks pretty reasonable, but there is a memory leak in this new code, I think. > Source/WebCore/platform/gtk/RunLoopGtk.cpp:35 > #include <glib.h> > > +#include <wtf/MainThread.h> > + > namespace WebCore { You should have these includes be all one block. > Source/WebCore/platform/gtk/RunLoopGtk.cpp:40 > + m_runLoopContext = isMainThread() ? g_main_context_default() : g_main_context_new(); g_main_context_default does not return a new reference while g_main_context_new does. You are leaking the new main loop here. You should do: m_runLoopContext = isMainThread() ? g_main_context_default() : adoptGRef(g_main_context_new()); 822216 8 185912 dev 2013-01-31 18:40:06 -0800 Created attachment 185912 Patch 828070 9 185912 mrobinson 2013-02-07 18:08:02 -0800 Comment on attachment 185912 Patch Okay. This seem pretty reasonable. 828087 10 185912 webkit.review.bot 2013-02-07 18:42:57 -0800 Comment on attachment 185912 Patch Clearing flags on attachment: 185912 Committed r142219: <http://trac.webkit.org/changeset/142219> 828088 11 webkit.review.bot 2013-02-07 18:43:02 -0800 All reviewed patches have been landed. Closing bug. 184933 2013-01-27 20:55:10 -0800 2013-01-27 21:40:33 -0800 Patch bug-107887-20130128135158.patch text/plain 2339 dev U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTI1ZGEwNTEzNzA3NWQy NDNkZjUyNTVlNjUyMTk4OGRmOTdiNmVjOS4uNDA5OWVmY2ZiZWRhNWFkMTczYTZjZTMzZjQ1MmNk MWQ4NTNiYjc0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAxLTI3ICBTZXVs Z2kgS2ltICA8c2V1bGdpa2ltQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtHdGtdIFJ1bkxv b3A6OnJ1biBzaHVvbGQgcnVuIGN1cnJlbnQgdGhyZWFkJ3MgcnVuIGxvb3AuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc4ODcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHksIFJ1bkxvb3Ag aW4gR3RrIGNhbiB1c2UganVzdCBtYWluIHRocmVhZCdzIGV2ZW50IGxvb3AuCisgICAgICAgIEJ1 dCB0aGUgb3RoZXIgcG9ydHMgYXJlIGltcGxlbWVudGVkIHRvIHVzZSBSdW5Mb29wIGluIHN1YiB0 aHJlYWRzLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgUnVuTG9vcCBjb25zdHJ1Y3RvciBj cmVhdGUgbmV3IGNvbnRleHQsIG5vdCB1c2UgZGVmYXVsdAorICAgICAgICBjb250ZXh0LgorICAg ICAgICBCdXQgaW4gdGhlIG1haW4gdGhyZWFkIHN0aWxsIHVzZXMgZGVmYXVsdCBjb250ZXh0IHRv IHVzZSBtYWluIGV2ZW50IGxvb3AKKyAgICAgICAgc2luY2UgdGhlcmUgaXMgc29tZSBjb2RlcyB1 c2luZyBnbGliIGRpcmVjdGx5IGZvciBzb21lIHJlYXNvbiAoZS5nLiBpbgorICAgICAgICBMYXll clRyZWVIb3N0R3RrOjpzY2hlZHVsZUxheWVyRmx1c2gpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9S dW5Mb29wR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJ1bkxvb3A6OlJ1bkxvb3ApOgorICAg ICAgICAoV2ViQ29yZTo6UnVuTG9vcDo6cnVuKToKKwogMjAxMy0wMS0yNyAgSm9jaGVuIEVpc2lu Z2VyICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDaGVjayBub3RpZmljYXRpb24g cGVybWlzc2lvbnMgaW4gdGhlIHNob3coKSBtZXRob2QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2d0ay9SdW5Mb29wR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9SdW5Mb29wR3RrLmNwcAppbmRleCBlNmVlNmMwZjU1MzJlZWZjNmQxZjI1NGVmMTExNjg2 MzUyOTU0ZGRkLi45NGI3NzU2ODVlMTgyNjQ0N2I0ODYxYzk4YjJjNTExNDIzZWU2MWFjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUnVuTG9vcEd0ay5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1J1bkxvb3BHdGsuY3BwCkBAIC0zMCwxMiArMzAs MTQgQEAKICNpbmNsdWRlIDxnZGsvZ2RrLmg+CiAjaW5jbHVkZSA8Z2xpYi5oPgogCisjaW5jbHVk ZSA8d3RmL01haW5UaHJlYWQuaD4KKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBSdW5Mb29wOjpS dW5Mb29wKCkKIHsKICAgICAvLyBnX21haW5fY29udGV4dF9kZWZhdWx0KCkgZG9lc24ndCBhZGQg YW4gZXh0cmEgcmVmZXJlbmNlLgotICAgIG1fcnVuTG9vcENvbnRleHQgPSBnX21haW5fY29udGV4 dF9kZWZhdWx0KCk7CisgICAgbV9ydW5Mb29wQ29udGV4dCA9IGlzTWFpblRocmVhZCgpID8gZ19t YWluX2NvbnRleHRfZGVmYXVsdCgpIDogZ19tYWluX2NvbnRleHRfbmV3KCk7CiAgICAgQVNTRVJU KG1fcnVuTG9vcENvbnRleHQpOwogICAgIEdSZWZQdHI8R01haW5Mb29wPiBpbm5lcm1vc3RMb29w ID0gYWRvcHRHUmVmKGdfbWFpbl9sb29wX25ldyhtX3J1bkxvb3BDb250ZXh0LmdldCgpLCBGQUxT RSkpOwogICAgIEFTU0VSVChpbm5lcm1vc3RMb29wKTsKQEAgLTUzLDcgKzU1LDcgQEAgUnVuTG9v cDo6flJ1bkxvb3AoKQogCiB2b2lkIFJ1bkxvb3A6OnJ1bigpCiB7Ci0gICAgUnVuTG9vcCogbWFp blJ1bkxvb3AgPSBSdW5Mb29wOjptYWluKCk7CisgICAgUnVuTG9vcCogbWFpblJ1bkxvb3AgPSBS dW5Mb29wOjpjdXJyZW50KCk7CiAgICAgR01haW5Mb29wKiBpbm5lcm1vc3RMb29wID0gbWFpblJ1 bkxvb3AtPmlubmVybW9zdExvb3AoKTsKICAgICBpZiAoIWdfbWFpbl9sb29wX2lzX3J1bm5pbmco aW5uZXJtb3N0TG9vcCkpIHsKICAgICAgICAgZ19tYWluX2xvb3BfcnVuKGlubmVybW9zdExvb3Ap Owo= 184936 2013-01-27 21:40:37 -0800 2013-01-31 18:40:01 -0800 Patch bug-107887-20130128143725.patch text/plain 2320 dev U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTI1ZGEwNTEzNzA3NWQy NDNkZjUyNTVlNjUyMTk4OGRmOTdiNmVjOS4uMzA4ODNmMzRlOTQ5ZWJmYTMyNTdlYmIwYmU3YWQ1 ZDEwNzFiOWFkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAxLTI3ICBTZXVs Z2kgS2ltICA8c2V1bGdpa2ltQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtHdGtdIFJ1bkxv b3A6OnJ1biBzaHVvbGQgcnVuIGN1cnJlbnQgdGhyZWFkJ3MgcnVuIGxvb3AuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc4ODcKKworICAgICAgICBD dXJyZW50bHksIFJ1bkxvb3AgaW4gR3RrIGNhbiB1c2UganVzdCBtYWluIHRocmVhZCdzIGV2ZW50 IGxvb3AuCisgICAgICAgIEJ1dCB0aGUgb3RoZXIgcG9ydHMgYXJlIGltcGxlbWVudGVkIHRvIHVz ZSBSdW5Mb29wIGluIHN1YiB0aHJlYWRzLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgUnVu TG9vcCBjb25zdHJ1Y3RvciBjcmVhdGUgbmV3IGNvbnRleHQsIG5vdCB1c2UgZGVmYXVsdAorICAg ICAgICBjb250ZXh0LgorICAgICAgICBCdXQgaW4gdGhlIG1haW4gdGhyZWFkIHN0aWxsIHVzZXMg ZGVmYXVsdCBjb250ZXh0IHRvIHVzZSBtYWluIGV2ZW50IGxvb3AKKyAgICAgICAgc2luY2UgdGhl cmUgaXMgc29tZSBjb2RlcyB1c2luZyBnbGliIGRpcmVjdGx5IChlLmcuIGluCisgICAgICAgIExh eWVyVHJlZUhvc3RHdGs6OnNjaGVkdWxlTGF5ZXJGbHVzaCkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLiBUaGVyZSBpcyBubyBjYXNlIHRoYXQgdXNlcyBSdW5Mb29wIGluIG9mZiB0aGUgbWFpbiB0 aHJlYWQgeWV0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1J1bkxvb3BHdGsuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UnVuTG9vcDo6UnVuTG9vcCk6CisgICAgICAgIChXZWJDb3JlOjpSdW5M b29wOjpydW4pOgorCiAyMDEzLTAxLTI3ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIENoZWNrIG5vdGlmaWNhdGlvbiBwZXJtaXNzaW9ucyBpbiB0aGUg c2hvdygpIG1ldGhvZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1J1 bkxvb3BHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1J1bkxvb3BHdGsuY3Bw CmluZGV4IGU2ZWU2YzBmNTUzMmVlZmM2ZDFmMjU0ZWYxMTE2ODYzNTI5NTRkZGQuLjk0Yjc3NTY4 NWUxODI2NDQ3YjQ4NjFjOThiMmM1MTE0MjNlZTYxYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2d0ay9SdW5Mb29wR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvUnVuTG9vcEd0ay5jcHAKQEAgLTMwLDEyICszMCwxNCBAQAogI2luY2x1ZGUgPGdk ay9nZGsuaD4KICNpbmNsdWRlIDxnbGliLmg+CiAKKyNpbmNsdWRlIDx3dGYvTWFpblRocmVhZC5o PgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFJ1bkxvb3A6OlJ1bkxvb3AoKQogewogICAgIC8v IGdfbWFpbl9jb250ZXh0X2RlZmF1bHQoKSBkb2Vzbid0IGFkZCBhbiBleHRyYSByZWZlcmVuY2Uu Ci0gICAgbV9ydW5Mb29wQ29udGV4dCA9IGdfbWFpbl9jb250ZXh0X2RlZmF1bHQoKTsKKyAgICBt X3J1bkxvb3BDb250ZXh0ID0gaXNNYWluVGhyZWFkKCkgPyBnX21haW5fY29udGV4dF9kZWZhdWx0 KCkgOiBnX21haW5fY29udGV4dF9uZXcoKTsKICAgICBBU1NFUlQobV9ydW5Mb29wQ29udGV4dCk7 CiAgICAgR1JlZlB0cjxHTWFpbkxvb3A+IGlubmVybW9zdExvb3AgPSBhZG9wdEdSZWYoZ19tYWlu X2xvb3BfbmV3KG1fcnVuTG9vcENvbnRleHQuZ2V0KCksIEZBTFNFKSk7CiAgICAgQVNTRVJUKGlu bmVybW9zdExvb3ApOwpAQCAtNTMsNyArNTUsNyBAQCBSdW5Mb29wOjp+UnVuTG9vcCgpCiAKIHZv aWQgUnVuTG9vcDo6cnVuKCkKIHsKLSAgICBSdW5Mb29wKiBtYWluUnVuTG9vcCA9IFJ1bkxvb3A6 Om1haW4oKTsKKyAgICBSdW5Mb29wKiBtYWluUnVuTG9vcCA9IFJ1bkxvb3A6OmN1cnJlbnQoKTsK ICAgICBHTWFpbkxvb3AqIGlubmVybW9zdExvb3AgPSBtYWluUnVuTG9vcC0+aW5uZXJtb3N0TG9v cCgpOwogICAgIGlmICghZ19tYWluX2xvb3BfaXNfcnVubmluZyhpbm5lcm1vc3RMb29wKSkgewog ICAgICAgICBnX21haW5fbG9vcF9ydW4oaW5uZXJtb3N0TG9vcCk7Cg== 185912 2013-01-31 18:40:06 -0800 2013-02-07 18:42:57 -0800 Patch bug-107887-20130201113652.patch text/plain 2358 dev U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTZiNGI1YWQ3MWJmYTI2 MjFjMjJmNDZmNDY1YTFjNTlkOWU1N2NhMy4uMjNlNTFhMzRlNWQwN2NiYzZmZGNhYmE5OTQ0YmE5 ZTkxM2E4ZjZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAxLTMxICBTZXVs Z2kgS2ltICA8c2V1bGdpa2ltQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtHdGtdIFJ1bkxv b3A6OnJ1biBzaHVvbGQgcnVuIGN1cnJlbnQgdGhyZWFkJ3MgcnVuIGxvb3AuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc4ODcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHksIFJ1bkxvb3Ag aW4gR3RrIGNhbiB1c2UganVzdCBtYWluIHRocmVhZCdzIGV2ZW50IGxvb3AuCisgICAgICAgIEJ1 dCB0aGUgb3RoZXIgcG9ydHMgYXJlIGltcGxlbWVudGVkIHRvIHVzZSBSdW5Mb29wIGluIHN1YiB0 aHJlYWRzLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgUnVuTG9vcCBjb25zdHJ1Y3RvciBj cmVhdGUgbmV3IGNvbnRleHQsIG5vdCB1c2UgZGVmYXVsdAorICAgICAgICBjb250ZXh0LgorICAg ICAgICBCdXQgaW4gdGhlIG1haW4gdGhyZWFkIHN0aWxsIHVzZXMgZGVmYXVsdCBjb250ZXh0IHRv IHVzZSBtYWluIGV2ZW50IGxvb3AKKyAgICAgICAgc2luY2UgdGhlcmUgaXMgc29tZSBjb2RlcyB1 c2luZyBnbGliIGRpcmVjdGx5IChlLmcuIGluCisgICAgICAgIExheWVyVHJlZUhvc3RHdGs6OnNj aGVkdWxlTGF5ZXJGbHVzaCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGVyZSBpcyBubyBj YXNlIHRoYXQgdXNlcyBSdW5Mb29wIGluIG9mZiB0aGUgbWFpbiB0aHJlYWQKKyAgICAgICAgeWV0 LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1J1bkxvb3BHdGsuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UnVuTG9vcDo6UnVuTG9vcCk6CisgICAgICAgIChXZWJDb3JlOjpSdW5Mb29wOjpydW4p OgorCiAyMDEzLTAxLTMxICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQxNTAyLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1J1bkxvb3BHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL1J1bkxvb3BHdGsuY3BwCmluZGV4IGU2ZWU2YzBmNTUzMmVlZmM2ZDFmMjU0 ZWYxMTE2ODYzNTI5NTRkZGQuLjE5MGYzNWNhNjZkMjIwYjQwZDRmNjNmN2Q5ZjZjOTg0Mjc1Nzc3 MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SdW5Mb29wR3RrLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUnVuTG9vcEd0ay5jcHAKQEAgLTMw LDEyICszMCwxNCBAQAogI2luY2x1ZGUgPGdkay9nZGsuaD4KICNpbmNsdWRlIDxnbGliLmg+CiAK KyNpbmNsdWRlIDx3dGYvTWFpblRocmVhZC5oPgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFJ1 bkxvb3A6OlJ1bkxvb3AoKQogewogICAgIC8vIGdfbWFpbl9jb250ZXh0X2RlZmF1bHQoKSBkb2Vz bid0IGFkZCBhbiBleHRyYSByZWZlcmVuY2UuCi0gICAgbV9ydW5Mb29wQ29udGV4dCA9IGdfbWFp bl9jb250ZXh0X2RlZmF1bHQoKTsKKyAgICBtX3J1bkxvb3BDb250ZXh0ID0gaXNNYWluVGhyZWFk KCkgPyBnX21haW5fY29udGV4dF9kZWZhdWx0KCkgOiBhZG9wdEdSZWYoZ19tYWluX2NvbnRleHRf bmV3KCkpOwogICAgIEFTU0VSVChtX3J1bkxvb3BDb250ZXh0KTsKICAgICBHUmVmUHRyPEdNYWlu TG9vcD4gaW5uZXJtb3N0TG9vcCA9IGFkb3B0R1JlZihnX21haW5fbG9vcF9uZXcobV9ydW5Mb29w Q29udGV4dC5nZXQoKSwgRkFMU0UpKTsKICAgICBBU1NFUlQoaW5uZXJtb3N0TG9vcCk7CkBAIC01 Myw3ICs1NSw3IEBAIFJ1bkxvb3A6On5SdW5Mb29wKCkKIAogdm9pZCBSdW5Mb29wOjpydW4oKQog ewotICAgIFJ1bkxvb3AqIG1haW5SdW5Mb29wID0gUnVuTG9vcDo6bWFpbigpOworICAgIFJ1bkxv b3AqIG1haW5SdW5Mb29wID0gUnVuTG9vcDo6Y3VycmVudCgpOwogICAgIEdNYWluTG9vcCogaW5u ZXJtb3N0TG9vcCA9IG1haW5SdW5Mb29wLT5pbm5lcm1vc3RMb29wKCk7CiAgICAgaWYgKCFnX21h aW5fbG9vcF9pc19ydW5uaW5nKGlubmVybW9zdExvb3ApKSB7CiAgICAgICAgIGdfbWFpbl9sb29w X3J1bihpbm5lcm1vc3RMb29wKTsK