107869 2013-01-24 15:16:14 -0800 Some formerly-fixed objects scroll as if they are still fixed 2013-01-24 16:29:56 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin bdakin bdakin simon.fraser oldest_to_newest 815891 0 bdakin 2013-01-24 15:16:14 -0800 It is possible to have an object that toggles between being fixed and being static that will still scroll as if it is fixed when it has become static. The attached test case demonstrates the bugs. 815892 1 184591 bdakin 2013-01-24 15:17:20 -0800 Created attachment 184591 Test case 815903 2 184593 bdakin 2013-01-24 15:27:47 -0800 Created attachment 184593 Patch Unfortunately, I was unable to create a test for this because scrollingStateTreeAsText() will make that commit that wasn't happening happen anyway. 815960 3 bdakin 2013-01-24 16:29:56 -0800 Thanks, Simon! http://trac.webkit.org/changeset/140747 184591 2013-01-24 15:17:20 -0800 2013-01-24 15:17:20 -0800 Test case toggle-fixed-on-scroll.html text/html 1443 bdakin PGh0bWw+CjxoZWFkPgogICAgPHN0eWxlPgogICAgICAgIGJvZHkgewogICAgICAgICAgICBoZWln aHQ6IDIwMDBweDsKICAgICAgICB9CiAgICAgICAgLmNvbnRhaW5lciB7CiAgICAgICAgICAgIHBv c2l0aW9uOiBhYnNvbHV0ZTsKICAgICAgICAgICAgdG9wOiAxMDBweDsKICAgICAgICAgICAgaGVp Z2h0OiAzMDBweDsKICAgICAgICAgICAgd2lkdGg6IDMwMHB4OwogICAgICAgICAgICBib3JkZXI6 IDFweCBzb2xpZCBibGFjazsKICAgICAgICB9CiAgICAgICAgCiAgICAgICAgLnVuZGVyIHsKICAg ICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgICAgICBoZWlnaHQ6IDMwMHB4Owog ICAgICAgICAgICB3aWR0aDogMzAwcHg7CiAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IHNp bHZlcjsKICAgICAgICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZVooMCk7CiAgICAg ICAgfQogICAgICAgIC5ib3ggewogICAgICAgICAgICBoZWlnaHQ6IDUwcHg7CiAgICAgICAgICAg IHdpZHRoOiA1MHB4OwogICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOwogICAgICAg ICAgICBtYXJnaW46IDIwcHg7CiAgICAgICAgfQogICAgICAgIAogICAgICAgICNzaWRlYmFyc3Rp Y2t5IHsKICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgICAgICB0b3A6IDEw MHB4OwogICAgICAgIH0KICAgICAgICAKICAgICAgICAjc2lkZWJhcnN0aWNreS5zdGlja3kgewog ICAgICAgICAgICBwb3NpdGlvbjogZml4ZWQ7CiAgICAgICAgICAgIHRvcDogMDsKICAgICAgICB9 CiAgICA8L3N0eWxlPgogICAgPHNjcmlwdD4KICAgICAgICAKICAgICAgICBmdW5jdGlvbiBkb09u U2Nyb2xsKCkKICAgICAgICB7CiAgICAgICAgICAgIHZhciBzY3JvbGxUb3AgPSB3aW5kb3cuc2Ny b2xsWTsKICAgICAgICAgICAgdmFyIHN0aWNreSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdz aWRlYmFyc3RpY2t5Jyk7CiAgICAgICAgICAgIAogICAgICAgICAgICBpZiAoc2Nyb2xsVG9wID4g MTAwKQogICAgICAgICAgICAgICAgc3RpY2t5LmNsYXNzTGlzdC5hZGQoJ3N0aWNreScpOwogICAg ICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICBzdGlja3kuY2xhc3NMaXN0LnJlbW92ZSgnc3Rp Y2t5Jyk7CiAgICAgICAgfQogICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdzY3JvbGwn LCBkb09uU2Nyb2xsLCBmYWxzZSk7CiAgICA8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keT4KCiAgICA8 ZGl2IGNsYXNzPSJ1bmRlciI+CiAgICAgICAgCiAgICA8L2Rpdj4KICAgIDxkaXYgaWQ9InNpZGVi YXJzdGlja3kiPgogICAgICAgIDxkaXYgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6Z3JlZW47IHdp ZHRoOjUwcHg7IGhlaWdodDo1MHB4OyIgaWQ9Im5ld1NoYXJlQm94Ij48L2Rpdj4KICAgIDwvZGl2 Pgo8L2JvZHk+CjwvaHRtbD4K 184593 2013-01-24 15:27:47 -0800 2013-01-24 16:27:54 -0800 Patch for-review.txt text/plain 1527 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDczNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTI0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTb21lIGZvcm1lcmx5LWZpeGVkIG9i amVjdHMgc2Nyb2xsIGFzIGlmIHRoZXkgYXJlIHN0aWxsIGZpeGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc4NjkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmluZyBub2RlcyBuZWVkIHRvIG1h cmsgbV9oYXNDaGFuZ2VkUHJvcGVydGllcyBvbiB0aGUgc3RhdGUgdHJlZSwgb3RoZXJ3aXNlIAor ICAgICAgICB0aGV5IHdpbGwgbm90IGJlIGNvbW1pdHRlZCB0byB0aGUgc2Nyb2xsaW5nIHRyZWUg dW50aWwgc29tZXRoaW5nIGVsc2UgY2hhbmdlcywgCisgICAgICAgIHdoaWNoIGNvdWxkIGFjdHVh bGx5IHRha2UgYSB3aGlsZS4gRHVyaW5nIHRoZSBkZWxheSwgdGhlIHNjcm9sbGluZyB0cmVlIHdp bGwgCisgICAgICAgIGNvbnRpbnVlIHRvIG1vdmUgYXJvdW5kIHRoZSBmb3JtZXJseS1maXhlZCBv YmplY3QgYXMgbG9uZyBhcyBpdCBzdGlsbCBoYXMgYSBsYXllci4KKyAgICAgICAgKiBwYWdlL3Nj cm9sbGluZy9TY3JvbGxpbmdTdGF0ZVRyZWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xs aW5nU3RhdGVUcmVlOjpkaWRSZW1vdmVOb2RlKToKKwogMjAxMy0wMS0yNCAgTWlrZSBXZXN0ICA8 bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6ICJYSFIgbG9hZGVk ISIgbWVzc2FnZXMgc2hvdWxkIGJlIERlYnVnTWVzc2FnZUxldmVsLgpJbmRleDogU291cmNlL1dl YkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVUcmVlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZVRyZWUuY3BwCShy ZXZpc2lvbiAxNDA1OTUpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxp bmdTdGF0ZVRyZWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MCw2ICs3MCw3IEBAIHZvaWQgU2Ny b2xsaW5nU3RhdGVUcmVlOjpyZW1vdmVOb2RlKFNjcm8KIHZvaWQgU2Nyb2xsaW5nU3RhdGVUcmVl OjpkaWRSZW1vdmVOb2RlKFNjcm9sbGluZ05vZGVJRCBub2RlSUQpCiB7CiAgICAgbV9ub2Rlc1Jl bW92ZWRTaW5jZUxhc3RDb21taXQuYXBwZW5kKG5vZGVJRCk7CisgICAgbV9oYXNDaGFuZ2VkUHJv cGVydGllcyA9IHRydWU7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK