107865 2013-01-24 14:34:38 -0800 CertificateChain functions in ResourceResponse should be inside proper ifdefs 2013-01-24 15:29:44 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki ap beidson psolanki oldest_to_newest 815838 0 psolanki 2013-01-24 14:34:38 -0800 ResourceResponse::setCertificateChain() and ResourceResponse::certificateChain() are declared inside #if PLATFORM(MAC || USE(CFNETWORK) but the definition is inside !USE(CFNETWORK). We should put it in the proper ifdef. 815841 1 184580 psolanki 2013-01-24 14:37:29 -0800 Created attachment 184580 Patch 815844 2 184580 beidson 2013-01-24 14:38:44 -0800 Comment on attachment 184580 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184580&action=review > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:192 > > -#endif // USE(CFNETWORK) > +#endif I'm sure you meant to add "// PLATFORM(MAC) || USE(CFNETWORK)" :) 815904 3 psolanki 2013-01-24 15:29:44 -0800 Committed r140738: <http://trac.webkit.org/changeset/140738> 184580 2013-01-24 14:37:29 -0800 2013-01-24 14:38:44 -0800 Patch bug-107865-20130124143420.patch text/plain 1850 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGMzOWQyY2VjZDRlOWVk ODhhNDQxYTY0M2RlMjE0NTA5YTc1ODIyOS4uZjdjODY1MjQ0YzFlM2FiMDdhMTA2ZTAwNWJiMjRk MmQ0MDQxMDUzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTI0ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBDZXJ0aWZpY2F0ZUNo YWluIGZ1bmN0aW9ucyBpbiBSZXNvdXJjZVJlc3BvbnNlIHNob3VsZCBiZSBpbnNpZGUgcHJvcGVy IGlmZGVmcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA3ODY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TW92ZSBSZXNvdXJjZVJlc3BvbnNlOjpzZXRDZXJ0aWZpY2F0ZUNoYWluKCkgYW5kIFJlc291cmNl UmVzcG9uc2U6OmNlcnRpZmljYXRlQ2hhaW4oKQorICAgICAgICBiZSB1bmRlciB0aGUgc2FtZSBp ZmRlZnMgdGhhdCB0aGV5IGFyZSBkZWNsYXJlZCBpbi4KKworICAgICAgICBObyBuZXcgdGVzdHMg YmVjYXVzZSBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBsYXRmb3Jt L25ldHdvcmsvbWFjL1Jlc291cmNlUmVzcG9uc2VNYWMubW06CisKIDIwMTMtMDEtMjQgIE1heCBW dWpvdmljICA8bXZ1am92aWNAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgRmlsdGVyc10gQ1NT IG9wYWNpdHkgcHJvcGVydHkgY2xpcHMgZmlsdGVyIG91dHNldHMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVzcG9uc2VNYWMubW0gYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZVJlc3BvbnNlTWFjLm1t CmluZGV4IDJkM2Y2MmYyMzY0ODJiZDFhOGJhMDJkYTU1YjY3MTY3MTNjZjQ4MDIuLjFjNDhkM2Iw MDNjY2NjMmVjYTY4NDE0MDMwNTNhNTZlNWMwMGU0ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVzcG9uc2VNYWMubW0KKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VSZXNwb25zZU1hYy5tbQpA QCAtMTcxLDYgKzE3MSwxMCBAQCBib29sIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtQ29tcGFy ZShjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiBhLCBjb25zdCBSZXNvdXJjZQogICAgIHJldHVybiBh Lm5zVVJMUmVzcG9uc2UoKSA9PSBiLm5zVVJMUmVzcG9uc2UoKTsKIH0KIAorI2VuZGlmIC8vIFVT RShDRk5FVFdPUkspCisKKyNpZiBQTEFURk9STShNQUMpIHx8IFVTRShDRk5FVFdPUkspCisKIHZv aWQgUmVzb3VyY2VSZXNwb25zZTo6c2V0Q2VydGlmaWNhdGVDaGFpbihDRkFycmF5UmVmIGNlcnRp ZmljYXRlQ2hhaW4pCiB7CiAgICAgQVNTRVJUKCF3a0NvcHlOU1VSTFJlc3BvbnNlQ2VydGlmaWNh dGVDaGFpbihuc1VSTFJlc3BvbnNlKCkpKTsKQEAgLTE4NSw3ICsxODksNyBAQCBSZXRhaW5QdHI8 Q0ZBcnJheVJlZj4gUmVzb3VyY2VSZXNwb25zZTo6Y2VydGlmaWNhdGVDaGFpbigpIGNvbnN0CiAg ICAgcmV0dXJuIGFkb3B0Q0Yod2tDb3B5TlNVUkxSZXNwb25zZUNlcnRpZmljYXRlQ2hhaW4obnNV UkxSZXNwb25zZSgpKSk7CiB9CiAKLSNlbmRpZiAvLyBVU0UoQ0ZORVRXT1JLKQorI2VuZGlmCiAK IH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAo=