107860 2013-01-24 13:57:38 -0800 DFG::JITCompiler::getSpeculation() methods are badly named and superfluous 2013-01-24 14:00:58 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 106868 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 815804 0 fpizlo 2013-01-24 13:57:38 -0800 They should be called getPrediction(). But they're superfluous since it takes less typing to just call Node::prediction() anyway. 815806 1 184574 fpizlo 2013-01-24 13:58:45 -0800 Created attachment 184574 the patch 815810 2 184574 mhahnenberg 2013-01-24 13:59:44 -0800 Comment on attachment 184574 the patch r=me 815812 3 fpizlo 2013-01-24 14:00:58 -0800 Landed in http://trac.webkit.org/changeset/140719 184574 2013-01-24 13:58:45 -0800 2013-01-24 13:59:43 -0800 the patch blah.patch text/plain 2775 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQwNzE4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTAxLTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpKSVRDb21waWxlcjo6Z2V0U3BlY3VsYXRpb24oKSBtZXRob2RzIGFyZSBiYWRseSBuYW1l ZCBhbmQgc3VwZXJmbHVvdXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNzg2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZGZnL0RGR0pJVENvbXBpbGVyLmg6CisgICAgICAgIChKSVRDb21waWxlcik6 CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwOgorICAgICAgICAoSlNDOjpE Rkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlTG9naWNhbE5vdCk6CisgICAgICAgIChKU0M6OkRG Rzo6U3BlY3VsYXRpdmVKSVQ6OmVtaXRCcmFuY2gpOgorCiAyMDEzLTAxLTI0ICBNYXJrIEhhaG5l bmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgT2JqZWN0aXZlLUMgQVBJ OiBSZW5hbWUgSlNWYWx1ZS5oL0FQSUpTVmFsdWUuaCB0byBKU0NKU1ZhbHVlLmgvSlNWYWx1ZS5o CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5oCShyZXZp c2lvbiAxNDA0OTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVy LmgJKHdvcmtpbmcgY29weSkKQEAgLTM0MCwxMSArMzQwLDYgQEAgcHVibGljOgogICAgICAgICBt X2V4Y2VwdGlvbkNoZWNrcy5hcHBlbmQoQ2FsbEV4Y2VwdGlvblJlY29yZChmdW5jdGlvbkNhbGws IGV4Y2VwdGlvbkNoZWNrLCBjb2RlT3JpZ2luKSk7CiAgICAgfQogICAgIAotICAgIC8vIEhlbHBl ciBtZXRob2RzIHRvIGdldCBwcmVkaWN0aW9ucwotICAgIFNwZWN1bGF0ZWRUeXBlIGdldFNwZWN1 bGF0aW9uKE5vZGUmIG5vZGUpIHsgcmV0dXJuIG5vZGUucHJlZGljdGlvbigpOyB9Ci0gICAgU3Bl Y3VsYXRlZFR5cGUgZ2V0U3BlY3VsYXRpb24oTm9kZUluZGV4IG5vZGVJbmRleCkgeyByZXR1cm4g Z2V0U3BlY3VsYXRpb24oZ3JhcGgoKVtub2RlSW5kZXhdKTsgfQotICAgIFNwZWN1bGF0ZWRUeXBl IGdldFNwZWN1bGF0aW9uKEVkZ2Ugbm9kZVVzZSkgeyByZXR1cm4gZ2V0U3BlY3VsYXRpb24obm9k ZVVzZS5pbmRleCgpKTsgfQotCiAgICAgdm9pZCBhcHBlbmRFeGl0SW5mbyhNYWNyb0Fzc2VtYmxl cjo6SnVtcExpc3QganVtcHNUb0ZhaWwgPSBNYWNyb0Fzc2VtYmxlcjo6SnVtcExpc3QoKSkKICAg ICB7CiAgICAgICAgIE9TUkV4aXRDb21waWxhdGlvbkluZm8gaW5mbzsKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAkocmV2aXNp b24gMTQwNDkzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VDY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTkzNCw3ICsxOTM0LDcgQEAgdm9pZCBTcGVjdWxh dGl2ZUpJVDo6Y29tcGlsZUxvZ2ljYWxOb3QoTgogICAgICAgICByZXR1cm47CiAgICAgfQogICAg IAotICAgIFNwZWN1bGF0ZWRUeXBlIHByZWRpY3Rpb24gPSBtX2ppdC5nZXRTcGVjdWxhdGlvbihu b2RlLmNoaWxkMSgpKTsKKyAgICBTcGVjdWxhdGVkVHlwZSBwcmVkaWN0aW9uID0gYXQobm9kZS5j aGlsZDEoKSkucHJlZGljdGlvbigpOwogICAgIGlmIChpc0Jvb2xlYW5TcGVjdWxhdGlvbihwcmVk aWN0aW9uKSkgewogICAgICAgICBpZiAoaXNCb29sZWFuU3BlY3VsYXRpb24obV9zdGF0ZS5mb3JO b2RlKG5vZGUuY2hpbGQxKCkpLm1fdHlwZSkpIHsKICAgICAgICAgICAgIFNwZWN1bGF0ZUJvb2xl YW5PcGVyYW5kIHZhbHVlKHRoaXMsIG5vZGUuY2hpbGQxKCkpOwpAQCAtMjA2Niw3ICsyMDY2LDcg QEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6ZW1pdEJyYW5jaChOb2RlJiBubwogICAgICAgICBKU1Zh bHVlT3BlcmFuZCB2YWx1ZSh0aGlzLCBub2RlLmNoaWxkMSgpKTsKICAgICAgICAgR1BSUmVnIHZh bHVlR1BSID0gdmFsdWUuZ3ByKCk7CiAgICAgICAgIAotICAgICAgICBib29sIHByZWRpY3RCb29s ZWFuID0gaXNCb29sZWFuU3BlY3VsYXRpb24obV9qaXQuZ2V0U3BlY3VsYXRpb24obm9kZS5jaGls ZDEoKSkpOworICAgICAgICBib29sIHByZWRpY3RCb29sZWFuID0gaXNCb29sZWFuU3BlY3VsYXRp b24oYXQobm9kZS5jaGlsZDEoKSkucHJlZGljdGlvbigpKTsKICAgICAKICAgICAgICAgaWYgKHBy ZWRpY3RCb29sZWFuKSB7CiAgICAgICAgICAgICBpZiAoaXNCb29sZWFuU3BlY3VsYXRpb24obV9z dGF0ZS5mb3JOb2RlKG5vZGUuY2hpbGQxKCkpLm1fdHlwZSkpIHsK