107842 2013-01-24 10:39:23 -0800 [BlackBerry] Fix crash in SpellingHandler 2013-01-24 12:36:46 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nghanavatian mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 815595 0 nima.ghanavatian 2013-01-24 10:39:23 -0800 ssia 815611 1 184528 nghanavatian 2013-01-24 10:49:33 -0800 Created attachment 184528 Patch 815616 2 184528 rwlbuis 2013-01-24 10:51:19 -0800 Comment on attachment 184528 Patch LGTM. 815737 3 184528 webkit.review.bot 2013-01-24 12:36:43 -0800 Comment on attachment 184528 Patch Clearing flags on attachment: 184528 Committed r140708: <http://trac.webkit.org/changeset/140708> 815738 4 webkit.review.bot 2013-01-24 12:36:46 -0800 All reviewed patches have been landed. Closing bug. 184528 2013-01-24 10:49:33 -0800 2013-01-24 12:36:43 -0800 Patch bug-107842-20130124134020.patch text/plain 3273 nghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA5ZmQ5YzRlMDU0Y2QxOTY3Njg3OWEzNmUyYTcxZDdhNDYwMTUyY2U5Li4yZGM3MjJkYTRj ZmY0ODFhNTM4MmJlMjNjMDk4NzY3ZDQxMWM4ZGQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMy0wMS0yNCAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBGaXggY3Jhc2ggaW4g U3BlbGxpbmdIYW5kbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDc4NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJZiB3ZSBoYXZlIGFuIGVtcHR5IHJhbmdlIG9yIG9uZSB3aXRoIGFsbCBzcGFjZXMs IHdlIGNhbiBzaW1wbHkgcmV0dXJuIDAgaW5zdGVhZCBvZgorICAgICAgICBzdGlsbCBjcmVhdGlu ZyBhIHJhbmdlLiBQdXR0aW5nIGluIGEgbnVsbCBjaGVjayBhZnRlciB0cmltbWluZyB0byBjYXRj aCB0aGlzIGNhc2UKKyAgICAgICAgd2hpY2ggd2FzIGNhdXNpbmcgdGhlIGNyYXNoIGluIHNvbWUg RFJUIHRlc3RzLgorCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgTWlrZSBGZW50b24u CisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwOgorICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpET01TdXBwb3J0Ojp0cmltV2hpdGVzcGFjZUZyb21SYW5nZSk6Cisg ICAgICAgICogV2ViS2l0U3VwcG9ydC9TcGVsbGluZ0hhbmRsZXIuY3BwOgorICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpTcGVsbGluZ0hhbmRsZXI6OmNyZWF0ZVNwZWxsQ2hlY2tSZXF1ZXN0 KToKKwogMjAxMy0wMS0yNCAgU2VhbiBXYW5nICA8WHVld2VuLldhbmdAdG9yY2htb2JpbGUuY29t LmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBJdCBjYW4ndCBTZWxlY3QgdGV4dHMgaW4gbWFp biBmcmFtZSB3aGVuIHRoZSBjdXJyZW50IGZvY3VzIGlzIGluIGEgSUZyYW1lCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwCmlu ZGV4IGRhMWM0YWM1OTAwNWRiMTY1YzdmMDk2ZGYwOTM5Zjc2ZGEzMzlkNjEuLmM5ODY0YTc5YjY4 NzIxZGI4ZDRiN2ZjY2EzMjQ2ZDc5ODJhM2UzMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwCkBAIC01MjQsNyArNTI0 LDcgQEAgUGFzc1JlZlB0cjxSYW5nZT4gdHJpbVdoaXRlc3BhY2VGcm9tUmFuZ2UoUGFzc1JlZlB0 cjxSYW5nZT4gcmFuZ2UpCiBQYXNzUmVmUHRyPFJhbmdlPiB0cmltV2hpdGVzcGFjZUZyb21SYW5n ZShWaXNpYmxlUG9zaXRpb24gc3RhcnRQb3NpdGlvbiwgVmlzaWJsZVBvc2l0aW9uIGVuZFBvc2l0 aW9uKQogewogICAgIGlmIChpc0VtcHR5UmFuZ2VPckFsbFNwYWNlcyhzdGFydFBvc2l0aW9uLCBl bmRQb3NpdGlvbikpCi0gICAgICAgIHJldHVybiBWaXNpYmxlU2VsZWN0aW9uKGVuZFBvc2l0aW9u LCBlbmRQb3NpdGlvbikudG9Ob3JtYWxpemVkUmFuZ2UoKTsKKyAgICAgICAgcmV0dXJuIDA7CiAK ICAgICB3aGlsZSAoaXNXaGl0ZXNwYWNlKHN0YXJ0UG9zaXRpb24uY2hhcmFjdGVyQWZ0ZXIoKSkp CiAgICAgICAgIHN0YXJ0UG9zaXRpb24gPSBzdGFydFBvc2l0aW9uLm5leHQoKTsKQEAgLTUzMiw3 ICs1MzIsNyBAQCBQYXNzUmVmUHRyPFJhbmdlPiB0cmltV2hpdGVzcGFjZUZyb21SYW5nZShWaXNp YmxlUG9zaXRpb24gc3RhcnRQb3NpdGlvbiwgVmlzaWJsZQogICAgIHdoaWxlIChpc1doaXRlc3Bh Y2UoZW5kUG9zaXRpb24uY2hhcmFjdGVyQmVmb3JlKCkpKQogICAgICAgICBlbmRQb3NpdGlvbiA9 IGVuZFBvc2l0aW9uLnByZXZpb3VzKCk7CiAKLSAgICByZXR1cm4gVmlzaWJsZVNlbGVjdGlvbihz dGFydFBvc2l0aW9uLCBlbmRQb3NpdGlvbikudG9Ob3JtYWxpemVkUmFuZ2UoKTsKKyAgICByZXR1 cm4gbWFrZVJhbmdlKHN0YXJ0UG9zaXRpb24sIGVuZFBvc2l0aW9uKTsKIH0KIAogYm9vbCBpc0Vt cHR5UmFuZ2VPckFsbFNwYWNlcyhWaXNpYmxlUG9zaXRpb24gc3RhcnRQb3NpdGlvbiwgVmlzaWJs ZVBvc2l0aW9uIGVuZFBvc2l0aW9uKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYktpdFN1cHBvcnQvU3BlbGxpbmdIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NwZWxsaW5nSGFuZGxlci5jcHAKaW5kZXggMTc4MzE3Y2Rl YWRhMzAwOWQ5NGQ1ZmNiOWE4NWZjYjlkZTcxNDkwZS4uYmM5ODBiOGI0MWY0MjBkZjc5MjVkNDA2 OWNiMmQ0NmRjZjYyYThhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YktpdFN1cHBvcnQvU3BlbGxpbmdIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9TcGVsbGluZ0hhbmRsZXIuY3BwCkBAIC04MSw2ICs4MSw4IEBA IHZvaWQgU3BlbGxpbmdIYW5kbGVyOjpjcmVhdGVTcGVsbENoZWNrUmVxdWVzdChQYXNzUmVmUHRy PFdlYkNvcmU6OlJhbmdlPiByYW5nZUZvCiB7CiAgICAgUmVmUHRyPFdlYkNvcmU6OlJhbmdlPiBy YW5nZUZvclNwZWxsQ2hlY2tpbmcgPSByYW5nZUZvclNwZWxsQ2hlY2tpbmdQdHI7CiAgICAgcmFu Z2VGb3JTcGVsbENoZWNraW5nID0gRE9NU3VwcG9ydDo6dHJpbVdoaXRlc3BhY2VGcm9tUmFuZ2Uo cmFuZ2VGb3JTcGVsbENoZWNraW5nKTsKKyAgICBpZiAoIXJhbmdlRm9yU3BlbGxDaGVja2luZykK KyAgICAgICAgcmV0dXJuOwogCiAgICAgU3BlbGxpbmdMb2coUGxhdGZvcm06OkxvZ0xldmVsSW5m bywgIlNwZWxsaW5nSGFuZGxlcjo6Y3JlYXRlU3BlbGxDaGVja1JlcXVlc3QgU3Vic3RyaW5nIHRl eHQgaXMgJyVzJywgb2Ygc2l6ZSAlZCIKICAgICAgICAgLCByYW5nZUZvclNwZWxsQ2hlY2tpbmct PnRleHQoKS5sYXRpbjEoKS5kYXRhKCkK