<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>107841</bug_id>
          
          <creation_ts>2013-01-24 09:51:57 -0800</creation_ts>
          <short_desc>[Skia] Update SkiaImageFilterBuilder&apos;s brightness matrix to match Chromium&apos;s implementation</short_desc>
          <delta_ts>2013-01-31 09:38:23 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Florin Malita">fmalita</reporter>
          <assigned_to name="Florin Malita">fmalita</assigned_to>
          <cc>dino</cc>
    
    <cc>junov</cc>
    
    <cc>krit</cc>
    
    <cc>senorblanco</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>815566</commentid>
    <comment_count>0</comment_count>
    <who name="Florin Malita">fmalita</who>
    <bug_when>2013-01-24 09:51:57 -0800</bug_when>
    <thetext>After http://trac.webkit.org/changeset/139770, the brightness formula needs to be updated for both Chromium and WK/Skia.

This tracks the WK/Skia change. Corresponding Chromium CL: https://codereview.chromium.org/12033075/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>815567</commentid>
    <comment_count>1</comment_count>
      <attachid>184518</attachid>
    <who name="Florin Malita">fmalita</who>
    <bug_when>2013-01-24 09:56:32 -0800</bug_when>
    <thetext>Created attachment 184518
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>815581</commentid>
    <comment_count>2</comment_count>
      <attachid>184518</attachid>
    <who name="Stephen White">senorblanco</who>
    <bug_when>2013-01-24 10:19:39 -0800</bug_when>
    <thetext>Comment on attachment 184518
Patch

Looks good (bots willing).  r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>821591</commentid>
    <comment_count>3</comment_count>
      <attachid>184518</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-31 09:38:19 -0800</bug_when>
    <thetext>Comment on attachment 184518
Patch

Clearing flags on attachment: 184518

Committed r141427: &lt;http://trac.webkit.org/changeset/141427&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>821592</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-31 09:38:23 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>184518</attachid>
            <date>2013-01-24 09:56:32 -0800</date>
            <delta_ts>2013-01-31 09:38:19 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-107841-20130124125324.patch</filename>
            <type>text/plain</type>
            <size>1736</size>
            <attacher name="Florin Malita">fmalita</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjRmMDNhNTMwY2U3NzZj
OWFhM2QxMjZkYzY0M2U4NmRhYTA4ODU3OC4uMjAwZWI3YTI2YWMxMjk0ZDQxMTE2NzUyNDVjMzBl
ZTVjMjAwODVlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTI0ICBGbG9y
aW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1NraWFdIFVwZGF0
ZSBTa2lhSW1hZ2VGaWx0ZXJCdWlsZGVyJ3MgYnJpZ2h0bmVzcyBtYXRyaXggdG8gbWF0Y2ggQ2hy
b21pdW0ncyBpbXBsZW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTA3ODQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgVXBkYXRlIFNraWEncyBicmlnaHRuZXNzIGZpbHRlciB0byBtYXRjaCB0
aGUgc3BlYyBhZnRlciBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMzk3NzAuCisK
KyAgICAgICAgTm8gbmV3IHRlc3RzOiBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzIChjdXJyZW50
bHkgZGlzYWJsZWQgcGVuZGluZyByZWJhc2VsaW5lKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dy
YXBoaWNzL2ZpbHRlcnMvc2tpYS9Ta2lhSW1hZ2VGaWx0ZXJCdWlsZGVyLmNwcDoKKwogMjAxMy0w
MS0yMyAgSnVuIEppYW5nICA8anVuLmEuamlhbmdAaW50ZWwuY29tPgogCiAgICAgICAgIEF2b2lk
IHVubmVjZXNzYXJ5IGZvcm1hdCBjb252ZXJzaW9uIGZvciB0ZXh7U3VifUltYWdlMkQoKSBmb3Ig
SW1hZ2VEYXRhIG9mIFdlYkdMCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n
cmFwaGljcy9maWx0ZXJzL3NraWEvU2tpYUltYWdlRmlsdGVyQnVpbGRlci5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL3NraWEvU2tpYUltYWdlRmlsdGVyQnVp
bGRlci5jcHAKaW5kZXggOGI4NjY2OGYwM2MxZDFlOWNhYzZkNWE0MTBjY2I0MmRkMjJjMzk0Ny4u
OGZmNGEzMWMyYWQ4YzEyYjZhNTNlNmRmMTgwNjM4NzY1NzRhODFiNSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9za2lhL1NraWFJbWFnZUZpbHRl
ckJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRl
cnMvc2tpYS9Ta2lhSW1hZ2VGaWx0ZXJCdWlsZGVyLmNwcApAQCAtMzksOCArMzksOCBAQCBuYW1l
c3BhY2Ugewogdm9pZCBnZXRCcmlnaHRuZXNzTWF0cml4KGZsb2F0IGFtb3VudCwgU2tTY2FsYXIg
bWF0cml4WzIwXSkKIHsKICAgICBtZW1zZXQobWF0cml4LCAwLCAyMCAqIHNpemVvZihTa1NjYWxh
cikpOwotICAgIG1hdHJpeFswXSA9IG1hdHJpeFs2XSA9IG1hdHJpeFsxMl0gPSBtYXRyaXhbMThd
ID0gMTsKLSAgICBtYXRyaXhbNF0gPSBtYXRyaXhbOV0gPSBtYXRyaXhbMTRdID0gYW1vdW50ICog
MjU1OworICAgIG1hdHJpeFswXSA9IG1hdHJpeFs2XSA9IG1hdHJpeFsxMl0gPSBhbW91bnQ7Cisg
ICAgbWF0cml4WzE4XSA9IDE7CiB9CiAKIHZvaWQgZ2V0Q29udHJhc3RNYXRyaXgoZmxvYXQgYW1v
dW50LCBTa1NjYWxhciBtYXRyaXhbMjBdKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>