107828 2013-01-24 08:07:15 -0800 Web Inspector: Move dispatchMouseEvent optional params after x,y 2013-01-25 05:12:13 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kkania kkania apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 815482 0 kkania 2013-01-24 08:07:15 -0800 In r140649 we moved the timestamp/modifiers params to be before x,y to match dispatchKeyEvent. That makes JSCompiler produce warning because optional args should be after non-optional ones. Moving these back to their original place... 815483 1 184501 kkania 2013-01-24 08:11:25 -0800 Created attachment 184501 Patch 815519 2 184501 webkit.review.bot 2013-01-24 08:59:46 -0800 Comment on attachment 184501 Patch Rejecting attachment 184501 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 184501, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: webkit-commit-queue Parsed 4 diffs from patch file(s). patch: **** Can't create file /tmp/ppTVTENi : No space left on device patch: **** Can't create file /tmp/ppDCvFCj : No space left on device patch: **** Can't create file /tmp/ppJyO4ij : No space left on device patch: **** Can't create file /tmp/pppOsUwj : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Pavel Feldman']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16073854 816502 3 184501 webkit.review.bot 2013-01-25 05:12:10 -0800 Comment on attachment 184501 Patch Clearing flags on attachment: 184501 Committed r140818: <http://trac.webkit.org/changeset/140818> 816503 4 webkit.review.bot 2013-01-25 05:12:13 -0800 All reviewed patches have been landed. Closing bug. 184501 2013-01-24 08:11:25 -0800 2013-01-25 05:12:10 -0800 Patch bug-107828-20130124080817.patch text/plain 5284 kkania U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzdiOWZmZGVhZmI2NDg1 MzQxMTk2YjU3MDE4YzMyNDRlNzkxYTQ5YS4uMTFkMzc4MjhlNWQzOWI4ZTQ3YzI3ZjdhYjk0ZDA0 NWExNmU0MWM2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTI0ICBLZW4g S2FuaWEgIDxra2FuaWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE1v dmUgZGlzcGF0Y2hNb3VzZUV2ZW50IG9wdGlvbmFsIHBhcmFtcyBhZnRlciB4LHkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzgyOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYXMg dGhpcyBqdXN0IHJlYXJyYW5nZXMgdGhlIG9yZGVyIG9mIGFyZ3VtZW50cyB0byBtYWtlCisgICAg ICAgIEpTQ29tcGlsZXIgaGFwcHkuIFRoZSBwYXJhbXMgd2VyZSByZWFycmFuZ2VkIGluIHIxNDA2 NDkgdG8gbWF0Y2gKKyAgICAgICAgZGlzcGF0Y2hLZXlFdmVudCdzIHBhcmFtcy4KKworICAgICAg ICAqIGluc3BlY3Rvci9JbnNwZWN0b3IuanNvbjoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVj dG9ySW5wdXRBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JJbnB1dEFnZW50 OjpkaXNwYXRjaE1vdXNlRXZlbnQpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JJbnB1 dEFnZW50Lmg6CisgICAgICAgIChJbnNwZWN0b3JJbnB1dEFnZW50KToKKwogMjAxMy0wMS0yNCAg Wm9sdGFuIEFydmFpICA8emFydmFpQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBSZW1vdmlu ZyBkZWxldGVkIGZpbGVzIGZyb20gV2ViQ29yZS9UYXJnZXQucHJpIGFmdGVyIHIxNDAzOTkuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLmpzb24gYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLmpzb24KaW5kZXggNjFmYWRkNDUxZGM1OGEx N2M0YmI4OTJjMzRhM2YzNjU0YzIxNzkyYy4uZTViMmMxYjc3NTdhNTM0ZmExMDRhYWYzMTJmN2Nk ZWE5M2VlN2IyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ci5qc29uCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3IuanNvbgpAQCAt MzM5OCwxMCArMzM5OCwxMCBAQAogICAgICAgICAgICAgICAgICJuYW1lIjogImRpc3BhdGNoTW91 c2VFdmVudCIsCiAgICAgICAgICAgICAgICAgInBhcmFtZXRlcnMiOiBbCiAgICAgICAgICAgICAg ICAgICAgIHsgIm5hbWUiOiAidHlwZSIsICJ0eXBlIjogInN0cmluZyIsICJlbnVtIjogWyJtb3Vz ZVByZXNzZWQiLCAibW91c2VSZWxlYXNlZCIsICJtb3VzZU1vdmVkIl0sICJkZXNjcmlwdGlvbiI6 ICJUeXBlIG9mIHRoZSBtb3VzZSBldmVudC4iIH0sCi0gICAgICAgICAgICAgICAgICAgIHsgIm5h bWUiOiAibW9kaWZpZXJzIiwgInR5cGUiOiAiaW50ZWdlciIsICJvcHRpb25hbCI6IHRydWUsICJk ZXNjcmlwdGlvbiI6ICJCaXQgZmllbGQgcmVwcmVzZW50aW5nIHByZXNzZWQgbW9kaWZpZXIga2V5 cy4gQWx0PTEsIEN0cmw9MiwgTWV0YS9Db21tYW5kPTQsIFNoaWZ0PTggKGRlZmF1bHQ6IDApLiIg fSwKLSAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJ0aW1lc3RhbXAiLCAidHlwZSI6ICJu dW1iZXIiLCAib3B0aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiVGltZSBhdCB3aGljaCB0 aGUgZXZlbnQgb2NjdXJyZWQuIE1lYXN1cmVkIGluIFVUQyB0aW1lIGluIHNlY29uZHMgc2luY2Ug SmFudWFyeSAxLCAxOTcwIChkZWZhdWx0OiBjdXJyZW50IHRpbWUpLiIgfSwKICAgICAgICAgICAg ICAgICAgICAgeyAibmFtZSI6ICJ4IiwgInR5cGUiOiAiaW50ZWdlciIsICJkZXNjcmlwdGlvbiI6 ICJYIGNvb3JkaW5hdGUgb2YgdGhlIGV2ZW50IHJlbGF0aXZlIHRvIHRoZSBtYWluIGZyYW1lJ3Mg dmlld3BvcnQuIn0sCiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAieSIsICJ0eXBlIjog ImludGVnZXIiLCAiZGVzY3JpcHRpb24iOiAiWSBjb29yZGluYXRlIG9mIHRoZSBldmVudCByZWxh dGl2ZSB0byB0aGUgbWFpbiBmcmFtZSdzIHZpZXdwb3J0LiAwIHJlZmVycyB0byB0aGUgdG9wIG9m IHRoZSB2aWV3cG9ydCBhbmQgWSBpbmNyZWFzZXMgYXMgaXQgcHJvY2VlZHMgdG93YXJkcyB0aGUg Ym90dG9tIG9mIHRoZSB2aWV3cG9ydC4ifSwKKyAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6 ICJtb2RpZmllcnMiLCAidHlwZSI6ICJpbnRlZ2VyIiwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2Ny aXB0aW9uIjogIkJpdCBmaWVsZCByZXByZXNlbnRpbmcgcHJlc3NlZCBtb2RpZmllciBrZXlzLiBB bHQ9MSwgQ3RybD0yLCBNZXRhL0NvbW1hbmQ9NCwgU2hpZnQ9OCAoZGVmYXVsdDogMCkuIiB9LAor ICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInRpbWVzdGFtcCIsICJ0eXBlIjogIm51bWJl ciIsICJvcHRpb25hbCI6IHRydWUsICJkZXNjcmlwdGlvbiI6ICJUaW1lIGF0IHdoaWNoIHRoZSBl dmVudCBvY2N1cnJlZC4gTWVhc3VyZWQgaW4gVVRDIHRpbWUgaW4gc2Vjb25kcyBzaW5jZSBKYW51 YXJ5IDEsIDE5NzAgKGRlZmF1bHQ6IGN1cnJlbnQgdGltZSkuIiB9LAogICAgICAgICAgICAgICAg ICAgICB7ICJuYW1lIjogImJ1dHRvbiIsICJ0eXBlIjogInN0cmluZyIsICJlbnVtIjogWyJub25l IiwgImxlZnQiLCAibWlkZGxlIiwgInJpZ2h0Il0sICJvcHRpb25hbCI6IHRydWUsICJkZXNjcmlw dGlvbiI6ICJNb3VzZSBidXR0b24gKGRlZmF1bHQ6IFwibm9uZVwiKS4iIH0sCiAgICAgICAgICAg ICAgICAgICAgIHsgIm5hbWUiOiAiY2xpY2tDb3VudCIsICJ0eXBlIjogImludGVnZXIiLCAib3B0 aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiTnVtYmVyIG9mIHRpbWVzIHRoZSBtb3VzZSBi dXR0b24gd2FzIGNsaWNrZWQgKGRlZmF1bHQ6IDApLiIgfQogICAgICAgICAgICAgICAgIF0sCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5wdXRBZ2VudC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5wdXRBZ2VudC5jcHAKaW5k ZXggYzhmMDFmNTdhNGNjNjcyMjZjZjM5ZTFmZmNkMTk1ZjdmNmZlMjg4NC4uYjcxMDgwMzBkMTI3 NmRlZDk0ZGIyZDQzNGRjYTJjMDE4MWMwMWNlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvcklucHV0QWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JJbnB1dEFnZW50LmNwcApAQCAtOTMsNyArOTMsNyBAQCB2b2lkIElu c3BlY3RvcklucHV0QWdlbnQ6OmRpc3BhdGNoS2V5RXZlbnQoRXJyb3JTdHJpbmcqIGVycm9yLCBj b25zdCBTdHJpbmcmIHR5cAogICAgIG1fcGFnZS0+bWFpbkZyYW1lKCktPmV2ZW50SGFuZGxlcigp LT5rZXlFdmVudChldmVudCk7CiB9CiAKLXZvaWQgSW5zcGVjdG9ySW5wdXRBZ2VudDo6ZGlzcGF0 Y2hNb3VzZUV2ZW50KEVycm9yU3RyaW5nKiBlcnJvciwgY29uc3QgU3RyaW5nJiB0eXBlLCBjb25z dCBpbnQqIG1vZGlmaWVycywgY29uc3QgZG91YmxlKiB0aW1lc3RhbXAsIGludCB4LCBpbnQgeSwg Y29uc3QgU3RyaW5nKiBidXR0b24sIGNvbnN0IGludCogY2xpY2tDb3VudCkKK3ZvaWQgSW5zcGVj dG9ySW5wdXRBZ2VudDo6ZGlzcGF0Y2hNb3VzZUV2ZW50KEVycm9yU3RyaW5nKiBlcnJvciwgY29u c3QgU3RyaW5nJiB0eXBlLCBpbnQgeCwgaW50IHksIGNvbnN0IGludCogbW9kaWZpZXJzLCBjb25z dCBkb3VibGUqIHRpbWVzdGFtcCwgY29uc3QgU3RyaW5nKiBidXR0b24sIGNvbnN0IGludCogY2xp Y2tDb3VudCkKIHsKICAgICBQbGF0Zm9ybUV2ZW50OjpUeXBlIGNvbnZlcnRlZFR5cGU7CiAgICAg aWYgKHR5cGUgPT0gIm1vdXNlUHJlc3NlZCIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9ySW5wdXRBZ2VudC5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvcklucHV0QWdlbnQuaAppbmRleCAzNzFiZTA0NTIyMzMzOWJlNjg4MmM2NzRlNDBj OTk0MDNmNzBlMWJhLi4zMjZiZTc2MzA0MjM2NmUwZDYxNThjYzgwMjAyNTgwNzcxOGJjMzE2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5wdXRBZ2VudC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JJbnB1dEFnZW50LmgKQEAg LTU3LDcgKzU3LDcgQEAgcHVibGljOgogCiAgICAgLy8gTWV0aG9kcyBjYWxsZWQgZnJvbSB0aGUg ZnJvbnRlbmQgZm9yIHNpbXVsYXRpbmcgaW5wdXQuCiAgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNo S2V5RXZlbnQoRXJyb3JTdHJpbmcqLCBjb25zdCBTdHJpbmcmIHR5cGUsIGNvbnN0IGludCogbW9k aWZpZXJzLCBjb25zdCBkb3VibGUqIHRpbWVzdGFtcCwgY29uc3QgU3RyaW5nKiB0ZXh0LCBjb25z dCBTdHJpbmcqIHVubW9kaWZpZWRUZXh0LCBjb25zdCBTdHJpbmcqIGtleUlkZW50aWZpZXIsIGNv bnN0IGludCogd2luZG93c1ZpcnR1YWxLZXlDb2RlLCBjb25zdCBpbnQqIG5hdGl2ZVZpcnR1YWxL ZXlDb2RlLCBjb25zdCBpbnQqIG1hY0NoYXJDb2RlLCBjb25zdCBib29sKiBhdXRvUmVwZWF0LCBj b25zdCBib29sKiBpc0tleXBhZCwgY29uc3QgYm9vbCogaXNTeXN0ZW1LZXkpOwotICAgIHZpcnR1 YWwgdm9pZCBkaXNwYXRjaE1vdXNlRXZlbnQoRXJyb3JTdHJpbmcqLCBjb25zdCBTdHJpbmcmIHR5 cGUsIGNvbnN0IGludCogbW9kaWZpZXJzLCBjb25zdCBkb3VibGUqIHRpbWVzdGFtcCwgaW50IHgs IGludCB5LCBjb25zdCBTdHJpbmcqIGJ1dHRvbiwgY29uc3QgaW50KiBjbGlja0NvdW50KTsKKyAg ICB2aXJ0dWFsIHZvaWQgZGlzcGF0Y2hNb3VzZUV2ZW50KEVycm9yU3RyaW5nKiwgY29uc3QgU3Ry aW5nJiB0eXBlLCBpbnQgeCwgaW50IHksIGNvbnN0IGludCogbW9kaWZpZXJzLCBjb25zdCBkb3Vi bGUqIHRpbWVzdGFtcCwgY29uc3QgU3RyaW5nKiBidXR0b24sIGNvbnN0IGludCogY2xpY2tDb3Vu dCk7CiAKIHByaXZhdGU6CiAgICAgSW5zcGVjdG9ySW5wdXRBZ2VudChJbnN0cnVtZW50aW5nQWdl bnRzKiwgSW5zcGVjdG9yQ29tcG9zaXRlU3RhdGUqLCBQYWdlKik7Cg==