107817 2013-01-24 06:09:38 -0800 Web Inspector: "XHR loaded!" messages should be DebugMessageLevel. 2013-01-24 15:18:54 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED WebExposed P2 Normal --- 97978 1 mkwst mkwst apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 815391 0 mkwst 2013-01-24 06:09:38 -0800 We currently allow users to opt-in to displaying messages when XHR loads successfully. These shouldn't be LogMessageLevel; that should be reserved for user-generated messages (`console.XXX()` calls). 815408 1 mkwst 2013-01-24 06:19:03 -0800 It also shouldn't be "LogMessageType", but "NetworkMessageType". Patch in a moment. 815412 2 184481 mkwst 2013-01-24 06:25:49 -0800 Created attachment 184481 Patch 815475 3 184481 webkit.review.bot 2013-01-24 08:02:00 -0800 Comment on attachment 184481 Patch Rejecting attachment 184481 from commit-queue. New failing tests: fast/repaint/selection-clear.html Full output: http://queues.webkit.org/results/16073816 815742 4 184481 mkwst 2013-01-24 12:42:50 -0800 Comment on attachment 184481 Patch It looks like the test is a flake; let's try the CQ again. 815893 5 184481 webkit.review.bot 2013-01-24 15:18:51 -0800 Comment on attachment 184481 Patch Clearing flags on attachment: 184481 Committed r140733: <http://trac.webkit.org/changeset/140733> 815894 6 webkit.review.bot 2013-01-24 15:18:54 -0800 All reviewed patches have been landed. Closing bug. 184481 2013-01-24 06:25:49 -0800 2013-01-24 15:18:51 -0800 Patch bug-107817-20130124152241.patch text/plain 1992 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWMxMWRkZDExODYwMzZk YmI0MzIwZTIyODMxOWYxNGEwM2U3ODRmOC4uNzY4OGIyNTVkZWUwMjVjN2ZmZTUyYjk4ZTJiMzg1 ZmUzMjhiZjQ5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTI0ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogIlhI UiBsb2FkZWQhIiBtZXNzYWdlcyBzaG91bGQgYmUgRGVidWdNZXNzYWdlTGV2ZWwuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc4MTcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgJ1hIUiBmaW5pc2hl ZCBsb2FkaW5nOicgbWVzc2FnZSBpcyBjdXJyZW50bHkgc2VudCBhdAorICAgICAgICBMb2dNZXNz YWdlTGV2ZWwuIFVwb24gcmVmbGVjdGlvbiwgdGhlIG9ubHkgbWVzc2FnZXMgdGhhdCBzaG91bGQg YmUKKyAgICAgICAgc2VudCBhdCB0aGF0IGxldmVsIGFyZSBtZXNzYWdlcyB0aGUgZGV2ZWxvcGVy IGdlbmVyYXRlcyBoZXJzZWxmIHZpYQorICAgICAgICAnY29uc29sZS4qJyBjYWxscy4gVGhpcyBt ZXNzYWdlIGlzIGJldHRlciBjYXRlZ29yaXplZCBhcyAnZGVidWcnLgorCisgICAgICAgICogaW5z cGVjdG9yL0luc3BlY3RvckNvbnNvbGVBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNw ZWN0b3JDb25zb2xlQWdlbnQ6OmRpZEZpbmlzaFhIUkxvYWRpbmcpOgorICAgICAgICAgICAgQ2hh bmdlIHRoZSBtZXNzYWdlIHRvIERlYnVnTWVzc2FnZUxldmVsLgorCiAyMDEzLTAxLTI0ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGJyZWFrcG9pbnRzIGFyZSBub3QgcmVzdG9yZWQgdXBvbiByZWxvYWQgZm9yIHNjcmlwdHMg d2l0aCBzY3JpcHQgbWFwcGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JDb25zb2xlQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckNvbnNvbGVBZ2VudC5jcHAKaW5kZXggNzdmZWJkYzNhYjY0ZTMyZDIzMWJhZDVmNTc1 NDlmN2I4OTQ5MzRiOS4uYzk4ZTVmNzg3Yzk4OWZmMGUzZDZmNjQzNmI3MTcyNzlkZDliMWFhOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnNvbGVBZ2Vu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnNvbGVBZ2Vu dC5jcHAKQEAgLTI2OCw3ICsyNjgsNyBAQCB2b2lkIEluc3BlY3RvckNvbnNvbGVBZ2VudDo6ZGlk RmluaXNoWEhSTG9hZGluZyh1bnNpZ25lZCBsb25nIHJlcXVlc3RJZGVudGlmaWVyLAogICAgICAg ICByZXR1cm47CiAgICAgaWYgKG1fZnJvbnRlbmQgJiYgbV9zdGF0ZS0+Z2V0Qm9vbGVhbihDb25z b2xlQWdlbnRTdGF0ZTo6bW9uaXRvcmluZ1hIUikpIHsKICAgICAgICAgU3RyaW5nIG1lc3NhZ2Ug PSAiWEhSIGZpbmlzaGVkIGxvYWRpbmc6IFwiIiArIHVybCArICJcIi4iOwotICAgICAgICBhZGRN ZXNzYWdlVG9Db25zb2xlKE5ldHdvcmtNZXNzYWdlU291cmNlLCBMb2dNZXNzYWdlVHlwZSwgTG9n TWVzc2FnZUxldmVsLCBtZXNzYWdlLCBzZW5kVVJMLCBzZW5kTGluZU51bWJlciwgMCwgcmVxdWVz dElkZW50aWZpZXIpOworICAgICAgICBhZGRNZXNzYWdlVG9Db25zb2xlKE5ldHdvcmtNZXNzYWdl U291cmNlLCBMb2dNZXNzYWdlVHlwZSwgRGVidWdNZXNzYWdlTGV2ZWwsIG1lc3NhZ2UsIHNlbmRV UkwsIHNlbmRMaW5lTnVtYmVyLCAwLCByZXF1ZXN0SWRlbnRpZmllcik7CiAgICAgfQogCiAK