107803 2013-01-24 01:35:14 -0800 [Qt] Build is KO since r140610 (QString::fromUTF16 function does not exist) 2013-01-24 06:31:04 -0800 1 1 1 Unclassified WebKit XML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Critical --- 0 jbriance webkit-unassigned mrobinson webkit.review.bot zarvai oldest_to_newest 815239 0 jbriance 2013-01-24 01:35:14 -0800 Qt SH4 build slave (http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release) doesn't build since r140610 There is a typo error for QString::fromUtf16 call. It is fromUtf16 and not fromUTF16 in Qt. 815247 1 184440 jbriance 2013-01-24 01:51:55 -0800 Created attachment 184440 Fix Qt QString::fromUtf16() function call 815255 2 184440 kling 2013-01-24 01:57:44 -0800 Comment on attachment 184440 Fix Qt QString::fromUtf16() function call rs=me 815296 3 184440 webkit.review.bot 2013-01-24 03:27:22 -0800 Comment on attachment 184440 Fix Qt QString::fromUtf16() function call Clearing flags on attachment: 184440 Committed r140671: <http://trac.webkit.org/changeset/140671> 815297 4 webkit.review.bot 2013-01-24 03:27:25 -0800 All reviewed patches have been landed. Closing bug. 815358 5 zarvai 2013-01-24 05:22:17 -0800 A problem still exists with QString::fromUtf16 usage on windows bot: http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Release/builds/60904/steps/compile-webkit/logs/stdio C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebCore\xml\parser\XMLDocumentParserQt.cpp(74) : error C2664: 'QString::fromUtf16' : cannot convert parameter 1 from 'UChar [4]' to 'const ushort *' Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast Can you take a look at the conversation issue, please? 815386 6 mrobinson 2013-01-24 05:59:46 -0800 Sorry for the breakage. It's odd that the EWS did not catch this. 815417 7 zarvai 2013-01-24 06:31:04 -0800 (In reply to comment #6) > Sorry for the breakage. It's odd that the EWS did not catch this. Maybe Win EWS uses MINGW while Qt Win bot uses MSVC for build. 184440 2013-01-24 01:51:55 -0800 2013-01-24 03:27:21 -0800 Fix Qt QString::fromUtf16() function call fix_qt_qstring_fromutf16_call.patch text/plain 1384 jbriance SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDY2NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTI0ICBKdWxpZW4g QlJJQU5DRUFVICAgPGpicmlhbmNlYXVAbmRzLmNvbT4KKworICAgICAgICBGaXggUXQgYnVpbGQg KEtPIHNpbmNlIHIxNDA2MTApLCB0eXBvIGVycm9yIGZvciBRU3RyaW5nOjpmcm9tVXRmMTYgZnVu Y3Rpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDc4MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHhtbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXJRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpk ZWNvZGVOYW1lZEVudGl0eSk6CisKIDIwMTMtMDEtMjQgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1h bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYnJlYWtwb2ludHMgYXJl IG5vdCByZXN0b3JlZCB1cG9uIHJlbG9hZCBmb3Igc2NyaXB0cyB3aXRoIHNjcmlwdCBtYXBwaW5n LgpJbmRleDogU291cmNlL1dlYkNvcmUveG1sL3BhcnNlci9YTUxEb2N1bWVudFBhcnNlclF0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFy c2VyUXQuY3BwCShyZXZpc2lvbiAxNDA2NjEpCisrKyBTb3VyY2UvV2ViQ29yZS94bWwvcGFyc2Vy L1hNTERvY3VtZW50UGFyc2VyUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MSw3ICs3MSw3IEBA IHN0YXRpYyBRU3RyaW5nIGRlY29kZU5hbWVkRW50aXR5KGNvbnN0IFEKIHsKICAgICBVQ2hhciB1 dGYxNkRlY29kZWRFbnRpdHlbNF07CiAgICAgc2l6ZV90IG51bWJlck9mQ29kZVBvaW50cyA9IGRl Y29kZU5hbWVkRW50aXR5VG9VQ2hhckFycmF5KGVudGl0eU5hbWUudG9VdGY4KCkuY29uc3REYXRh KCksIHV0ZjE2RGVjb2RlZEVudGl0eSk7Ci0gICAgcmV0dXJuIFFTdHJpbmc6OmZyb21VVEYxNih1 dGYxNkRlY29kZWRFbnRpdHksIG51bWJlck9mQ29kZVBvaW50cyk7CisgICAgcmV0dXJuIFFTdHJp bmc6OmZyb21VdGYxNih1dGYxNkRlY29kZWRFbnRpdHksIG51bWJlck9mQ29kZVBvaW50cyk7CiB9 CiAKIFFTdHJpbmcgRW50aXR5UmVzb2x2ZXI6OnJlc29sdmVVbmRlY2xhcmVkRW50aXR5KGNvbnN0 IFFTdHJpbmcgJm5hbWUpCg==