107799 2013-01-24 00:57:20 -0800 Web Inspector: breakpoints are not restored upon reload for scripts with script mapping. 2013-01-24 01:21:53 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 815207 0 pfeldman 2013-01-24 00:57:20 -0800 The problem is that source mapping is set after UISourceCode gets into the workspace. 815209 1 184432 pfeldman 2013-01-24 01:00:57 -0800 Created attachment 184432 Patch 815212 2 184432 apavlov 2013-01-24 01:03:35 -0800 Comment on attachment 184432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184432&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:116 > + var uiSourceCode = /** @type {WebInspector.UISourceCode} */ (event.target); Can this fire several times per the same UISourceCode? I'm wary of duplicate breakpoints, actually. 815232 3 184432 webkit.review.bot 2013-01-24 01:17:16 -0800 Comment on attachment 184432 Patch Rejecting attachment 184432 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 184432, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16021038 815233 4 pfeldman 2013-01-24 01:21:53 -0800 Committed r140666: <http://trac.webkit.org/changeset/140666> 184432 2013-01-24 01:00:57 -0800 2013-01-24 01:17:16 -0800 Patch bug-107799-20130124125749.patch text/plain 6052 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2M3ZTU3YzdhNTNhZTNj NTRiN2ZiYzUyMzY1NDZkMTM2ZGRmY2E2NS4uN2U4YTIwYzMwYjZkMzA1YzUyZWZhMzQxY2M4YTQ3 M2FjYWE0YjBiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTI0ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGJyZWFrcG9pbnRzIGFyZSBub3QgcmVzdG9yZWQgdXBvbiByZWxvYWQgZm9yIHNjcmlwdHMg d2l0aCBzY3JpcHQgbWFwcGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNzc5OQorCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgc291cmNl IG1hcHBpbmcgaXMgc2V0IGFmdGVyIFVJU291cmNlQ29kZSBnZXRzIGludG8gdGhlIHdvcmtzcGFj ZS4KKyAgICAgICAgQnJlYWtwb2ludCBtYW5hZ2VyIHdpbGwgbm93IG9ubHkgcmVzdG9yZSBicmVh a3BvaW50cyB1cG9uIHNldHRpbmcgdGhlIHNvdXJjZSBtYXBzLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9CcmVha3BvaW50 TWFuYWdlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5CcmVha3BvaW50TWFuYWdlci5wcm90 b3R5cGUuX3VpU291cmNlQ29kZUFkZGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5CcmVha3Bv aW50TWFuYWdlci5wcm90b3R5cGUuX3VpU291cmNlQ29kZU1hcHBpbmdDaGFuZ2VkKToKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvbXBpbGVyU2NyaXB0TWFwcGluZy5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5Db21waWxlclNjcmlwdE1hcHBpbmcucHJvdG90eXBlLmdldCBhZGRT Y3JpcHQuZ2V0IHRoaXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbXBpbGVyU2NyaXB0TWFw cGluZy5wcm90b3R5cGUuZ2V0IGFkZFNjcmlwdCk6CisKIDIwMTMtMDEtMjMgIFJhZmFlbCBXZWlu c3RlaW4gIDxyYWZhZWx3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNDAx MDEpOiBjYXVzZWQgZGVidWcgYXNzZXJ0cyBpbiBmYXN0L2Zvcm1zL2Fzc29jaWF0ZWQtZWxlbWVu dC1jcmFzaC5odG1sIGFuZCBodG1sNWxpYi9ydW4tdGVtcGxhdGUuaHRtbApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9CcmVha3BvaW50TWFuYWdlci5qcyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQnJlYWtwb2ludE1hbmFnZXIuanMK aW5kZXggYThmOWExNGM4YWMwMDQ3ZjQ5YmEzOGJmYjQ3MWQ4NGFhY2JjY2M0YS4uMjkxNzNkNDkx ODhiYTQwMGY2MWZiMjExOTZjOTRmNTJiOGI4YjhjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9CcmVha3BvaW50TWFuYWdlci5qcworKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0JyZWFrcG9pbnRNYW5hZ2VyLmpzCkBAIC05NCw3 ICs5NCw3IEBAIFdlYkluc3BlY3Rvci5CcmVha3BvaW50TWFuYWdlci5wcm90b3R5cGUgPSB7CiAg ICAgewogICAgICAgICB2YXIgdWlTb3VyY2VDb2RlID0gLyoqIEB0eXBlIHtXZWJJbnNwZWN0b3Iu VUlTb3VyY2VDb2RlfSAqLyAoZXZlbnQuZGF0YSk7CiAgICAgICAgIGlmICh1aVNvdXJjZUNvZGUu Y29udGVudFR5cGUoKSA9PT0gV2ViSW5zcGVjdG9yLnJlc291cmNlVHlwZXMuU2NyaXB0IHx8IHVp U291cmNlQ29kZS5jb250ZW50VHlwZSgpID09PSBXZWJJbnNwZWN0b3IucmVzb3VyY2VUeXBlcy5E b2N1bWVudCkgewotICAgICAgICAgICAgdGhpcy5fcmVzdG9yZUJyZWFrcG9pbnRzKHVpU291cmNl Q29kZSk7CisgICAgICAgICAgICB1aVNvdXJjZUNvZGUuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNw ZWN0b3IuVUlTb3VyY2VDb2RlLkV2ZW50cy5Tb3VyY2VNYXBwaW5nQ2hhbmdlZCwgdGhpcy5fdWlT b3VyY2VDb2RlTWFwcGluZ0NoYW5nZWQsIHRoaXMpOwogICAgICAgICAgICAgdWlTb3VyY2VDb2Rl LmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlVJU291cmNlQ29kZS5FdmVudHMuRm9ybWF0 dGVkQ2hhbmdlZCwgdGhpcy5fdWlTb3VyY2VDb2RlRm9ybWF0dGVkLCB0aGlzKTsKICAgICAgICAg fQogICAgIH0sCkBAIC0xMDksNiArMTA5LDE1IEBAIFdlYkluc3BlY3Rvci5CcmVha3BvaW50TWFu YWdlci5wcm90b3R5cGUgPSB7CiAgICAgfSwKIAogICAgIC8qKgorICAgICAqIEBwYXJhbSB7V2Vi SW5zcGVjdG9yLkV2ZW50fSBldmVudAorICAgICAqLworICAgIF91aVNvdXJjZUNvZGVNYXBwaW5n Q2hhbmdlZDogZnVuY3Rpb24oZXZlbnQpCisgICAgeworICAgICAgICB2YXIgdWlTb3VyY2VDb2Rl ID0gLyoqIEB0eXBlIHtXZWJJbnNwZWN0b3IuVUlTb3VyY2VDb2RlfSAqLyAoZXZlbnQudGFyZ2V0 KTsKKyAgICAgICAgdGhpcy5fcmVzdG9yZUJyZWFrcG9pbnRzKHVpU291cmNlQ29kZSk7CisgICAg fSwKKworICAgIC8qKgogICAgICAqIEBwYXJhbSB7V2ViSW5zcGVjdG9yLlVJU291cmNlQ29kZX0g dWlTb3VyY2VDb2RlCiAgICAgICogQHBhcmFtIHtudW1iZXJ9IGxpbmVOdW1iZXIKICAgICAgKiBA cGFyYW0ge3N0cmluZ30gY29uZGl0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NvbXBpbGVyU2NyaXB0TWFwcGluZy5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29tcGlsZXJTY3JpcHRNYXBwaW5nLmpzCmluZGV4IDcyMzZk Y2ZiOGNlYjgxMTUyZGZlYTM0NWE0OWI1MWQ4ZGI1NDY4NGIuLmU2ZTRkMzM4YzkzNzBlN2YyYzRm NjM0ZjdiZWU0YWNmZjZjZDdiYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvQ29tcGlsZXJTY3JpcHRNYXBwaW5nLmpzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29tcGlsZXJTY3JpcHRNYXBwaW5nLmpzCkBAIC0xMDEsNiAr MTAxLDkgQEAgV2ViSW5zcGVjdG9yLkNvbXBpbGVyU2NyaXB0TWFwcGluZy5wcm90b3R5cGUgPSB7 CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAorICAgICAgICB0aGlzLl9zb3VyY2VN YXBGb3JTY3JpcHRJZFtzY3JpcHQuc2NyaXB0SWRdID0gc291cmNlTWFwOworICAgICAgICB0aGlz Ll9zY3JpcHRGb3JTb3VyY2VNYXAucHV0KHNvdXJjZU1hcCwgc2NyaXB0KTsKKwogICAgICAgICB2 YXIgc291cmNlVVJMcyA9IHNvdXJjZU1hcC5zb3VyY2VzKCk7CiAgICAgICAgIGZvciAodmFyIGkg PSAwOyBpIDwgc291cmNlVVJMcy5sZW5ndGg7ICsraSkgewogICAgICAgICAgICAgdmFyIHNvdXJj ZVVSTCA9IHNvdXJjZVVSTHNbaV07CkBAIC0xMjMsOCArMTI2LDYgQEAgV2ViSW5zcGVjdG9yLkNv bXBpbGVyU2NyaXB0TWFwcGluZy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgdWlTb3Vy Y2VDb2RlLmlzQ29udGVudFNjcmlwdCA9IHNjcmlwdC5pc0NvbnRlbnRTY3JpcHQ7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0KLSAgICAgICAgdGhpcy5fc291cmNlTWFwRm9yU2NyaXB0SWRbc2Ny aXB0LnNjcmlwdElkXSA9IHNvdXJjZU1hcDsKLSAgICAgICAgdGhpcy5fc2NyaXB0Rm9yU291cmNl TWFwLnB1dChzb3VyY2VNYXAsIHNjcmlwdCk7CiAgICAgICAgIHNjcmlwdC5wdXNoU291cmNlTWFw cGluZyh0aGlzKTsKICAgICB9LAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWE5NWNiNDhiODRlMzg0Mzk2ZTAwMjI5ZDFm ZWM3NWQ4ZGUzMTVmMC4uZjQ3ZDc4YTI5ZjhhM2MxMzk0NDQ4NTQyZGIxM2E4NGE4NTE5YTczNiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAxLTI0ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRt YW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGJyZWFrcG9pbnRzIGFy ZSBub3QgcmVzdG9yZWQgdXBvbiByZWxvYWQgZm9yIHNjcmlwdHMgd2l0aCBzY3JpcHQgbWFwcGlu Zy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzc5 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5z cGVjdG9yL2RlYnVnZ2VyL2JyZWFrcG9pbnQtbWFuYWdlci5odG1sOgorCiAyMDEzLTAxLTIzICBS YWZhZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUkVHUkVT U0lPTihyMTQwMTAxKTogY2F1c2VkIGRlYnVnIGFzc2VydHMgaW4gZmFzdC9mb3Jtcy9hc3NvY2lh dGVkLWVsZW1lbnQtY3Jhc2guaHRtbCBhbmQgaHRtbDVsaWIvcnVuLXRlbXBsYXRlLmh0bWwKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9icmVha3BvaW50LW1hbmFn ZXIuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9icmVha3BvaW50LW1hbmFn ZXIuaHRtbAppbmRleCA1Nzg1MWVhOTQ2NDUyNzIwYTMyMWUzZjU4OTdhYjZhMGMzMmNiYzQyLi4z ZTMyNWE4ZGEwNzkwMzYwOTkyZWFkZTk1YmM3M2M3NzU5NGU0ZjliIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvYnJlYWtwb2ludC1tYW5hZ2VyLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL2JyZWFrcG9pbnQtbWFuYWdlci5odG1sCkBA IC0xMTksMTkgKzExOSwxOSBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgX2FkZFVJU291cmNl Q29kZTogZnVuY3Rpb24odXJsKQogICAgICAgICB7CiAgICAgICAgICAgICB2YXIgdWlTb3VyY2VD b2RlID0gbmV3IFdlYkluc3BlY3Rvci5VSVNvdXJjZUNvZGUodGhpcywgdXJsLCB1cmwsIHVybCwg V2ViSW5zcGVjdG9yLnJlc291cmNlVHlwZXMuU2NyaXB0LCBmYWxzZSk7Ci0gICAgICAgICAgICB1 aVNvdXJjZUNvZGUuc2V0U291cmNlTWFwcGluZyhkZWZhdWx0TWFwcGluZyk7CiAgICAgICAgICAg ICB1aVNvdXJjZUNvZGVzW3VybF0gPSB1aVNvdXJjZUNvZGU7CiAgICAgICAgICAgICB0aGlzLmRp c3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuVUlTb3VyY2VDb2RlUHJvdmlkZXIu RXZlbnRzLlVJU291cmNlQ29kZUFkZGVkLCB1aVNvdXJjZUNvZGUpOworICAgICAgICAgICAgdWlT b3VyY2VDb2RlLnNldFNvdXJjZU1hcHBpbmcoZGVmYXVsdE1hcHBpbmcpOwogICAgICAgICAgICAg cmV0dXJuIHVpU291cmNlQ29kZTsKICAgICAgICAgfSwKIAogICAgICAgICBfYWRkVGVtcG9yYXJ5 VUlTb3VyY2VDb2RlOiBmdW5jdGlvbih1cmwpCiAgICAgICAgIHsKICAgICAgICAgICAgIHZhciB1 aVNvdXJjZUNvZGUgPSBuZXcgV2ViSW5zcGVjdG9yLlVJU291cmNlQ29kZSh0aGlzLCAidGVtcG9y YXJ5OiIgKyB1cmwsIHVybCwgdXJsLCBXZWJJbnNwZWN0b3IucmVzb3VyY2VUeXBlcy5TY3JpcHQs IGZhbHNlKTsKLSAgICAgICAgICAgIHVpU291cmNlQ29kZS5zZXRTb3VyY2VNYXBwaW5nKGRlZmF1 bHRNYXBwaW5nKTsKICAgICAgICAgICAgIHVpU291cmNlQ29kZXNbdXJsXSA9IHVpU291cmNlQ29k ZTsKICAgICAgICAgICAgIHRlbXBvcmFyeVVJU291cmNlQ29kZXNbdXJsXSA9IHVpU291cmNlQ29k ZTsKICAgICAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rv ci5VSVNvdXJjZUNvZGVQcm92aWRlci5FdmVudHMuVGVtcG9yYXJ5VUlTb3VyY2VDb2RlQWRkZWQs IHVpU291cmNlQ29kZSk7CisgICAgICAgICAgICB1aVNvdXJjZUNvZGUuc2V0U291cmNlTWFwcGlu ZyhkZWZhdWx0TWFwcGluZyk7CiAgICAgICAgICAgICByZXR1cm4gdWlTb3VyY2VDb2RlOwogICAg ICAgICB9LAogCg==