107791 2013-01-23 23:12:57 -0800 Refactoring: Use AtomicString for an InputType::create argument 2013-01-24 01:09:16 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tkent tkent haraken mifenton morrita ojan.autocc webkit.review.bot oldest_to_newest 815119 0 tkent 2013-01-23 23:12:57 -0800 Refactoring: Use AtomicString for a InputType::create argument 815127 1 184413 tkent 2013-01-23 23:18:51 -0800 Created attachment 184413 Patch 815158 2 184413 haraken 2013-01-23 23:56:19 -0800 Comment on attachment 184413 Patch The kind of input.types is limited, so the change looks reasonable. 815218 3 184413 webkit.review.bot 2013-01-24 01:09:12 -0800 Comment on attachment 184413 Patch Clearing flags on attachment: 184413 Committed r140665: <http://trac.webkit.org/changeset/140665> 815219 4 webkit.review.bot 2013-01-24 01:09:16 -0800 All reviewed patches have been landed. Closing bug. 184413 2013-01-23 23:18:51 -0800 2013-01-24 01:09:12 -0800 Patch bug-107791-20130124161542.patch text/plain 2987 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjljNDBjMzhlN2I5ZGIz NDA2M2Q3YjUxNjg1NzBkNTBhMDI0NzVlZC4uZTUyM2NlZDcwNDdiZDJjN2JlMjU5MzM5M2NlNGE3 M2ZlOTNkMjQ2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAxLTI0ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZWZhY3RvcmluZzogVXNl IEF0b21pY1N0cmluZyBmb3IgYW4gSW5wdXRUeXBlOjpjcmVhdGUgYXJndW1lbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzc5MQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEEgc3RyaW5nIHBhc3NlZCB0 byBJbnB1dFR5cGU6OmNyZWF0ZSBpcyBhICd0eXBlJyBhdHRyaWJ1dGUgdmFsdWUsIHdoaWNoCisg ICAgICAgIGlzIGFuIEF0b21pY1N0cmluZy4gQWxzbywgSW5wdXRUeXBlRmFjdG9yeU1hcCBpcyBj cmVhdGVkIHdpdGggbWVtYmVycyBvZgorICAgICAgICBJbnB1dFR5cGVOYW1lLCB3aGljaCBhcmUg QXRvbWljU3RyaW5ncy4gV2UgaGFkIGJldHRlciB1c2UgQXRvbWljU3RyaW5ncworICAgICAgICBm b3IgdGhlbS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgaXMganVzdCBhIHJlZmFjdG9y aW5nLgorCisgICAgICAgICogaHRtbC9JbnB1dFR5cGUuY3BwOgorICAgICAgICBDaGFuZ2UgdGhl IGtleSB0eXBlIG9mIElucHV0VHlwZUZhY3RvcnlNYXAgZnJvbSBTdHJpbmcgdG8gQXRvbWljU3Ry aW5nLgorICAgICAgICAoV2ViQ29yZTo6SW5wdXRUeXBlOjpjcmVhdGUpOgorICAgICAgICBDaGFu Z2UgYW4gYXJndW1lbnQgdHlwZSBmcm9tIGNvbnN0IFN0cmluZyYgdG8gY29uc3QgQXRvbWljU3Ry aW5nJi4KKyAgICAgICAgKiBodG1sL0lucHV0VHlwZS5oOgorICAgICAgICAoSW5wdXRUeXBlKTog RGl0dG8uCisKIDIwMTMtMDEtMjMgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIEFkZCBmb3JtLXJlbGF0ZWQgaW5zdHJ1bWVudGF0aW9ucywgYW5kIHN1cHBvcnQg MzMrIGZlYXR1cmVzIGluIEZlYXR1cmVPYnNlcnZlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9JbnB1dFR5cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuY3Bw CmluZGV4IDY0MjE3NzcxNWIxYTYxMjcyNDRkMGMyYmRmMjRkODlmMTgyNjU0MWQuLjE0MTEwZGY2 YzlkYmQ2OWMxYzZmZDk2YWI0N2Y5ZDYwYWQ2MjZmNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlw ZS5jcHAKQEAgLTg1LDcgKzg1LDcgQEAgdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIHVzaW5n IG5hbWVzcGFjZSBzdGQ7CiAKIHR5cGVkZWYgUGFzc093blB0cjxJbnB1dFR5cGU+ICgqSW5wdXRU eXBlRmFjdG9yeUZ1bmN0aW9uKShIVE1MSW5wdXRFbGVtZW50Kik7Ci10eXBlZGVmIEhhc2hNYXA8 U3RyaW5nLCBJbnB1dFR5cGVGYWN0b3J5RnVuY3Rpb24sIENhc2VGb2xkaW5nSGFzaD4gSW5wdXRU eXBlRmFjdG9yeU1hcDsKK3R5cGVkZWYgSGFzaE1hcDxBdG9taWNTdHJpbmcsIElucHV0VHlwZUZh Y3RvcnlGdW5jdGlvbiwgQ2FzZUZvbGRpbmdIYXNoPiBJbnB1dFR5cGVGYWN0b3J5TWFwOwogCiBz dGF0aWMgUGFzc093blB0cjxJbnB1dFR5cGVGYWN0b3J5TWFwPiBjcmVhdGVJbnB1dFR5cGVGYWN0 b3J5TWFwKCkKIHsKQEAgLTEzNiw3ICsxMzYsNyBAQCBzdGF0aWMgUGFzc093blB0cjxJbnB1dFR5 cGVGYWN0b3J5TWFwPiBjcmVhdGVJbnB1dFR5cGVGYWN0b3J5TWFwKCkKICAgICByZXR1cm4gbWFw LnJlbGVhc2UoKTsKIH0KIAotUGFzc093blB0cjxJbnB1dFR5cGU+IElucHV0VHlwZTo6Y3JlYXRl KEhUTUxJbnB1dEVsZW1lbnQqIGVsZW1lbnQsIGNvbnN0IFN0cmluZyYgdHlwZU5hbWUpCitQYXNz T3duUHRyPElucHV0VHlwZT4gSW5wdXRUeXBlOjpjcmVhdGUoSFRNTElucHV0RWxlbWVudCogZWxl bWVudCwgY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlTmFtZSkKIHsKICAgICBzdGF0aWMgY29uc3Qg SW5wdXRUeXBlRmFjdG9yeU1hcCogZmFjdG9yeU1hcCA9IGNyZWF0ZUlucHV0VHlwZUZhY3RvcnlN YXAoKS5sZWFrUHRyKCk7CiAgICAgUGFzc093blB0cjxJbnB1dFR5cGU+ICgqZmFjdG9yeSkoSFRN TElucHV0RWxlbWVudCopID0gdHlwZU5hbWUuaXNFbXB0eSgpID8gMCA6IGZhY3RvcnlNYXAtPmdl dCh0eXBlTmFtZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5o IGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaAppbmRleCAzMzNhMjU2YTAwZThhOThj YzlmNzAwZmIwY2M4MDJkZjlkM2I3NzBhLi5jNmQxNGE5NzFiMmQ4NzY1YTUwYTY2ZDE3YmNkMjk0 ZTBmMzg0ZjBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmgKQEAgLTgyLDcgKzgyLDcgQEAgY2xh c3MgSW5wdXRUeXBlIHsKICAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIAogcHVibGljOgot ICAgIHN0YXRpYyBQYXNzT3duUHRyPElucHV0VHlwZT4gY3JlYXRlKEhUTUxJbnB1dEVsZW1lbnQq LCBjb25zdCBTdHJpbmcmKTsKKyAgICBzdGF0aWMgUGFzc093blB0cjxJbnB1dFR5cGU+IGNyZWF0 ZShIVE1MSW5wdXRFbGVtZW50KiwgY29uc3QgQXRvbWljU3RyaW5nJik7CiAgICAgc3RhdGljIFBh c3NPd25QdHI8SW5wdXRUeXBlPiBjcmVhdGVUZXh0KEhUTUxJbnB1dEVsZW1lbnQqKTsKICAgICB2 aXJ0dWFsIH5JbnB1dFR5cGUoKTsKIAo=