107790 2013-01-23 23:03:25 -0800 There are a few of wrong removeAllChildren() call 2013-01-24 22:47:23 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 107640 1 morrita morrita adamk darin esprehn mifenton ojan.autocc rniwa tkent webkit-bug-importer webkit.review.bot oldest_to_newest 815111 0 morrita 2013-01-23 23:03:25 -0800 This is from bug 107640. 815120 1 184412 morrita 2013-01-23 23:13:41 -0800 Created attachment 184412 Patch 815172 2 184412 webkit.review.bot 2013-01-24 00:24:46 -0800 Comment on attachment 184412 Patch Clearing flags on attachment: 184412 Committed r140659: <http://trac.webkit.org/changeset/140659> 815173 3 webkit.review.bot 2013-01-24 00:24:49 -0800 All reviewed patches have been landed. Closing bug. 815174 4 webkit-bug-importer 2013-01-24 00:26:44 -0800 <rdar://problem/13076849> 815679 5 darin 2013-01-24 11:49:04 -0800 Seems critical to rename removeAllChildren so future programmers don’t make the same mistake. 815684 6 rniwa 2013-01-24 11:52:17 -0800 (In reply to comment #5) > Seems critical to rename removeAllChildren so future programmers don’t make the same mistake. This was split off from that effort: https://bugs.webkit.org/show_bug.cgi?id=107640. 184412 2013-01-23 23:13:41 -0800 2013-01-24 00:24:46 -0800 Patch bug-107790-20130124161033.patch text/plain 5743 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjljNDBjMzhlN2I5ZGIz NDA2M2Q3YjUxNjg1NzBkNTBhMDI0NzVlZC4uYTA4NWYyMjIyMTI1NjNmMzIzM2UwYmM2MDQwYjlj MDRhMTgyMjlhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAxLTIzICBIYWpp bWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBUaGVyZSBhcmUgYSBm ZXcgb2Ygd3JvbmcgcmVtb3ZlQWxsQ2hpbGRyZW4oKSBjYWxsCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc3OTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByZW1vdmVBbGxDaGlsZHJlbigpIGlzIGRlc2ln bmVkIGZvciB0cmFzaGluZyBkZWxldGluZyBjaGlsZHJlbiBvdXQuCisgICAgICAgIEl0IGRvZXNu J3QgZGV0YWNoKCkgY2hpbGRyZW4gYW5kIGNvdWxkIGhhdmUgcG9zc2libGUgbGVhay4KKyAgICAg ICAgVGhpcyBjaGFuZ2UgcmVwbGFjZXMgc3VjaCByZW1vdmVBbGxDaGlsZHJlbigpIHVzYWdlIHdp dGggc2FmZXIgcmVtb3ZlQ2hpbGRyZW4oKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIENvdmVy ZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUp OgorICAgICAgICAqIGh0bWwvSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklucHV0 VHlwZTo6ZGVzdHJveVNoYWRvd1N1YnRyZWUpOgorICAgICAgICAqIGh0bWwvVmFsaWRhdGlvbk1l c3NhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VmFsaWRhdGlvbk1lc3NhZ2U6OnNldE1lc3Nh Z2VET01BbmRTdGFydFRpbWVyKToKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxk ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNzRW5kVGFn KToKKwogMjAxMy0wMS0yMyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgQWRkIGZvcm0tcmVsYXRlZCBpbnN0cnVtZW50YXRpb25zLCBhbmQgc3VwcG9ydCAzMysg ZmVhdHVyZXMgaW4gRmVhdHVyZU9ic2VydmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDk3M2ViODA3OTk2 OWMxMTFhYWZjNGJiYTIyYzNmMGY5NDRkYjVlODYuLjE4ZWY5MTk1YzQxNWI0YTgzOWIyZDZiZjY4 OWE5OGRlYjZmMzBlZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDEt MjMgIEhhamltZSBNb3JyaXRhICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFRoZXJl IGFyZSBhIGZldyBvZiB3cm9uZyByZW1vdmVBbGxDaGlsZHJlbigpIGNhbGwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzc5MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQXBpL3F3ZWJlbGVtZW50LmNw cDogUmVwYWxjZWQgcmVtb3ZlQWxsQ2hpbGRyZW4oKSB3aXRoIHNhZmVyIHJlbW92ZUNoaWxkcmVu KCkKKyAgICAgICAgKFFXZWJFbGVtZW50OjpyZW1vdmVBbGxDaGlsZHJlbik6CisKIDIwMTMtMDEt MjMgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHNo YWRvd0FuY2VzdG9yTm9kZSgpIHNob3VsZCBiZSByZW5hbWVkIHRvIGRlcHJlY2F0ZWRTaGFkb3dB bmNlc3Rvck5vZGUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKaW5k ZXggYjIwMWVlMzU2MWMzOGQ5YzM0MTZkMWQ2ZjVjNmIwMTliYmJkNzYzYy4uNmFhZjk5NDk4YjZh MDA0MTM5NWFmNTU1ZjUyZTE3MGJlZmRmYmZiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJ bnB1dEVsZW1lbnQuY3BwCkBAIC03NTIsNyArNzUyLDggQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50 OjpwYXJzZUF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9taWNT dHIKICAgICAgICAgICAgIGRldGFjaCgpOwogICAgICAgICAgICAgbV9pbnB1dFR5cGUtPmRlc3Ry b3lTaGFkb3dTdWJ0cmVlKCk7CiAgICAgICAgICAgICBtX2lucHV0VHlwZS0+Y3JlYXRlU2hhZG93 U3VidHJlZSgpOwotICAgICAgICAgICAgYXR0YWNoKCk7CisgICAgICAgICAgICBpZiAoIWF0dGFj aGVkKCkpCisgICAgICAgICAgICAgICAgYXR0YWNoKCk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAg ICAgICAgICBtX2lucHV0VHlwZS0+ZGVzdHJveVNoYWRvd1N1YnRyZWUoKTsKICAgICAgICAgICAg IG1faW5wdXRUeXBlLT5jcmVhdGVTaGFkb3dTdWJ0cmVlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0lucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlw ZS5jcHAKaW5kZXggNjQyMTc3NzE1YjFhNjEyNzI0NGQwYzJiZGYyNGQ4OWYxODI2NTQxZC4uYmMz ODhlZjliNTRmNzhjMWJjMWNkMGRiOTg2NzE4YzE1ODA5MDI5ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5w dXRUeXBlLmNwcApAQCAtNDg5LDE0ICs0ODksMTQgQEAgdm9pZCBJbnB1dFR5cGU6OmRlc3Ryb3lT aGFkb3dTdWJ0cmVlKCkKICAgICBpZiAoIXJvb3QpCiAgICAgICAgIHJldHVybjsKIAotICAgIHJv b3QtPnJlbW92ZUFsbENoaWxkcmVuKCk7CisgICAgcm9vdC0+cmVtb3ZlQ2hpbGRyZW4oKTsKIAog ICAgIC8vIEl0J3Mgb2sgdG8gY2xlYXIgY29udGVudHMgb2YgYWxsIG90aGVyIFNoYWRvd1Jvb3Rz IGJlY2F1c2UgdGhleSBtdXN0IGhhdmUKICAgICAvLyBiZWVuIGNyZWF0ZWQgYnkgVGV4dEZpZWxk RGVjb3JhdGlvbkVsZW1lbnQsIGFuZCB3ZSBkb24ndCBhbGxvdyBhZGRpbmcKICAgICAvLyBBdXRo b3JTaGFkb3dSb290IHRvIEhUTUxJbnB1dEVsZW1lbnQuCiAgICAgd2hpbGUgKChyb290ID0gcm9v dC0+eW91bmdlclNoYWRvd1Jvb3QoKSkpIHsKICNpZiBFTkFCTEUoU0hBRE9XX0RPTSkKLSAgICAg ICAgcm9vdC0+cmVtb3ZlQWxsQ2hpbGRyZW4oKTsKKyAgICAgICAgcm9vdC0+cmVtb3ZlQ2hpbGRy ZW4oKTsKICAgICAgICAgcm9vdC0+YXBwZW5kQ2hpbGQoSFRNTFNoYWRvd0VsZW1lbnQ6OmNyZWF0 ZShzaGFkb3dUYWcsIGVsZW1lbnQoKS0+ZG9jdW1lbnQoKSkpOwogI2Vsc2UKICAgICAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1ZhbGlk YXRpb25NZXNzYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVmFsaWRhdGlvbk1lc3NhZ2Uu Y3BwCmluZGV4IDUzZWM3ZTQzODM1ODBkOGFiZDBiZDhiZGVjOThlMTJkNWNhODJmMmMuLmE2MzQz ZjkyMTM0YTBjNzk0ZjQxYWJlMzUzMTkyZDVhZDNhYmJmNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvVmFsaWRhdGlvbk1lc3NhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvVmFsaWRhdGlvbk1lc3NhZ2UuY3BwCkBAIC0xMjUsOCArMTI1LDggQEAgdm9pZCBWYWxpZGF0 aW9uTWVzc2FnZTo6c2V0TWVzc2FnZURPTUFuZFN0YXJ0VGltZXIoVGltZXI8VmFsaWRhdGlvbk1l c3NhZ2U+KikKICAgICBBU1NFUlQoIXZhbGlkYXRpb25NZXNzYWdlQ2xpZW50KCkpOwogICAgIEFT U0VSVChtX21lc3NhZ2VIZWFkaW5nKTsKICAgICBBU1NFUlQobV9tZXNzYWdlQm9keSk7Ci0gICAg bV9tZXNzYWdlSGVhZGluZy0+cmVtb3ZlQWxsQ2hpbGRyZW4oKTsKLSAgICBtX21lc3NhZ2VCb2R5 LT5yZW1vdmVBbGxDaGlsZHJlbigpOworICAgIG1fbWVzc2FnZUhlYWRpbmctPnJlbW92ZUNoaWxk cmVuKCk7CisgICAgbV9tZXNzYWdlQm9keS0+cmVtb3ZlQ2hpbGRyZW4oKTsKICAgICBWZWN0b3I8 U3RyaW5nPiBsaW5lczsKICAgICBtX21lc3NhZ2Uuc3BsaXQoJ1xuJywgbGluZXMpOwogICAgIERv Y3VtZW50KiBkb2MgPSBtX21lc3NhZ2VIZWFkaW5nLT5kb2N1bWVudCgpOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAKaW5kZXggNWUyMDYyZmE1Zjc2 ZWFmNmMxMmIwYmYwZDhmMjY2MmQzM2U5MDc0Mi4uYzcwMTE5ZDcyNGUzY2U4YjBmYTAxMzI3YTEy NTgxMGMwNzcwZTdjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRN TFRyZWVCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJl ZUJ1aWxkZXIuY3BwCkBAIC0yMTUyLDcgKzIxNTIsNyBAQCB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6 cHJvY2Vzc0VuZFRhZyhBdG9taWNIVE1MVG9rZW4qIHRva2VuKQogICAgICAgICAgICAgbV9zY3Jp cHRUb1Byb2Nlc3MgPSBtX3RyZWUuY3VycmVudEVsZW1lbnQoKTsKICAgICAgICAgICAgIG1fdHJl ZS5vcGVuRWxlbWVudHMoKS0+cG9wKCk7CiAgICAgICAgICAgICBpZiAoaXNQYXJzaW5nRnJhZ21l bnQoKSAmJiAhc2NyaXB0aW5nQ29udGVudElzQWxsb3dlZChtX2ZyYWdtZW50Q29udGV4dC5zY3Jp cHRpbmdQZXJtaXNzaW9uKCkpKQotICAgICAgICAgICAgICAgIG1fc2NyaXB0VG9Qcm9jZXNzLT5y ZW1vdmVBbGxDaGlsZHJlbigpOworICAgICAgICAgICAgICAgIG1fc2NyaXB0VG9Qcm9jZXNzLT5y ZW1vdmVDaGlsZHJlbigpOwogICAgICAgICAgICAgc2V0SW5zZXJ0aW9uTW9kZShtX29yaWdpbmFs SW5zZXJ0aW9uTW9kZSk7CiAKICAgICAgICAgICAgIC8vIFRoaXMgdG9rZW4gd2lsbCBub3QgaGF2 ZSBiZWVuIGNyZWF0ZWQgYnkgdGhlIHRva2VuaXplciBpZiBhCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L3F0L0FwaS9xd2ViZWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Vi ZWxlbWVudC5jcHAKaW5kZXggODJmNTc5ZDk1NTBhM2FjZmQ5OWQ0MzBkMWQ1Y2ZhMDc4ZmVlODM4 ZS4uM2IwOWViYjc4MzcwNGRkOWM1ZGE1MDA5NzI0MWIyODE5NDIzN2U2MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv cXQvQXBpL3F3ZWJlbGVtZW50LmNwcApAQCAtMTE5OCw3ICsxMTk4LDcgQEAgdm9pZCBRV2ViRWxl bWVudDo6cmVtb3ZlQWxsQ2hpbGRyZW4oKQogICAgIGlmICghbV9lbGVtZW50KQogICAgICAgICBy ZXR1cm47CiAKLSAgICBtX2VsZW1lbnQtPnJlbW92ZUFsbENoaWxkcmVuKCk7CisgICAgbV9lbGVt ZW50LT5yZW1vdmVDaGlsZHJlbigpOwogfQogCiAvLyBGSVhNRTogVGhpcyBjb2RlLCBhbmQgYWxs IGNhbGxlcnMgYXJlIHdyb25nLCBhbmQgaGF2ZSBubyBwbGFjZSBpbiBhCg==