107775 2013-01-23 19:36:36 -0800 QueueStatusServer crashes in production on next-patch 2013-01-23 21:51:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107612 1 alancutter alancutter abarth eric ossy webkit.review.bot oldest_to_newest 814974 0 alancutter 2013-01-23 19:36:36 -0800 [From https://bugs.webkit.org/show_bug.cgi?id=107612#c17] > (In reply to comment #15) > > (From update of attachment 184154 [details] [details]) > > Clearing flags on attachment: 184154 > > > > Committed r140513: <http://trac.webkit.org/changeset/140513> > > It seems it broke all EWS bots somehow. For example Qt EWS bots > are stucked in the following exception when they try to fetch http://queues.webkit.org/next-patch/qt-ews: > > Traceback (most recent call last): > File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 96, in run > work_item = self._delegate.next_work_item() > File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/tool/commands/queues.py", line 419, in next_work_item > return self._next_patch() > File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/tool/commands/queues.py", line 216, in _next_patch > patch_id = self._tool.status_server.next_work_item(self.name) > File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/common/net/statusserver.py", line 128, in next_work_item > return self._fetch_url(next_patch_url) > File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/common/net/statusserver.py", line 162, in _fetch_url > raise e > HTTPError: HTTP Error 500: Internal Server Error > > > I tried to fetch this URL from the browser and I got this exception: > Traceback (most recent call last): > File "/base/python_runtime/python_lib/versions/1/google/appengine/ext/webapp/_webapp25.py", line 714, in __call__ > handler.get(*groups) > File "/base/data/home/apps/webkit-commit-queue/107612.364787856447592722/handlers/nextpatch.py", line 51, in get > RecordPatchEvent.started(patch_id, queue_name) > File "/base/data/home/apps/webkit-commit-queue/107612.364787856447592722/loggers/recordpatchevent.py", line 63, in started > patch_log.calculate_wait_duration() > File "/base/data/home/apps/webkit-commit-queue/107612.364787856447592722/model/patchlog.py", line 52, in calculate_wait_duration > self.wait_duration = int(time_delta.total_seconds()) > AttributeError: 'datetime.timedelta' object has no attribute 'total_seconds' > > Could you guys check it, please? The QSS server is running on Python 2.5 which does not have timedelta.total_seconds. Unfortunately the local dev_server used for testing was using Python 2.7 and did not catch this. 814977 1 184383 alancutter 2013-01-23 19:45:59 -0800 Created attachment 184383 Patch 815049 2 abarth 2013-01-23 21:32:48 -0800 I think AppEngine supports Python 2.7. I'm not sure what's involved in upgrading. 815054 3 eric 2013-01-23 21:42:49 -0800 Mostly just have to change app.yaml. :-) 815057 4 alancutter 2013-01-23 21:44:30 -0800 (In reply to comment #3) > Mostly just have to change app.yaml. :-) I hope it will be that simple! 815062 5 184383 webkit.review.bot 2013-01-23 21:51:00 -0800 Comment on attachment 184383 Patch Clearing flags on attachment: 184383 Committed r140652: <http://trac.webkit.org/changeset/140652> 815063 6 webkit.review.bot 2013-01-23 21:51:04 -0800 All reviewed patches have been landed. Closing bug. 184383 2013-01-23 19:45:59 -0800 2013-01-23 21:51:00 -0800 Patch bug-107775-20130124144251.patch text/plain 2453 alancutter U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDc1NWZjOWYxOTljYjFlMGUzODZiMGE3ZmRmMjc2NDJi YjE0MmRjNS4uNTYwY2MxYTgzYWEyZTNhZDA5OTg2MmRmZjg1YTViZGE4ZDE4ZmIzMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTAxLTIzICBBbGFuIEN1dHRlciAgPGFsYW5jdXR0ZXJAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFF1ZXVlU3RhdHVzU2VydmVyIGNyYXNoZXMgaW4gcHJvZHVjdGlvbiBvbiBuZXh0 LXBhdGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDc3NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZXBsYWNlZCBQeXRob24gMi41IGluY29tcGF0aWJsZSBjYWxsIHRvIHRpbWVkZWx0YS50b3RhbF9z ZWNvbmRzKCkuCisKKyAgICAgICAgKiBRdWV1ZVN0YXR1c1NlcnZlci9hcHAueWFtbDoKKyAgICAg ICAgKiBRdWV1ZVN0YXR1c1NlcnZlci9tb2RlbC9wYXRjaGxvZy5weToKKyAgICAgICAgKFBhdGNo TG9nLmNhbGN1bGF0ZV93YWl0X2R1cmF0aW9uKToKKyAgICAgICAgKFBhdGNoTG9nLmNhbGN1bGF0 ZV9wcm9jZXNzX2R1cmF0aW9uKToKKyAgICAgICAgKFBhdGNoTG9nKToKKyAgICAgICAgKFBhdGNo TG9nLl90aW1lX2RlbHRhX3RvX3NlY29uZHMpOgorCiAyMDEzLTAxLTIzICBNYXJrIFBpbGdyaW0g IDxwaWxncmltQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFJlbW92ZSB1bnVz ZWQgaGVhZGVyIGZpbGVzIGluIGNocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS8KZGlmZiAtLWdpdCBh L1Rvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2FwcC55YW1sIGIvVG9vbHMvUXVldWVTdGF0dXNTZXJ2 ZXIvYXBwLnlhbWwKaW5kZXggMzViNGVkNWMxNWVlMDE0YjRiOWFkMTZkMzMwYWRhYTBmM2ZlZWI4 Zi4uMTAxOTQ2MWE4YWM5MzliNmE0YjU1NzA0N2E2ZWVmYTQ5MWJjMDkxNyAxMDA2NDQKLS0tIGEv VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvYXBwLnlhbWwKKysrIGIvVG9vbHMvUXVldWVTdGF0dXNT ZXJ2ZXIvYXBwLnlhbWwKQEAgLTEsNSArMSw1IEBACiBhcHBsaWNhdGlvbjogd2Via2l0LWNvbW1p dC1xdWV1ZQotdmVyc2lvbjogMTA3NjEyICMgQnVnemlsbGEgYnVnIElEIG9mIGxhc3QgbWFqb3Ig Y2hhbmdlCit2ZXJzaW9uOiAxMDc3NzUgIyBCdWd6aWxsYSBidWcgSUQgb2YgbGFzdCBtYWpvciBj aGFuZ2UKIHJ1bnRpbWU6IHB5dGhvbgogYXBpX3ZlcnNpb246IDEKIApkaWZmIC0tZ2l0IGEvVG9v bHMvUXVldWVTdGF0dXNTZXJ2ZXIvbW9kZWwvcGF0Y2hsb2cucHkgYi9Ub29scy9RdWV1ZVN0YXR1 c1NlcnZlci9tb2RlbC9wYXRjaGxvZy5weQppbmRleCBmYmI5ODZlOGUwY2VmZjRiNTVjY2Q2YTQy MTkwMzQ1ZTBhZjUwNGZmLi5jY2RiZWYyNWQ4ZmM3YjFmZmZkMmYyYTY5MmIzZWQwYjZhZDRjMGVj IDEwMDY0NAotLS0gYS9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9tb2RlbC9wYXRjaGxvZy5weQor KysgYi9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9tb2RlbC9wYXRjaGxvZy5weQpAQCAtNDksOSAr NDksMTQgQEAgY2xhc3MgUGF0Y2hMb2coZGIuTW9kZWwpOgogCiAgICAgZGVmIGNhbGN1bGF0ZV93 YWl0X2R1cmF0aW9uKHNlbGYpOgogICAgICAgICB0aW1lX2RlbHRhID0gZGF0ZXRpbWUudXRjbm93 KCkgLSBzZWxmLmRhdGUKLSAgICAgICAgc2VsZi53YWl0X2R1cmF0aW9uID0gaW50KHRpbWVfZGVs dGEudG90YWxfc2Vjb25kcygpKQorICAgICAgICBzZWxmLndhaXRfZHVyYXRpb24gPSBpbnQoc2Vs Zi5fdGltZV9kZWx0YV90b19zZWNvbmRzKHRpbWVfZGVsdGEpKQogCiAgICAgZGVmIGNhbGN1bGF0 ZV9wcm9jZXNzX2R1cmF0aW9uKHNlbGYpOgogICAgICAgICBpZiBzZWxmLndhaXRfZHVyYXRpb246 CiAgICAgICAgICAgICB0aW1lX2RlbHRhID0gZGF0ZXRpbWUudXRjbm93KCkgLSBzZWxmLmRhdGUK LSAgICAgICAgICAgIHNlbGYucHJvY2Vzc19kdXJhdGlvbiA9IGludCh0aW1lX2RlbHRhLnRvdGFs X3NlY29uZHMoKSkgLSBzZWxmLndhaXRfZHVyYXRpb24KKyAgICAgICAgICAgIHNlbGYucHJvY2Vz c19kdXJhdGlvbiA9IGludChzZWxmLl90aW1lX2RlbHRhX3RvX3NlY29uZHModGltZV9kZWx0YSkp IC0gc2VsZi53YWl0X2R1cmF0aW9uCisKKyAgICAjIE5lZWRlZCB0byBzdXBwb3J0IFB5dGhvbiAy LjUncyBsYWNrIG9mIHRpbWVkZWx0YS50b3RhbF9zZWNvbmRzKCkuCisgICAgQGNsYXNzbWV0aG9k CisgICAgZGVmIF90aW1lX2RlbHRhX3RvX3NlY29uZHMoY2xzLCB0aW1lX2RlbHRhKToKKyAgICAg ICAgcmV0dXJuIHRpbWVfZGVsdGEuc2Vjb25kcyArIHRpbWVfZGVsdGEuZGF5cyAqIDI0ICogMzYw MAo=