107756 2013-01-23 16:27:40 -0800 Don't allocate rare data on every Element on removal 2013-01-23 20:07:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 esprehn esprehn cmarcelo eric falken ojan.autocc ojan webkit.review.bot oldest_to_newest 814794 0 esprehn 2013-01-23 16:27:40 -0800 Don't allocate rare data on every Element won removal 814797 1 184339 esprehn 2013-01-23 16:29:59 -0800 Created attachment 184339 Patch 814799 2 184340 esprehn 2013-01-23 16:30:53 -0800 Created attachment 184340 Patch 814813 3 184343 esprehn 2013-01-23 16:38:38 -0800 Created attachment 184343 Patch 814831 4 184343 eric 2013-01-23 16:49:02 -0800 Comment on attachment 184343 Patch !! Do we have any ways to detect rare-data thrash? 814849 5 esprehn 2013-01-23 17:02:25 -0800 (In reply to comment #4) > (From update of attachment 184343 [details]) > !! Do we have any ways to detect rare-data thrash? Apparently not, we should figure out some way to detect this. 814990 6 184343 webkit.review.bot 2013-01-23 20:07:51 -0800 Comment on attachment 184343 Patch Clearing flags on attachment: 184343 Committed r140638: <http://trac.webkit.org/changeset/140638> 814991 7 webkit.review.bot 2013-01-23 20:07:55 -0800 All reviewed patches have been landed. Closing bug. 184339 2013-01-23 16:29:59 -0800 2013-01-23 16:30:52 -0800 Patch bug-107756-20130123162652.patch text/plain 1685 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNmN2ZkMTIwOWZhMWU0 YWQ2ZWIzMzM1YWZjMWYwYmQ3NzdmN2MxOS4uMGU5N2EyMjhiMDMyYWU1OTI0OGQ5NmIzOWI5ZGFi NmFlZDAzMWU2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTIzICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AZ21haWwuY29tPgorCisgICAgICAgIERvbid0IGFsbG9jYXRl IHJhcmUgZGF0YSBvbiBldmVyeSBFbGVtZW50IG9uIHJlbW92YWwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzc1NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBub3QgYWxsb2NhdGUgYW4g RWxlbWVudFJhcmVEYXRhIGZvciBldmVyeSBlbGVtZW50CisgICAgICAgIGluIEVsZW1lbnQ6OnJl bW92ZWRGcm9tLiBQcmV2aW91c2x5IGNhbGxzIHRvIHNldElzSW5Ub3BMYXllcgorICAgICAgICB3 b3VsZCB1bmNvbmRpdGlvbmFsbHkgY2FsbCBlbnN1cmVFbGVtZW50UmFyZURhdGEoKSwgYW5kIHRo aXMgd2FzCisgICAgICAgIGNhbGxlZCBmcm9tIEVsZW1lbnQ6OnJlbW92ZWRGcm9tIG1lYW5pbmcg cmVtb3ZpbmcgYW4gZWxlbWVudAorICAgICAgICBtYWRlIHRoZSBlbnRpcmUgc3VidHJlZSBzdWRk ZW5seSBiYWxsb29uIHRvIGh1Z2UgaW4gc2l6ZSBhcyBlYWNoCisgICAgICAgIG9uZSBnb3QgYW4g RWxlbWVudFJhcmVEYXRhLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQsIGNvdmVyZWQg YnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpFbGVtZW50OjpzZXRJc0luVG9wTGF5ZXIpOgorCiAyMDEzLTAxLTIzICBIYW5z IE11bGxlciAgPGhtdWxsZXJAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgRXhjbHVzaW9uc10g QWRkIHN1cHBvcnQgZm9yIGNvbXB1dGluZyBmaXJzdCBpbmNsdWRlZCBpbnRlcnZhbCBwb3NpdGlv biBmb3IgcG9seWdvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCA1ZDhmOTQ1YzEwYTFlYTgz YWMwNGU2MjkyNGE2NDMwOTU2ZDBjNDc0Li5lMmM2OTk0OGU4MmViNDZiZDliY2Q5N2NjZTY2NTEw YWEwZmNkMGZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0yNDAxLDYgKzI0MDEsOCBAQCBi b29sIEVsZW1lbnQ6OmlzSW5Ub3BMYXllcigpIGNvbnN0CiAKIHZvaWQgRWxlbWVudDo6c2V0SXNJ blRvcExheWVyKGJvb2wgaW5Ub3BMYXllcikKIHsKKyAgICBpZiAoIWhhc1JhcmVEYXRhKCkgfHwg IWluVG9wTGF5ZXIpCisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBlbnN1cmVFbGVtZW50UmFy ZURhdGEoKS0+c2V0SXNJblRvcExheWVyKGluVG9wTGF5ZXIpOwogICAgIHNldE5lZWRzU3R5bGVS ZWNhbGMoU3ludGhldGljU3R5bGVDaGFuZ2UpOwogfQo= 184340 2013-01-23 16:30:53 -0800 2013-01-23 16:38:37 -0800 Patch bug-107756-20130123162746.patch text/plain 1679 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNmN2ZkMTIwOWZhMWU0 YWQ2ZWIzMzM1YWZjMWYwYmQ3NzdmN2MxOS4uMGU5N2EyMjhiMDMyYWU1OTI0OGQ5NmIzOWI5ZGFi NmFlZDAzMWU2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTIzICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AZ21haWwuY29tPgorCisgICAgICAgIERvbid0IGFsbG9jYXRl IHJhcmUgZGF0YSBvbiBldmVyeSBFbGVtZW50IG9uIHJlbW92YWwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzc1NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBub3QgYWxsb2NhdGUgYW4g RWxlbWVudFJhcmVEYXRhIGZvciBldmVyeSBlbGVtZW50CisgICAgICAgIGluIEVsZW1lbnQ6OnJl bW92ZWRGcm9tLiBQcmV2aW91c2x5IGNhbGxzIHRvIHNldElzSW5Ub3BMYXllcgorICAgICAgICB3 b3VsZCB1bmNvbmRpdGlvbmFsbHkgY2FsbCBlbnN1cmVFbGVtZW50UmFyZURhdGEoKSwgYW5kIHRo aXMgd2FzCisgICAgICAgIGNhbGxlZCBmcm9tIEVsZW1lbnQ6OnJlbW92ZWRGcm9tIG1lYW5pbmcg cmVtb3ZpbmcgYW4gZWxlbWVudAorICAgICAgICBtYWRlIHRoZSBlbnRpcmUgc3VidHJlZSBzdWRk ZW5seSBiYWxsb29uIHRvIGh1Z2UgaW4gc2l6ZSBhcyBlYWNoCisgICAgICAgIG9uZSBnb3QgYW4g RWxlbWVudFJhcmVEYXRhLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQsIGNvdmVyZWQg YnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpFbGVtZW50OjpzZXRJc0luVG9wTGF5ZXIpOgorCiAyMDEzLTAxLTIzICBIYW5z IE11bGxlciAgPGhtdWxsZXJAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgRXhjbHVzaW9uc10g QWRkIHN1cHBvcnQgZm9yIGNvbXB1dGluZyBmaXJzdCBpbmNsdWRlZCBpbnRlcnZhbCBwb3NpdGlv biBmb3IgcG9seWdvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCA1ZDhmOTQ1YzEwYTFlYTgz YWMwNGU2MjkyNGE2NDMwOTU2ZDBjNDc0Li5hYWQwYjc5YTlkODgzMzY2M2FkYzY1ZmE3OWQyZDNm YjZkYzNlNjM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0yNDAxLDYgKzI0MDEsOCBAQCBi b29sIEVsZW1lbnQ6OmlzSW5Ub3BMYXllcigpIGNvbnN0CiAKIHZvaWQgRWxlbWVudDo6c2V0SXNJ blRvcExheWVyKGJvb2wgaW5Ub3BMYXllcikKIHsKKyAgICBpZiAoIWhhc1JhcmVEYXRhKCkgJiYg IWluVG9wTGF5ZXIpCisgICAgICAgIHJldHVybjsKICAgICBlbnN1cmVFbGVtZW50UmFyZURhdGEo KS0+c2V0SXNJblRvcExheWVyKGluVG9wTGF5ZXIpOwogICAgIHNldE5lZWRzU3R5bGVSZWNhbGMo U3ludGhldGljU3R5bGVDaGFuZ2UpOwogfQo= 184343 2013-01-23 16:38:38 -0800 2013-01-23 20:07:51 -0800 Patch bug-107756-20130123163531.patch text/plain 1801 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNmN2ZkMTIwOWZhMWU0 YWQ2ZWIzMzM1YWZjMWYwYmQ3NzdmN2MxOS4uYzBmOGM0OGMzY2NjZWZkODYxNjNiMDJiMzMyNGQ0 MmQ4MTNmMzc1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAxLTIzICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AZ21haWwuY29tPgorCisgICAgICAgIERvbid0IGFsbG9jYXRl IHJhcmUgZGF0YSBvbiBldmVyeSBFbGVtZW50IG9uIHJlbW92YWwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzc1NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBub3QgYWxsb2NhdGUgYW4g RWxlbWVudFJhcmVEYXRhIGZvciBldmVyeSBlbGVtZW50CisgICAgICAgIGluIEVsZW1lbnQ6OnJl bW92ZWRGcm9tLiBQcmV2aW91c2x5IGNhbGxzIHRvIHNldElzSW5Ub3BMYXllcgorICAgICAgICB3 b3VsZCB1bmNvbmRpdGlvbmFsbHkgY2FsbCBlbnN1cmVFbGVtZW50UmFyZURhdGEoKSwgYW5kIHRo aXMgd2FzCisgICAgICAgIGNhbGxlZCBmcm9tIEVsZW1lbnQ6OnJlbW92ZWRGcm9tIG1lYW5pbmcg cmVtb3ZpbmcgYW4gZWxlbWVudAorICAgICAgICBtYWRlIHRoZSBlbnRpcmUgc3VidHJlZSBzdWRk ZW5seSBiYWxsb29uIHRvIGh1Z2UgaW4gc2l6ZSBhcyBlYWNoCisgICAgICAgIG9uZSBnb3QgYW4g RWxlbWVudFJhcmVEYXRhLgorCisgICAgICAgIFRoaXMgaXMgYSByZWdyZXNzaW9uIGZyb20gbXkg cGF0Y2ggb24gQnVnIDEwMzkxMiB3aGVyZSBJIHJlbW92ZWQgYSBjaGVjaworICAgICAgICB0aGF0 IGF2b2lkZWQgdGhpcyBhbGxvY2F0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQs IGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjpzZXRJc0luVG9wTGF5ZXIpOgorCiAyMDEzLTAx LTIzICBIYW5zIE11bGxlciAgPGhtdWxsZXJAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgRXhj bHVzaW9uc10gQWRkIHN1cHBvcnQgZm9yIGNvbXB1dGluZyBmaXJzdCBpbmNsdWRlZCBpbnRlcnZh bCBwb3NpdGlvbiBmb3IgcG9seWdvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCA1ZDhmOTQ1 YzEwYTFlYTgzYWMwNGU2MjkyNGE2NDMwOTU2ZDBjNDc0Li4wYjg1ZmZlMzMwZjc2ODIzZDVhYzNi NTAzYmFmNjZmYmVjNDcxY2VlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0yNDAxLDYgKzI0 MDEsOCBAQCBib29sIEVsZW1lbnQ6OmlzSW5Ub3BMYXllcigpIGNvbnN0CiAKIHZvaWQgRWxlbWVu dDo6c2V0SXNJblRvcExheWVyKGJvb2wgaW5Ub3BMYXllcikKIHsKKyAgICBpZiAoaXNJblRvcExh eWVyKCkgPT0gaW5Ub3BMYXllcikKKyAgICAgICAgcmV0dXJuOwogICAgIGVuc3VyZUVsZW1lbnRS YXJlRGF0YSgpLT5zZXRJc0luVG9wTGF5ZXIoaW5Ub3BMYXllcik7CiAgICAgc2V0TmVlZHNTdHls ZVJlY2FsYyhTeW50aGV0aWNTdHlsZUNoYW5nZSk7CiB9Cg==