107755 2013-01-23 16:23:29 -0800 Teach threaded HTML parser to update InspectorInstrumentation when writing HTML 2013-01-23 18:18:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106127 1 tonyg tonyg ojan.autocc webkit.review.bot oldest_to_newest 814789 0 tonyg 2013-01-23 16:23:29 -0800 Teach threaded HTML parser to update InspectorInstrumentation when writing HTML 814791 1 184338 tonyg 2013-01-23 16:24:53 -0800 Created attachment 184338 Patch 814818 2 184338 eric 2013-01-23 16:42:25 -0800 Comment on attachment 184338 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184338&action=review > Source/WebCore/html/parser/HTMLDocumentParser.cpp:284 > + InspectorInstrumentationCookie cookie = InspectorInstrumentation::willWriteHTML(document(), 0, 0); We have the line number, we could easily pass it here. :) > Source/WebCore/html/parser/HTMLDocumentParser.cpp:313 > + InspectorInstrumentation::didWriteHTML(cookie, 0); Similarly here, lineNumber() should just be correct already. :) 814836 3 184350 tonyg 2013-01-23 16:54:09 -0800 Created attachment 184350 Patch 814840 4 tonyg 2013-01-23 16:57:05 -0800 > Similarly here, lineNumber() should just be correct already. :) You are right. Fixed. 814842 5 184350 eric 2013-01-23 16:59:25 -0800 Comment on attachment 184350 Patch LGTM. It would be easy to wire the input length into the "packets of tokens" sent back from the background parser, but we can do that in a second pass. 814927 6 184350 webkit.review.bot 2013-01-23 18:18:53 -0800 Comment on attachment 184350 Patch Clearing flags on attachment: 184350 Committed r140628: <http://trac.webkit.org/changeset/140628> 814928 7 webkit.review.bot 2013-01-23 18:18:56 -0800 All reviewed patches have been landed. Closing bug. 184338 2013-01-23 16:24:53 -0800 2013-01-23 16:54:06 -0800 Patch bug-107755-20130123162146.patch text/plain 2952 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmYxNGRhNGRlZGYzYTJj YzBjMzdjMjU1OGE3NzZlMmYwODM1NDQ3Ny4uMGU2MzZhNGRhMWM2NTAyNTBmYjdjYTBiOTI0OTc3 ZDc0MGIzMGZiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTIzICBUb255 IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVGVhY2ggdGhyZWFk ZWQgSFRNTCBwYXJzZXIgdG8gdXBkYXRlIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbiB3aGVuIHdy aXRpbmcgSFRNTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA3NzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIGN1cnJlbnQgbGluZSBhbmQgbGVuZ3RoIGlzIHVudXNlZCwgc28gaXQgZG9lc24ndCBj YXVzZSBhbnkgbm90aWNlYWJsZSBiZWhhdmlvciBkaWZmZXJlbmNlIHRvIG5vdCBwYXNzIGl0IGhl cmUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgY292ZXJlZCBieSBleGlzdGluZyB0 ZXN0cy4KKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MRG9jdW1lbnRQYXJzZXI6OnByb2Nlc3NUb2tlbnNGcm9tQmFj a2dyb3VuZFBhcnNlcik6CisKIDIwMTMtMDEtMjMgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBJbmNvcnJlY3Qgc2Nyb2xsYWJsZSBoZWlnaHQgZHVyaW5nIHNpbXBs aWZpZWQgbGF5b3V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1M RG9jdW1lbnRQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTERvY3Vt ZW50UGFyc2VyLmNwcAppbmRleCBhNGQ3YzJhYTM0Njc0NjFkZWY2Y2VkNjQ5Yzc5YTJhZDE3ODRk NTlmLi5jMmY0MTIwOGIxNWMyM2JjMjM1ODA2N2MzOGY5ZTQ5MWRkMDY5YzE3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MRG9jdW1lbnRQYXJzZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5jcHAKQEAgLTI4 MCw3ICsyODAsOCBAQCB2b2lkIEhUTUxEb2N1bWVudFBhcnNlcjo6cHJvY2Vzc1Rva2Vuc0Zyb21C YWNrZ3JvdW5kUGFyc2VyKFBhc3NPd25QdHI8Q29tcGFjdEhUTQogICAgIC8vIGJ1dCB3ZSBuZWVk IHRvIGVuc3VyZSBpdCBpc24ndCBkZWxldGVkIHlldC4KICAgICBSZWZQdHI8SFRNTERvY3VtZW50 UGFyc2VyPiBwcm90ZWN0KHRoaXMpOwogCi0gICAgLy8gRklYTUU6IEFkZCBzdXBwb3J0IGZvciBJ bnNwZWN0b3JJbnN0cnVtZW50YXRpb24uCisgICAgLy8gRklYTUU6IFBhc3MgaW4gY3VycmVudCBp bnB1dCBsZW5ndGggYW5kIGxpbmUgbnVtYmVyLgorICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlv bkNvb2tpZSBjb29raWUgPSBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OndpbGxXcml0ZUhUTUwo ZG9jdW1lbnQoKSwgMCwgMCk7CiAKICAgICBmb3IgKFZlY3RvcjxDb21wYWN0SFRNTFRva2VuPjo6 Y29uc3RfaXRlcmF0b3IgaXQgPSB0b2tlbnMtPmJlZ2luKCk7IGl0ICE9IHRva2Vucy0+ZW5kKCk7 ICsraXQpIHsKICAgICAgICAgQVNTRVJUKCFpc1dhaXRpbmdGb3JTY3JpcHRzKCkpOwpAQCAtMjkw LDcgKzI5MSw3IEBAIHZvaWQgSFRNTERvY3VtZW50UGFyc2VyOjpwcm9jZXNzVG9rZW5zRnJvbUJh Y2tncm91bmRQYXJzZXIoUGFzc093blB0cjxDb21wYWN0SFRNCiAgICAgICAgIGNvbnN0cnVjdFRy ZWVGcm9tQ29tcGFjdEhUTUxUb2tlbigqaXQpOwogCiAgICAgICAgIGlmIChpc1N0b3BwZWQoKSkK LSAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgIC8vIEZJ WE1FOiBXZSdsbCBwcm9iYWJseSBuZWVkIHRvIGNoZWNrIGRvY3VtZW50KCktPmZyYW1lKCktPm5h dmlnYXRpb25TY2hlZHVsZXIoKS0+bG9jYXRpb25DaGFuZ2VQZW5kaW5nKCkpCiAgICAgICAgIC8v IGFzIHdlIGRvIGluIGNhblRha2VOZXh0VG9rZW47CkBAIC0yOTgsMTUgKzI5OSwxOCBAQCB2b2lk IEhUTUxEb2N1bWVudFBhcnNlcjo6cHJvY2Vzc1Rva2Vuc0Zyb21CYWNrZ3JvdW5kUGFyc2VyKFBh c3NPd25QdHI8Q29tcGFjdEhUTQogICAgICAgICBpZiAoaXNXYWl0aW5nRm9yU2NyaXB0cygpKSB7 CiAgICAgICAgICAgICBBU1NFUlQoaXQgKyAxID09IHRva2Vucy0+ZW5kKCkpOyAvLyBUaGUgPC9z Y3JpcHQ+IGlzIGFzc3VtZWQgdG8gYmUgdGhlIGxhc3QgdG9rZW4gb2YgdGhpcyBidW5jaC4KICAg ICAgICAgICAgIHJ1blNjcmlwdHNGb3JQYXVzZWRUcmVlQnVpbGRlcigpOwotICAgICAgICAgICAg cmV0dXJuOworICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAoaXQt PnR5cGUoKSA9PSBIVE1MVG9rZW5UeXBlczo6RW5kT2ZGaWxlKSB7CiAgICAgICAgICAgICBBU1NF UlQoaXQgKyAxID09IHRva2Vucy0+ZW5kKCkpOyAvLyBUaGUgRU9GIGlzIGFzc3VtZWQgdG8gYmUg dGhlIGxhc3QgdG9rZW4gb2YgdGhpcyBidW5jaC4KICAgICAgICAgICAgIHByZXBhcmVUb1N0b3BQ YXJzaW5nKCk7Ci0gICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICBicmVhazsKICAgICAg ICAgfQogICAgIH0KKworICAgIC8vIEZJWE1FOiBQYXNzIGluIGN1cnJlbnQgbGluZSBudW1iZXIu CisgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpkaWRXcml0ZUhUTUwoY29va2llLCAwKTsK IH0KIAogI2VuZGlmIC8vIEVOQUJMRShUSFJFQURFRF9IVE1MX1BBUlNFUikK 184350 2013-01-23 16:54:09 -0800 2013-01-23 18:18:52 -0800 Patch bug-107755-20130123165101.patch text/plain 2951 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjdmMzlmMzNjZTcxOTI4 OTkzZTdmODQ4YzAyOWQ1MjQ1YThiYWRlZC4uNWE2MzBhOTQ0ZjRhNjE4YjZmZWY1M2VkOWEyM2I4 NzdkMjlkNWNjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTIzICBUb255 IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVGVhY2ggdGhyZWFk ZWQgSFRNTCBwYXJzZXIgdG8gdXBkYXRlIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbiB3aGVuIHdy aXRpbmcgSFRNTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA3NzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIGN1cnJlbnQgbGVuZ3RoIGlzIHVudXNlZCwgc28gaXQgZG9lc24ndCBjYXVzZSBhbnkg bm90aWNlYWJsZSBiZWhhdmlvciBkaWZmZXJlbmNlIHRvIG5vdCBwYXNzIGl0IGhlcmUuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKwor ICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MRG9jdW1lbnRQYXJzZXI6OnByb2Nlc3NUb2tlbnNGcm9tQmFja2dyb3VuZFBh cnNlcik6CisKIDIwMTMtMDEtMjMgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtWOF0gTW92ZSBWOERPTVdyYXBwZXI6OmdldEV2ZW50TGlzdGVuZXIoKSB0 byBWOEV2ZW50TGlzdGVyTGlzdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJz ZXIvSFRNTERvY3VtZW50UGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hU TUxEb2N1bWVudFBhcnNlci5jcHAKaW5kZXggY2VlNTUyMWZiNTk2MzhhYmJjNTlhOWM0MDJiZTFj M2JmYzNhZTA5Zi4uZTdhMGUxNzVmNWMyNjUzN2FkMTczZTVkYjkwMTMxMDZkNmIzZWYzNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2VyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MRG9jdW1lbnRQYXJzZXIuY3Bw CkBAIC0yOTAsNyArMjkwLDggQEAgdm9pZCBIVE1MRG9jdW1lbnRQYXJzZXI6OnByb2Nlc3NUb2tl bnNGcm9tQmFja2dyb3VuZFBhcnNlcihQYXNzT3duUHRyPENvbXBhY3RIVE0KICAgICAvLyBidXQg d2UgbmVlZCB0byBlbnN1cmUgaXQgaXNuJ3QgZGVsZXRlZCB5ZXQuCiAgICAgUmVmUHRyPEhUTUxE b2N1bWVudFBhcnNlcj4gcHJvdGVjdCh0aGlzKTsKIAotICAgIC8vIEZJWE1FOiBBZGQgc3VwcG9y dCBmb3IgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLgorICAgIC8vIEZJWE1FOiBQYXNzIGluIGN1 cnJlbnQgaW5wdXQgbGVuZ3RoLgorICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbkNvb2tpZSBj b29raWUgPSBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OndpbGxXcml0ZUhUTUwoZG9jdW1lbnQo KSwgMCwgbGluZU51bWJlcigpLnplcm9CYXNlZEludCgpKTsKIAogICAgIGZvciAoVmVjdG9yPENv bXBhY3RIVE1MVG9rZW4+Ojpjb25zdF9pdGVyYXRvciBpdCA9IHRva2Vucy0+YmVnaW4oKTsgaXQg IT0gdG9rZW5zLT5lbmQoKTsgKytpdCkgewogICAgICAgICBBU1NFUlQoIWlzV2FpdGluZ0ZvclNj cmlwdHMoKSk7CkBAIC0zMDAsNyArMzAxLDcgQEAgdm9pZCBIVE1MRG9jdW1lbnRQYXJzZXI6OnBy b2Nlc3NUb2tlbnNGcm9tQmFja2dyb3VuZFBhcnNlcihQYXNzT3duUHRyPENvbXBhY3RIVE0KICAg ICAgICAgY29uc3RydWN0VHJlZUZyb21Db21wYWN0SFRNTFRva2VuKCppdCk7CiAKICAgICAgICAg aWYgKGlzU3RvcHBlZCgpKQotICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgYnJlYWs7 CiAKICAgICAgICAgLy8gRklYTUU6IFdlJ2xsIHByb2JhYmx5IG5lZWQgdG8gY2hlY2sgZG9jdW1l bnQoKS0+ZnJhbWUoKS0+bmF2aWdhdGlvblNjaGVkdWxlcigpLT5sb2NhdGlvbkNoYW5nZVBlbmRp bmcoKSkKICAgICAgICAgLy8gYXMgd2UgZG8gaW4gY2FuVGFrZU5leHRUb2tlbjsKQEAgLTMwOCwx NSArMzA5LDE3IEBAIHZvaWQgSFRNTERvY3VtZW50UGFyc2VyOjpwcm9jZXNzVG9rZW5zRnJvbUJh Y2tncm91bmRQYXJzZXIoUGFzc093blB0cjxDb21wYWN0SFRNCiAgICAgICAgIGlmIChpc1dhaXRp bmdGb3JTY3JpcHRzKCkpIHsKICAgICAgICAgICAgIEFTU0VSVChpdCArIDEgPT0gdG9rZW5zLT5l bmQoKSk7IC8vIFRoZSA8L3NjcmlwdD4gaXMgYXNzdW1lZCB0byBiZSB0aGUgbGFzdCB0b2tlbiBv ZiB0aGlzIGJ1bmNoLgogICAgICAgICAgICAgcnVuU2NyaXB0c0ZvclBhdXNlZFRyZWVCdWlsZGVy KCk7Ci0gICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQog CiAgICAgICAgIGlmIChpdC0+dHlwZSgpID09IEhUTUxUb2tlblR5cGVzOjpFbmRPZkZpbGUpIHsK ICAgICAgICAgICAgIEFTU0VSVChpdCArIDEgPT0gdG9rZW5zLT5lbmQoKSk7IC8vIFRoZSBFT0Yg aXMgYXNzdW1lZCB0byBiZSB0aGUgbGFzdCB0b2tlbiBvZiB0aGlzIGJ1bmNoLgogICAgICAgICAg ICAgcHJlcGFyZVRvU3RvcFBhcnNpbmcoKTsKLSAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfQorCisgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0 aW9uOjpkaWRXcml0ZUhUTUwoY29va2llLCBsaW5lTnVtYmVyKCkuemVyb0Jhc2VkSW50KCkpOwog fQogCiAjZW5kaWYgLy8gRU5BQkxFKFRIUkVBREVEX0hUTUxfUEFSU0VSKQo=