107717 2013-01-23 12:18:42 -0800 Assert that Supplementable objects are only used in their creator thread 2013-01-23 13:28:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam abarth ggaren oldest_to_newest 814489 0 mark.lam 2013-01-23 12:18:42 -0800 Supplementable and Supplement instances should only be used in the thread that created them. Adding an assertion to help detect when someone is unknowingly violating this design premise. 814505 1 184282 mark.lam 2013-01-23 12:29:54 -0800 Created attachment 184282 The patch. 814551 2 184282 abarth 2013-01-23 13:16:08 -0800 Comment on attachment 184282 The patch. View in context: https://bugs.webkit.org/attachment.cgi?id=184282&action=review > Source/WebCore/platform/Supplementable.h:128 > + ThreadIdentifier m_threadId; I wonder if this is the right thing for code that uses libdispatch. I think there's some other notion of thread affinity that we're supposed to use in those cases. 814567 3 mark.lam 2013-01-23 13:28:40 -0800 Landed in r140580: <http://trac.webkit.org/changeset/140580> 184282 2013-01-23 12:29:54 -0800 2013-01-23 13:16:07 -0800 The patch. bug-107717.patch text/plain 2981 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDU3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTIzICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBBc3NlcnQgdGhhdCBTdXBwbGVtZW50 YWJsZSBvYmplY3RzIGlzIG9ubHkgdXNlZCBpbiB0aGVpciBjcmVhdG9yIHRocmVhZC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzcxNy4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9TdXBwbGVtZW50YWJsZS5oOgorICAgICAgICAoV2ViQ29y ZSk6CisgICAgICAgIChXZWJDb3JlOjpTdXBwbGVtZW50YWJsZTo6cHJvdmlkZVN1cHBsZW1lbnQp OgorICAgICAgICAoV2ViQ29yZTo6U3VwcGxlbWVudGFibGU6OnJlbW92ZVN1cHBsZW1lbnQpOgor ICAgICAgICAoV2ViQ29yZTo6U3VwcGxlbWVudGFibGU6OnJlcXVpcmVTdXBwbGVtZW50KToKKyAg ICAgICAgKFN1cHBsZW1lbnRhYmxlKToKKyAgICAgICAgKFdlYkNvcmU6OlN1cHBsZW1lbnRhYmxl OjpTdXBwbGVtZW50YWJsZSk6CisKIDIwMTMtMDEtMjMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25A YXBwbGUuY29tPgogCiAgICAgICAgIFJlY3Vyc2lvbiBoYW5kbGluZyBjYW5jZWxsZWQgYXV0aGVu dGljYXRpb24gY2hhbGxlbmdlcyBpbiBOZXR3b3JrUHJvY2VzcwpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vU3VwcGxlbWVudGFibGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9TdXBwbGVtZW50YWJsZS5oCShyZXZpc2lvbiAxNDA1MDkpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9TdXBwbGVtZW50YWJsZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNiwx MiArMjYsMjUgQEAKICNpZm5kZWYgU3VwcGxlbWVudGFibGVfaAogI2RlZmluZSBTdXBwbGVtZW50 YWJsZV9oCiAKKyNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgogI2luY2x1ZGUgPHd0Zi9IYXNo TWFwLmg+CiAjaW5jbHVkZSA8d3RmL093blB0ci5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzT3duUHRy Lmg+CiAKKyNpZiAhQVNTRVJUX0RJU0FCTEVECisjaW5jbHVkZSA8d3RmL1RocmVhZGluZy5oPgor I2VuZGlmCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorLy8gV2hhdCB5b3Ugc2hvdWxkIGtub3cg YWJvdXQgU3VwcGxlbWVudGFibGUgYW5kIFN1cHBsZW1lbnQKKy8vID09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CisvLyBTdXBwbGVtZW50YWJs ZSBhbmQgU3VwcGxlbWVudCBpbnN0YW5jZXMgYXJlIG1lYW50IHRvIGJlIHRocmVhZCBsb2NhbC4g VGhleQorLy8gc2hvdWxkIG9ubHkgYmUgYWNjZXNzZWQgZnJvbSB3aXRoaW4gdGhlIHRocmVhZCB0 aGF0IGNyZWF0ZWQgdGhlbS4gVGhlCisvLyAyIGNsYXNzZXMgYXJlIG5vdCBkZXNpZ25lZCBmb3Ig c2FmZSBhY2Nlc3MgZnJvbSBhbm90aGVyIHRocmVhZC4gVmlvbGF0aW5nCisvLyB0aGlzIGRlc2ln biBhc3N1bXB0aW9uIGNhbiByZXN1bHQgaW4gbWVtb3J5IGNvcnJ1cHRpb24gYW5kIHVucHJlZGlj dGFibGUKKy8vIGJlaGF2aW9yLgorLy8KIC8vIFdoYXQgeW91IHNob3VsZCBrbm93IGFib3V0IHRo ZSBTdXBwbGVtZW50IGtleXMKIC8vID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KIC8vIFRoZSBTdXBwbGVtZW50IGlzIGV4cGVjdGVkIHRvIHVzZSB0aGUgc2Ft ZSBjb25zdCBjaGFyKiBzdHJpbmcgaW5zdGFuY2UKQEAgLTg2LDI1ICs5OSwzNyBAQCBjbGFzcyBT dXBwbGVtZW50YWJsZSB7CiBwdWJsaWM6CiAgICAgdm9pZCBwcm92aWRlU3VwcGxlbWVudChjb25z dCBjaGFyKiBrZXksIFBhc3NPd25QdHI8U3VwcGxlbWVudDxUPiA+IHN1cHBsZW1lbnQpCiAgICAg eworICAgICAgICBBU1NFUlQobV90aHJlYWRJZCA9PSBjdXJyZW50VGhyZWFkKCkpOwogICAgICAg ICBBU1NFUlQoIW1fc3VwcGxlbWVudHMuZ2V0KGtleSkpOwogICAgICAgICBtX3N1cHBsZW1lbnRz LnNldChrZXksIHN1cHBsZW1lbnQpOwogICAgIH0KIAogICAgIHZvaWQgcmVtb3ZlU3VwcGxlbWVu dChjb25zdCBjaGFyKiBrZXkpCiAgICAgeworICAgICAgICBBU1NFUlQobV90aHJlYWRJZCA9PSBj dXJyZW50VGhyZWFkKCkpOwogICAgICAgICBtX3N1cHBsZW1lbnRzLnJlbW92ZShrZXkpOwogICAg IH0KIAogICAgIFN1cHBsZW1lbnQ8VD4qIHJlcXVpcmVTdXBwbGVtZW50KGNvbnN0IGNoYXIqIGtl eSkKICAgICB7CisgICAgICAgIEFTU0VSVChtX3RocmVhZElkID09IGN1cnJlbnRUaHJlYWQoKSk7 CiAgICAgICAgIHJldHVybiBtX3N1cHBsZW1lbnRzLmdldChrZXkpOwogICAgIH0KIAorI2lmICFB U1NFUlRfRElTQUJMRUQKK3Byb3RlY3RlZDoKKyAgICBTdXBwbGVtZW50YWJsZSgpIDogbV90aHJl YWRJZChjdXJyZW50VGhyZWFkKCkpIHsgfQorI2VuZGlmCisKIHByaXZhdGU6CiAgICAgdHlwZWRl ZiBIYXNoTWFwPGNvbnN0IGNoYXIqLCBPd25QdHI8U3VwcGxlbWVudDxUPiA+LCBQdHJIYXNoPGNv bnN0IGNoYXIqPiA+IFN1cHBsZW1lbnRNYXA7CiAgICAgU3VwcGxlbWVudE1hcCBtX3N1cHBsZW1l bnRzOworI2lmICFBU1NFUlRfRElTQUJMRUQKKyAgICBUaHJlYWRJZGVudGlmaWVyIG1fdGhyZWFk SWQ7CisjZW5kaWYKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIFN1 cHBsZW1lbnRhYmxlX2gKKwo=