107706 2013-01-23 10:52:36 -0800 [BlackBerry] Take a better guess as to what text the user wants learned 2013-01-23 11:51:27 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nghanavatian mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 814361 0 nima.ghanavatian 2013-01-23 10:52:36 -0800 If we still have a valid caret position, use it to give priority to a region of text. We now take the text before the caret, instead of the text at the end of the field. If the caret is not present, we start from the beginning of the field. this helps learning in email where the region of interest is generally at the start, not end of the field. 814363 1 184264 nghanavatian 2013-01-23 10:53:53 -0800 Created attachment 184264 Patch 814402 2 184264 rwlbuis 2013-01-23 11:21:53 -0800 Comment on attachment 184264 Patch LGTM. 814441 3 184264 webkit.review.bot 2013-01-23 11:51:23 -0800 Comment on attachment 184264 Patch Clearing flags on attachment: 184264 Committed r140564: <http://trac.webkit.org/changeset/140564> 814442 4 webkit.review.bot 2013-01-23 11:51:27 -0800 All reviewed patches have been landed. Closing bug. 184264 2013-01-23 10:53:53 -0800 2013-01-23 11:51:23 -0800 Patch bug-107706-20130123134442.patch text/plain 2363 nghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAwMDJlZGQ1MmFkYjU2NWEyZmQ3Y2Y5Mzk3YjFjYTEyZjBlN2E5YzFjLi40YjBjNjY2YTc5 NDQ3MmFiZTg5ZmVhODQ3MmY5ZmM5YmUyMjViMzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMy0wMS0yMiAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBUYWtlIGEgYmV0dGVy IGd1ZXNzIGFzIHRvIHdoYXQgdGV4dCB0aGUgdXNlciB3YW50cyBsZWFybmVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc3MDYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB3ZSBzdGlsbCBoYXZlIGEg dmFsaWQgY2FyZXQgcG9zaXRpb24sIHVzZSBpdCB0byBnaXZlIHByaW9yaXR5IHRvIGEgcmVnaW9u CisgICAgICAgIG9mIHRleHQuICBXZSBub3cgdGFrZSB0aGUgdGV4dCBiZWZvcmUgdGhlIGNhcmV0 LCBpbnN0ZWFkIG9mIHRoZSB0ZXh0IGF0IHRoZSBlbmQKKyAgICAgICAgb2YgdGhlIGZpZWxkLiAg SWYgdGhlIGNhcmV0IGlzIG5vdCBwcmVzZW50LCB3ZSBzdGFydCBmcm9tIHRoZSBiZWdpbm5pbmcg b2YgdGhlIGZpZWxkLgorICAgICAgICBUaGlzIGhlbHBzIGxlYXJuaW5nIGluIGVtYWlsIHdoZXJl IHRoZSByZWdpb24gb2YgaW50ZXJlc3QgaXMgZ2VuZXJhbGx5IGF0IHRoZSBzdGFydCwKKyAgICAg ICAgbm90IGVuZCBvZiB0aGUgZmllbGQuCisKKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBi eSBNaWtlIEZlbnRvbgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3Bw OgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OmxlYXJuVGV4dCk6 CisKIDIwMTMtMDEtMjMgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIHNoYWRvd0FuY2VzdG9yTm9kZSgpIHNob3VsZCBiZSByZW5hbWVkIHRvIGRlcHJl Y2F0ZWRTaGFkb3dBbmNlc3Rvck5vZGUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKaW5kZXggMGQ5NGViYzBiYzE1 NTg0MWEwMzExZjdmNmEwNGM2ZmQ1ODIwZWI5MC4uOTY0MDdjYTM3MWUzMTU4YjRkOGU4NjkxNGVl NjA2N2Q1MjVkNjRmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv V2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCkBAIC04MCw4ICs4MCw2IEBACiAjZGVmaW5l IEVOQUJMRV9GT0NVU19MT0cgMAogI2RlZmluZSBFTkFCTEVfU1BFTExJTkdfTE9HIDAKIAotc3Rh dGljIGNvbnN0IHVuc2lnbmVkIE1heExlYXJuVGV4dERhdGFTaXplID0gNTAwOwotCiB1c2luZyBu YW1lc3BhY2UgQmxhY2tCZXJyeTo6UGxhdGZvcm07CiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsK IApAQCAtNTY2LDcgKzU2NCw5IEBAIHZvaWQgSW5wdXRIYW5kbGVyOjpsZWFyblRleHQoKQogICAg ICAgICByZXR1cm47CiAKICAgICBXVEY6OlN0cmluZyB0ZXh0SW5GaWVsZChlbGVtZW50VGV4dCgp KTsKLSAgICB0ZXh0SW5GaWVsZCA9IHRleHRJbkZpZWxkLnN1YnN0cmluZyhzdGQ6Om1heCgwLCBz dGF0aWNfY2FzdDxpbnQ+KHRleHRJbkZpZWxkLmxlbmd0aCgpIC0gTWF4TGVhcm5UZXh0RGF0YVNp emUpKSwgdGV4dEluRmllbGQubGVuZ3RoKCkpOworICAgIGlmICh0ZXh0SW5GaWVsZC5sZW5ndGgo KSA+PSBNYXhMZWFyblRleHREYXRhU2l6ZSkKKyAgICAgICAgdGV4dEluRmllbGQgPSB0ZXh0SW5G aWVsZC5zdWJzdHJpbmcoc3RkOjptYXgoMCwgc3RhdGljX2Nhc3Q8aW50PihjYXJldFBvc2l0aW9u KCkgLSBNYXhMZWFyblRleHREYXRhU2l6ZSkpLCBzdGQ6Om1pbih0ZXh0SW5GaWVsZC5sZW5ndGgo KSwgTWF4TGVhcm5UZXh0RGF0YVNpemUpKTsKKwogICAgIHRleHRJbkZpZWxkID0gdGV4dEluRmll bGQuc3RyaXBXaGl0ZVNwYWNlKCk7CiAKICAgICAvLyBCdWlsZCB1cCB0aGUgNTAwIGNoYXJhY3Rl ciBzdHJpbmdzIGluIHdvcmQgY2h1bmtzLgo=