107700 2013-01-23 09:33:36 -0800 [Chromium] Fix inclusion of pch .cpp in webcore_platform and webcore_rendering 2013-01-23 14:51:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 scottmg scottmg dpranke webkit.review.bot oldest_to_newest 814261 0 scottmg 2013-01-23 09:33:36 -0800 [Chromium] Fix inclusion of pch .cpp in webcore_platform and webcore_rendering 814321 1 184258 scottmg 2013-01-23 10:25:38 -0800 Created attachment 184258 Patch 814330 2 scottmg 2013-01-23 10:30:31 -0800 The ['exclude', '.*'], in these targets was excluding the pch cpp file from WinPrecompile.gypi. This works anyway in VS2010 (though is wrong), but VS2012 errors out. Goes with https://codereview.chromium.org/12052029/. 814670 3 184258 webkit.review.bot 2013-01-23 14:51:04 -0800 Comment on attachment 184258 Patch Clearing flags on attachment: 184258 Committed r140598: <http://trac.webkit.org/changeset/140598> 814671 4 webkit.review.bot 2013-01-23 14:51:07 -0800 All reviewed patches have been landed. Closing bug. 184258 2013-01-23 10:25:38 -0800 2013-01-23 14:51:04 -0800 Patch bug-107700-20130123102231.patch text/plain 1802 scottmg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTExOTY1Y2M1ODU3Mjhh ZWIwMDk4NWRjZmU2MTA5ZGNiNGU5OWMwMC4uZDA2ZDcwMzM0YTY4MjFlN2M2MzViYjM5N2IxN2Ri MThhNzQ1NzRiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTIzICBTY290 dCBHcmFoYW0gIDxzY290dG1nQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEZp eCBpbmNsdXNpb24gb2YgcGNoIC5jcHAgaW4gd2ViY29yZV9wbGF0Zm9ybSBhbmQgd2ViY29yZV9y ZW5kZXJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNzcwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cywgQ2hyb21pdW0gc2hvdWxkIGxpbmsgb24gVlMgMjAxMi4KKworICAgICAg ICAqIFdlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwOgorCiAyMDEzLTAxLTE4ICBCcmFkeSBFaWRzb24g IDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXdvcmsgTmV0d29ya1Byb2Nlc3MgcmVz b3VyY2UgbG9hZCBpZGVudGlmaWVycy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNv cmUuZ3lwL1dlYkNvcmUuZ3lwIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5n eXAKaW5kZXggMDBhZjQyOTE5MTkwZjYxZDIyOWU2ZTg4OTgyZGQ2MjhjNjMxNDQ5Yi4uNGUxYzYy OGM2MDk3YzFkZTkwMGM2NzEzYTNlZDliODQ1YmRjYjI1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29y ZS5neXAvV2ViQ29yZS5neXAKQEAgLTE5MjIsNiArMTkyMiwxMSBAQAogICAgICAgICAgICAgWydp bmNsdWRlJywgJ3BsYXRmb3JtL2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlU2FuaXRpemVyXFwu Y3BwJCddLAogICAgICAgICAgIF0sCiAgICAgICAgIH1dLAorICAgICAgICBbJ09TPT0id2luIiBh bmQgY2hyb21pdW1fd2luX3BjaD09MScsIHsKKyAgICAgICAgICAnc291cmNlcy8nOiBbCisgICAg ICAgICAgICBbJ2luY2x1ZGUnLCAnPCh3aW5fcGNoX2RpcikvV2luUHJlY29tcGlsZS5jcHAnXSwK KyAgICAgICAgICBdLAorICAgICAgICB9XSwKICAgICAgICAgWydPUz09ImFuZHJvaWQiJywgewog ICAgICAgICAgICdzb3VyY2VzLyc6IFsKICAgICAgICAgICAgIFsnaW5jbHVkZScsICdwbGF0Zm9y bS9jaHJvbWl1bS9DbGlwYm9hcmRDaHJvbWl1bUxpbnV4XFwuY3BwJCddLApAQCAtMjAxOCw2ICsy MDIzLDExIEBACiAgICAgICAgICAgICBbJ2V4Y2x1ZGUnLCAnV2luXFwuY3BwJCddLAogICAgICAg ICAgIF0sCiAgICAgICAgIH1dLAorICAgICAgICBbJ09TPT0id2luIiBhbmQgY2hyb21pdW1fd2lu X3BjaD09MScsIHsKKyAgICAgICAgICAnc291cmNlcy8nOiBbCisgICAgICAgICAgICBbJ2luY2x1 ZGUnLCAnPCh3aW5fcGNoX2RpcikvV2luUHJlY29tcGlsZS5jcHAnXSwKKyAgICAgICAgICBdLAor ICAgICAgICB9XSwKICAgICAgICAgWydPUz09Im1hYyInLCB7CiAgICAgICAgICAgJ3NvdXJjZXMv JzogWwogICAgICAgICAgICAgIyBSZW5kZXJUaGVtZUNocm9taXVtU2tpYSBpcyBub3QgdXNlZCBv biBtYWMgc2luY2UgUmVuZGVyVGhlbWVDaHJvbWl1bU1hYwo=