<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>107693</bug_id>
          
          <creation_ts>2013-01-23 07:48:05 -0800</creation_ts>
          <short_desc>[WK2][EFL] Remove unneeded private methods</short_desc>
          <delta_ts>2013-01-28 02:29:22 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>107657</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kenneth Rohde Christiansen">kenneth</reporter>
          <assigned_to name="Kenneth Rohde Christiansen">kenneth</assigned_to>
          <cc>benjamin</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kalyan.kondapally</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>mikhail.pozdnyakov</cc>
    
    <cc>ostap73</cc>
    
    <cc>rakuco</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>814204</commentid>
    <comment_count>0</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2013-01-23 07:48:05 -0800</bug_when>
    <thetext>Remove two unneeded private methods in EwkViewImpl as we are trying to slim the class somewhat and later split it up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>814205</commentid>
    <comment_count>1</comment_count>
      <attachid>184234</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2013-01-23 07:49:53 -0800</bug_when>
    <thetext>Created attachment 184234
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>814327</commentid>
    <comment_count>2</comment_count>
      <attachid>184234</attachid>
    <who name="Mikhail Pozdnyakov">mikhail.pozdnyakov</who>
    <bug_when>2013-01-23 10:28:01 -0800</bug_when>
    <thetext>Comment on attachment 184234
Patch

looks nice.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>814328</commentid>
    <comment_count>3</comment_count>
      <attachid>184234</attachid>
    <who name="Mikhail Pozdnyakov">mikhail.pozdnyakov</who>
    <bug_when>2013-01-23 10:29:49 -0800</bug_when>
    <thetext>Comment on attachment 184234
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184234&amp;action=review

&gt; Source/WebKit2/ChangeLog:3
&gt; +        [WK][EFL] Remove unneeded private methods

[WK2] ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>814681</commentid>
    <comment_count>4</comment_count>
      <attachid>184234</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-01-23 14:54:22 -0800</bug_when>
    <thetext>Comment on attachment 184234
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184234&amp;action=review

&gt; Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:380
&gt; +    if (m_pendingSurfaceResize || !m_evasGLSurface) {

The way the state is handled before coming here is madness.

I am not sure you even need &quot;|| !m_evasGLSurface&quot;. I think some clarifying of the state would be beneficial.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>815280</commentid>
    <comment_count>5</comment_count>
      <attachid>184452</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2013-01-24 02:57:02 -0800</bug_when>
    <thetext>Created attachment 184452
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>815282</commentid>
    <comment_count>6</comment_count>
    <who name="Kalyan">kalyan.kondapally</who>
    <bug_when>2013-01-24 02:59:01 -0800</bug_when>
    <thetext>LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>815817</commentid>
    <comment_count>7</comment_count>
      <attachid>184452</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-01-24 14:12:14 -0800</bug_when>
    <thetext>Comment on attachment 184452
Patch

This needs a rebase after r140686.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>817624</commentid>
    <comment_count>8</comment_count>
      <attachid>184957</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2013-01-28 02:04:54 -0800</bug_when>
    <thetext>Created attachment 184957
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>817632</commentid>
    <comment_count>9</comment_count>
      <attachid>184957</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-01-28 02:17:11 -0800</bug_when>
    <thetext>Comment on attachment 184957
Patch

rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>817643</commentid>
    <comment_count>10</comment_count>
      <attachid>184957</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-28 02:29:17 -0800</bug_when>
    <thetext>Comment on attachment 184957
Patch

Clearing flags on attachment: 184957

Committed r140961: &lt;http://trac.webkit.org/changeset/140961&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>817644</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-28 02:29:22 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>184234</attachid>
            <date>2013-01-23 07:49:53 -0800</date>
            <delta_ts>2013-01-24 02:56:51 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>0001-WK-EFL-Remove-unneeded-private-methods.patch</filename>
            <type>text/plain</type>
            <size>4130</size>
            <attacher name="Kenneth Rohde Christiansen">kenneth</attacher>
            
              <data encoding="base64">RnJvbSAyNTQwZTA2YmZlODQxZDM1NDlhNjc1OTgwMGVhMzJhMzZkNjgwNWUwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3
ZWJraXQub3JnPgpEYXRlOiBXZWQsIDIzIEphbiAyMDEzIDE2OjQ1OjUyICswMTAwClN1YmplY3Q6
IFtQQVRDSF0gW1dLXVtFRkxdIFJlbW92ZSB1bm5lZWRlZCBwcml2YXRlIG1ldGhvZHMKIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc2OTMKClJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgoKTWFrZSBzdXJlIHRoZSB3cmFwcGVycyBjYW4gbmV2ZXIgYmUgbnVsbCB3
aGVuIGNhbGxlZC4KCiogVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwOgooRXdrVmll
d0ltcGw6OmRpc3BsYXlUaW1lckZpcmVkKToKKEV3a1ZpZXdJbXBsOjpjcmVhdGVHTFN1cmZhY2Up
OgoqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmg6CihFd2tWaWV3SW1wbCk6Ci0tLQog
U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNSAr
KysrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJ
bXBsLmNwcCB8ICAgMTEgKysrKysrLS0tLS0KIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv
ZWZsL0V3a1ZpZXdJbXBsLmggICB8ICAgIDUgLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMjEgaW5z
ZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv
Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDIxYzY2MDYuLjJkYjRl
OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMy0wMS0yMyAgS2VubmV0aCBSb2hk
ZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1dLXVtFRkxd
IFJlbW92ZSB1bm5lZWRlZCBwcml2YXRlIG1ldGhvZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzY5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSB0aGUgd3JhcHBlcnMgY2FuIG5ldmVy
IGJlIG51bGwgd2hlbiBjYWxsZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tW
aWV3SW1wbC5jcHA6CisgICAgICAgIChFd2tWaWV3SW1wbDo6ZGlzcGxheVRpbWVyRmlyZWQpOgor
ICAgICAgICAoRXdrVmlld0ltcGw6OmNyZWF0ZUdMU3VyZmFjZSk6CisgICAgICAgICogVUlQcm9j
ZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuaDoKKyAgICAgICAgKEV3a1ZpZXdJbXBsKToKKworMjAx
My0wMS0yMyAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+
CisKICAgICAgICAgW1dLMl0gUmVwbGFjZSBzb21lIGludGVybmFsIEFQSSB1c2FnZSBpbiBFd2tW
aWV3IHdpdGggQyBBUEkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTEwNzY1MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ
L2VmbC9Fd2tWaWV3SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9F
d2tWaWV3SW1wbC5jcHAKaW5kZXggNzVmYjFkNy4uNzBhMjJhZCAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwCisrKyBiL1NvdXJjZS9X
ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcApAQCAtMzc3LDE1ICszNzcs
MTYgQEAgdm9pZCBFd2tWaWV3SW1wbDo6ZGlzcGxheVRpbWVyRmlyZWQoVGltZXI8RXdrVmlld0lt
cGw+KikKICNpZiBVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1MpCiAgICAgRXdrX1ZpZXdfU21hcnRf
RGF0YSogc2QgPSBzbWFydERhdGEoKTsKIAotICAgIGlmIChtX3BlbmRpbmdTdXJmYWNlUmVzaXpl
KSB7CisgICAgaWYgKG1fcGVuZGluZ1N1cmZhY2VSZXNpemUgfHwgIW1fZXZhc0dMU3VyZmFjZSkg
ewogICAgICAgICAvLyBDcmVhdGUgYSBHTCBzdXJmYWNlIGhlcmUgc28gdGhhdCBFdmFzIGhhcyBu
byBjaGFuY2Ugb2YgcGFpbnRpbmcgdG8gYW4gZW1wdHkgR0wgc3VyZmFjZS4KICAgICAgICAgY3Jl
YXRlR0xTdXJmYWNlKEludFNpemUoc2QtPnZpZXcudywgc2QtPnZpZXcuaCkpOwogICAgICAgICBp
ZiAoIW1fZXZhc0dMU3VyZmFjZSkKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBtX3Bl
bmRpbmdTdXJmYWNlUmVzaXplID0gZmFsc2U7Ci0gICAgfSBlbHNlCi0gICAgICAgIGV2YXNfZ2xf
bWFrZV9jdXJyZW50KG1fZXZhc0dMLmdldCgpLCBldmFzR0xTdXJmYWNlKCksIGV2YXNHTENvbnRl
eHQoKSk7CisgICAgfQorCisgICAgZXZhc19nbF9tYWtlX2N1cnJlbnQobV9ldmFzR0wuZ2V0KCks
IG1fZXZhc0dMU3VyZmFjZS0+c3VyZmFjZSgpLCBtX2V2YXNHTENvbnRleHQtPmNvbnRleHQoKSk7
CiAKICAgICAvLyBXZSBhcmUgc3VwcG9zZWQgdG8gY2xpcCB0byB0aGUgYWN0dWFsIHZpZXdwb3J0
LCBub3RoaW5nIGxlc3MuCiAgICAgSW50UmVjdCB2aWV3cG9ydChzZC0+dmlldy54LCBzZC0+dmll
dy55LCBzZC0+dmlldy53LCBzZC0+dmlldy5oKTsKQEAgLTY3NiwxMCArNjc3LDEwIEBAIGJvb2wg
RXdrVmlld0ltcGw6OmNyZWF0ZUdMU3VyZmFjZShjb25zdCBJbnRTaXplJiB2aWV3U2l6ZSkKICAg
ICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgRXZhc19OYXRpdmVfU3VyZmFjZSBuYXRpdmVTdXJm
YWNlOwotICAgIGV2YXNfZ2xfbmF0aXZlX3N1cmZhY2VfZ2V0KG1fZXZhc0dMLmdldCgpLCBldmFz
R0xTdXJmYWNlKCksICZuYXRpdmVTdXJmYWNlKTsKKyAgICBldmFzX2dsX25hdGl2ZV9zdXJmYWNl
X2dldChtX2V2YXNHTC5nZXQoKSwgbV9ldmFzR0xTdXJmYWNlLT5zdXJmYWNlKCksICZuYXRpdmVT
dXJmYWNlKTsKICAgICBldmFzX29iamVjdF9pbWFnZV9uYXRpdmVfc3VyZmFjZV9zZXQoc2QtPmlt
YWdlLCAmbmF0aXZlU3VyZmFjZSk7CiAKLSAgICBldmFzX2dsX21ha2VfY3VycmVudChtX2V2YXNH
TC5nZXQoKSwgZXZhc0dMU3VyZmFjZSgpLCBldmFzR0xDb250ZXh0KCkpOworICAgIGV2YXNfZ2xf
bWFrZV9jdXJyZW50KG1fZXZhc0dMLmdldCgpLCBtX2V2YXNHTFN1cmZhY2UtPnN1cmZhY2UoKSwg
bV9ldmFzR0xDb250ZXh0LT5jb250ZXh0KCkpOwogCiAgICAgRXZhc19HTF9BUEkqIGdsID0gZXZh
c19nbF9hcGlfZ2V0KG1fZXZhc0dMLmdldCgpKTsKICAgICBnbC0+Z2xWaWV3cG9ydCgwLCAwLCB2
aWV3U2l6ZS53aWR0aCgpICsgc2QtPnZpZXcueCwgdmlld1NpemUuaGVpZ2h0KCkgKyBzZC0+dmll
dy55KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1Zp
ZXdJbXBsLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5o
CmluZGV4IGI1NTgzZjUuLjhhZGVhOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv
Y2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz
L0FQSS9lZmwvRXdrVmlld0ltcGwuaApAQCAtMjE1LDExICsyMTUsNiBAQCBwdWJsaWM6CiAgICAg
UGFzc1JlZlB0cjxjYWlyb19zdXJmYWNlX3Q+IHRha2VTbmFwc2hvdCgpOwogCiBwcml2YXRlOgot
I2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICBFdmFzX0dMX0NvbnRleHQqIGV2
YXNHTENvbnRleHQoKSB7IHJldHVybiBtX2V2YXNHTENvbnRleHQgPyBtX2V2YXNHTENvbnRleHQt
PmNvbnRleHQoKSA6IDA7IH0KLSAgICBFdmFzX0dMX1N1cmZhY2UqIGV2YXNHTFN1cmZhY2UoKSB7
IHJldHVybiBtX2V2YXNHTFN1cmZhY2UgPyBtX2V2YXNHTFN1cmZhY2UtPnN1cmZhY2UoKSA6IDA7
IH0KLSNlbmRpZgotCiAgICAgaW5saW5lIEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNtYXJ0RGF0YSgp
IGNvbnN0OwogICAgIHZvaWQgZGlzcGxheVRpbWVyRmlyZWQoV2ViQ29yZTo6VGltZXI8RXdrVmll
d0ltcGw+Kik7CiAKLS0gCjEuNy4xMC40Cgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>184452</attachid>
            <date>2013-01-24 02:57:02 -0800</date>
            <delta_ts>2013-01-28 02:04:54 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-107693-20130124115348.patch</filename>
            <type>text/plain</type>
            <size>3452</size>
            <attacher name="Kenneth Rohde Christiansen">kenneth</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjMwYzQ2ODdjZDJkYmQ3
ODJiMjlkYWZhZGEyMjY1NzE5YWRmMzIzNC4uZWUxMGM0OTFiZDA3MDIzZjhiYjYzNDFlZTFlOTBk
YmY2OWQyYzY3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTI0ICBLZW5u
ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBb
V0syXVtFRkxdIFJlbW92ZSB1bm5lZWRlZCBwcml2YXRlIG1ldGhvZHMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzY5MworCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhcmUgaGFzIGJlZW4gdGFrZW4gdG8g
dmVyaWZ5IHRoYXQgdGhlIHdyYXBwZXJzIGNhbgorICAgICAgICBuZXZlciBiZSBudWxsIHdoZW4g
Y2FsbGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwOgor
ICAgICAgICAoRXdrVmlld0ltcGw6OmRpc3BsYXlUaW1lckZpcmVkKToKKyAgICAgICAgKEV3a1Zp
ZXdJbXBsOjpjcmVhdGVHTFN1cmZhY2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3
a1ZpZXdJbXBsLmg6CisgICAgICAgIChFd2tWaWV3SW1wbCk6CisKIDIwMTMtMDEtMjMgIFNlb2tq
dSBLd29uICA8c2Vva2p1Lmt3b25AZ21haWwuY29tPgogCiAgICAgICAgIFtFRkxdIFVucmV2aWV3
ZWQgYnVpbGQgZml4IGFmdGVyIHIxNDA2MDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAppbmRleCA3NWZiMWQ3MDhkOGE3ODgxNGYyNmUyNDdk
NWMxOWI2ODE0NDk2Zjg1Li5jNjNiOWE0NTFlYjk5MGY5ZjE4N2RlZjI4MDQ2YTlhNzZkOGNkNzUz
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1w
bC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwu
Y3BwCkBAIC0zNzksMTMgKzM3OSwxMyBAQCB2b2lkIEV3a1ZpZXdJbXBsOjpkaXNwbGF5VGltZXJG
aXJlZChUaW1lcjxFd2tWaWV3SW1wbD4qKQogCiAgICAgaWYgKG1fcGVuZGluZ1N1cmZhY2VSZXNp
emUpIHsKICAgICAgICAgLy8gQ3JlYXRlIGEgR0wgc3VyZmFjZSBoZXJlIHNvIHRoYXQgRXZhcyBo
YXMgbm8gY2hhbmNlIG9mIHBhaW50aW5nIHRvIGFuIGVtcHR5IEdMIHN1cmZhY2UuCi0gICAgICAg
IGNyZWF0ZUdMU3VyZmFjZShJbnRTaXplKHNkLT52aWV3LncsIHNkLT52aWV3LmgpKTsKLSAgICAg
ICAgaWYgKCFtX2V2YXNHTFN1cmZhY2UpCisgICAgICAgIGlmICghY3JlYXRlR0xTdXJmYWNlKElu
dFNpemUoc2QtPnZpZXcudywgc2QtPnZpZXcuaCkpKQogICAgICAgICAgICAgcmV0dXJuOwogCiAg
ICAgICAgIG1fcGVuZGluZ1N1cmZhY2VSZXNpemUgPSBmYWxzZTsKLSAgICB9IGVsc2UKLSAgICAg
ICAgZXZhc19nbF9tYWtlX2N1cnJlbnQobV9ldmFzR0wuZ2V0KCksIGV2YXNHTFN1cmZhY2UoKSwg
ZXZhc0dMQ29udGV4dCgpKTsKKyAgICB9CisKKyAgICBldmFzX2dsX21ha2VfY3VycmVudChtX2V2
YXNHTC5nZXQoKSwgbV9ldmFzR0xTdXJmYWNlLT5zdXJmYWNlKCksIG1fZXZhc0dMQ29udGV4dC0+
Y29udGV4dCgpKTsKIAogICAgIC8vIFdlIGFyZSBzdXBwb3NlZCB0byBjbGlwIHRvIHRoZSBhY3R1
YWwgdmlld3BvcnQsIG5vdGhpbmcgbGVzcy4KICAgICBJbnRSZWN0IHZpZXdwb3J0KHNkLT52aWV3
LngsIHNkLT52aWV3LnksIHNkLT52aWV3LncsIHNkLT52aWV3LmgpOwpAQCAtNjc2LDEwICs2NzYs
MTAgQEAgYm9vbCBFd2tWaWV3SW1wbDo6Y3JlYXRlR0xTdXJmYWNlKGNvbnN0IEludFNpemUmIHZp
ZXdTaXplKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBFdmFzX05hdGl2ZV9TdXJmYWNl
IG5hdGl2ZVN1cmZhY2U7Ci0gICAgZXZhc19nbF9uYXRpdmVfc3VyZmFjZV9nZXQobV9ldmFzR0wu
Z2V0KCksIGV2YXNHTFN1cmZhY2UoKSwgJm5hdGl2ZVN1cmZhY2UpOworICAgIGV2YXNfZ2xfbmF0
aXZlX3N1cmZhY2VfZ2V0KG1fZXZhc0dMLmdldCgpLCBtX2V2YXNHTFN1cmZhY2UtPnN1cmZhY2Uo
KSwgJm5hdGl2ZVN1cmZhY2UpOwogICAgIGV2YXNfb2JqZWN0X2ltYWdlX25hdGl2ZV9zdXJmYWNl
X3NldChzZC0+aW1hZ2UsICZuYXRpdmVTdXJmYWNlKTsKIAotICAgIGV2YXNfZ2xfbWFrZV9jdXJy
ZW50KG1fZXZhc0dMLmdldCgpLCBldmFzR0xTdXJmYWNlKCksIGV2YXNHTENvbnRleHQoKSk7Cisg
ICAgZXZhc19nbF9tYWtlX2N1cnJlbnQobV9ldmFzR0wuZ2V0KCksIG1fZXZhc0dMU3VyZmFjZS0+
c3VyZmFjZSgpLCBtX2V2YXNHTENvbnRleHQtPmNvbnRleHQoKSk7CiAKICAgICBFdmFzX0dMX0FQ
SSogZ2wgPSBldmFzX2dsX2FwaV9nZXQobV9ldmFzR0wuZ2V0KCkpOwogICAgIGdsLT5nbFZpZXdw
b3J0KDAsIDAsIHZpZXdTaXplLndpZHRoKCkgKyBzZC0+dmlldy54LCB2aWV3U2l6ZS5oZWlnaHQo
KSArIHNkLT52aWV3LnkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ
SS9lZmwvRXdrVmlld0ltcGwuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3
a1ZpZXdJbXBsLmgKaW5kZXggYjU1ODNmNTI1YWUyMTY1Y2YxODEzNDM4YTZiM2FlODdjZGE0ZmQ4
YS4uOGFkZWE5MGRlNTUxNThlZGIxMjdlNGE4YjY0YjE0NDRkMTQ4YzQ3MyAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuaAorKysgYi9Tb3Vy
Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5oCkBAIC0yMTUsMTEgKzIx
NSw2IEBAIHB1YmxpYzoKICAgICBQYXNzUmVmUHRyPGNhaXJvX3N1cmZhY2VfdD4gdGFrZVNuYXBz
aG90KCk7CiAKIHByaXZhdGU6Ci0jaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotICAg
IEV2YXNfR0xfQ29udGV4dCogZXZhc0dMQ29udGV4dCgpIHsgcmV0dXJuIG1fZXZhc0dMQ29udGV4
dCA/IG1fZXZhc0dMQ29udGV4dC0+Y29udGV4dCgpIDogMDsgfQotICAgIEV2YXNfR0xfU3VyZmFj
ZSogZXZhc0dMU3VyZmFjZSgpIHsgcmV0dXJuIG1fZXZhc0dMU3VyZmFjZSA/IG1fZXZhc0dMU3Vy
ZmFjZS0+c3VyZmFjZSgpIDogMDsgfQotI2VuZGlmCi0KICAgICBpbmxpbmUgRXdrX1ZpZXdfU21h
cnRfRGF0YSogc21hcnREYXRhKCkgY29uc3Q7CiAgICAgdm9pZCBkaXNwbGF5VGltZXJGaXJlZChX
ZWJDb3JlOjpUaW1lcjxFd2tWaWV3SW1wbD4qKTsKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>184957</attachid>
            <date>2013-01-28 02:04:54 -0800</date>
            <delta_ts>2013-01-28 02:29:17 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>0001-WK2-EFL-Remove-unneeded-private-methods.patch</filename>
            <type>text/plain</type>
            <size>3991</size>
            <attacher name="Kenneth Rohde Christiansen">kenneth</attacher>
            
              <data encoding="base64">RnJvbSA1MTkyMDAyNTdiNjgzYmNkZGI0YTI2ZTE0ZDY5ZmEwNDI2ODgwZGY4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3
ZWJraXQub3JnPgpEYXRlOiBXZWQsIDIzIEphbiAyMDEzIDE2OjQ1OjUyICswMTAwClN1YmplY3Q6
IFtQQVRDSCAxLzNdIFtXSzJdW0VGTF0gUmVtb3ZlIHVubmVlZGVkIHByaXZhdGUgbWV0aG9kcwog
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzY5MwoKUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCgpDYXJlIGhhcyBiZWVuIHRha2VuIHRvIHZlcmlmeSB0aGF0IHRo
ZSB3cmFwcGVycyBjYW4KbmV2ZXIgYmUgbnVsbCB3aGVuIGNhbGxlZC4KCiogVUlQcm9jZXNzL0FQ
SS9lZmwvRXdrVmlld0ltcGwuY3BwOgooRXdrVmlld0ltcGw6OmRpc3BsYXlUaW1lckZpcmVkKToK
KEV3a1ZpZXdJbXBsOjpjcmVhdGVHTFN1cmZhY2UpOgoqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1Zp
ZXdJbXBsLmg6CihFd2tWaWV3SW1wbCk6Ci0tLQogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nICAg
ICAgICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQy
L1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwIHwgICAxMiArKysrKystLS0tLS0KIFNvdXJj
ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuaCAgIHwgICAgNSAtLS0tLQogMyBm
aWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK
aW5kZXggNWFmNjc5Yi4uMjUyODUxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdl
TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEz
LTAxLTI0ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4K
KworICAgICAgICBbV0syXVtFRkxdIFJlbW92ZSB1bm5lZWRlZCBwcml2YXRlIG1ldGhvZHMKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzY5MworCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhcmUgaGFzIGJl
ZW4gdGFrZW4gdG8gdmVyaWZ5IHRoYXQgdGhlIHdyYXBwZXJzIGNhbgorICAgICAgICBuZXZlciBi
ZSBudWxsIHdoZW4gY2FsbGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmll
d0ltcGwuY3BwOgorICAgICAgICAoRXdrVmlld0ltcGw6OmRpc3BsYXlUaW1lckZpcmVkKToKKyAg
ICAgICAgKEV3a1ZpZXdJbXBsOjpjcmVhdGVHTFN1cmZhY2UpOgorICAgICAgICAqIFVJUHJvY2Vz
cy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmg6CisgICAgICAgIChFd2tWaWV3SW1wbCk6CisKIDIwMTMt
MDEtMjcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgRml4
IGxvY2F0aW9uIG9mIHNhbmRib3ggcHJvZmlsZXMgaW4gYnVpbHQgcHJvZHVjdHMKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwIGIvU291cmNl
L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKaW5kZXggZTQ3OGE4Ni4uMTMz
YTE1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmll
dy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAK
QEAgLTM3OSwxMyArMzc5LDEzIEBAIHZvaWQgRXdrVmlldzo6ZGlzcGxheVRpbWVyRmlyZWQoVGlt
ZXI8RXdrVmlldz4qKQogCiAgICAgaWYgKG1fcGVuZGluZ1N1cmZhY2VSZXNpemUpIHsKICAgICAg
ICAgLy8gQ3JlYXRlIGEgR0wgc3VyZmFjZSBoZXJlIHNvIHRoYXQgRXZhcyBoYXMgbm8gY2hhbmNl
IG9mIHBhaW50aW5nIHRvIGFuIGVtcHR5IEdMIHN1cmZhY2UuCi0gICAgICAgIGNyZWF0ZUdMU3Vy
ZmFjZShJbnRTaXplKHNkLT52aWV3LncsIHNkLT52aWV3LmgpKTsKLSAgICAgICAgaWYgKCFtX2V2
YXNHTFN1cmZhY2UpCisgICAgICAgIGlmICghY3JlYXRlR0xTdXJmYWNlKEludFNpemUoc2QtPnZp
ZXcudywgc2QtPnZpZXcuaCkpKQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIG1fcGVu
ZGluZ1N1cmZhY2VSZXNpemUgPSBmYWxzZTsKLSAgICB9IGVsc2UKLSAgICAgICAgZXZhc19nbF9t
YWtlX2N1cnJlbnQobV9ldmFzR0wuZ2V0KCksIGV2YXNHTFN1cmZhY2UoKSwgZXZhc0dMQ29udGV4
dCgpKTsKKyAgICB9CisKKyAgICBldmFzX2dsX21ha2VfY3VycmVudChtX2V2YXNHTC5nZXQoKSwg
bV9ldmFzR0xTdXJmYWNlLT5zdXJmYWNlKCksIG1fZXZhc0dMQ29udGV4dC0+Y29udGV4dCgpKTsK
IAogICAgIC8vIFdlIGFyZSBzdXBwb3NlZCB0byBjbGlwIHRvIHRoZSBhY3R1YWwgdmlld3BvcnQs
IG5vdGhpbmcgbGVzcy4KICAgICBJbnRSZWN0IHZpZXdwb3J0KHNkLT52aWV3LngsIHNkLT52aWV3
LnksIHNkLT52aWV3LncsIHNkLT52aWV3LmgpOwpAQCAtNjc2LDEwICs2NzYsMTAgQEAgYm9vbCBF
d2tWaWV3OjpjcmVhdGVHTFN1cmZhY2UoY29uc3QgSW50U2l6ZSYgdmlld1NpemUpCiAgICAgICAg
IHJldHVybiBmYWxzZTsKIAogICAgIEV2YXNfTmF0aXZlX1N1cmZhY2UgbmF0aXZlU3VyZmFjZTsK
LSAgICBldmFzX2dsX25hdGl2ZV9zdXJmYWNlX2dldChtX2V2YXNHTC5nZXQoKSwgZXZhc0dMU3Vy
ZmFjZSgpLCAmbmF0aXZlU3VyZmFjZSk7CisgICAgZXZhc19nbF9uYXRpdmVfc3VyZmFjZV9nZXQo
bV9ldmFzR0wuZ2V0KCksIG1fZXZhc0dMU3VyZmFjZS0+c3VyZmFjZSgpLCAmbmF0aXZlU3VyZmFj
ZSk7CiAgICAgZXZhc19vYmplY3RfaW1hZ2VfbmF0aXZlX3N1cmZhY2Vfc2V0KHNkLT5pbWFnZSwg
Jm5hdGl2ZVN1cmZhY2UpOwogCi0gICAgZXZhc19nbF9tYWtlX2N1cnJlbnQobV9ldmFzR0wuZ2V0
KCksIGV2YXNHTFN1cmZhY2UoKSwgZXZhc0dMQ29udGV4dCgpKTsKKyAgICBldmFzX2dsX21ha2Vf
Y3VycmVudChtX2V2YXNHTC5nZXQoKSwgbV9ldmFzR0xTdXJmYWNlLT5zdXJmYWNlKCksIG1fZXZh
c0dMQ29udGV4dC0+Y29udGV4dCgpKTsKIAogICAgIEV2YXNfR0xfQVBJKiBnbCA9IGV2YXNfZ2xf
YXBpX2dldChtX2V2YXNHTC5nZXQoKSk7CiAgICAgZ2wtPmdsVmlld3BvcnQoMCwgMCwgdmlld1Np
emUud2lkdGgoKSArIHNkLT52aWV3LngsIHZpZXdTaXplLmhlaWdodCgpICsgc2QtPnZpZXcueSk7
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3Lmgg
Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmgKaW5kZXggOTIwNTU2
My4uYTIxM2Y5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv
RXdrVmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcu
aApAQCAtMjE1LDExICsyMTUsNiBAQCBwdWJsaWM6CiAgICAgUGFzc1JlZlB0cjxjYWlyb19zdXJm
YWNlX3Q+IHRha2VTbmFwc2hvdCgpOwogCiBwcml2YXRlOgotI2lmIFVTRShBQ0NFTEVSQVRFRF9D
T01QT1NJVElORykKLSAgICBFdmFzX0dMX0NvbnRleHQqIGV2YXNHTENvbnRleHQoKSB7IHJldHVy
biBtX2V2YXNHTENvbnRleHQgPyBtX2V2YXNHTENvbnRleHQtPmNvbnRleHQoKSA6IDA7IH0KLSAg
ICBFdmFzX0dMX1N1cmZhY2UqIGV2YXNHTFN1cmZhY2UoKSB7IHJldHVybiBtX2V2YXNHTFN1cmZh
Y2UgPyBtX2V2YXNHTFN1cmZhY2UtPnN1cmZhY2UoKSA6IDA7IH0KLSNlbmRpZgotCiAgICAgaW5s
aW5lIEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNtYXJ0RGF0YSgpIGNvbnN0OwogICAgIHZvaWQgZGlz
cGxheVRpbWVyRmlyZWQoV2ViQ29yZTo6VGltZXI8RXdrVmlldz4qKTsKIAotLSAKMS43LjEwLjQK
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>