107692 2013-01-23 07:39:59 -0800 [Curl] There is no way for a WebKit client to set the Curl cookie jar path 2013-01-31 12:45:48 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned ap bfulgham peavo webkit.review.bot oldest_to_newest 814197 0 peavo 2013-01-23 07:39:59 -0800 There exists a method setCookieJarFileName() in WebCore\platform\network\curl\ResourceHandleManager.cpp, but noone uses it. 814201 1 184233 peavo 2013-01-23 07:46:23 -0800 Created attachment 184233 Patch 816602 2 peavo 2013-01-25 08:01:52 -0800 Setting the Curl cookie jar path makes Curl enable cookies, which is important for many sites to work. 820199 3 185502 peavo 2013-01-30 07:39:57 -0800 Created attachment 185502 Patch 820201 4 peavo 2013-01-30 07:42:31 -0800 Modified patch to set a default cookie jar path, this will enable the Curl cookie engine by default (and persistent cookies). 820279 5 185502 bfulgham 2013-01-30 09:54:05 -0800 Comment on attachment 185502 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185502&action=review Thanks for working on this. I think it would be cleaner if you encapsulated this in a helper function (like I did with the "certificatePath"). Then we can provide port-specific logic for identifying where the cookie jar should live. > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:122 > + , m_cookieJarFileName("cookies.dat") I would prefer you write a helper function like "certificatePath" that encapsulates the identification of this cook jar. > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:137 > + m_cookieJarFileName = fastStrDup(cookieJarPath); This logic should go in the helper function. Then I can add a CF-variant without cluttering the code. 821510 6 185780 peavo 2013-01-31 07:25:55 -0800 Created attachment 185780 Patch 821511 7 peavo 2013-01-31 07:27:21 -0800 Modified patch according to review comments. 821766 8 185780 bfulgham 2013-01-31 11:41:50 -0800 Comment on attachment 185780 Patch Looks great! 821839 9 peavo 2013-01-31 12:32:44 -0800 (In reply to comment #8) > (From update of attachment 185780 [details]) > Looks great! Thanks for the review ;) 821854 10 185780 webkit.review.bot 2013-01-31 12:45:44 -0800 Comment on attachment 185780 Patch Clearing flags on attachment: 185780 Committed r141464: <http://trac.webkit.org/changeset/141464> 821855 11 webkit.review.bot 2013-01-31 12:45:48 -0800 All reviewed patches have been landed. Closing bug. 184233 2013-01-23 07:46:23 -0800 2013-01-30 07:39:52 -0800 Patch bug-107692-20130123164305.patch text/plain 1663 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDUzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTIzICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBUaGVyZSBp cyBubyB3YXkgZm9yIGEgV2ViS2l0IGNsaWVudCB0byBzZXQgdGhlIEN1cmwgY29va2llIGphciBw YXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc2 OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHZXQg dGhlIGNvb2tpZSBqYXIgcGF0aCBmb3IgQ3VybCBmcm9tIHRoZSBlbnZpcm9ubWVudCB2YXJpYWJs ZSBDVVJMX0NPT0tJRV9KQVJfUEFUSC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3Vy bC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VI YW5kbGVNYW5hZ2VyOjpSZXNvdXJjZUhhbmRsZU1hbmFnZXIpOgorCiAyMDEzLTAxLTIzICBSYWZh ZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lP TihyMTQwMTAxKTogY2F1c2VkIGRlYnVnIGFzc2VydHMgaW4gZmFzdC9mb3Jtcy9hc3NvY2lhdGVk LWVsZW1lbnQtY3Jhc2guaHRtbCBhbmQgaHRtbDVsaWIvcnVuLXRlbXBsYXRlLmh0bWwKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFn ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3Vy bC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCShyZXZpc2lvbiAxNDA1MTQpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTMxLDYgKzEzMSwxMCBAQCBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6 OlJlc291cmNlSGFuZGxlTWFuCiAgICAgY3VybF9zaGFyZV9zZXRvcHQobV9jdXJsU2hhcmVIYW5k bGUsIENVUkxTSE9QVF9TSEFSRSwgQ1VSTF9MT0NLX0RBVEFfRE5TKTsKICAgICBjdXJsX3NoYXJl X3NldG9wdChtX2N1cmxTaGFyZUhhbmRsZSwgQ1VSTFNIT1BUX0xPQ0tGVU5DLCBjdXJsX2xvY2tf Y2FsbGJhY2spOwogICAgIGN1cmxfc2hhcmVfc2V0b3B0KG1fY3VybFNoYXJlSGFuZGxlLCBDVVJM U0hPUFRfVU5MT0NLRlVOQywgY3VybF91bmxvY2tfY2FsbGJhY2spOworCisgICAgY2hhciogY29v a2llSmFyUGF0aCA9IGdldGVudigiQ1VSTF9DT09LSUVfSkFSX1BBVEgiKTsKKyAgICBpZiAoY29v a2llSmFyUGF0aCkKKyAgICAgICAgbV9jb29raWVKYXJGaWxlTmFtZSA9IGZhc3RTdHJEdXAoY29v a2llSmFyUGF0aCk7CiB9CiAKIFJlc291cmNlSGFuZGxlTWFuYWdlcjo6flJlc291cmNlSGFuZGxl TWFuYWdlcigpCg== 185502 2013-01-30 07:39:57 -0800 2013-01-31 07:25:49 -0800 Patch bug-107692-20130130163630.patch text/plain 1997 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MTI3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTMwICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBUaGVyZSBp cyBubyB3YXkgZm9yIGEgV2ViS2l0IGNsaWVudCB0byBzZXQgdGhlIEN1cmwgY29va2llIGphciBw YXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc2 OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXQg ZGVmYXVsdCBjb29raWUgamFyIHBhdGguCisgICAgICAgIEdldCB0aGUgY29va2llIGphciBwYXRo IGZvciBDdXJsIGZyb20gdGhlIGVudmlyb25tZW50IHZhcmlhYmxlIENVUkxfQ09PS0lFX0pBUl9Q QVRILgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFu YWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OlJlc291 cmNlSGFuZGxlTWFuYWdlcik6CisKIDIwMTMtMDEtMzAgIFZsYWRpc2xhdiBLYXpuYWNoZWV2ICA8 a2F6bmFjaGVldkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2lkZWJh ciBzcGxpdHRlciBpcyBpbnZpc2libGUgaW4gRWxlbWVudHMgYW5kIFNvdXJjZXMgcGFuZWxzCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVN YW5hZ2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAkocmV2aXNpb24gMTQxMjMwKQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTExOSw3ICsxMTksNyBAQCBzdGF0aWMgdm9pZCBjdXJsX3Vu bG9ja19jYWxsYmFjayhDVVJMKiBoCiAKIFJlc291cmNlSGFuZGxlTWFuYWdlcjo6UmVzb3VyY2VI YW5kbGVNYW5hZ2VyKCkKICAgICA6IG1fZG93bmxvYWRUaW1lcih0aGlzLCAmUmVzb3VyY2VIYW5k bGVNYW5hZ2VyOjpkb3dubG9hZFRpbWVyQ2FsbGJhY2spCi0gICAgLCBtX2Nvb2tpZUphckZpbGVO YW1lKDApCisgICAgLCBtX2Nvb2tpZUphckZpbGVOYW1lKCJjb29raWVzLmRhdCIpCiAgICAgLCBt X2NlcnRpZmljYXRlUGF0aCAoY2VydGlmaWNhdGVQYXRoKCkpCiAgICAgLCBtX3J1bm5pbmdKb2Jz KDApCiAKQEAgLTEzMSw2ICsxMzEsMTAgQEAgUmVzb3VyY2VIYW5kbGVNYW5hZ2VyOjpSZXNvdXJj ZUhhbmRsZU1hbgogICAgIGN1cmxfc2hhcmVfc2V0b3B0KG1fY3VybFNoYXJlSGFuZGxlLCBDVVJM U0hPUFRfU0hBUkUsIENVUkxfTE9DS19EQVRBX0ROUyk7CiAgICAgY3VybF9zaGFyZV9zZXRvcHQo bV9jdXJsU2hhcmVIYW5kbGUsIENVUkxTSE9QVF9MT0NLRlVOQywgY3VybF9sb2NrX2NhbGxiYWNr KTsKICAgICBjdXJsX3NoYXJlX3NldG9wdChtX2N1cmxTaGFyZUhhbmRsZSwgQ1VSTFNIT1BUX1VO TE9DS0ZVTkMsIGN1cmxfdW5sb2NrX2NhbGxiYWNrKTsKKworICAgIGNoYXIqIGNvb2tpZUphclBh dGggPSBnZXRlbnYoIkNVUkxfQ09PS0lFX0pBUl9QQVRIIik7CisgICAgaWYgKGNvb2tpZUphclBh dGgpCisgICAgICAgIG1fY29va2llSmFyRmlsZU5hbWUgPSBmYXN0U3RyRHVwKGNvb2tpZUphclBh dGgpOwogfQogCiBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6On5SZXNvdXJjZUhhbmRsZU1hbmFnZXIo KQo= 185780 2013-01-31 07:25:55 -0800 2013-01-31 12:45:44 -0800 Patch bug-107692-20130131162224.patch text/plain 1997 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MTQyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTMxICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBUaGVyZSBp cyBubyB3YXkgZm9yIGEgV2ViS2l0IGNsaWVudCB0byBzZXQgdGhlIEN1cmwgY29va2llIGphciBw YXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc2 OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXQg ZGVmYXVsdCBjb29raWUgamFyIHBhdGguCisgICAgICAgIEdldCB0aGUgY29va2llIGphciBwYXRo IGZvciBDdXJsIGZyb20gdGhlIGVudmlyb25tZW50IHZhcmlhYmxlIENVUkxfQ09PS0lFX0pBUl9Q QVRILgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFu YWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb29raWVKYXJQYXRoKTogQWRkZWQgaGVscGVy IGZ1bmN0aW9uIHRvIHNldCBjb29raWUgamFyIHBhdGguCisgICAgICAgIChXZWJDb3JlOjpSZXNv dXJjZUhhbmRsZU1hbmFnZXI6OlJlc291cmNlSGFuZGxlTWFuYWdlcik6IENhbGwgaGVscGVyIGZ1 bmN0aW9uLgorCiAyMDEzLTAxLTMxICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQGRp Z2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZpeCBtaW5vciBtZW1vcnkgbGVhayBpbiBzbG90IGV4 ZWN1dGlvbgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291 cmNlSGFuZGxlTWFuYWdlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAJKHJldmlzaW9uIDE0MTM4 MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRs ZU1hbmFnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NCw2ICs4NCwxNSBAQCBzdGF0aWMgQ1N0 cmluZyBjZXJ0aWZpY2F0ZVBhdGgoKQogICAgIHJldHVybiBDU3RyaW5nKCk7CiB9CiAKK3N0YXRp YyBjaGFyKiBjb29raWVKYXJQYXRoKCkKK3sKKyAgICBjaGFyKiBjb29raWVKYXJQYXRoID0gZ2V0 ZW52KCJDVVJMX0NPT0tJRV9KQVJfUEFUSCIpOworICAgIGlmIChjb29raWVKYXJQYXRoKQorICAg ICAgICByZXR1cm4gZmFzdFN0ckR1cChjb29raWVKYXJQYXRoKTsKKworICAgIHJldHVybiBmYXN0 U3RyRHVwKCJjb29raWVzLmRhdCIpOworfQorCiBzdGF0aWMgTXV0ZXgqIHNoYXJlZFJlc291cmNl TXV0ZXgoY3VybF9sb2NrX2RhdGEgZGF0YSkgewogICAgIERFRklORV9TVEFUSUNfTE9DQUwoTXV0 ZXgsIGNvb2tpZU11dGV4LCAoKSk7CiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChNdXRleCwgZG5z TXV0ZXgsICgpKTsKQEAgLTExOSw3ICsxMjgsNyBAQCBzdGF0aWMgdm9pZCBjdXJsX3VubG9ja19j YWxsYmFjayhDVVJMKiBoCiAKIFJlc291cmNlSGFuZGxlTWFuYWdlcjo6UmVzb3VyY2VIYW5kbGVN YW5hZ2VyKCkKICAgICA6IG1fZG93bmxvYWRUaW1lcih0aGlzLCAmUmVzb3VyY2VIYW5kbGVNYW5h Z2VyOjpkb3dubG9hZFRpbWVyQ2FsbGJhY2spCi0gICAgLCBtX2Nvb2tpZUphckZpbGVOYW1lKDAp CisgICAgLCBtX2Nvb2tpZUphckZpbGVOYW1lKGNvb2tpZUphclBhdGgoKSkKICAgICAsIG1fY2Vy dGlmaWNhdGVQYXRoIChjZXJ0aWZpY2F0ZVBhdGgoKSkKICAgICAsIG1fcnVubmluZ0pvYnMoMCkK IAo=