107684 2013-01-23 05:55:59 -0800 On Linux, can't get spelling suggestions without selection when unified text checker is enabled 2013-01-31 10:01:01 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 g.czajkowski g.czajkowski laszlo.gombos lucas.de.marchi mifenton morrita rniwa tony webkit.review.bot oldest_to_newest 814140 0 g.czajkowski 2013-01-23 05:55:59 -0800 Bug 103520 allows to retrieve the spelling suggestions without selecting the misspelled word. We need to do the same when unified text checker is enabled. 816594 1 184751 g.czajkowski 2013-01-25 07:49:19 -0800 Created attachment 184751 proposed patch 819921 2 184751 rniwa 2013-01-30 01:13:40 -0800 Comment on attachment 184751 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=184751&action=review > Source/WebCore/editing/Editor.cpp:1781 > if (!range) > return Vector<String>(); I would prefer moving this to after if, and then called frame()->selection()->toNormalizedRange() in the else clause. > Source/WebCore/editing/Editor.cpp:1783 > + VisibleSelection wordSelection(frame()->selection()->base()); wordSelection = frame()->selection()->base() ? > Source/WebCore/editing/Editor.cpp:1786 > + ASSERT(range); I don’t think we can assert that range is always non-null. 821440 3 184751 g.czajkowski 2013-01-31 05:42:59 -0800 Comment on attachment 184751 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=184751&action=review >> Source/WebCore/editing/Editor.cpp:1781 >> return Vector<String>(); > > I would prefer moving this to after if, and then called frame()->selection()->toNormalizedRange() in the else clause. Done. >> Source/WebCore/editing/Editor.cpp:1783 >> + VisibleSelection wordSelection(frame()->selection()->base()); > > wordSelection = frame()->selection()->base() ? I found two ways of constructing VisibleSelection object in WebCore: either 1) VisibleSelection wordSelection(positionObject) or 2) VisibleSelection wordSelection = VisibleSelection(positionObject). I have updated this line with second one. >> Source/WebCore/editing/Editor.cpp:1786 >> + ASSERT(range); > > I don’t think we can assert that range is always non-null. Thanks for the hint. Done. 821449 4 185765 g.czajkowski 2013-01-31 05:50:28 -0800 Created attachment 185765 apply Ryosuke's suggestions Ryosuke, is it ok for you now? If yes feel free to land this patch. I had to change the code a little to apply the review. I am not sure whether it can be landed without review. 821599 5 185765 rniwa 2013-01-31 09:48:44 -0800 Comment on attachment 185765 apply Ryosuke's suggestions Yup, looks great to me. 821603 6 185765 webkit.review.bot 2013-01-31 10:00:56 -0800 Comment on attachment 185765 apply Ryosuke's suggestions Clearing flags on attachment: 185765 Committed r141429: <http://trac.webkit.org/changeset/141429> 821604 7 webkit.review.bot 2013-01-31 10:01:01 -0800 All reviewed patches have been landed. Closing bug. 184751 2013-01-25 07:49:19 -0800 2013-01-31 05:50:28 -0800 proposed patch spelling-context-menu-suggestion-unified-text-checker.patch text/plain 1843 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NDdiM2Q1Li42NmVmODMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTMtMDEtMjUgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CiAKKyAgICAgICAgT24gTGludXgsIGNhbid0IGdldCBzcGVsbGluZyBzdWdnZXN0aW9u cyB3aXRob3V0IHNlbGVjdGlvbiB3aGVuIHVuaWZpZWQgdGV4dCBjaGVja2VyIGlzIGVuYWJsZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzY4NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgY292ZXJlZCBieSBjb250ZXh0LW1lbnUtc3VnZ2VzdGlvbnMuaHRtbC4KKworICAgICAg ICAqIGVkaXRpbmcvRWRpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6Z3Vlc3Nl c0Zvck1pc3NwZWxsZWRPclVuZ3JhbW1hdGljYWwpOgorICAgICAgICBGb3IgTGludXgsIGV4dGVu ZCBzZWxlY3Rpb24gcmFuZ2UgdG8gdGhlIGNsb3Nlc3Qgd29yZCB0byBnZXQKKyAgICAgICAgdGhl IHNwZWxsaW5nIHN1Z2dlc3Rpb25zIHdoZW4gdW5pZmllZCB0ZXh0IGNoZWNrZXIgaXMgZW5hYmxl ZC4KKworMjAxMy0wMS0yNSAgR3J6ZWdvcnogQ3phamtvd3NraSAgPGcuY3phamtvd3NraUBzYW1z dW5nLmNvbT4KKwogICAgICAgICBbRUZMXSBVbmlmaWVkIHRleHQgY2hlY2tlciBpbXBsZW1lbnRh dGlvbi4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NzY4MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKaW5kZXggMmUxZDVlYy4uMGVlM2RiMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcApAQCAtMTc3OSw2ICsxNzc5LDEyIEBAIFZlY3Rv cjxTdHJpbmc+IEVkaXRvcjo6Z3Vlc3Nlc0Zvck1pc3NwZWxsZWRPclVuZ3JhbW1hdGljYWwoYm9v bCYgbWlzc3BlbGxlZCwgYm9vCiAgICAgICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSBmcmFtZSgp LT5zZWxlY3Rpb24oKS0+dG9Ob3JtYWxpemVkUmFuZ2UoKTsKICAgICAgICAgaWYgKCFyYW5nZSkK ICAgICAgICAgICAgIHJldHVybiBWZWN0b3I8U3RyaW5nPigpOworICAgICAgICBpZiAocmFuZ2Ut PmNvbGxhcHNlZCgpICYmIGJlaGF2aW9yKCkuc2hvdWxkQWxsb3dTcGVsbGluZ1N1Z2dlc3Rpb25z V2l0aG91dFNlbGVjdGlvbigpKSB7CisgICAgICAgICAgICBWaXNpYmxlU2VsZWN0aW9uIHdvcmRT ZWxlY3Rpb24oZnJhbWUoKS0+c2VsZWN0aW9uKCktPmJhc2UoKSk7CisgICAgICAgICAgICB3b3Jk U2VsZWN0aW9uLmV4cGFuZFVzaW5nR3JhbnVsYXJpdHkoV29yZEdyYW51bGFyaXR5KTsKKyAgICAg ICAgICAgIHJhbmdlID0gd29yZFNlbGVjdGlvbi50b05vcm1hbGl6ZWRSYW5nZSgpOworICAgICAg ICAgICAgQVNTRVJUKHJhbmdlKTsKKyAgICAgICAgfQogICAgICAgICByZXR1cm4gVGV4dENoZWNr aW5nSGVscGVyKGNsaWVudCgpLCByYW5nZSkuZ3Vlc3Nlc0Zvck1pc3NwZWxsZWRPclVuZ3JhbW1h dGljYWxSYW5nZShpc0dyYW1tYXJDaGVja2luZ0VuYWJsZWQoKSwgbWlzc3BlbGxlZCwgdW5ncmFt bWF0aWNhbCk7CiAgICAgfQogCg== 185765 2013-01-31 05:50:28 -0800 2013-01-31 10:00:56 -0800 apply Ryosuke's suggestions spelling-context-menu-suggestion-unified-text-checker.patch text/plain 2060 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2Mjc0MTljLi45NzE2ODJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDEtMzEgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgT24gTGludXgsIGNhbid0IGdldCBzcGVsbGluZyBzdWdnZXN0aW9u cyB3aXRob3V0IHNlbGVjdGlvbiB3aGVuIHVuaWZpZWQgdGV4dCBjaGVja2VyIGlzIGVuYWJsZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzY4NAor CisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAgICBObyBuZXcgdGVz dHMsIGNvdmVyZWQgYnkgY29udGV4dC1tZW51LXN1Z2dlc3Rpb25zLmh0bWwuCisKKyAgICAgICAg KiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6Omd1ZXNzZXNG b3JNaXNzcGVsbGVkT3JVbmdyYW1tYXRpY2FsKToKKyAgICAgICAgRm9yIExpbnV4LCBleHRlbmQg c2VsZWN0aW9uIHJhbmdlIHRvIHRoZSBjbG9zZXN0IHdvcmQgdG8gZ2V0CisgICAgICAgIHRoZSBz cGVsbGluZyBzdWdnZXN0aW9ucyB3aGVuIHVuaWZpZWQgdGV4dCBjaGVja2VyIGlzIGVuYWJsZWQu CisKIDIwMTMtMDEtMzEgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJlbmFtZSBXaGVlbEV2ZW50OjpHcmFudWxhcml0eSB0byBXaGVlbEV2ZW50OjpEZWx0 YU1vZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAppbmRleCBiMmUzMjc3Li4wODlhOTA1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCkBAIC0xNzc2LDcgKzE3NzYsMTQgQEAgVmVjdG9y PFN0cmluZz4gRWRpdG9yOjpndWVzc2VzRm9yTWlzc3BlbGxlZFdvcmQoY29uc3QgU3RyaW5nJiB3 b3JkKSBjb25zdAogVmVjdG9yPFN0cmluZz4gRWRpdG9yOjpndWVzc2VzRm9yTWlzc3BlbGxlZE9y VW5ncmFtbWF0aWNhbChib29sJiBtaXNzcGVsbGVkLCBib29sJiB1bmdyYW1tYXRpY2FsKQogewog ICAgIGlmICh1bmlmaWVkVGV4dENoZWNrZXJFbmFibGVkKCkpIHsKLSAgICAgICAgUmVmUHRyPFJh bmdlPiByYW5nZSA9IGZyYW1lKCktPnNlbGVjdGlvbigpLT50b05vcm1hbGl6ZWRSYW5nZSgpOwor ICAgICAgICBSZWZQdHI8UmFuZ2U+IHJhbmdlOworICAgICAgICBGcmFtZVNlbGVjdGlvbiogZnJh bWVTZWxlY3Rpb24gPSBmcmFtZSgpLT5zZWxlY3Rpb24oKTsKKyAgICAgICAgaWYgKGZyYW1lU2Vs ZWN0aW9uLT5pc0NhcmV0KCkgJiYgYmVoYXZpb3IoKS5zaG91bGRBbGxvd1NwZWxsaW5nU3VnZ2Vz dGlvbnNXaXRob3V0U2VsZWN0aW9uKCkpIHsKKyAgICAgICAgICAgIFZpc2libGVTZWxlY3Rpb24g d29yZFNlbGVjdGlvbiA9IFZpc2libGVTZWxlY3Rpb24oZnJhbWVTZWxlY3Rpb24tPmJhc2UoKSk7 CisgICAgICAgICAgICB3b3JkU2VsZWN0aW9uLmV4cGFuZFVzaW5nR3JhbnVsYXJpdHkoV29yZEdy YW51bGFyaXR5KTsKKyAgICAgICAgICAgIHJhbmdlID0gd29yZFNlbGVjdGlvbi50b05vcm1hbGl6 ZWRSYW5nZSgpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIHJhbmdlID0gZnJhbWVTZWxl Y3Rpb24tPnRvTm9ybWFsaXplZFJhbmdlKCk7CiAgICAgICAgIGlmICghcmFuZ2UpCiAgICAgICAg ICAgICByZXR1cm4gVmVjdG9yPFN0cmluZz4oKTsKICAgICAgICAgcmV0dXJuIFRleHRDaGVja2lu Z0hlbHBlcihjbGllbnQoKSwgcmFuZ2UpLmd1ZXNzZXNGb3JNaXNzcGVsbGVkT3JVbmdyYW1tYXRp Y2FsUmFuZ2UoaXNHcmFtbWFyQ2hlY2tpbmdFbmFibGVkKCksIG1pc3NwZWxsZWQsIHVuZ3JhbW1h dGljYWwpOwo=