107655 2013-01-23 03:10:34 -0800 [v8] prepare SerializedScriptValue for transition to Latin-1 2013-06-11 19:23:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dcarney webkit-unassigned abarth alecflett buildbot dglazkov haraken japhet jsbell noel.gordon rniwa webkit.review.bot oldest_to_newest 814060 0 dcarney 2013-01-23 03:10:34 -0800 [v8] prepare SerializedScriptValue for transition to Latin-1 814063 1 184190 dcarney 2013-01-23 03:12:00 -0800 Created attachment 184190 Patch 814066 2 184190 haraken 2013-01-23 03:21:20 -0800 Comment on attachment 184190 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184190&action=review > LayoutTests/platform/chromium/fast/storage/serialized-script-value.html:13 > +var curVer = 0x02ff; Nit: curVer => currentVersion WebKit uses a fully qualified variable name. > LayoutTests/platform/chromium/fast/storage/serialized-script-value.html:28 > - [ 0x02ff, 0x003f, 0x3f6f, 0x5301, 0x6603, > + [ curVer, 0x003f, 0x3f6f, 0x5301, 0x6603, Won't this change lose compatibility for already stored serialized script values (e.g. localStorage)? (I just wanted to confirm that it's OK to change the serialized results.) 814067 3 184190 dcarney 2013-01-23 03:24:43 -0800 Comment on attachment 184190 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184190&action=review >> LayoutTests/platform/chromium/fast/storage/serialized-script-value.html:13 >> +var curVer = 0x02ff; > > Nit: curVer => currentVersion > > WebKit uses a fully qualified variable name. I used curVer to have 6 characters and keep all the byte arrays nicely lined up. >> LayoutTests/platform/chromium/fast/storage/serialized-script-value.html:28 >> + [ curVer, 0x003f, 0x3f6f, 0x5301, 0x6603, > > Won't this change lose compatibility for already stored serialized script values (e.g. localStorage)? (I just wanted to confirm that it's OK to change the serialized results.) This change is backwards but not forwards compatible. If i'm reading SerializedScriptValue.cpp correctly, this bumping the version number is the correct way to do this transition. 814071 4 haraken 2013-01-23 03:28:15 -0800 (In reply to comment #3) > I used curVer to have 6 characters and keep all the byte arrays nicely lined up. Ah, makes sense. > This change is backwards but not forwards compatible. If i'm reading SerializedScriptValue.cpp correctly, this bumping the version number is the correct way to do this transition. Looks like so. jsbell, alecflett: would you check that the patch is safe in terms of compatibility? 814077 5 dcarney 2013-01-23 03:41:45 -0800 jsbell, alecflett: just to clarify what will happen. Once V8_ONE_BYTE_STRINGS_ENABLED is defined in v8, one byte strings will now potentially have payloads with bytes > 0xf. This was previously impossible, so a version 2 SSV should not be allowed to read from a version 3 value. Version 3 can read version 2 without issue. 814259 6 jsbell 2013-01-23 09:29:47 -0800 (In reply to comment #5) > jsbell, alecflett: just to clarify what will happen. Once V8_ONE_BYTE_STRINGS_ENABLED is defined in v8, one byte strings will now potentially have payloads with bytes > 0xf. This was previously impossible, so a version 2 SSV should not be allowed to read from a version 3 value. Version 3 can read version 2 without issue. Thanks. Conceptually, this looks correct. There is a problem, though - this conceptually *removes* test coverage for parsing v2 SSVs, since with this patch and once the new flag is defined, the test will only exercise parsing v3 SSVs. You'll need to add tests that use the (optional) oldFormat param of _testSerialization and explicitly test 0x02ff, or expand testSerialization() to insert the version prefix since most v2 and v3 SSVs will serialize identically. I'm not sure which is better. Or perhaps oldFormat should turn into a map of version/serializations? Not sure what is best here. (alecflett's not going to be able to look at this until tomorrow, unfortunately.) 814308 7 dcarney 2013-01-23 10:15:33 -0800 (In reply to comment #6) > (In reply to comment #5) > > jsbell, alecflett: just to clarify what will happen. Once V8_ONE_BYTE_STRINGS_ENABLED is defined in v8, one byte strings will now potentially have payloads with bytes > 0xf. This was previously impossible, so a version 2 SSV should not be allowed to read from a version 3 value. Version 3 can read version 2 without issue. > > Thanks. Conceptually, this looks correct. > > There is a problem, though - this conceptually *removes* test coverage for parsing v2 SSVs, since with this patch and once the new flag is defined, the test will only exercise parsing v3 SSVs. > > You'll need to add tests that use the (optional) oldFormat param of _testSerialization and explicitly test 0x02ff, or expand testSerialization() to insert the version prefix since most v2 and v3 SSVs will serialize identically. I'm not sure which is better. Or perhaps oldFormat should turn into a map of version/serializations? Not sure what is best here. > > (alecflett's not going to be able to look at this until tomorrow, unfortunately.) Good point. I'll work something into the test to test both v2 and v3, including something that differs between v2 and v3. 815366 8 184470 dcarney 2013-01-24 05:34:49 -0800 Created attachment 184470 Patch 815367 9 dcarney 2013-01-24 05:37:41 -0800 After looking into it, I realized that only utf8 and two byte strings are supported by the current system. I've adjusted the patch to handle this, without needing to bump the version. It comes at a performance cost, but once v8 latin-1 support is stable, I'll implement a version 3 SSV which handles one byte strings directly, without the need to unnecessarily jump in and out of utf8. 815607 10 alecflett 2013-01-24 10:47:59 -0800 Yes, the test should be purely additive - all existing tests should remain or be tweaked to indicate that its testing an old version (to avoid the bidirectional serialization tests for those) (The "old version" parameter should probably be tweaked to take a list of old versioned data, so we can keep adding to the test with each subsequent version) 816067 11 184470 webkit.review.bot 2013-01-24 18:24:50 -0800 Comment on attachment 184470 Patch Attachment 184470 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16119005 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 816339 12 haraken 2013-01-25 00:28:16 -0800 jsbell: Does it look fine? 816343 13 184470 buildbot 2013-01-25 00:43:16 -0800 Comment on attachment 184470 Patch Attachment 184470 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16112351 New failing tests: svg/as-image/img-preserveAspectRatio-support-2.html 816597 14 184470 jsbell 2013-01-25 07:51:57 -0800 Comment on attachment 184470 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184470&action=review Looks fine to me. > Source/WebCore/bindings/v8/SerializedScriptValue.cpp:324 > + ensureSpace(utf8Length); Could move this up and use ensureSpace(sizeof(StringTag) + sizeof(uint32_t) + utf8Length) (probably premature optimization, though) 817047 15 184470 haraken 2013-01-25 16:48:21 -0800 Comment on attachment 184470 Patch Please apply jsbell's comment before landing. 817191 16 dcarney 2013-01-26 07:33:08 -0800 (In reply to comment #15) > (From update of attachment 184470 [details]) > Please apply jsbell's comment before landing. kentaro, I'm marking this cq? for now as I have no access to a dev environment this weekend. I have to do a bunch of optimization in this class after latin-1 is stable in v8, so I'll apply jsbell's optimization there instead. 817198 17 184470 webkit.review.bot 2013-01-26 08:10:11 -0800 Comment on attachment 184470 Patch Clearing flags on attachment: 184470 Committed r140911: <http://trac.webkit.org/changeset/140911> 817199 18 webkit.review.bot 2013-01-26 08:10:15 -0800 All reviewed patches have been landed. Closing bug. 899080 19 noel.gordon 2013-06-11 00:49:46 -0700 (In reply to comment #9) > After looking into it, I realized that only utf8 and two byte strings are supported by the current system. huh? > I've adjusted the patch to handle this, without needing to bump the version. It comes at a performance cost, but once v8 latin-1 support is stable, I'll implement a version 3 SSV which handles one byte strings directly, without the need to unnecessarily jump in and out of utf8. And did we file about that somewhere? 899087 20 rniwa 2013-06-11 01:14:05 -0700 This bug is clearly dead since we've removed V8 from WebKit. 899365 21 noel.gordon 2013-06-11 19:23:45 -0700 Remove yourself from the bug then, seeing as it's dead to you. 184190 2013-01-23 03:12:00 -0800 2013-01-24 05:34:44 -0800 Patch bug-107655-20130123120853.patch text/plain 10218 dcarney U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTgzOWM3NWYxOTJkZTFl N2M2NDFhMjZmY2JjYjA3ZTEyNDk2NmMyYi4uZmI5ZmU4Y2I4MThkYmYwYmMyY2JmOTVhMGRhZmM3 ZjhkODE2YjE5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTIzICBEYW4g Q2FybmV5ICA8ZGNhcm5leUBnb29nbGUuY29tPgorCisgICAgICAgIFt2OF0gcHJlcGFyZSBTZXJp YWxpemVkU2NyaXB0VmFsdWUgZm9yIHRyYW5zaXRpb24gdG8gTGF0aW4tMQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NjU1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAgRXhpc3Rp bmcgdGVzdCBtb2RpZmllZC4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3Jp cHRWYWx1ZS5jcHA6CisKIDIwMTMtMDEtMjMgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtWOF0gUmVtb3ZlIGlmKGlzb2xhdGUpIGNoZWNrcyBmcm9tIHY4 U3RyaW5nKCkgYW5kIHY4SW50ZWdlcigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAppbmRleCA4NjI2ZDdiZGNlNGI1Zjg0ZjI4 N2RjN2U0OTAwYjA4ZjI4Y2QzMjU1Li4wZDNkNmVkNzUzN2ViNzI2YmY0ZGI1OTI0NGE4MGU4YWZi OGUxZGFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxpemVk U2NyaXB0VmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6 ZWRTY3JpcHRWYWx1ZS5jcHAKQEAgLTI0NSw4ICsyNDUsMTQgQEAgc3RhdGljIGJvb2wgc2hvdWxk Q2hlY2tGb3JDeWNsZXMoaW50IGRlcHRoKQogfQogCiAvLyBJbmNyZW1lbnQgdGhpcyBmb3IgZWFj aCBpbmNvbXBhdGlibGUgY2hhbmdlIHRvIHRoZSB3aXJlIGZvcm1hdC4KKy8vIEZJWE1FOiByZW1v dmUgdGhpcyBvbmNlIGNvbW1pdCBzdGlja3MuCisjaWZkZWYgVjhfT05FX0JZVEVfU1RSSU5HU19F TkFCTEVECisvLyBWZXJzaW9uIDM6IExhdGluLTEgY2FuIGJlIHdyaXR0ZW4gaW50byBvbmUgYnl0 ZSBzdHJpbmdzLgorc3RhdGljIGNvbnN0IHVpbnQzMl90IHdpcmVGb3JtYXRWZXJzaW9uID0gMzsK KyNlbHNlCiAvLyBWZXJzaW9uIDI6IEFkZGVkIFN0cmluZ1VDaGFyVGFnIGZvciBVQ2hhciB2OCBz dHJpbmdzLgogc3RhdGljIGNvbnN0IHVpbnQzMl90IHdpcmVGb3JtYXRWZXJzaW9uID0gMjsKKyNl bmRpZgogCiBzdGF0aWMgY29uc3QgaW50IG1heERlcHRoID0gMjAwMDA7CiAKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyY2Nj YTkyYjBjNDE5ODFiMDViMzQyM2NkNTkwODBiMTAzNGU5YjUwLi4xNjU5NmQ2MTdhOWJlMGJhNDQ5 YTdmZDBmNjk5ODA3OTM5NjYxYzUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDEtMjMg IERhbiBDYXJuZXkgIDxkY2FybmV5QGdvb2dsZS5jb20+CisKKyAgICAgICAgW3Y4XSBwcmVwYXJl IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSBmb3IgdHJhbnNpdGlvbiB0byBMYXRpbi0xCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc2NTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL2Zhc3Qvc3RvcmFnZS9zZXJpYWxpemVkLXNjcmlwdC12YWx1ZS5odG1sOgorCiAyMDEzLTAx LTIzICBIYWppbWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBJbnZh bGlkYXRlZCBTVkcgc2hhZG93IHRyZWUgc2hvdWxkIGJlIGFsd2F5cyBkZXRhY2hlZC4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3Qvc3RvcmFnZS9zZXJpYWxp emVkLXNjcmlwdC12YWx1ZS5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFz dC9zdG9yYWdlL3NlcmlhbGl6ZWQtc2NyaXB0LXZhbHVlLmh0bWwKaW5kZXggMjk4Mjc1MzQ1NTM0 ZDA0OGIxYzMwNjliNzhhYTRhZDVmZDMyYWU5Yi4uZmRiY2MwMjdhODdjMTAyMGYyYjMwNjczY2Iz MGI4OWYwOGRlNmQwYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0v ZmFzdC9zdG9yYWdlL3NlcmlhbGl6ZWQtc2NyaXB0LXZhbHVlLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9zdG9yYWdlL3NlcmlhbGl6ZWQtc2NyaXB0LXZhbHVl Lmh0bWwKQEAgLTEwLDYgKzEwLDEyIEBACiAgICAgY29ycmVzcG9uZGluZyB0ZXN0IG9mIHRoZSBK U0Mgc2VyaWFsaXphdGlvbiBmb3JtYXQuCiAqLwogCit2YXIgY3VyVmVyID0gMHgwMmZmOworLy8g RklYTUU6IFJlbW92ZSB0aGlzIG9uY2UgdmVyc2lvbiAzIGlzIHN0YWJsZS4KK2lmIChuZXcgVWlu dDE2QXJyYXkoaW50ZXJuYWxzLnNlcmlhbGl6ZU9iamVjdCgnYScpKVswXSA9PSAweDAzZmYpIHsK KyAgY3VyVmVyID0gMHgwM2ZmOworfQorCiBmdW5jdGlvbiB0ZXN0U2VyaWFsaXphdGlvbihvYmos IHZhbHVlcywgb2xkRm9ybWF0LCBzZXJpYWxpemVFeGNlcHRpb25WYWx1ZSkgewogICAgIF90ZXN0 U2VyaWFsaXphdGlvbigyLCBvYmosIHZhbHVlcywgb2xkRm9ybWF0LCBzZXJpYWxpemVFeGNlcHRp b25WYWx1ZSk7CiB9CkBAIC0xOSw3ICsyNSw3IEBAIGZ1bmN0aW9uIHRlc3RTZXJpYWxpemF0aW9u KG9iaiwgdmFsdWVzLCBvbGRGb3JtYXQsIHNlcmlhbGl6ZUV4Y2VwdGlvblZhbHVlKSB7CiAvLyBh cmUgb25seSBwZXJzaXN0ZWQgb3V0IGluIHRoZSB3b3JsZCBpbiBJbmRleGVkREIgc3RvcmVzIHRo YXQgd2VyZQogLy8gd3JpdHRlbiB3aXRoIGltcGxlbWVudGF0aW9ucyBidWlsdCBiZWZvcmUgbWlk LTIwMTEuCiB0ZXN0U2VyaWFsaXphdGlvbih7Zm9vOiAnem9vJywgYmFyOiB7YmF6OiAnbXlOZXdL ZXknfX0sCi0gICAgICAgICAgICAgICAgICBbIDB4MDJmZiwgMHgwMDNmLCAweDNmNmYsIDB4NTMw MSwgMHg2NjAzLAorICAgICAgICAgICAgICAgICAgWyBjdXJWZXIsIDB4MDAzZiwgMHgzZjZmLCAw eDUzMDEsIDB4NjYwMywKICAgICAgICAgICAgICAgICAgICAgMHg2ZjZmLCAweDAxM2YsIDB4MDM1 MywgMHg2ZjdhLCAweDNmNmYsCiAgICAgICAgICAgICAgICAgICAgIDB4NTMwMSwgMHg2MjAzLCAw eDcyNjEsIDB4MDEzZiwgMHgzZjZmLAogICAgICAgICAgICAgICAgICAgICAweDUzMDIsIDB4NjIw MywgMHg3YTYxLCAweDAyM2YsIDB4MDg1MywKQEAgLTI3LDY1ICszMyw2NSBAQCB0ZXN0U2VyaWFs aXphdGlvbih7Zm9vOiAnem9vJywgYmFyOiB7YmF6OiAnbXlOZXdLZXknfX0sCiAgICAgICAgICAg ICAgICAgICAgIDB4MDI3YiBdKTsKIAogdGVzdFNlcmlhbGl6YXRpb24oe2ZvbzogJ3pvbycsIGJh cjogJ215TmV3S2V5J30sCi0gICAgICAgICAgICAgICAgICBbMHgwMmZmLCAweDAwM2YsIDB4M2Y2 ZiwgMHg1MzAxLCAweDY2MDMsCisgICAgICAgICAgICAgICAgICBbY3VyVmVyLCAweDAwM2YsIDB4 M2Y2ZiwgMHg1MzAxLCAweDY2MDMsCiAgICAgICAgICAgICAgICAgICAgMHg2ZjZmLCAweDAxM2Ys IDB4MDM1MywgMHg2ZjdhLCAweDNmNmYsCiAgICAgICAgICAgICAgICAgICAgMHg1MzAxLCAweDYy MDMsIDB4NzI2MSwgMHgwMTNmLCAweDA4NTMsCiAgICAgICAgICAgICAgICAgICAgMHg3OTZkLCAw eDY1NGUsIDB4NGI3NywgMHg3OTY1LCAweDAyN2JdKTsKIAotdGVzdFNlcmlhbGl6YXRpb24oW10s IFsweDAyZmYsIDB4MDAzZiwgMHgwMDQxLCAweDAwMjQsIDB4MDAwMCBdKTsKK3Rlc3RTZXJpYWxp emF0aW9uKFtdLCBbY3VyVmVyLCAweDAwM2YsIDB4MDA0MSwgMHgwMDI0LCAweDAwMDAgXSk7CiB0 ZXN0U2VyaWFsaXphdGlvbih7Zm9vOiAiem9vIn0sCi0gICAgICAgICAgICAgICAgICBbMHgwMmZm LCAweDAwM2YsIDB4M2Y2ZiwgMHg1MzAxLCAweDY2MDMsIDB4NmY2ZiwKKyAgICAgICAgICAgICAg ICAgIFtjdXJWZXIsIDB4MDAzZiwgMHgzZjZmLCAweDUzMDEsIDB4NjYwMywgMHg2ZjZmLAogICAg ICAgICAgICAgICAgICAgIDB4MDEzZiwgMHgwMzUzLCAweDZmN2EsIDB4N2I2ZiwgMHgwMDAxXSwK ICAgICAgICAgICAgICAgICAgIFsweDAzNTMsIDB4NmY2NiwgMHg1MzZmLCAweDdhMDMsIDB4NmY2 ZiwgMHgwMTdiXSk7CiB0ZXN0U2VyaWFsaXphdGlvbih7Zm9vOiBudWxsfSwKLSAgICAgICAgICAg ICAgICAgIFsweDAyZmYsIDB4MDAzZiwgMHgzZjZmLCAweDUzMDEsIDB4NjYwMywgMHg2ZjZmLAor ICAgICAgICAgICAgICAgICAgW2N1clZlciwgMHgwMDNmLCAweDNmNmYsIDB4NTMwMSwgMHg2NjAz LCAweDZmNmYsCiAgICAgICAgICAgICAgICAgICAgMHgwMTNmLCAweDdiMzAsIDB4MDAwMV0sCiAg ICAgICAgICAgICAgICAgICBbMHgwMzUzLCAweDZmNjYsIDB4MzA2ZiwgMHgwMTdiXSk7Ci10ZXN0 U2VyaWFsaXphdGlvbih7fSwgWzB4MDJmZiwgMHgwMDNmLCAweDdiNmYsIDB4MDAwMF0sIFsweDAw N2JdKTsKK3Rlc3RTZXJpYWxpemF0aW9uKHt9LCBbY3VyVmVyLCAweDAwM2YsIDB4N2I2ZiwgMHgw MDAwXSwgWzB4MDA3Yl0pOwogCi10ZXN0U2VyaWFsaXphdGlvbih1bmRlZmluZWQsIFsweDAyZmYs IDB4MDAzZiwgMHgwMDVmXSk7Ci10ZXN0U2VyaWFsaXphdGlvbih0cnVlLCBbMHgwMmZmLCAweDAw M2YsIDB4MDA1NF0pOwotdGVzdFNlcmlhbGl6YXRpb24oZmFsc2UsIFsweDAyZmYsIDB4MDAzZiwg MHgwMDQ2XSk7Cit0ZXN0U2VyaWFsaXphdGlvbih1bmRlZmluZWQsIFtjdXJWZXIsIDB4MDAzZiwg MHgwMDVmXSk7Cit0ZXN0U2VyaWFsaXphdGlvbih0cnVlLCBbY3VyVmVyLCAweDAwM2YsIDB4MDA1 NF0pOwordGVzdFNlcmlhbGl6YXRpb24oZmFsc2UsIFtjdXJWZXIsIDB4MDAzZiwgMHgwMDQ2XSk7 CiAvLyBTcGFyc2UgYXJyYXkgZGVzZXJpYWxpemF0aW9uIGlzIGJyb2tlbi4KIC8vIFNlZTogaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2ODM4Ci0vLyB0ZXN0U2VyaWFs aXphdGlvbihuZXcgQXJyYXkoMTAwKSwgWzB4MDJmZiwgMHgwMDNmLCAweDY0NjEsIDB4MDA0MCwg MHgwMDY0XSk7Ci10ZXN0U2VyaWFsaXphdGlvbigxMCwgWzB4MDJmZiwgMHgwMDNmLCAweDE0NDld KTsKLXRlc3RTZXJpYWxpemF0aW9uKC0xMCwgWzB4MDJmZiwgMHgwMDNmLCAweDEzNDldKTsKLXRl c3RTZXJpYWxpemF0aW9uKE1hdGgucG93KDIsMzApLCBbMHgwMmZmLCAweDAwM2YsIDB4ODA0OSwg MHg4MDgwLCAweDA4ODBdKTsKLXRlc3RTZXJpYWxpemF0aW9uKE1hdGgucG93KDIsNTUpLCBbMHgw MmZmLCAweDAwM2YsIDB4MDA0ZSwgMHgwMDAwLCAweDAwMDAsCisvLyB0ZXN0U2VyaWFsaXphdGlv bihuZXcgQXJyYXkoMTAwKSwgW2N1clZlciwgMHgwMDNmLCAweDY0NjEsIDB4MDA0MCwgMHgwMDY0 XSk7Cit0ZXN0U2VyaWFsaXphdGlvbigxMCwgW2N1clZlciwgMHgwMDNmLCAweDE0NDldKTsKK3Rl c3RTZXJpYWxpemF0aW9uKC0xMCwgW2N1clZlciwgMHgwMDNmLCAweDEzNDldKTsKK3Rlc3RTZXJp YWxpemF0aW9uKE1hdGgucG93KDIsMzApLCBbY3VyVmVyLCAweDAwM2YsIDB4ODA0OSwgMHg4MDgw LCAweDA4ODBdKTsKK3Rlc3RTZXJpYWxpemF0aW9uKE1hdGgucG93KDIsNTUpLCBbY3VyVmVyLCAw eDAwM2YsIDB4MDA0ZSwgMHgwMDAwLCAweDAwMDAsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIDB4NjAwMCwgMHgwMDQzXSk7Ci10ZXN0U2VyaWFsaXphdGlvbigxLjIzLCBbMHgw MmZmLCAweDAwM2YsIDB4YWU0ZSwgMHhlMTQ3LCAweDE0N2EsIDB4ZjNhZSwgMHgwMDNmXSk7Ci10 ZXN0U2VyaWFsaXphdGlvbigiIiwgWzB4MDJmZiwgMHgwMDNmLCAweDAwNTNdKTsKLXRlc3RTZXJp YWxpemF0aW9uKCJhYmMiLCBbMHgwMmZmLCAweDAwM2YsIDB4MDM1MywgMHg2MjYxLCAweDAwNjNd KTsKLXRlc3RTZXJpYWxpemF0aW9uKHtpbnRlZ2VyOiAxMjN9LCBbMHgwMmZmLCAweDAwM2YsIDB4 M2Y2ZiwgMHg1MzAxLCAweDY5MDcsCit0ZXN0U2VyaWFsaXphdGlvbigxLjIzLCBbY3VyVmVyLCAw eDAwM2YsIDB4YWU0ZSwgMHhlMTQ3LCAweDE0N2EsIDB4ZjNhZSwgMHgwMDNmXSk7Cit0ZXN0U2Vy aWFsaXphdGlvbigiIiwgW2N1clZlciwgMHgwMDNmLCAweDAwNTNdKTsKK3Rlc3RTZXJpYWxpemF0 aW9uKCJhYmMiLCBbY3VyVmVyLCAweDAwM2YsIDB4MDM1MywgMHg2MjYxLCAweDAwNjNdKTsKK3Rl c3RTZXJpYWxpemF0aW9uKHtpbnRlZ2VyOiAxMjN9LCBbY3VyVmVyLCAweDAwM2YsIDB4M2Y2Ziwg MHg1MzAxLCAweDY5MDcsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDB4NzQ2 ZSwgMHg2NzY1LCAweDcyNjUsIDB4MDEzZiwgMHhmNjQ5LAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAweDdiMDEsIDB4MDAwMV0pOwotdGVzdFNlcmlhbGl6YXRpb24oe3N0cmlu ZzogInN0ciJ9LCBbMHgwMmZmLCAweDAwM2YsIDB4M2Y2ZiwgMHg1MzAxLCAweDczMDYsCit0ZXN0 U2VyaWFsaXphdGlvbih7c3RyaW5nOiAic3RyIn0sIFtjdXJWZXIsIDB4MDAzZiwgMHgzZjZmLCAw eDUzMDEsIDB4NzMwNiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDB4NzI3 NCwgMHg2ZTY5LCAweDNmNjcsIDB4NTMwMSwgMHg3MzAzLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgMHg3Mjc0LCAweDAxN2JdKTsKLXRlc3RTZXJpYWxpemF0aW9uKHtsaXN0 OiBbMSwyLDNdfSwgWzB4MDJmZiwgMHgwMDNmLCAweDNmNmYsIDB4NTMwMSwgMHg2YzA0LAordGVz dFNlcmlhbGl6YXRpb24oe2xpc3Q6IFsxLDIsM119LCBbY3VyVmVyLCAweDAwM2YsIDB4M2Y2Ziwg MHg1MzAxLCAweDZjMDQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAweDcz NjksIDB4M2Y3NCwgMHg0MTAxLCAweDNmMDMsIDB4NDkwMiwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDB4M2YwMiwgMHg0OTAyLCAweDNmMDQsIDB4NDkwMiwgMHgyNDA2LAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMHgwMzAwLCAweDAxN2JdKTsKLXRl c3RTZXJpYWxpemF0aW9uKG51bGwsIFsweDAyZmYsIDB4MDAzZiwgMHgwMDMwXSk7Ci10ZXN0U2Vy aWFsaXphdGlvbigvYWJjLywgWzB4MDJmZiwgMHgwMDNmLCAweDAzNTIsIDB4NjI2MSwgMHgwMDYz XSk7Cit0ZXN0U2VyaWFsaXphdGlvbihudWxsLCBbY3VyVmVyLCAweDAwM2YsIDB4MDAzMF0pOwor dGVzdFNlcmlhbGl6YXRpb24oL2FiYy8sIFtjdXJWZXIsIDB4MDAzZiwgMHgwMzUyLCAweDYyNjEs IDB4MDA2M10pOwogCiB2YXIgaW5uZXJPYmplY3QgPSB7aGVsbG86ICJ0aGVyZSJ9OwogdmFyIG91 dGVyT2JqZWN0ID0ge2lubmVyOiBpbm5lck9iamVjdH07CiBvdXRlck9iamVjdFsnb3V0ZXInXSA9 IGlubmVyT2JqZWN0OwotdGVzdFNlcmlhbGl6YXRpb24ob3V0ZXJPYmplY3QsIFsweDAyZmYsIDB4 MDAzZiwgMHgzZjZmLCAweDUzMDEsIDB4NjkwNSwKK3Rlc3RTZXJpYWxpemF0aW9uKG91dGVyT2Jq ZWN0LCBbY3VyVmVyLCAweDAwM2YsIDB4M2Y2ZiwgMHg1MzAxLCAweDY5MDUsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIDB4NmU2ZSwgMHg3MjY1LCAweDAxM2YsIDB4M2Y2ZiwgMHg1 MzAyLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAweDY4MDUsIDB4NmM2NSwgMHg2 ZjZjLCAweDAyM2YsIDB4MDU1MywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMHg2 ODc0LCAweDcyNjUsIDB4N2I2NSwgMHgzZjAxLCAweDUzMDIsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIDB4NmYwNSwgMHg3NDc1LCAweDcyNjUsIDB4MDIzZiwgMHgwMTVlLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAweDAyN2JdKTsKLXRlc3RTZXJpYWxpemF0aW9u KGlubmVyT2JqZWN0LCBbMHgwMmZmLCAweDAwM2YsIDB4M2Y2ZiwgMHg1MzAxLCAweDY4MDUsCit0 ZXN0U2VyaWFsaXphdGlvbihpbm5lck9iamVjdCwgW2N1clZlciwgMHgwMDNmLCAweDNmNmYsIDB4 NTMwMSwgMHg2ODA1LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAweDZjNjUsIDB4 NmY2YywgMHgwMTNmLCAweDA1NTMsIDB4Njg3NCwKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgMHg3MjY1LCAweDdiNjUsIDB4MDAwMV0pOwogCiB2YXIgdW5pY29kZU9iamVjdCA9IHth OiAnYScsIHU6IFN0cmluZy5mcm9tQ2hhckNvZGUoMHgwM0IxLDB4MDNCMiksIGQ6IDQyfTsKIHRl c3RTZXJpYWxpemF0aW9uKHVuaWNvZGVPYmplY3QsCi0gICAgICAgICAgICAgICAgICBbMHgwMmZm LCAweDAwM2YsIDB4M2Y2ZiwgMHg1MzAxLCAweDYxMDEsCisgICAgICAgICAgICAgICAgICBbY3Vy VmVyLCAweDAwM2YsIDB4M2Y2ZiwgMHg1MzAxLCAweDYxMDEsCiAgICAgICAgICAgICAgICAgICAg MHgwMTNmLCAweDAxNTMsIDB4M2Y2MSwgMHg1MzAxLCAweDc1MDEsCiAgICAgICAgICAgICAgICAg ICAgMHgwMTNmLCAweDA0NjMsIDB4MDNiMSwgMHgwM2IyLCAweDAxM2YsCiAgICAgICAgICAgICAg ICAgICAgMHgwMTUzLCAweDNmNjQsIDB4NDkwMSwgMHg3YjU0LCAweDAwMDNdLApAQCAtOTUsNyAr MTAxLDcgQEAgdGVzdFNlcmlhbGl6YXRpb24odW5pY29kZU9iamVjdCwKICAgICAgICAgICAgICAg ICAgICAweDAxNTMsIDB4M2Y2NCwgMHg0OTAxLCAweDdiNTQsIDB4MDAwM10pOwogdW5pY29kZU9i amVjdC5hID0gJ2FiJzsKIHRlc3RTZXJpYWxpemF0aW9uKHVuaWNvZGVPYmplY3QsCi0gICAgICAg ICAgICAgICAgICBbMHgwMmZmLCAweDAwM2YsIDB4M2Y2ZiwgMHg1MzAxLCAweDYxMDEsCisgICAg ICAgICAgICAgICAgICBbY3VyVmVyLCAweDAwM2YsIDB4M2Y2ZiwgMHg1MzAxLCAweDYxMDEsCiAg ICAgICAgICAgICAgICAgICAgMHgwMTNmLCAweDAyNTMsIDB4NjI2MSwgMHgwMTNmLCAweDAxNTMs CiAgICAgICAgICAgICAgICAgICAgMHgzZjc1LCAweDAwMDEsIDB4MDQ2MywgMHgwM2IxLCAweDAz YjIsCiAgICAgICAgICAgICAgICAgICAgMHgwMTNmLCAweDAxNTMsIDB4M2Y2NCwgMHg0OTAxLCAw eDdiNTQsCkBAIC0xMTIsNyArMTE4LDcgQEAgYXJyYXlPYmplY3RbJ2ZvbyddID0gMTIzOwogYXJy YXlPYmplY3RbJ2JhciddID0gNDU2OwogYXJyYXlPYmplY3RbJyddID0gbnVsbDsKIHRlc3RTZXJp YWxpemF0aW9uKGFycmF5T2JqZWN0LAotICAgICAgICAgICAgICAgICAgWzB4MDJmZiwgMHgwMDNm LCAweDAwNDEsIDB4MDEzZiwgMHgwMTUzLAorICAgICAgICAgICAgICAgICAgW2N1clZlciwgMHgw MDNmLCAweDAwNDEsIDB4MDEzZiwgMHgwMTUzLAogICAgICAgICAgICAgICAgICAgIDB4M2Y2MSwg MHg1NDAxLCAweDAxM2YsIDB4MDE1MywgMHgzZjYyLAogICAgICAgICAgICAgICAgICAgIDB4NDYw MSwgMHgwMTNmLCAweDAzNTMsIDB4NmY2NiwgMHgzZjZmLAogICAgICAgICAgICAgICAgICAgIDB4 NDkwMSwgMHgwMWY2LCAweDAxM2YsIDB4MDM1MywgMHg2MTYyLApAQCAtMTI4LDcgKzEzNCw3IEBA IHRlc3RTZXJpYWxpemF0aW9uKGFycmF5T2JqZWN0LAogYXJyYXlPYmplY3RbMF0gPSAnZm9vJzsK IGFycmF5T2JqZWN0WzFdID0gJ2Jhcic7CiB0ZXN0U2VyaWFsaXphdGlvbihhcnJheU9iamVjdCwK LSAgICAgICAgICAgICAgICAgIFsweDAyZmYsIDB4MDAzZiwgMHgwMjQxLCAweDAxM2YsIDB4MDM1 MywKKyAgICAgICAgICAgICAgICAgIFtjdXJWZXIsIDB4MDAzZiwgMHgwMjQxLCAweDAxM2YsIDB4 MDM1MywKICAgICAgICAgICAgICAgICAgICAweDZmNjYsIDB4M2Y2ZiwgMHg1MzAxLCAweDYyMDMs IDB4NzI2MSwKICAgICAgICAgICAgICAgICAgICAweDAxM2YsIDB4MDE1MywgMHgzZjYxLCAweDU0 MDEsIDB4MDEzZiwKICAgICAgICAgICAgICAgICAgICAweDAxNTMsIDB4M2Y2MiwgMHg0NjAxLCAw eDAxM2YsIDB4MDM1MywK 184470 2013-01-24 05:34:49 -0800 2013-01-26 08:10:11 -0800 Patch bug-107655-20130124143141.patch text/plain 2110 dcarney U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjE4MmYxODMyMGI1Yjg2 M2NlZGQ4OTNlMTA1YjcxMDBhMmE5ZmJhMC4uMDQ5MmFjNzgyYzIyNDA1MzRhYzExNzIzNjRlMzMw ODAzZWRlMDU3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTI0ICBEYW4g Q2FybmV5ICA8ZGNhcm5leUBnb29nbGUuY29tPgorCisgICAgICAgIFt2OF0gcHJlcGFyZSBTZXJp YWxpemVkU2NyaXB0VmFsdWUgZm9yIHRyYW5zaXRpb24gdG8gTGF0aW4tMQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NjU1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBDb3ZlcmVk IGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvU2VyaWFsaXplZFNj cmlwdFZhbHVlLmNwcDoKKwogMjAxMy0wMS0yMyAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IE1vdXNlRXZlbnQgY29uc3RydWN0b3IKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1 ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUu Y3BwCmluZGV4IDg2MjZkN2JkY2U0YjVmODRmMjg3ZGM3ZTQ5MDBiMDhmMjhjZDMyNTUuLjlhOTQz Y2RlYmM4YjYwMjkyNzZlYjBjNzQ4NTFiMDQ5YWI5N2ZjYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcApAQCAtMzE1LDE1 ICszMTUsMjIgQEAgcHVibGljOgogCiAgICAgdm9pZCB3cml0ZU9uZUJ5dGVTdHJpbmcodjg6Okhh bmRsZTx2ODo6U3RyaW5nPiYgc3RyaW5nKQogICAgIHsKLSAgICAgICAgaW50IGxlbmd0aCA9IHN0 cmluZy0+TGVuZ3RoKCk7Ci0gICAgICAgIEFTU0VSVChsZW5ndGggPj0gMCk7CisgICAgICAgIGlu dCBzdHJpbmdMZW5ndGggPSBzdHJpbmctPkxlbmd0aCgpOworICAgICAgICBpbnQgdXRmOExlbmd0 aCA9IHN0cmluZy0+VXRmOExlbmd0aCgpOworICAgICAgICBBU1NFUlQoc3RyaW5nTGVuZ3RoID49 IDAgJiYgdXRmOExlbmd0aCA+PSAwKTsKIAogICAgICAgICBhcHBlbmQoU3RyaW5nVGFnKTsKLSAg ICAgICAgZG9Xcml0ZVVpbnQzMihzdGF0aWNfY2FzdDx1aW50MzJfdD4obGVuZ3RoKSk7Ci0gICAg ICAgIGVuc3VyZVNwYWNlKGxlbmd0aCk7Ci0KLSAgICAgICAgc3RyaW5nLT5Xcml0ZU9uZUJ5dGUo Ynl0ZUF0KG1fcG9zaXRpb24pLCAwLCBsZW5ndGgsIHY4U3RyaW5nV3JpdGVPcHRpb25zKCkpOwot ICAgICAgICBtX3Bvc2l0aW9uICs9IGxlbmd0aDsKKyAgICAgICAgZG9Xcml0ZVVpbnQzMihzdGF0 aWNfY2FzdDx1aW50MzJfdD4odXRmOExlbmd0aCkpOworICAgICAgICBlbnN1cmVTcGFjZSh1dGY4 TGVuZ3RoKTsKKworICAgICAgICAvLyBBU0NJSSBmYXN0IHBhdGguCisgICAgICAgIGlmIChzdHJp bmdMZW5ndGggPT0gdXRmOExlbmd0aCkKKyAgICAgICAgICAgIHN0cmluZy0+V3JpdGVPbmVCeXRl KGJ5dGVBdChtX3Bvc2l0aW9uKSwgMCwgdXRmOExlbmd0aCwgdjhTdHJpbmdXcml0ZU9wdGlvbnMo KSk7CisgICAgICAgIGVsc2UgeworICAgICAgICAgICAgY2hhciogYnVmZmVyID0gcmVpbnRlcnBy ZXRfY2FzdDxjaGFyKj4oYnl0ZUF0KG1fcG9zaXRpb24pKTsKKyAgICAgICAgICAgIHN0cmluZy0+ V3JpdGVVdGY4KGJ1ZmZlciwgdXRmOExlbmd0aCwgMCwgdjhTdHJpbmdXcml0ZU9wdGlvbnMoKSk7 CisgICAgICAgIH0KKyAgICAgICAgbV9wb3NpdGlvbiArPSB1dGY4TGVuZ3RoOwogICAgIH0KIAog ICAgIHZvaWQgd3JpdGVVQ2hhclN0cmluZyh2ODo6SGFuZGxlPHY4OjpTdHJpbmc+JiBzdHJpbmcp Cg==