107649 2013-01-23 01:55:29 -0800 Web Inspector: remove invisibleLineRow code from paintLines DTE method 2013-01-23 09:47:57 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 lushnikov lushnikov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 814011 0 lushnikov 2013-01-23 01:55:29 -0800 As _paintLines method does everything synchronously, the order of linerows being processed does not matter. Removing "invisibleLineRow" logic will eliminate calls to scrollTop and offsetTop methods (which force sync relayout). 814014 1 184182 lushnikov 2013-01-23 01:58:41 -0800 Created attachment 184182 Patch 814279 2 184182 webkit.review.bot 2013-01-23 09:47:54 -0800 Comment on attachment 184182 Patch Clearing flags on attachment: 184182 Committed r140538: <http://trac.webkit.org/changeset/140538> 814281 3 webkit.review.bot 2013-01-23 09:47:57 -0800 All reviewed patches have been landed. Closing bug. 184182 2013-01-23 01:58:41 -0800 2013-01-23 09:47:54 -0800 Patch bug-107649-20130123135534.patch text/plain 2736 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdhOWYxMzdiOTlhMjYy MTE2MzJiNGU4YTczOTBiYzU0OTIyODUwMi4uZTMyMWUzYmRkZGNhNTZmMmM1MjUxNTdmMmZlNTUz ZjFiOGUxMzE0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTIzICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiByZW1vdmUgaW52aXNpYmxlTGluZVJvdyBjb2RlIGZyb20gcGFpbnRMaW5lcyBEVEUg bWV0aG9kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDc2NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZW1vdmUgaW52aXNpYmxlTGluZVJvdyBsb2dpYyBmcm9tIFRleHRFZGl0b3JNYWluUGFuZWwuX3Bh aW50TGluZXMgbWV0aG9kLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czogbm8gY2hhbmdlIGluIGJl aGF2aW91ci4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRleHRFZGl0 b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5 cGUuX3BhaW50TGluZXMpOgorCiAyMDEzLTAxLTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBDaGFuZ2UgdGhlIFN1cHBsZW1lbnRhYmxlIGNsYXNzIHRvIG5vdCB1 c2UgQXRvbWljU3RyaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRGVmYXVsdFRleHRFZGl0b3IuanMKaW5kZXggMTIyMjAyZTY2MjcyZjY2ODZkM2Q2 YWU4YTIzOTg0ODhkZGQ5NzIxMS4uNjZjMTY4M2NkNjNjY2YxMTg3ZTU4MGE3NzlmZWFiMTkxODE4 OThhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZh dWx0VGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0RlZmF1bHRUZXh0RWRpdG9yLmpzCkBAIC0xNzkxLDM1ICsxNzkxLDE5IEBAIFdlYkluc3BlY3Rv ci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgKi8KICAgICBfcGFpbnRM aW5lczogZnVuY3Rpb24oZnJvbUxpbmUsIHRvTGluZSwgcmVzdG9yZVNlbGVjdGlvbikKICAgICB7 Ci0gICAgICAgIC8vIEZpcnN0LCBwYWludCB2aXNpYmxlIGxpbmVzLCBzbyB0aGF0IGluIGNhc2Ug b2YgbG9uZyBsaW5lcyB3ZSBzaG91bGQgc3RhcnQgaGlnaGxpZ2h0aW5nCi0gICAgICAgIC8vIHRo ZSB2aXNpYmxlIGFyZWEgaW1tZWRpYXRlbHksIGluc3RlYWQgb2Ygd2FpdGluZyBmb3IgdGhlIGxp bmVzIGFib3ZlIHRoZSB2aXNpYmxlIGFyZWEuCi0gICAgICAgIHZhciB2aXNpYmxlRnJvbSA9IHRo aXMuc2Nyb2xsVG9wKCk7Ci0gICAgICAgIHZhciBmaXJzdFZpc2libGVMaW5lTnVtYmVyID0gdGhp cy5saW5lTnVtYmVyQXRPZmZzZXQodmlzaWJsZUZyb20pOwotCiAgICAgICAgIHZhciBjaHVuazsK ICAgICAgICAgdmFyIHNlbGVjdGlvbjsKLSAgICAgICAgdmFyIGludmlzaWJsZUxpbmVSb3dzID0g W107CiAgICAgICAgIGZvciAodmFyIGxpbmVOdW1iZXIgPSBmcm9tTGluZTsgbGluZU51bWJlciA8 IHRvTGluZTsgKytsaW5lTnVtYmVyKSB7CiAgICAgICAgICAgICBpZiAoIWNodW5rIHx8IGxpbmVO dW1iZXIgPCBjaHVuay5zdGFydExpbmUgfHwgbGluZU51bWJlciA+PSBjaHVuay5zdGFydExpbmUg KyBjaHVuay5saW5lc0NvdW50KQogICAgICAgICAgICAgICAgIGNodW5rID0gdGhpcy5jaHVua0Zv ckxpbmUobGluZU51bWJlcik7CiAgICAgICAgICAgICB2YXIgbGluZVJvdyA9IGNodW5rLmV4cGFu ZGVkTGluZVJvdyhsaW5lTnVtYmVyKTsKICAgICAgICAgICAgIGlmICghbGluZVJvdykKICAgICAg ICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgICAgIGlmIChsaW5lTnVtYmVyIDwgZmlyc3RW aXNpYmxlTGluZU51bWJlcikgewotICAgICAgICAgICAgICAgIGludmlzaWJsZUxpbmVSb3dzLnB1 c2gobGluZVJvdyk7Ci0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICB9CiAg ICAgICAgICAgICBpZiAocmVzdG9yZVNlbGVjdGlvbiAmJiAhc2VsZWN0aW9uKQogICAgICAgICAg ICAgICAgIHNlbGVjdGlvbiA9IHRoaXMuc2VsZWN0aW9uKCk7CiAgICAgICAgICAgICB0aGlzLl9w YWludExpbmUobGluZVJvdyk7CiAgICAgICAgIH0KIAotICAgICAgICBmb3IgKHZhciBpID0gMDsg aSA8IGludmlzaWJsZUxpbmVSb3dzLmxlbmd0aDsgKytpKSB7Ci0gICAgICAgICAgICBpZiAocmVz dG9yZVNlbGVjdGlvbiAmJiAhc2VsZWN0aW9uKQotICAgICAgICAgICAgICAgIHNlbGVjdGlvbiA9 IHRoaXMuc2VsZWN0aW9uKCk7Ci0gICAgICAgICAgICB0aGlzLl9wYWludExpbmUoaW52aXNpYmxl TGluZVJvd3NbaV0pOwotICAgICAgICB9Ci0KICAgICAgICAgaWYgKHJlc3RvcmVTZWxlY3Rpb24p CiAgICAgICAgICAgICB0aGlzLl9yZXN0b3JlU2VsZWN0aW9uKHNlbGVjdGlvbik7CiAgICAgfSwK