107646 2013-01-23 00:48:38 -0800 REGRESSION(r140338): WebKitGtk+ trying to allocate a buffer too big 2013-01-23 01:22:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar cgarcia danw gustavo mrobinson pnormand rakuco svillar webkit.review.bot oldest_to_newest 813963 0 svillar 2013-01-23 00:48:38 -0800 REGRESSION(r140338): WebKitGtk+ trying to allocate a buffer too big 813969 1 184175 svillar 2013-01-23 00:53:31 -0800 Created attachment 184175 Patch 813978 2 184175 cgarcia 2013-01-23 01:07:36 -0800 Comment on attachment 184175 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184175&action=review Thanks > Source/WebCore/ChangeLog:9 > + g_input_stream_read_async() to workaround a glib buffer. The former I guess you mean to workaround a glib bug? Assuming skip is more efficient than read, I think we could add a FIXME pointing to the glib bug to use skip again once the glib bug is fixed. 813981 3 svillar 2013-01-23 01:10:32 -0800 (In reply to comment #2) > (From update of attachment 184175 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184175&action=review > > Thanks > > > Source/WebCore/ChangeLog:9 > > + g_input_stream_read_async() to workaround a glib buffer. The former > > I guess you mean to workaround a glib bug? Assuming skip is more efficient than read, I think we could add a FIXME pointing to the glib bug to use skip again once the glib bug is fixed. Sure, it was a glib bug. I guess the FIXME had to be added in r140338 but I can add it here. 813994 4 svillar 2013-01-23 01:22:52 -0800 Committed r140524: <http://trac.webkit.org/changeset/140524> 184175 2013-01-23 00:53:31 -0800 2013-01-23 01:07:36 -0800 Patch bug-107646-20130123095024.patch text/plain 2628 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThhYWUwNDNlYWMwN2My ZGZjYTllN2RjODgxNmVlZWJkZGQ2Mzc4MS4uMjU5YzQwYmI2MGM4NWMwMmY2NWY5NWI5N2ZjN2Q2 MzFkYjVkMGQ5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAxLTIzICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjE0MDMzOCk6IFdlYktpdEd0aysgdHJ5aW5nIHRvIGFsbG9jYXRlIGEgYnVmZmVyIHRvbyBi aWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzY0 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGdfaW5w dXRfc3RyZWFtX3NraXBfYXN5bmMoKSB3YXMgcmVwbGFjZWQgaW4gcjE0MDMzOCBieQorICAgICAg ICBnX2lucHV0X3N0cmVhbV9yZWFkX2FzeW5jKCkgdG8gd29ya2Fyb3VuZCBhIGdsaWIgYnVmZmVy LiBUaGUgZm9ybWVyCisgICAgICAgIHdhcyB1c2luZyBHX01BWFNTSVpFIHRvIHNraXAgdGhlIHdo b2xlIHJlZGlyZWN0IG1lc3NhZ2UgYnV0IHdlCisgICAgICAgIGNhbm5vdCB1c2UgaXQgZm9yIHRo ZSBsYXR0ZXIgYmVjYXVzZSBpdCB3aWxsIHRyeSB0bworICAgICAgICBhbGxvY2F0ZSBhIGJ1ZmZl ciBvZiB0aGF0IHNpemUuIFJlcGxhY2VkIGl0IGJ5IFJFQURfQlVGRkVSX1NJWkUuIE5vCisgICAg ICAgIG5ldyB0ZXN0cyByZXF1aXJlZCwgZnVuY3Rpb25hbGl0eSBhbHJlYWR5IGNvdmVyZWQgYnkg bmV0d29yayB0ZXN0cy4uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3Vy Y2VIYW5kbGVTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJlZGlyZWN0U2tpcENhbGxiYWNr KToKKyAgICAgICAgKFdlYkNvcmU6OnNlbmRSZXF1ZXN0Q2FsbGJhY2spOgorCiAyMDEzLTAxLTIz ICBIYWppbWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBJbnZhbGlk YXRlZCBTVkcgc2hhZG93IHRyZWUgc2hvdWxkIGJlIGFsd2F5cyBkZXRhY2hlZC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNv dXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFu ZGxlU291cC5jcHAKaW5kZXggMTFmYjBlYjVlNTU0ZDBjNzk2YzhjMzg1ZWMxNDc0MmRlNjU3OGYy OS4uNjE2YmY4M2QwNWNiYjA0OGI1MzdkZDYwMjgzYjA1NTIzMTAzMjA5MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFu ZGxlU291cC5jcHAKQEAgLTUyNiw3ICs1MjYsNyBAQCBzdGF0aWMgdm9pZCByZWRpcmVjdFNraXBD YWxsYmFjayhHT2JqZWN0KiwgR0FzeW5jUmVzdWx0KiBhc3luY1Jlc3VsdCwgZ3BvaW50ZXIgZAog ICAgIH0KIAogICAgIGlmIChieXRlc1NraXBwZWQgPiAwKSB7Ci0gICAgICAgIGdfaW5wdXRfc3Ry ZWFtX3JlYWRfYXN5bmMoZC0+bV9pbnB1dFN0cmVhbS5nZXQoKSwgZC0+bV9idWZmZXIsIEdfTUFY U1NJWkUsIEdfUFJJT1JJVFlfREVGQVVMVCwKKyAgICAgICAgZ19pbnB1dF9zdHJlYW1fcmVhZF9h c3luYyhkLT5tX2lucHV0U3RyZWFtLmdldCgpLCBkLT5tX2J1ZmZlciwgUkVBRF9CVUZGRVJfU0la RSwgR19QUklPUklUWV9ERUZBVUxULAogICAgICAgICAgICAgZC0+bV9jYW5jZWxsYWJsZS5nZXQo KSwgcmVkaXJlY3RTa2lwQ2FsbGJhY2ssIGhhbmRsZS5nZXQoKSk7CiAgICAgICAgIHJldHVybjsK ICAgICB9CkBAIC02ODEsNyArNjgxLDcgQEAgc3RhdGljIHZvaWQgc2VuZFJlcXVlc3RDYWxsYmFj ayhHT2JqZWN0KiwgR0FzeW5jUmVzdWx0KiByZXN1bHQsIGdwb2ludGVyIGRhdGEpCiAgICAgICAg ICAgICAvLyBXZSB1c2UgcmVhZF9hc3luYygpIHJhdGhlciB0aGFuIHNraXBfYXN5bmMoKSB0byB3 b3JrIGFyb3VuZAogICAgICAgICAgICAgLy8gaHR0cHM6Ly9idWd6aWxsYS5nbm9tZS5vcmcvc2hv d19idWcuY2dpP2lkPTY5MTQ4OSB1bnRpbCB3ZSBjYW4KICAgICAgICAgICAgIC8vIGRlcGVuZCBv biBnbGliID4gMi4zNS40Ci0gICAgICAgICAgICBnX2lucHV0X3N0cmVhbV9yZWFkX2FzeW5jKGQt Pm1faW5wdXRTdHJlYW0uZ2V0KCksIGQtPm1fYnVmZmVyLCBHX01BWFNTSVpFLCBHX1BSSU9SSVRZ X0RFRkFVTFQsCisgICAgICAgICAgICBnX2lucHV0X3N0cmVhbV9yZWFkX2FzeW5jKGQtPm1faW5w dXRTdHJlYW0uZ2V0KCksIGQtPm1fYnVmZmVyLCBSRUFEX0JVRkZFUl9TSVpFLCBHX1BSSU9SSVRZ X0RFRkFVTFQsCiAgICAgICAgICAgICAgICAgZC0+bV9jYW5jZWxsYWJsZS5nZXQoKSwgcmVkaXJl Y3RTa2lwQ2FsbGJhY2ssIGhhbmRsZS5nZXQoKSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAg ICAgIH0K