107643 2013-01-23 00:42:19 -0800 Removing command line shortening as it makes it difficult to see the command during errors. 2013-01-23 02:08:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mithro mithro abarth alancutter dpranke eric webkit.review.bot oldest_to_newest 813954 0 mithro 2013-01-23 00:42:19 -0800 Removing command line shortening as it makes it difficult to see the command during errors. 813957 1 184169 mithro 2013-01-23 00:42:40 -0800 Created attachment 184169 Patch 813965 2 mithro 2013-01-23 00:49:21 -0800 Example case where this is annoying; Failed to run "['/mnt/git/webkit-chromium-ews/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-chromium-ews Running Python unit tests Failed to run "['Tools/Scripts/test-webkitpy', '--all']" exit_code: 1 We then include 500 lines of history, so it's not a case of wasting the space... 813973 3 184169 eric 2013-01-23 01:02:39 -0800 Comment on attachment 184169 Patch I'm not sure what this does? 813980 4 alancutter 2013-01-23 01:09:52 -0800 Sheriffbot will not output lines longer than IRC's limit (a bit over 400 characters) as multiple posts so there is some safe guard against #webkit being completely flooded if Sheriffbot posts an error. LGTM. 813983 5 mithro 2013-01-23 01:12:54 -0800 Currently when returning a ScriptError it restricts the args output part to be 100 characters wide. You get something like; Failed to run "['/mnt/git/webkit-chromium-ews/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-chromium-ews]" Rather than the command which actually failed, and hence you can't reproduce the problem. 814019 6 184169 eric 2013-01-23 02:04:22 -0800 Comment on attachment 184169 Patch OK. We could obviously make this output much prettier. :) But making it more useful is probably a good first step. 814022 7 184169 webkit.review.bot 2013-01-23 02:08:26 -0800 Comment on attachment 184169 Patch Clearing flags on attachment: 184169 Committed r140528: <http://trac.webkit.org/changeset/140528> 814023 8 webkit.review.bot 2013-01-23 02:08:30 -0800 All reviewed patches have been landed. Closing bug. 184169 2013-01-23 00:42:40 -0800 2013-01-23 02:08:26 -0800 Patch bug-107643-20130123193933.patch text/plain 3054 mithro U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzdmOWM1ZGNhMGUzNzgwYWI5ZTdiYTk5NzhmMjY3NjE3 ZWI1M2U1Yy4uNmE0M2U2NzUwNDFjNzkwZGRmMmU0ZjMwNGIzMGY4ODI2NDQyMzIwMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAxLTIzICBUaW0gJ21pdGhybycgQW5zZWxsICA8bWl0aHJvQG1pdGhpcy5jb20+ CisKKyAgICAgICAgUmVtb3ZpbmcgY29tbWFuZCBsaW5lIHNob3J0ZW5pbmcgYXMgaXQgbWFrZXMg aXQgZGlmZmljdWx0IHRvIHNlZSB0aGUgY29tbWFuZCBkdXJpbmcgZXJyb3JzLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NjQzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5OgorICAgICAgICAoU2NyaXB0RXJyb3IpOgorICAg ICAgICAoU2NyaXB0RXJyb3IuX19pbml0X18pOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv Y29tbW9uL3N5c3RlbS9leGVjdXRpdmVfdW5pdHRlc3QucHk6CisKIDIwMTMtMDEtMjIgIFRpbSAn bWl0aHJvJyBBbnNlbGwgIDxtaXRocm9AbWl0aGlzLmNvbT4KIAogICAgICAgICBVc2UgUHl0aG9u IDIuNyB1bml0dGVzdCBzeW50YXggaW4gb3VyIHVuaXR0ZXN0cwpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKaW5kZXggZjVhMWI1YmU5MDEx NmExNGM3ZTI2MTJlMGUxZmZjMWNmNmY4NTBhNC4uYzlkNmRhZDQ5NTc0Njc1NzNhY2ExMTdiNmVj YzJjNDFhNWU0MzM0YiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v c3lzdGVtL2V4ZWN1dGl2ZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z eXN0ZW0vZXhlY3V0aXZlLnB5CkBAIC00NiwxNCArNDYsNiBAQCBfbG9nID0gbG9nZ2luZy5nZXRM b2dnZXIoX19uYW1lX18pCiAKIGNsYXNzIFNjcmlwdEVycm9yKEV4Y2VwdGlvbik6CiAKLSAgICAj IFRoaXMgaXMgYSBjdXN0b20gTGlzdC5fX3N0cl9fIGltcGxlbWVudGF0aW9uIHRvIGFsbG93IHNp emUgbGltaXRpbmcuCi0gICAgZGVmIF9zdHJpbmdfZnJvbV9hcmdzKHNlbGYsIGFyZ3MsIGxpbWl0 PTEwMCk6Ci0gICAgICAgIGFyZ3Nfc3RyaW5nID0gdW5pY29kZShhcmdzKQotICAgICAgICAjIFdl IGNvdWxkIG1ha2UgdGhpcyBtdWNoIGZhbmNpZXIsIGJ1dCBmb3Igbm93IHRoaXMgaXMgT0suCi0g ICAgICAgIGlmIGxlbihhcmdzX3N0cmluZykgPiBsaW1pdDoKLSAgICAgICAgICAgIHJldHVybiBh cmdzX3N0cmluZ1s6bGltaXQgLSAzXSArICIuLi4iCi0gICAgICAgIHJldHVybiBhcmdzX3N0cmlu ZwotCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsCiAgICAgICAgICAgICAgICAgIG1lc3NhZ2U9Tm9u ZSwKICAgICAgICAgICAgICAgICAgc2NyaXB0X2FyZ3M9Tm9uZSwKQEAgLTYxLDcgKzUzLDcgQEAg Y2xhc3MgU2NyaXB0RXJyb3IoRXhjZXB0aW9uKToKICAgICAgICAgICAgICAgICAgb3V0cHV0PU5v bmUsCiAgICAgICAgICAgICAgICAgIGN3ZD1Ob25lKToKICAgICAgICAgaWYgbm90IG1lc3NhZ2U6 Ci0gICAgICAgICAgICBtZXNzYWdlID0gJ0ZhaWxlZCB0byBydW4gIiVzIicgJSBzZWxmLl9zdHJp bmdfZnJvbV9hcmdzKHNjcmlwdF9hcmdzKQorICAgICAgICAgICAgbWVzc2FnZSA9ICdGYWlsZWQg dG8gcnVuICIlcyInICUgc2NyaXB0X2FyZ3MKICAgICAgICAgICAgIGlmIGV4aXRfY29kZToKICAg ICAgICAgICAgICAgICBtZXNzYWdlICs9ICIgZXhpdF9jb2RlOiAlZCIgJSBleGl0X2NvZGUKICAg ICAgICAgICAgIGlmIGN3ZDoKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL3N5c3RlbS9leGVjdXRpdmVfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlX3VuaXR0ZXN0LnB5CmluZGV4IGM1YjY1MWRmOWM3YmU4 OWE5MjdjYmRlNjhiODkxYWI5N2JmZTBmYzAuLmYxZmRmODA4NzY0MjllNDY4OTA1NjAyN2I1YzBi MTIzYjljNjE2MWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9leGVjdXRpdmVfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vc3lzdGVtL2V4ZWN1dGl2ZV91bml0dGVzdC5weQpAQCAtNTAsMTIgKzUwLDYgQEAgZnJv bSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmZpbGVzeXN0ZW1fbW9jayBpbXBvcnQgTW9ja0ZpbGVT eXN0ZW0KIAogCiBjbGFzcyBTY3JpcHRFcnJvclRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgotICAg IGRlZiB0ZXN0X3N0cmluZ19mcm9tX2FyZ3Moc2VsZik6Ci0gICAgICAgIGVycm9yID0gU2NyaXB0 RXJyb3IoKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGVycm9yLl9zdHJpbmdfZnJvbV9hcmdz KE5vbmUpLCAnTm9uZScpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoZXJyb3IuX3N0cmluZ19m cm9tX2FyZ3MoW10pLCAnW10nKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGVycm9yLl9zdHJp bmdfZnJvbV9hcmdzKG1hcChzdHIsIHJhbmdlKDMwKSkpLCAiWycwJywgJzEnLCAnMicsICczJywg JzQnLCAnNScsICc2JywgJzcnLCAnOCcsICc5JywgJzEwJywgJzExJywgJzEyJywgJzEzJywgJzE0 JywgJzE1JywgJzE2JywgJzE3Jy4uLiIpCi0KICAgICBkZWYgdGVzdF9tZXNzYWdlX3dpdGhfb3V0 cHV0KHNlbGYpOgogICAgICAgICBlcnJvciA9IFNjcmlwdEVycm9yKCdNeSBjdXN0b20gbWVzc2Fn ZSEnLCAnJywgLTEpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoZXJyb3IubWVzc2FnZV93aXRo X291dHB1dCgpLCAnTXkgY3VzdG9tIG1lc3NhZ2UhJykK