107636 2013-01-22 23:35:15 -0800 [V8] Make an Isolate parameter mandatory in throwError() 2013-01-23 00:29:45 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 813898 0 haraken 2013-01-22 23:35:15 -0800 [V8] Make an Isolate parameter mandatory in throwError() 813899 1 184157 haraken 2013-01-22 23:37:07 -0800 Created attachment 184157 Patch 813902 2 184157 haraken 2013-01-22 23:37:56 -0800 Comment on attachment 184157 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184157&action=review > Source/WebCore/bindings/v8/V8Binding.h:466 > + // FIXME: This should receive an Isolate. I found that this requires a bunch of fixes. I'll do it later. 813910 3 184157 abarth 2013-01-22 23:45:44 -0800 Comment on attachment 184157 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184157&action=review > Source/WebCore/bindings/v8/WorkerScriptController.cpp:174 > - state->exception = throwError(v8GeneralError, state->errorMessage.utf8().data()); > + state->exception = throwError(v8GeneralError, state->errorMessage.utf8().data(), m_context.get()->GetIsolate()); You shouldn't need to call get(). We've overloaded operator-> 813918 4 184163 haraken 2013-01-22 23:56:29 -0800 Created attachment 184163 patch for landing 813938 5 184163 webkit.review.bot 2013-01-23 00:29:42 -0800 Comment on attachment 184163 patch for landing Clearing flags on attachment: 184163 Committed r140516: <http://trac.webkit.org/changeset/140516> 813939 6 webkit.review.bot 2013-01-23 00:29:45 -0800 All reviewed patches have been landed. Closing bug. 184157 2013-01-22 23:37:07 -0800 2013-01-22 23:56:26 -0800 Patch bug-107636-20130123163401.patch text/plain 5373 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTAxMmQ2N2IwZGFkNDNj YTgwNjVmOGE2MzgwNmUwNmE0MjVmYzA1ZC4uMzU1Y2YyNTZlY2E2YzliNTMzOWE3NjQwMDg0YzA1 MjhhNTYzNTdhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTIyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1ha2UgYW4g SXNvbGF0ZSBwYXJhbWV0ZXIgbWFuZGF0b3J5IGluIHRocm93RXJyb3IoKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NjM2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBp biBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L05QVjhPYmplY3QuY3BwOgorICAg ICAgICAoX05QTl9TZXRFeGNlcHRpb24pOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGlu Zy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpoYW5kbGVNYXhSZWN1cnNpb25EZXB0aEV4Y2VlZGVk KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmUp OgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6V29ya2VyU2NyaXB0Q29udHJvbGxlcjo6ZXZhbHVhdGUpOgorICAgICAg ICAoV2ViQ29yZTo6V29ya2VyU2NyaXB0Q29udHJvbGxlcjo6c2V0RXhjZXB0aW9uKToKKwogMjAx My0wMS0yMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAg IFVzZSBhIHBsYXRmb3JtIHN0cmF0ZWd5IGZvciBsb2NhbCBzdG9yYWdlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9OUFY4T2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L05QVjhPYmplY3QuY3BwCmluZGV4IDFiNDQ5M2E5NDJkYWYzMDVhMTAyM2Q3 ODBmODAxNDlkNmY0ZDA3OGUuLjU1NGRjYWVjNDFlZjUyMWI2MjQxZDIzMDA3NTZhZDNjYzNkNDFl NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L05QVjhPYmplY3QuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L05QVjhPYmplY3QuY3BwCkBAIC00Nzks NyArNDc5LDcgQEAgdm9pZCBfTlBOX1NldEV4Y2VwdGlvbihOUE9iamVjdCogbnBPYmplY3QsIGNv bnN0IE5QVVRGOCAqbWVzc2FnZSkKICAgICBpZiAoIW5wT2JqZWN0IHx8IG5wT2JqZWN0LT5fY2xh c3MgIT0gbnBTY3JpcHRPYmplY3RDbGFzcykgewogICAgICAgICAvLyBXZSB3b24ndCBiZSBhYmxl IHRvIGZpbmQgYSBwcm9wZXIgc2NvcGUgZm9yIHRoaXMgZXhjZXB0aW9uLCBzbyBqdXN0IHRocm93 IGl0LgogICAgICAgICAvLyBUaGlzIGlzIGNvbnNpc3RlbnQgd2l0aCBKU0MsIHdoaWNoIHRocm93 cyBhIGdsb2JhbCBleGNlcHRpb24gYWxsIHRoZSB0aW1lLgotICAgICAgICB0aHJvd0Vycm9yKHY4 R2VuZXJhbEVycm9yLCBtZXNzYWdlKTsKKyAgICAgICAgdGhyb3dFcnJvcih2OEdlbmVyYWxFcnJv ciwgbWVzc2FnZSwgdjg6Oklzb2xhdGU6OkdldEN1cnJlbnQoKSk7CiAgICAgICAgIHJldHVybjsK ICAgICB9CiAgICAgdjg6OkhhbmRsZVNjb3BlIGhhbmRsZVNjb3BlOwpAQCAtNDkwLDcgKzQ5MCw3 IEBAIHZvaWQgX05QTl9TZXRFeGNlcHRpb24oTlBPYmplY3QqIG5wT2JqZWN0LCBjb25zdCBOUFVU RjggKm1lc3NhZ2UpCiAgICAgdjg6OkNvbnRleHQ6OlNjb3BlIHNjb3BlKGNvbnRleHQpOwogICAg IEV4Y2VwdGlvbkNhdGNoZXIgZXhjZXB0aW9uQ2F0Y2hlcjsKIAotICAgIHRocm93RXJyb3IodjhH ZW5lcmFsRXJyb3IsIG1lc3NhZ2UpOworICAgIHRocm93RXJyb3IodjhHZW5lcmFsRXJyb3IsIG1l c3NhZ2UsIGNvbnRleHQtPkdldElzb2xhdGUoKSk7CiB9CiAKIGJvb2wgX05QTl9FbnVtZXJhdGUo TlBQIG5wcCwgTlBPYmplY3QqIG5wT2JqZWN0LCBOUElkZW50aWZpZXIqKiBpZGVudGlmaWVyLCB1 aW50MzJfdCogY291bnQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OEJpbmRpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcApp bmRleCA2YmVhZWZjNjJjY2JjNDdlM2I4NTEwMzQ3MGJlZjYwYmVmMzYyNGIyLi4zMTIxMWY1NjYz Y2FjYWM0ODU3MmQ2YjFmNDQ5NTIyYzczMDNjOGFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4QmluZGluZy5jcHAKQEAgLTI5Miw3ICsyOTIsNyBAQCBib29sIGhhbmRsZU91dE9mTWVt b3J5KCkKIAogdjg6OkxvY2FsPHY4OjpWYWx1ZT4gaGFuZGxlTWF4UmVjdXJzaW9uRGVwdGhFeGNl ZWRlZCgpCiB7Ci0gICAgdGhyb3dFcnJvcih2OFJhbmdlRXJyb3IsICJNYXhpbXVtIGNhbGwgc3Rh Y2sgc2l6ZSBleGNlZWRlZC4iKTsKKyAgICB0aHJvd0Vycm9yKHY4UmFuZ2VFcnJvciwgIk1heGlt dW0gY2FsbCBzdGFjayBzaXplIGV4Y2VlZGVkLiIsIHY4OjpJc29sYXRlOjpHZXRDdXJyZW50KCkp OwogICAgIHJldHVybiB2ODo6TG9jYWw8djg6OlZhbHVlPigpOwogfQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4QmluZGluZy5oCmluZGV4IDI2MTNhYTA0Y2ZiMzI3OTQ0NDAwNzFiNGM4OWU5 ZDA4NmQzOTgyYjMuLjBjY2MwMzMxMmUzZDJhZmZiYzIxZDlmNDg0NDRiYmQ3NDdkODZkNzggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCkBAIC02MiwxMCArNjIsMTAgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBzZXRET01FeGNl cHRpb24oaW50LCB2ODo6SXNvbGF0ZSopOwogCiAgICAgLy8gU2NoZWR1bGUgYSBKYXZhU2NyaXB0 IGVycm9yIHRvIGJlIHRocm93bi4KLSAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdGhyb3dFcnJv cihWOEVycm9yVHlwZSwgY29uc3QgY2hhciosIHY4OjpJc29sYXRlKiA9IDApOworICAgIHY4OjpI YW5kbGU8djg6OlZhbHVlPiB0aHJvd0Vycm9yKFY4RXJyb3JUeXBlLCBjb25zdCBjaGFyKiwgdjg6 Oklzb2xhdGUqKTsKIAogICAgIC8vIFNjaGVkdWxlIGEgSmF2YVNjcmlwdCBlcnJvciB0byBiZSB0 aHJvd24uCi0gICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHRocm93RXJyb3Iodjg6OkxvY2FsPHY4 OjpWYWx1ZT4sIHY4OjpJc29sYXRlKiA9IDApOworICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB0 aHJvd0Vycm9yKHY4OjpMb2NhbDx2ODo6VmFsdWU+LCB2ODo6SXNvbGF0ZSopOwogCiAgICAgLy8g QSBoZWxwZXIgZm9yIHRocm93aW5nIEphdmFTY3JpcHQgVHlwZUVycm9yLgogICAgIHY4OjpIYW5k bGU8djg6OlZhbHVlPiB0aHJvd1R5cGVFcnJvcihjb25zdCBjaGFyKiA9IDAsIHY4OjpJc29sYXRl KiA9IDApOwpAQCAtNDYzLDYgKzQ2Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAvLyBJ ZiB0aGUgY3VycmVudCBjb250ZXh0IGNhdXNlcyBvdXQgb2YgbWVtb3J5LCBKYXZhU2NyaXB0IHNl dHRpbmcKICAgICAvLyBpcyBkaXNhYmxlZCBhbmQgaXQgcmV0dXJucyB0cnVlLgogICAgIGJvb2wg aGFuZGxlT3V0T2ZNZW1vcnkoKTsKKyAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgcmVjZWl2ZSBh biBJc29sYXRlLgogICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IGhhbmRsZU1heFJlY3Vyc2lvbkRl cHRoRXhjZWVkZWQoKTsKIAogICAgIHZvaWQgY3Jhc2hJZlY4SXNEZWFkKCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCmlu ZGV4IDJhN2UxNjM0NjVjYWNjZWUwNjYyZDU1NDA5ZTQ1NDg4ZjcyOWNkYzUuLjQ5ODY2ZDY2MTdk NzY4ZDBlMjA2NDBiYWUxZWU4MTA2YTA0ZjBlOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCkBAIC0xNzEsNyArMTcx LDcgQEAgU2NyaXB0VmFsdWUgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6ZXZhbHVhdGUoY29uc3Qg U3RyaW5nJiBzY3JpcHQsIGNvbnN0IFN0cmluZyYKICAgICAgICAgc3RhdGUtPmxpbmVOdW1iZXIg PSBtZXNzYWdlLT5HZXRMaW5lTnVtYmVyKCk7CiAgICAgICAgIHN0YXRlLT5zb3VyY2VVUkwgPSB0 b1dlYkNvcmVTdHJpbmcobWVzc2FnZS0+R2V0U2NyaXB0UmVzb3VyY2VOYW1lKCkpOwogICAgICAg ICBpZiAobV93b3JrZXJDb250ZXh0LT5zYW5pdGl6ZVNjcmlwdEVycm9yKHN0YXRlLT5lcnJvck1l c3NhZ2UsIHN0YXRlLT5saW5lTnVtYmVyLCBzdGF0ZS0+c291cmNlVVJMKSkKLSAgICAgICAgICAg IHN0YXRlLT5leGNlcHRpb24gPSB0aHJvd0Vycm9yKHY4R2VuZXJhbEVycm9yLCBzdGF0ZS0+ZXJy b3JNZXNzYWdlLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICAgICAgc3RhdGUtPmV4Y2VwdGlvbiA9 IHRocm93RXJyb3IodjhHZW5lcmFsRXJyb3IsIHN0YXRlLT5lcnJvck1lc3NhZ2UudXRmOCgpLmRh dGEoKSwgbV9jb250ZXh0LmdldCgpLT5HZXRJc29sYXRlKCkpOwogICAgICAgICBlbHNlCiAgICAg ICAgICAgICBzdGF0ZS0+ZXhjZXB0aW9uID0gU2NyaXB0VmFsdWUoYmxvY2suRXhjZXB0aW9uKCkp OwogCkBAIC0yMzgsNyArMjM4LDcgQEAgdm9pZCBXb3JrZXJTY3JpcHRDb250cm9sbGVyOjpkaXNh YmxlRXZhbChjb25zdCBTdHJpbmcmIGVycm9yTWVzc2FnZSkKIAogdm9pZCBXb3JrZXJTY3JpcHRD b250cm9sbGVyOjpzZXRFeGNlcHRpb24oY29uc3QgU2NyaXB0VmFsdWUmIGV4Y2VwdGlvbikKIHsK LSAgICB0aHJvd0Vycm9yKCpleGNlcHRpb24udjhWYWx1ZSgpKTsKKyAgICB0aHJvd0Vycm9yKCpl eGNlcHRpb24udjhWYWx1ZSgpLCBtX2NvbnRleHQuZ2V0KCktPkdldElzb2xhdGUoKSk7CiB9CiAK IFdvcmtlclNjcmlwdENvbnRyb2xsZXIqIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6OmNvbnRyb2xs ZXJGb3JDb250ZXh0KCkK 184163 2013-01-22 23:56:29 -0800 2013-01-23 00:29:42 -0800 patch for landing bug-107636-20130123165322.patch text/plain 5357 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTAxMmQ2N2IwZGFkNDNj YTgwNjVmOGE2MzgwNmUwNmE0MjVmYzA1ZC4uMjYxZjdhN2JhYTgzOTZkMjc4OWM0NTNiMDUyNmFk ZTVhNGM0Njc3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTIyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1ha2UgYW4g SXNvbGF0ZSBwYXJhbWV0ZXIgbWFuZGF0b3J5IGluIHRocm93RXJyb3IoKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NjM2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJl aGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvTlBWOE9iamVjdC5jcHA6CisgICAgICAg IChfTlBOX1NldEV4Y2VwdGlvbik6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmhhbmRsZU1heFJlY3Vyc2lvbkRlcHRoRXhjZWVkZWQpOgor ICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5oOgorICAgICAgICAoV2ViQ29yZSk6Cisg ICAgICAgICogYmluZGluZ3MvdjgvV29ya2VyU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpXb3JrZXJTY3JpcHRDb250cm9sbGVyOjpldmFsdWF0ZSk6CisgICAgICAgIChX ZWJDb3JlOjpXb3JrZXJTY3JpcHRDb250cm9sbGVyOjpzZXRFeGNlcHRpb24pOgorCiAyMDEzLTAx LTIyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgVXNl IGEgcGxhdGZvcm0gc3RyYXRlZ3kgZm9yIGxvY2FsIHN0b3JhZ2UKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L05QVjhPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvTlBWOE9iamVjdC5jcHAKaW5kZXggMWI0NDkzYTk0MmRhZjMwNWExMDIzZDc4MGY4 MDE0OWQ2ZjRkMDc4ZS4uNTU0ZGNhZWM0MWVmNTIxYjYyNDFkMjMwMDc1NmFkM2NjM2Q0MWU3OSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvTlBWOE9iamVjdC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvTlBWOE9iamVjdC5jcHAKQEAgLTQ3OSw3ICs0 NzksNyBAQCB2b2lkIF9OUE5fU2V0RXhjZXB0aW9uKE5QT2JqZWN0KiBucE9iamVjdCwgY29uc3Qg TlBVVEY4ICptZXNzYWdlKQogICAgIGlmICghbnBPYmplY3QgfHwgbnBPYmplY3QtPl9jbGFzcyAh PSBucFNjcmlwdE9iamVjdENsYXNzKSB7CiAgICAgICAgIC8vIFdlIHdvbid0IGJlIGFibGUgdG8g ZmluZCBhIHByb3BlciBzY29wZSBmb3IgdGhpcyBleGNlcHRpb24sIHNvIGp1c3QgdGhyb3cgaXQu CiAgICAgICAgIC8vIFRoaXMgaXMgY29uc2lzdGVudCB3aXRoIEpTQywgd2hpY2ggdGhyb3dzIGEg Z2xvYmFsIGV4Y2VwdGlvbiBhbGwgdGhlIHRpbWUuCi0gICAgICAgIHRocm93RXJyb3IodjhHZW5l cmFsRXJyb3IsIG1lc3NhZ2UpOworICAgICAgICB0aHJvd0Vycm9yKHY4R2VuZXJhbEVycm9yLCBt ZXNzYWdlLCB2ODo6SXNvbGF0ZTo6R2V0Q3VycmVudCgpKTsKICAgICAgICAgcmV0dXJuOwogICAg IH0KICAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxlU2NvcGU7CkBAIC00OTAsNyArNDkwLDcgQEAg dm9pZCBfTlBOX1NldEV4Y2VwdGlvbihOUE9iamVjdCogbnBPYmplY3QsIGNvbnN0IE5QVVRGOCAq bWVzc2FnZSkKICAgICB2ODo6Q29udGV4dDo6U2NvcGUgc2NvcGUoY29udGV4dCk7CiAgICAgRXhj ZXB0aW9uQ2F0Y2hlciBleGNlcHRpb25DYXRjaGVyOwogCi0gICAgdGhyb3dFcnJvcih2OEdlbmVy YWxFcnJvciwgbWVzc2FnZSk7CisgICAgdGhyb3dFcnJvcih2OEdlbmVyYWxFcnJvciwgbWVzc2Fn ZSwgY29udGV4dC0+R2V0SXNvbGF0ZSgpKTsKIH0KIAogYm9vbCBfTlBOX0VudW1lcmF0ZShOUFAg bnBwLCBOUE9iamVjdCogbnBPYmplY3QsIE5QSWRlbnRpZmllcioqIGlkZW50aWZpZXIsIHVpbnQz Ml90KiBjb3VudCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Qmlu ZGluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCmluZGV4 IDZiZWFlZmM2MmNjYmM0N2UzYjg1MTAzNDcwYmVmNjBiZWYzNjI0YjIuLjMxMjExZjU2NjNjYWNh YzQ4NTcyZDZiMWY0NDk1MjJjNzMwM2M4YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhCaW5kaW5nLmNwcApAQCAtMjkyLDcgKzI5Miw3IEBAIGJvb2wgaGFuZGxlT3V0T2ZNZW1vcnko KQogCiB2ODo6TG9jYWw8djg6OlZhbHVlPiBoYW5kbGVNYXhSZWN1cnNpb25EZXB0aEV4Y2VlZGVk KCkKIHsKLSAgICB0aHJvd0Vycm9yKHY4UmFuZ2VFcnJvciwgIk1heGltdW0gY2FsbCBzdGFjayBz aXplIGV4Y2VlZGVkLiIpOworICAgIHRocm93RXJyb3IodjhSYW5nZUVycm9yLCAiTWF4aW11bSBj YWxsIHN0YWNrIHNpemUgZXhjZWVkZWQuIiwgdjg6Oklzb2xhdGU6OkdldEN1cnJlbnQoKSk7CiAg ICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6VmFsdWU+KCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhCaW5kaW5nLmgKaW5kZXggMjYxM2FhMDRjZmIzMjc5NDQ0MDA3MWI0Yzg5ZTlkMDg2 ZDM5ODJiMy4uMGNjYzAzMzEyZTNkMmFmZmJjMjFkOWY0ODQ0NGJiZDc0N2Q4NmQ3OCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKQEAgLTYyLDEwICs2MiwxMCBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHNldERPTUV4Y2VwdGlv bihpbnQsIHY4OjpJc29sYXRlKik7CiAKICAgICAvLyBTY2hlZHVsZSBhIEphdmFTY3JpcHQgZXJy b3IgdG8gYmUgdGhyb3duLgotICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB0aHJvd0Vycm9yKFY4 RXJyb3JUeXBlLCBjb25zdCBjaGFyKiwgdjg6Oklzb2xhdGUqID0gMCk7CisgICAgdjg6OkhhbmRs ZTx2ODo6VmFsdWU+IHRocm93RXJyb3IoVjhFcnJvclR5cGUsIGNvbnN0IGNoYXIqLCB2ODo6SXNv bGF0ZSopOwogCiAgICAgLy8gU2NoZWR1bGUgYSBKYXZhU2NyaXB0IGVycm9yIHRvIGJlIHRocm93 bi4KLSAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdGhyb3dFcnJvcih2ODo6TG9jYWw8djg6OlZh bHVlPiwgdjg6Oklzb2xhdGUqID0gMCk7CisgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHRocm93 RXJyb3Iodjg6OkxvY2FsPHY4OjpWYWx1ZT4sIHY4OjpJc29sYXRlKik7CiAKICAgICAvLyBBIGhl bHBlciBmb3IgdGhyb3dpbmcgSmF2YVNjcmlwdCBUeXBlRXJyb3IuCiAgICAgdjg6OkhhbmRsZTx2 ODo6VmFsdWU+IHRocm93VHlwZUVycm9yKGNvbnN0IGNoYXIqID0gMCwgdjg6Oklzb2xhdGUqID0g MCk7CkBAIC00NjMsNiArNDYzLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIC8vIElmIHRo ZSBjdXJyZW50IGNvbnRleHQgY2F1c2VzIG91dCBvZiBtZW1vcnksIEphdmFTY3JpcHQgc2V0dGlu ZwogICAgIC8vIGlzIGRpc2FibGVkIGFuZCBpdCByZXR1cm5zIHRydWUuCiAgICAgYm9vbCBoYW5k bGVPdXRPZk1lbW9yeSgpOworICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCByZWNlaXZlIGFuIElz b2xhdGUuCiAgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gaGFuZGxlTWF4UmVjdXJzaW9uRGVwdGhF eGNlZWRlZCgpOwogCiAgICAgdm9pZCBjcmFzaElmVjhJc0RlYWQoKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyU2NyaXB0Q29udHJvbGxlci5jcHAKaW5kZXgg MmE3ZTE2MzQ2NWNhY2NlZTA2NjJkNTU0MDllNDU0ODhmNzI5Y2RjNS4uZjA0OTY4ZDI5ZGZiZTlj NWU4ZDhkNDU3MDBhY2RhYTUxMDEwNGRiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvV29ya2VyU2NyaXB0Q29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvV29ya2VyU2NyaXB0Q29udHJvbGxlci5jcHAKQEAgLTE3MSw3ICsxNzEsNyBA QCBTY3JpcHRWYWx1ZSBXb3JrZXJTY3JpcHRDb250cm9sbGVyOjpldmFsdWF0ZShjb25zdCBTdHJp bmcmIHNjcmlwdCwgY29uc3QgU3RyaW5nJgogICAgICAgICBzdGF0ZS0+bGluZU51bWJlciA9IG1l c3NhZ2UtPkdldExpbmVOdW1iZXIoKTsKICAgICAgICAgc3RhdGUtPnNvdXJjZVVSTCA9IHRvV2Vi Q29yZVN0cmluZyhtZXNzYWdlLT5HZXRTY3JpcHRSZXNvdXJjZU5hbWUoKSk7CiAgICAgICAgIGlm IChtX3dvcmtlckNvbnRleHQtPnNhbml0aXplU2NyaXB0RXJyb3Ioc3RhdGUtPmVycm9yTWVzc2Fn ZSwgc3RhdGUtPmxpbmVOdW1iZXIsIHN0YXRlLT5zb3VyY2VVUkwpKQotICAgICAgICAgICAgc3Rh dGUtPmV4Y2VwdGlvbiA9IHRocm93RXJyb3IodjhHZW5lcmFsRXJyb3IsIHN0YXRlLT5lcnJvck1l c3NhZ2UudXRmOCgpLmRhdGEoKSk7CisgICAgICAgICAgICBzdGF0ZS0+ZXhjZXB0aW9uID0gdGhy b3dFcnJvcih2OEdlbmVyYWxFcnJvciwgc3RhdGUtPmVycm9yTWVzc2FnZS51dGY4KCkuZGF0YSgp LCBtX2NvbnRleHQtPkdldElzb2xhdGUoKSk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHN0 YXRlLT5leGNlcHRpb24gPSBTY3JpcHRWYWx1ZShibG9jay5FeGNlcHRpb24oKSk7CiAKQEAgLTIz OCw3ICsyMzgsNyBAQCB2b2lkIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6OmRpc2FibGVFdmFsKGNv bnN0IFN0cmluZyYgZXJyb3JNZXNzYWdlKQogCiB2b2lkIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6 OnNldEV4Y2VwdGlvbihjb25zdCBTY3JpcHRWYWx1ZSYgZXhjZXB0aW9uKQogewotICAgIHRocm93 RXJyb3IoKmV4Y2VwdGlvbi52OFZhbHVlKCkpOworICAgIHRocm93RXJyb3IoKmV4Y2VwdGlvbi52 OFZhbHVlKCksIG1fY29udGV4dC0+R2V0SXNvbGF0ZSgpKTsKIH0KIAogV29ya2VyU2NyaXB0Q29u dHJvbGxlciogV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6Y29udHJvbGxlckZvckNvbnRleHQoKQo=