107620 2013-01-22 20:39:55 -0800 Make MediaQueryEvaluator(bool) constructor explicit. 2013-01-22 21:16:14 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hayato hayato cmarcelo eric.carlson feature-media-reviews macpherson menard ojan.autocc shinyak webcomponents-bugzilla webkit.review.bot oldest_to_newest 813736 0 hayato 2013-01-22 20:39:55 -0800 I had to confess that I've spent a couple of hours on debugging due to this non-explicit constructor. RuleSet:::addRulesFromSheet is defined: RuleSet:addRulesFromSheet(StyleSheetContents*, const MediaQueryEvaluator&, StyleResolver* = 0, const ContainerNode* = 0) I wrongly called it with 'ruleSet.addRulesFromSheet(sheet, resolver)'. My bad. :( 813738 1 184119 hayato 2013-01-22 20:43:12 -0800 Created attachment 184119 Make it explicit 813743 2 184120 hayato 2013-01-22 20:46:41 -0800 Created attachment 184120 Fix a title. 813755 3 shinyak 2013-01-22 21:02:36 -0800 Looks ok if all build-bots pass. 813771 4 184120 webkit.review.bot 2013-01-22 21:16:10 -0800 Comment on attachment 184120 Fix a title. Clearing flags on attachment: 184120 Committed r140503: <http://trac.webkit.org/changeset/140503> 813772 5 webkit.review.bot 2013-01-22 21:16:14 -0800 All reviewed patches have been landed. Closing bug. 184119 2013-01-22 20:43:12 -0800 2013-01-22 20:46:37 -0800 Make it explicit bug-107620-20130123134005.patch text/plain 1458 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2IyZDRhN2Q1ZTM3NDM3 ODc4OWU3YjI1ZTk2MTFhYWFkY2MzNDRhNS4uMDI5Y2U2OTU4OTg2ZjQwNWFhNmU2ZTk4MDE3M2Y3 MTY2MWIyM2EyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTIyICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIE1lZGlhUXVhZXlF dmFsdWF0b3IoYm9vbCkgY29uc3RydWN0b3IgZXhwbGljaXQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc2MjAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHM6IG5vIGNoYW5nZSBpbiBi ZWhhdmlvci4KKworICAgICAgICAqIGNzcy9NZWRpYVF1ZXJ5RXZhbHVhdG9yLmg6CisgICAgICAg IChNZWRpYVF1ZXJ5RXZhbHVhdG9yKToKKwogMjAxMy0wMS0yMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgogCiAgICAgICAgIEVOQUJMRShORVdfWE1MKSBpc24ndCB1c2VkIGJ5IGFu eW9uZSBhbmQgbm8gb25lIGlzIGFjdGl2ZWx5IHdvcmtpbmcgb24gaXQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5RXZhbHVhdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9j c3MvTWVkaWFRdWVyeUV2YWx1YXRvci5oCmluZGV4IDcxZGU2ZWRhMTBmYzhjNjg0YzJkZTlhNDdj ZGZjZTVkNmQyODcyMjAuLjE2NjE5Y2FlZTk5MzVlNmI5M2FjYmM5NDE5NTIwNDc1NjU0ZGE4Yzgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5RXZhbHVhdG9yLmgKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlFdmFsdWF0b3IuaApAQCAtNTYsNyArNTYs NyBAQCBwdWJsaWM6CiAgICAgICogIEV2YWx1YXRvciByZXR1cm5zIHRydWUgZm9yICJhbGwiLCBh bmQgcmV0dXJucyB2YWx1ZSBvZiBcbWVkaWFGZWF0dXJlUmVzdWx0CiAgICAgICogIGZvciBhbnkg bWVkaWEgZmVhdHVyZXMKICAgICAgKi8KLSAgICBNZWRpYVF1ZXJ5RXZhbHVhdG9yKGJvb2wgbWVk aWFGZWF0dXJlUmVzdWx0ID0gZmFsc2UpOworICAgIGV4cGxpY2l0IE1lZGlhUXVlcnlFdmFsdWF0 b3IoYm9vbCBtZWRpYUZlYXR1cmVSZXN1bHQgPSBmYWxzZSk7CiAKICAgICAvKiogQ3JlYXRlcyBl dmFsdWF0b3Igd2hpY2ggZXZhbHVhdGVzIG9ubHkgc2ltcGxlIG1lZGlhIHF1ZXJpZXMKICAgICAg KiAgRXZhbHVhdG9yICByZXR1cm5zIHRydWUgZm9yIGFjY2VwdGVkTWVkaWFUeXBlIGFuZCByZXR1 cm5zIHZhbHVlIG9mIFxtZWRpYWZlYXR1cmVSZXN1bHQK 184120 2013-01-22 20:46:41 -0800 2013-01-22 21:16:10 -0800 Fix a title. bug-107620-20130123134334.patch text/plain 1458 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2IyZDRhN2Q1ZTM3NDM3 ODc4OWU3YjI1ZTk2MTFhYWFkY2MzNDRhNS4uNDViY2VjZTI0YjY2MjYzMTE2YTc0ZDNiZjBkNDE1 MDM4MGZkYmJiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTIyICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIE1lZGlhUXVlcnlF dmFsdWF0b3IoYm9vbCkgY29uc3RydWN0b3IgZXhwbGljaXQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc2MjAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHM6IG5vIGNoYW5nZSBpbiBi ZWhhdmlvci4KKworICAgICAgICAqIGNzcy9NZWRpYVF1ZXJ5RXZhbHVhdG9yLmg6CisgICAgICAg IChNZWRpYVF1ZXJ5RXZhbHVhdG9yKToKKwogMjAxMy0wMS0yMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgogCiAgICAgICAgIEVOQUJMRShORVdfWE1MKSBpc24ndCB1c2VkIGJ5IGFu eW9uZSBhbmQgbm8gb25lIGlzIGFjdGl2ZWx5IHdvcmtpbmcgb24gaXQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5RXZhbHVhdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9j c3MvTWVkaWFRdWVyeUV2YWx1YXRvci5oCmluZGV4IDcxZGU2ZWRhMTBmYzhjNjg0YzJkZTlhNDdj ZGZjZTVkNmQyODcyMjAuLjE2NjE5Y2FlZTk5MzVlNmI5M2FjYmM5NDE5NTIwNDc1NjU0ZGE4Yzgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5RXZhbHVhdG9yLmgKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlFdmFsdWF0b3IuaApAQCAtNTYsNyArNTYs NyBAQCBwdWJsaWM6CiAgICAgICogIEV2YWx1YXRvciByZXR1cm5zIHRydWUgZm9yICJhbGwiLCBh bmQgcmV0dXJucyB2YWx1ZSBvZiBcbWVkaWFGZWF0dXJlUmVzdWx0CiAgICAgICogIGZvciBhbnkg bWVkaWEgZmVhdHVyZXMKICAgICAgKi8KLSAgICBNZWRpYVF1ZXJ5RXZhbHVhdG9yKGJvb2wgbWVk aWFGZWF0dXJlUmVzdWx0ID0gZmFsc2UpOworICAgIGV4cGxpY2l0IE1lZGlhUXVlcnlFdmFsdWF0 b3IoYm9vbCBtZWRpYUZlYXR1cmVSZXN1bHQgPSBmYWxzZSk7CiAKICAgICAvKiogQ3JlYXRlcyBl dmFsdWF0b3Igd2hpY2ggZXZhbHVhdGVzIG9ubHkgc2ltcGxlIG1lZGlhIHF1ZXJpZXMKICAgICAg KiAgRXZhbHVhdG9yICByZXR1cm5zIHRydWUgZm9yIGFjY2VwdGVkTWVkaWFUeXBlIGFuZCByZXR1 cm5zIHZhbHVlIG9mIFxtZWRpYWZlYXR1cmVSZXN1bHQK