107607 2013-01-22 17:56:28 -0800 [Chromium, Mobile] Do not show disambiguation pop up in mobile sites 2013-01-28 15:39:50 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dfalcantara dfalcantara aelias dglazkov klobag trchen webkit.review.bot oldest_to_newest 813628 0 dfalcantara 2013-01-22 17:56:28 -0800 Corresponding Chromium bug: http://crbug.com/168117 For mobile sites, it seems unnecessary to make a disambiguation popup since the page should be designed specifically for ease of use on a mobile device, e.g. touch targets should be big enough to click on without ambiguity. 813645 1 184097 dfalcantara 2013-01-22 18:18:11 -0800 Created attachment 184097 Patch 813688 2 184097 webkit.review.bot 2013-01-22 19:30:32 -0800 Comment on attachment 184097 Patch Attachment 184097 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16039885 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 814414 3 184097 abarth 2013-01-23 11:29:55 -0800 Comment on attachment 184097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184097&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:758 > + // Don't trigger a disambiguation popup on sites designed for mobile devices. > + // Instead, assume that the page has been designed with big enough buttons and links. > + ViewportArguments viewportArguments = mainFrameImpl()->frame()->document()->viewportArguments(); > + bool isLikelyMobileSite = !viewportArguments.userZoom || (viewportArguments.width == ViewportArguments::ValueDeviceWidth); Do we have other heuristics like this elsewhere? Should we use the same one consistently? If not, should we factor this code in a way that future code that wants a "is mobile site" heuristic can use it too? Also, we need a test. 814570 4 dfalcantara 2013-01-23 13:30:21 -0800 > Do we have other heuristics like this elsewhere? Should we use the same one consistently? If not, should we factor this code in a way that future code that wants a "is mobile site" heuristic can use it too? > > Also, we need a test. I think I found the code you mentioned for the 300ms simulated click event delay Chromium-side, in ContentViewGestureHandler.java. It seems pretty specific, though: because our double tap action is to zoom in, we simply don't enforce the trigger the delay when there is a fixed page scale. I'll dig around some more for other current possible use-cases, but I think factoring out the code is a good idea, regardless. 814828 5 184346 dfalcantara 2013-01-23 16:46:46 -0800 Created attachment 184346 Patch 815671 6 184542 dfalcantara 2013-01-24 11:43:18 -0800 Created attachment 184542 Patch 815672 7 dfalcantara 2013-01-24 11:44:07 -0800 Alex: is this what you were going for? 815688 8 aelias 2013-01-24 11:54:12 -0800 LGTM 818016 9 dfalcantara 2013-01-28 13:04:29 -0800 Ping? 818171 10 184542 abarth 2013-01-28 15:15:26 -0800 Comment on attachment 184542 Patch Thanks. This is much better. 818198 11 184542 webkit.review.bot 2013-01-28 15:39:46 -0800 Comment on attachment 184542 Patch Clearing flags on attachment: 184542 Committed r141019: <http://trac.webkit.org/changeset/141019> 818199 12 webkit.review.bot 2013-01-28 15:39:50 -0800 All reviewed patches have been landed. Closing bug. 184097 2013-01-22 18:18:11 -0800 2013-01-23 16:46:44 -0800 Patch bug-107607-20130122181505.patch text/plain 1956 dfalcantara SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDA0OTQpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTAxLTIyICBEYW4gQWxjYW50YXJhICA8ZGZhbGNhbnRhcmFAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtDaHJvbWl1bSwgTW9iaWxlXSBEbyBub3Qgc2hvdyBkaXNhbWJpZ3VhdGlv biBwb3AgdXAgaW4gbW9iaWxlIHNpdGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDc2MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYSBjaGVjayBiZWZvcmUgc2hvd2luZyB0aGUgZGlzYW1iaWd1 YXRpb24gcG9wdXAgdG8gcHJldmVudCBpdCBmcm9tIGFwcGVhcmluZworICAgICAgICBvbiBtb2Jp bGUgc2l0ZXMuCisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJWaWV3SW1wbDo6aGFuZGxlR2VzdHVyZUV2ZW50KToKKwogMjAxMy0wMS0yMSAgS2Vu dGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IFVJ RXZlbnQgY29uc3RydWN0b3IKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp ZXdJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW aWV3SW1wbC5jcHAJKHJldmlzaW9uIDE0MDQ5NCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzUyLDcgKzc1MiwxMiBAQCBi b29sIFdlYlZpZXdJbXBsOjpoYW5kbGVHZXN0dXJlRXZlbnQoY29uCiAgICAgICAgIGhpZGVTZWxl Y3RQb3B1cCgpOwogICAgICAgICBBU1NFUlQoIW1fc2VsZWN0UG9wdXApOwogCi0gICAgICAgIGlm IChldmVudC5kYXRhLnRhcC53aWR0aCA+IDApIHsKKyAgICAgICAgLy8gRG9uJ3QgdHJpZ2dlciBh IGRpc2FtYmlndWF0aW9uIHBvcHVwIG9uIHNpdGVzIGRlc2lnbmVkIGZvciBtb2JpbGUgZGV2aWNl cy4KKyAgICAgICAgLy8gSW5zdGVhZCwgYXNzdW1lIHRoYXQgdGhlIHBhZ2UgaGFzIGJlZW4gZGVz aWduZWQgd2l0aCBiaWcgZW5vdWdoIGJ1dHRvbnMgYW5kIGxpbmtzLgorICAgICAgICBWaWV3cG9y dEFyZ3VtZW50cyB2aWV3cG9ydEFyZ3VtZW50cyA9IG1haW5GcmFtZUltcGwoKS0+ZnJhbWUoKS0+ ZG9jdW1lbnQoKS0+dmlld3BvcnRBcmd1bWVudHMoKTsKKyAgICAgICAgYm9vbCBpc0xpa2VseU1v YmlsZVNpdGUgPSAhdmlld3BvcnRBcmd1bWVudHMudXNlclpvb20gfHwgKHZpZXdwb3J0QXJndW1l bnRzLndpZHRoID09IFZpZXdwb3J0QXJndW1lbnRzOjpWYWx1ZURldmljZVdpZHRoKTsKKworICAg ICAgICBpZiAoZXZlbnQuZGF0YS50YXAud2lkdGggPiAwICYmICFpc0xpa2VseU1vYmlsZVNpdGUp IHsKICAgICAgICAgICAgIEludFJlY3QgYm91bmRpbmdCb3goZXZlbnQueCAtIGV2ZW50LmRhdGEu dGFwLndpZHRoIC8gMiwgZXZlbnQueSAtIGV2ZW50LmRhdGEudGFwLmhlaWdodCAvIDIsIGV2ZW50 LmRhdGEudGFwLndpZHRoLCBldmVudC5kYXRhLnRhcC5oZWlnaHQpOwogICAgICAgICAgICAgVmVj dG9yPEludFJlY3Q+IGdvb2RUYXJnZXRzOwogICAgICAgICAgICAgZmluZEdvb2RUb3VjaFRhcmdl dHMoYm91bmRpbmdCb3gsIG1haW5GcmFtZUltcGwoKS0+ZnJhbWUoKSwgcGFnZVNjYWxlRmFjdG9y KCksIGdvb2RUYXJnZXRzKTsK 184346 2013-01-23 16:46:46 -0800 2013-01-24 11:43:16 -0800 Patch bug-107607-20130123164339.patch text/plain 5975 dfalcantara SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDA2MTUpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIz IEBACisyMDEzLTAxLTIzICBEYW4gQWxjYW50YXJhICA8ZGZhbGNhbnRhcmFAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtDaHJvbWl1bSwgTW9iaWxlXSBEbyBub3Qgc2hvdyBkaXNhbWJpZ3VhdGlv biBwb3AgdXAgaW4gbW9iaWxlIHNpdGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDc2MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYSBjaGVjayBiZWZvcmUgc2hvd2luZyB0aGUgZGlzYW1iaWd1 YXRpb24gcG9wdXAgdG8gcHJldmVudCBpdCBmcm9tIGFwcGVhcmluZworICAgICAgICBvbiBtb2Jp bGUgc2l0ZXMuICBNYWtlcyBhIHNpbWlsYXIgdGVzdCB0byB0aGUgY3VycmVudCBkaXNhbWJpZ3Vh dGlvbiBwb3B1cCB0ZXN0CisgICAgICAgIHRoYXQgZXhwZWN0cyB0aGUgcG9wdXAgdG8gbmV2ZXIg YXBwZWFyLgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViVmlld0ltcGw6OmhhbmRsZUdlc3R1cmVFdmVudCk6CisgICAgICAgIChXZWJLaXQpOgor ICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6aXNMaWtlbHlNb2JpbGVTaXRlKToKKyAgICAg ICAgKiBzcmMvV2ViVmlld0ltcGwuaDoKKyAgICAgICAgKFdlYlZpZXdJbXBsKToKKyAgICAgICAg KiB0ZXN0cy9XZWJGcmFtZVRlc3QuY3BwOgorICAgICAgICAqIHRlc3RzL2RhdGEvZGlzYW1iaWd1 YXRpb25fcG9wdXBfbW9iaWxlX3NpdGUuaHRtbDogQWRkZWQuCisKIDIwMTMtMDEtMjMgIEpvc2h1 YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IFJlbW92 ZSBJREJWZXJzaW9uQ2hhbmdlUmVxdWVzdApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gMTQwNjExKQorKysgU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NTMsNyArNzUz LDkgQEAgYm9vbCBXZWJWaWV3SW1wbDo6aGFuZGxlR2VzdHVyZUV2ZW50KGNvbgogICAgICAgICBo aWRlU2VsZWN0UG9wdXAoKTsKICAgICAgICAgQVNTRVJUKCFtX3NlbGVjdFBvcHVwKTsKIAotICAg ICAgICBpZiAoZXZlbnQuZGF0YS50YXAud2lkdGggPiAwKSB7CisgICAgICAgIC8vIERvbid0IHRy aWdnZXIgYSBkaXNhbWJpZ3VhdGlvbiBwb3B1cCBvbiBzaXRlcyBkZXNpZ25lZCBmb3IgbW9iaWxl IGRldmljZXMuCisgICAgICAgIC8vIEluc3RlYWQsIGFzc3VtZSB0aGF0IHRoZSBwYWdlIGhhcyBi ZWVuIGRlc2lnbmVkIHdpdGggYmlnIGVub3VnaCBidXR0b25zIGFuZCBsaW5rcy4KKyAgICAgICAg aWYgKGV2ZW50LmRhdGEudGFwLndpZHRoID4gMCAmJiAhaXNMaWtlbHlNb2JpbGVTaXRlKCkpIHsK ICAgICAgICAgICAgIEludFJlY3QgYm91bmRpbmdCb3goZXZlbnQueCAtIGV2ZW50LmRhdGEudGFw LndpZHRoIC8gMiwgZXZlbnQueSAtIGV2ZW50LmRhdGEudGFwLmhlaWdodCAvIDIsIGV2ZW50LmRh dGEudGFwLndpZHRoLCBldmVudC5kYXRhLnRhcC5oZWlnaHQpOwogICAgICAgICAgICAgVmVjdG9y PEludFJlY3Q+IGdvb2RUYXJnZXRzOwogICAgICAgICAgICAgZmluZEdvb2RUb3VjaFRhcmdldHMo Ym91bmRpbmdCb3gsIG1haW5GcmFtZUltcGwoKS0+ZnJhbWUoKSwgcGFnZVNjYWxlRmFjdG9yKCks IGdvb2RUYXJnZXRzKTsKQEAgLTQzNDEsNCArNDM0MywxMCBAQCB2b2lkIFdlYlZpZXdJbXBsOjpw b2ludGVyTG9ja01vdXNlRXZlbnQoCiB9CiAjZW5kaWYKIAorYm9vbCBXZWJWaWV3SW1wbDo6aXNM aWtlbHlNb2JpbGVTaXRlKCkKK3sKKyAgICBWaWV3cG9ydEFyZ3VtZW50cyB2aWV3cG9ydEFyZ3Vt ZW50cyA9IG1haW5GcmFtZUltcGwoKS0+ZnJhbWUoKS0+ZG9jdW1lbnQoKS0+dmlld3BvcnRBcmd1 bWVudHMoKTsKKyAgICByZXR1cm4gIXZpZXdwb3J0QXJndW1lbnRzLnVzZXJab29tIHx8ICh2aWV3 cG9ydEFyZ3VtZW50cy53aWR0aCA9PSBWaWV3cG9ydEFyZ3VtZW50czo6VmFsdWVEZXZpY2VXaWR0 aCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRleDogU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViVmlld0ltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5oCShyZXZpc2lvbiAxNDA2MTEpCisrKyBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC02MDAsNiArNjAw LDkgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBpc1BvaW50ZXJMb2NrZWQoKTsKICNlbmRp ZgogCisgICAgLy8gSGV1cmlzdGljLWJhc2VkIGZ1bmN0aW9uIGZvciBkZXRlcm1pbmluZyBpZiB3 ZSBhcmUgcmVuZGVyaW5nIGEgbW9iaWxlLW9wdGltaXplZCBzaXRlLgorICAgIGJvb2wgaXNMaWtl bHlNb2JpbGVTaXRlKCk7CisKICNpZiBFTkFCTEUoR0VTVFVSRV9FVkVOVFMpCiAgICAgLy8gRXhw b3NlZCBmb3IgdGVzdHMuCiAgICAgTGlua0hpZ2hsaWdodCogbGlua0hpZ2hsaWdodCgpIHsgcmV0 dXJuIG1fbGlua0hpZ2hsaWdodC5nZXQoKTsgfQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1 bS90ZXN0cy9XZWJGcmFtZVRlc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAkocmV2aXNpb24gMTQwNjExKQorKysgU291cmNl L1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFtZVRlc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xNjgzLDYgKzE2ODMsMzkgQEAgVEVTVF9GKFdlYkZyYW1lVGVzdCwgRGlzYW1iaWd1YXRpb25Q b3B1cAogICAgIEVYUEVDVF9GQUxTRShjbGllbnQudHJpZ2dlcmVkKCkpOwogfQogCitURVNUX0Yo V2ViRnJhbWVUZXN0LCBEaXNhbWJpZ3VhdGlvblBvcHVwTW9iaWxlU2l0ZSkKK3sKKyAgICByZWdp c3Rlck1vY2tlZEh0dHBVUkxMb2FkKCJkaXNhbWJpZ3VhdGlvbl9wb3B1cF9tb2JpbGVfc2l0ZS5o dG1sIik7CisKKyAgICBEaXNhbWJpZ3VhdGlvblBvcHVwVGVzdFdlYlZpZXdDbGllbnQgY2xpZW50 OworCisgICAgLy8gTWFrZSBzdXJlIHdlIGluaXRpYWxpemUgdG8gbWluaW11bSBzY2FsZSwgZXZl biBpZiB0aGUgd2luZG93IHNpemUKKyAgICAvLyBvbmx5IGJlY29tZXMgYXZhaWxhYmxlIGFmdGVy IHRoZSBsb2FkIGJlZ2lucy4KKyAgICBXZWJWaWV3SW1wbCogd2ViVmlld0ltcGwgPSBzdGF0aWNf Y2FzdDxXZWJWaWV3SW1wbCo+KEZyYW1lVGVzdEhlbHBlcnM6OmNyZWF0ZVdlYlZpZXdBbmRMb2Fk KG1fYmFzZVVSTCArICJkaXNhbWJpZ3VhdGlvbl9wb3B1cC5odG1sIiwgdHJ1ZSwgMCwgJmNsaWVu dCkpOworICAgIHdlYlZpZXdJbXBsLT5yZXNpemUoV2ViU2l6ZSgxMDAwLCAxMDAwKSk7CisgICAg d2ViVmlld0ltcGwtPmxheW91dCgpOworCisgICAgY2xpZW50LnJlc2V0VHJpZ2dlcmVkKCk7Cisg ICAgd2ViVmlld0ltcGwtPmhhbmRsZUlucHV0RXZlbnQoZmF0VGFwKDAsIDApKTsKKyAgICBFWFBF Q1RfRkFMU0UoY2xpZW50LnRyaWdnZXJlZCgpKTsKKworICAgIGNsaWVudC5yZXNldFRyaWdnZXJl ZCgpOworICAgIHdlYlZpZXdJbXBsLT5oYW5kbGVJbnB1dEV2ZW50KGZhdFRhcCgyMDAsIDExNSkp OworICAgIEVYUEVDVF9GQUxTRShjbGllbnQudHJpZ2dlcmVkKCkpOworCisgICAgZm9yIChpbnQg aSA9IDA7IGkgPD0gNDY7IGkrKykgeworICAgICAgICBjbGllbnQucmVzZXRUcmlnZ2VyZWQoKTsK KyAgICAgICAgd2ViVmlld0ltcGwtPmhhbmRsZUlucHV0RXZlbnQoZmF0VGFwKDEyMCwgMjMwICsg aSAqIDUpKTsKKyAgICAgICAgRVhQRUNUX0ZBTFNFKGNsaWVudC50cmlnZ2VyZWQoKSk7CisgICAg fQorCisgICAgZm9yIChpbnQgaSA9IDA7IGkgPD0gNDY7IGkrKykgeworICAgICAgICBjbGllbnQu cmVzZXRUcmlnZ2VyZWQoKTsKKyAgICAgICAgd2ViVmlld0ltcGwtPmhhbmRsZUlucHV0RXZlbnQo ZmF0VGFwKDEwICsgaSAqIDUsIDU5MCkpOworICAgICAgICBFWFBFQ1RfRkFMU0UoY2xpZW50LnRy aWdnZXJlZCgpKTsKKyAgICB9Cit9CisKIGNsYXNzIFRlc3RTdWJzdGl0dXRlRGF0YVdlYkZyYW1l Q2xpZW50IDogcHVibGljIFdlYkZyYW1lQ2xpZW50IHsKIHB1YmxpYzoKICAgICBUZXN0U3Vic3Rp dHV0ZURhdGFXZWJGcmFtZUNsaWVudCgpCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rl c3RzL2RhdGEvZGlzYW1iaWd1YXRpb25fcG9wdXBfbW9iaWxlX3NpdGUuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2RhdGEvZGlzYW1iaWd1YXRpb25fcG9w dXBfbW9iaWxlX3NpdGUuaHRtbAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvZGF0YS9kaXNhbWJpZ3VhdGlvbl9wb3B1cF9tb2JpbGVfc2l0ZS5odG1sCShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDMxIEBACis8aHRtbD4KKzxoZWFkPgorPHRpdGxlPkRpc2FtYmln dWF0aW9uIFBvcHVwIFRlc3Q8L3RpdGxlPgorPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KKy5ob3Jp em9udGFsLWxpbmsgeworICAgIGRpc3BsYXk6YmxvY2s7CisgICAgd2lkdGg6MjAwcHg7CisgICAg aGVpZ2h0OjMwcHg7CisgICAgbWFyZ2luOjIwcHg7CisgICAgYmFja2dyb3VuZC1jb2xvcjojY2Nj Y2ZmOworfQorLnZlcnRpY2FsLWxpbmsgeworICAgIGRpc3BsYXk6aW5saW5lLWJsb2NrOworICAg IHdpZHRoOjMwcHg7CisgICAgaGVpZ2h0OjIwMHB4OworICAgIG1hcmdpbjoxMHB4OworICAgIGJh Y2tncm91bmQtY29sb3I6I2NjY2NmZjsKK30KKzwvc3R5bGU+Cis8bWV0YSBuYW1lPSJ2aWV3cG9y dCIgY29udGVudD0id2lkdGg9ZGV2aWNlLXdpZHRoIj4KKzwvaGVhZD4KKzxib2R5IHN0eWxlPSJt YXJnaW46MHB4OyI+Cis8YSBocmVmPSIjIiBjbGFzcz0iaG9yaXpvbnRhbC1saW5rIiBzdHlsZT0i bWFyZ2luOjEwMHB4Ij5MaW5rPC9hPgorPGEgaHJlZj0iIyIgY2xhc3M9Imhvcml6b250YWwtbGlu ayI+TGluayAxPC9hPgorPGEgaHJlZj0iIyIgY2xhc3M9Imhvcml6b250YWwtbGluayI+TGluayAy PC9hPgorPGEgaHJlZj0iIyIgY2xhc3M9Imhvcml6b250YWwtbGluayI+TGluayAzPC9hPgorPGEg aHJlZj0iIyIgY2xhc3M9Imhvcml6b250YWwtbGluayI+TGluayA0PC9hPgorPGEgaHJlZj0iIyIg Y2xhc3M9Imhvcml6b250YWwtbGluayI+TGluayA1PC9hPgorPGEgaHJlZj0iIyIgY2xhc3M9InZl cnRpY2FsLWxpbmsiPkxpbmsgMTwvYT48YSBocmVmPSIjIiBjbGFzcz0idmVydGljYWwtbGluayI+ TGluayAyPC9hPjxhIGhyZWY9IiMiIGNsYXNzPSJ2ZXJ0aWNhbC1saW5rIj5MaW5rIDM8L2E+PGEg aHJlZj0iIyIgY2xhc3M9InZlcnRpY2FsLWxpbmsiPkxpbmsgNDwvYT48YSBocmVmPSIjIiBjbGFz cz0idmVydGljYWwtbGluayI+TGluayA1PC9hPgorPC9ib2R5PgorPC9odG1sPgo= 184542 2013-01-24 11:43:18 -0800 2013-01-28 15:39:45 -0800 Patch bug-107607-20130124114010.patch text/plain 6556 dfalcantara SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDA3MDIpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMy IEBACisyMDEzLTAxLTI0ICBEYW4gQWxjYW50YXJhICA8ZGZhbGNhbnRhcmFAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtDaHJvbWl1bSwgTW9iaWxlXSBEbyBub3Qgc2hvdyBkaXNhbWJpZ3VhdGlv biBwb3AgdXAgaW4gbW9iaWxlIHNpdGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDc2MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYSBjaGVjayBiZWZvcmUgc2hvd2luZyB0aGUgZGlzYW1iaWd1 YXRpb24gcG9wdXAgdG8gcHJldmVudCBpdCBmcm9tIGFwcGVhcmluZworICAgICAgICBvbiBtb2Jp bGUgc2l0ZXMuICBNYWtlcyBhIHNpbWlsYXIgdGVzdCB0byB0aGUgY3VycmVudCBkaXNhbWJpZ3Vh dGlvbiBwb3B1cCB0ZXN0CisgICAgICAgIHRoYXQgZXhwZWN0cyB0aGUgcG9wdXAgdG8gbmV2ZXIg YXBwZWFyLgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViVmlld0ltcGw6OmhhbmRsZUdlc3R1cmVFdmVudCk6CisgICAgICAgIChXZWJLaXQpOgor ICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6aXNMaWtlbHlNb2JpbGVTaXRlKToKKyAgICAg ICAgKiBzcmMvV2ViVmlld0ltcGwuaDoKKyAgICAgICAgKFdlYlZpZXdJbXBsKToKKyAgICAgICAg KiB0ZXN0cy9XZWJGcmFtZVRlc3QuY3BwOgorICAgICAgICAqIHRlc3RzL2RhdGEvZGlzYW1iaWd1 YXRpb25fcG9wdXBfbW9iaWxlX3NpdGUuaHRtbDogQWRkZWQuCisKKyAgICAgICAgKiBzcmMvV2Vi Vmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6aGFuZGxlR2VzdHVy ZUV2ZW50KToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBs OjpzaG91bGREaXNhYmxlRGVza3RvcFdvcmthcm91bmRzKToKKyAgICAgICAgKiBzcmMvV2ViVmll d0ltcGwuaDoKKyAgICAgICAgKFdlYlZpZXdJbXBsKToKKyAgICAgICAgKiB0ZXN0cy9XZWJGcmFt ZVRlc3QuY3BwOgorICAgICAgICAqIHRlc3RzL2RhdGEvZGlzYW1iaWd1YXRpb25fcG9wdXBfbW9i aWxlX3NpdGUuaHRtbDogQWRkZWQuCisKIDIwMTMtMDEtMjQgIE1paGFpIE1hZXJlYW4gIDxtbWFl cmVhbkBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTU1JlZ2lvbnNdIHJlbW92ZSBzZXRFeHBlcmlt ZW50YWxDU1NSZWdpb25zRW5hYmxlZCBkZXByZWNhdGVkIEFQSSBpbiBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuY3BwCShyZXZpc2lvbiAxNDA3MDEpCisrKyBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc1Myw3ICs3 NTMsOSBAQCBib29sIFdlYlZpZXdJbXBsOjpoYW5kbGVHZXN0dXJlRXZlbnQoY29uCiAgICAgICAg IGhpZGVTZWxlY3RQb3B1cCgpOwogICAgICAgICBBU1NFUlQoIW1fc2VsZWN0UG9wdXApOwogCi0g ICAgICAgIGlmIChldmVudC5kYXRhLnRhcC53aWR0aCA+IDApIHsKKyAgICAgICAgLy8gRG9uJ3Qg dHJpZ2dlciBhIGRpc2FtYmlndWF0aW9uIHBvcHVwIG9uIHNpdGVzIGRlc2lnbmVkIGZvciBtb2Jp bGUgZGV2aWNlcy4KKyAgICAgICAgLy8gSW5zdGVhZCwgYXNzdW1lIHRoYXQgdGhlIHBhZ2UgaGFz IGJlZW4gZGVzaWduZWQgd2l0aCBiaWcgZW5vdWdoIGJ1dHRvbnMgYW5kIGxpbmtzLgorICAgICAg ICBpZiAoZXZlbnQuZGF0YS50YXAud2lkdGggPiAwICYmICFzaG91bGREaXNhYmxlRGVza3RvcFdv cmthcm91bmRzKCkpIHsKICAgICAgICAgICAgIEludFJlY3QgYm91bmRpbmdCb3goZXZlbnQueCAt IGV2ZW50LmRhdGEudGFwLndpZHRoIC8gMiwgZXZlbnQueSAtIGV2ZW50LmRhdGEudGFwLmhlaWdo dCAvIDIsIGV2ZW50LmRhdGEudGFwLndpZHRoLCBldmVudC5kYXRhLnRhcC5oZWlnaHQpOwogICAg ICAgICAgICAgVmVjdG9yPEludFJlY3Q+IGdvb2RUYXJnZXRzOwogICAgICAgICAgICAgZmluZEdv b2RUb3VjaFRhcmdldHMoYm91bmRpbmdCb3gsIG1haW5GcmFtZUltcGwoKS0+ZnJhbWUoKSwgcGFn ZVNjYWxlRmFjdG9yKCksIGdvb2RUYXJnZXRzKTsKQEAgLTQzNDEsNCArNDM0MywxMSBAQCB2b2lk IFdlYlZpZXdJbXBsOjpwb2ludGVyTG9ja01vdXNlRXZlbnQoCiB9CiAjZW5kaWYKIAorYm9vbCBX ZWJWaWV3SW1wbDo6c2hvdWxkRGlzYWJsZURlc2t0b3BXb3JrYXJvdW5kcygpCit7CisgICAgVmll d3BvcnRBcmd1bWVudHMgYXJndW1lbnRzID0gbWFpbkZyYW1lSW1wbCgpLT5mcmFtZSgpLT5kb2N1 bWVudCgpLT52aWV3cG9ydEFyZ3VtZW50cygpOworICAgIHJldHVybiBhcmd1bWVudHMud2lkdGgg PT0gVmlld3BvcnRBcmd1bWVudHM6OlZhbHVlRGV2aWNlV2lkdGggfHwgIWFyZ3VtZW50cy51c2Vy Wm9vbQorICAgICAgICB8fCAoYXJndW1lbnRzLm1pblpvb20gPT0gYXJndW1lbnRzLm1heFpvb20g JiYgYXJndW1lbnRzLm1pblpvb20gIT0gVmlld3BvcnRBcmd1bWVudHM6OlZhbHVlQXV0byk7Cit9 CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5oCShyZXZpc2lvbiAxNDA3MDEpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC02MDAsNiArNjAwLDEwIEBA IHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgaXNQb2ludGVyTG9ja2VkKCk7CiAjZW5kaWYKIAor ICAgIC8vIEhldXJpc3RpYy1iYXNlZCBmdW5jdGlvbiBmb3IgZGV0ZXJtaW5pbmcgaWYgd2Ugc2hv dWxkIGRpc2FibGUgd29ya2Fyb3VuZHMKKyAgICAvLyBmb3Igdmlld2luZyB3ZWJzaXRlcyB0aGF0 IGFyZSBub3Qgb3B0aW1pemVkIGZvciBtb2JpbGUgZGV2aWNlcy4KKyAgICBib29sIHNob3VsZERp c2FibGVEZXNrdG9wV29ya2Fyb3VuZHMoKTsKKwogI2lmIEVOQUJMRShHRVNUVVJFX0VWRU5UUykK ICAgICAvLyBFeHBvc2VkIGZvciB0ZXN0cy4KICAgICBMaW5rSGlnaGxpZ2h0KiBsaW5rSGlnaGxp Z2h0KCkgeyByZXR1cm4gbV9saW5rSGlnaGxpZ2h0LmdldCgpOyB9CkluZGV4OiBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFtZVRlc3QuY3BwCShyZXZpc2lvbiAxNDA3MDEp CisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE2ODMsNiArMTY4MywzOSBAQCBURVNUX0YoV2ViRnJhbWVUZXN0LCBEaXNh bWJpZ3VhdGlvblBvcHVwCiAgICAgRVhQRUNUX0ZBTFNFKGNsaWVudC50cmlnZ2VyZWQoKSk7CiB9 CiAKK1RFU1RfRihXZWJGcmFtZVRlc3QsIERpc2FtYmlndWF0aW9uUG9wdXBNb2JpbGVTaXRlKQor eworICAgIHJlZ2lzdGVyTW9ja2VkSHR0cFVSTExvYWQoImRpc2FtYmlndWF0aW9uX3BvcHVwX21v YmlsZV9zaXRlLmh0bWwiKTsKKworICAgIERpc2FtYmlndWF0aW9uUG9wdXBUZXN0V2ViVmlld0Ns aWVudCBjbGllbnQ7CisKKyAgICAvLyBNYWtlIHN1cmUgd2UgaW5pdGlhbGl6ZSB0byBtaW5pbXVt IHNjYWxlLCBldmVuIGlmIHRoZSB3aW5kb3cgc2l6ZQorICAgIC8vIG9ubHkgYmVjb21lcyBhdmFp bGFibGUgYWZ0ZXIgdGhlIGxvYWQgYmVnaW5zLgorICAgIFdlYlZpZXdJbXBsKiB3ZWJWaWV3SW1w bCA9IHN0YXRpY19jYXN0PFdlYlZpZXdJbXBsKj4oRnJhbWVUZXN0SGVscGVyczo6Y3JlYXRlV2Vi Vmlld0FuZExvYWQobV9iYXNlVVJMICsgImRpc2FtYmlndWF0aW9uX3BvcHVwLmh0bWwiLCB0cnVl LCAwLCAmY2xpZW50KSk7CisgICAgd2ViVmlld0ltcGwtPnJlc2l6ZShXZWJTaXplKDEwMDAsIDEw MDApKTsKKyAgICB3ZWJWaWV3SW1wbC0+bGF5b3V0KCk7CisKKyAgICBjbGllbnQucmVzZXRUcmln Z2VyZWQoKTsKKyAgICB3ZWJWaWV3SW1wbC0+aGFuZGxlSW5wdXRFdmVudChmYXRUYXAoMCwgMCkp OworICAgIEVYUEVDVF9GQUxTRShjbGllbnQudHJpZ2dlcmVkKCkpOworCisgICAgY2xpZW50LnJl c2V0VHJpZ2dlcmVkKCk7CisgICAgd2ViVmlld0ltcGwtPmhhbmRsZUlucHV0RXZlbnQoZmF0VGFw KDIwMCwgMTE1KSk7CisgICAgRVhQRUNUX0ZBTFNFKGNsaWVudC50cmlnZ2VyZWQoKSk7CisKKyAg ICBmb3IgKGludCBpID0gMDsgaSA8PSA0NjsgaSsrKSB7CisgICAgICAgIGNsaWVudC5yZXNldFRy aWdnZXJlZCgpOworICAgICAgICB3ZWJWaWV3SW1wbC0+aGFuZGxlSW5wdXRFdmVudChmYXRUYXAo MTIwLCAyMzAgKyBpICogNSkpOworICAgICAgICBFWFBFQ1RfRkFMU0UoY2xpZW50LnRyaWdnZXJl ZCgpKTsKKyAgICB9CisKKyAgICBmb3IgKGludCBpID0gMDsgaSA8PSA0NjsgaSsrKSB7CisgICAg ICAgIGNsaWVudC5yZXNldFRyaWdnZXJlZCgpOworICAgICAgICB3ZWJWaWV3SW1wbC0+aGFuZGxl SW5wdXRFdmVudChmYXRUYXAoMTAgKyBpICogNSwgNTkwKSk7CisgICAgICAgIEVYUEVDVF9GQUxT RShjbGllbnQudHJpZ2dlcmVkKCkpOworICAgIH0KK30KKwogY2xhc3MgVGVzdFN1YnN0aXR1dGVE YXRhV2ViRnJhbWVDbGllbnQgOiBwdWJsaWMgV2ViRnJhbWVDbGllbnQgewogcHVibGljOgogICAg IFRlc3RTdWJzdGl0dXRlRGF0YVdlYkZyYW1lQ2xpZW50KCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vdGVzdHMvZGF0YS9kaXNhbWJpZ3VhdGlvbl9wb3B1cF9tb2JpbGVfc2l0ZS5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvZGF0YS9kaXNhbWJp Z3VhdGlvbl9wb3B1cF9tb2JpbGVfc2l0ZS5odG1sCShyZXZpc2lvbiAwKQorKysgU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9kYXRhL2Rpc2FtYmlndWF0aW9uX3BvcHVwX21vYmlsZV9zaXRl Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzEgQEAKKzxodG1sPgorPGhlYWQ+Cis8dGl0 bGU+RGlzYW1iaWd1YXRpb24gUG9wdXAgVGVzdDwvdGl0bGU+Cis8c3R5bGUgdHlwZT0idGV4dC9j c3MiPgorLmhvcml6b250YWwtbGluayB7CisgICAgZGlzcGxheTpibG9jazsKKyAgICB3aWR0aDoy MDBweDsKKyAgICBoZWlnaHQ6MzBweDsKKyAgICBtYXJnaW46MjBweDsKKyAgICBiYWNrZ3JvdW5k LWNvbG9yOiNjY2NjZmY7Cit9CisudmVydGljYWwtbGluayB7CisgICAgZGlzcGxheTppbmxpbmUt YmxvY2s7CisgICAgd2lkdGg6MzBweDsKKyAgICBoZWlnaHQ6MjAwcHg7CisgICAgbWFyZ2luOjEw cHg7CisgICAgYmFja2dyb3VuZC1jb2xvcjojY2NjY2ZmOworfQorPC9zdHlsZT4KKzxtZXRhIG5h bWU9InZpZXdwb3J0IiBjb250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgiPgorPC9oZWFkPgorPGJv ZHkgc3R5bGU9Im1hcmdpbjowcHg7Ij4KKzxhIGhyZWY9IiMiIGNsYXNzPSJob3Jpem9udGFsLWxp bmsiIHN0eWxlPSJtYXJnaW46MTAwcHgiPkxpbms8L2E+Cis8YSBocmVmPSIjIiBjbGFzcz0iaG9y aXpvbnRhbC1saW5rIj5MaW5rIDE8L2E+Cis8YSBocmVmPSIjIiBjbGFzcz0iaG9yaXpvbnRhbC1s aW5rIj5MaW5rIDI8L2E+Cis8YSBocmVmPSIjIiBjbGFzcz0iaG9yaXpvbnRhbC1saW5rIj5MaW5r IDM8L2E+Cis8YSBocmVmPSIjIiBjbGFzcz0iaG9yaXpvbnRhbC1saW5rIj5MaW5rIDQ8L2E+Cis8 YSBocmVmPSIjIiBjbGFzcz0iaG9yaXpvbnRhbC1saW5rIj5MaW5rIDU8L2E+Cis8YSBocmVmPSIj IiBjbGFzcz0idmVydGljYWwtbGluayI+TGluayAxPC9hPjxhIGhyZWY9IiMiIGNsYXNzPSJ2ZXJ0 aWNhbC1saW5rIj5MaW5rIDI8L2E+PGEgaHJlZj0iIyIgY2xhc3M9InZlcnRpY2FsLWxpbmsiPkxp bmsgMzwvYT48YSBocmVmPSIjIiBjbGFzcz0idmVydGljYWwtbGluayI+TGluayA0PC9hPjxhIGhy ZWY9IiMiIGNsYXNzPSJ2ZXJ0aWNhbC1saW5rIj5MaW5rIDU8L2E+Cis8L2JvZHk+Cis8L2h0bWw+ Cg==