107602 2013-01-22 17:23:22 -0800 HTMLTreeBuilder should not block on <script> tags inside templates 2022-08-17 04:48:10 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 154614 1 adamk adamk abarth ahmad.saleem792 apavlov bfulgham eric ojan.autocc rafaelw rniwa webkit.review.bot oldest_to_newest 813600 0 adamk 2013-01-22 17:23:22 -0800 Because the tree builder does block, the parser kicks off a preload scanner. And because the preload scanner starts _inside_ the template, it's not able to make use of its m_templateCount counter to ignore resources it finds inside the scanner. This is what was causing the failure noted in bug 106810. Since the tree builder knows it's in a template, it could simply avoid queueing an scripts inside the template for processing. But that might be somewhat ugly, since it requires the tree builder to "know" that scripts are inert in templates (currently that knowledge is handled at the ScriptElement level instead, by examining the <script>'s ownerDocument). 813601 1 adamk 2013-01-22 17:26:15 -0800 It's possible this bug should instead be titled "HTMLPreloadScanner should be able to handle starting inside a <template>"; the title depends somewhat on how this should be fixed, which is a question I pose to our resident parser experts, eseidel and abarth. 813603 2 abarth 2013-01-22 17:27:52 -0800 We're in the process of removing the HTMLPreloadScanner. We shouldn't spend too much effort polishing these issues in the old design. 813605 3 abarth 2013-01-22 17:29:20 -0800 (Maybe that argues for fixing this issue in the tree builder?) 814743 4 184330 adamk 2013-01-23 15:31:14 -0800 Created attachment 184330 WIP 814746 5 adamk 2013-01-23 15:32:39 -0800 The WIP patch here unfortunately takes the approach of messing with the preload scanner's logic rather than trying to fix things in the tree builder. My first attempt at that (which was simply to avoid setting m_scriptToProcess when in template contents) didn't work, as the script wouldn't run later when attached to the page. 1891922 6 ahmad.saleem792 2022-08-17 04:47:59 -0700 I don't think this patch landed (although code is different now): https://github.com/WebKit/WebKit/blob/e7be2359033b5a89111f70b799953e17421eeede/Source/WebCore/html/parser/HTMLDocumentParser.cpp#L291 https://github.com/WebKit/WebKit/blob/941eb3e0b2a0c171ead200aade992b31b7d84493/Source/WebCore/html/parser/HTMLTreeBuilder.h#L64 rniwa@webkit.org - Is this needed anymore? Thanks! 184330 2013-01-23 15:31:14 -0800 2013-01-23 15:31:14 -0800 WIP bug-107602-20130123152807.patch text/plain 6954 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFjNmRmMGQ5N2YyMTRj MDUxMzAyMTI1ZjlhMzY2MWU1YjdkMTYzYy4uM2IwNTQyZTMyOGU5NDY4ODI1MjQyMjI4YjRkMDU2 YTdjMjhjMmI0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAxLTIzICBBZGFt IEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEhUTUxUcmVlQnVpbGRlciBz aG91bGQgbm90IGJsb2NrIG9uIDxzY3JpcHQ+IHRhZ3MgaW5zaWRlIHRlbXBsYXRlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NjAyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0lQOiBEb24ndCBydW4g dGhlIHByZWxvYWQgc2Nhbm5lciBpZiB0aGUgdHJlZSBidWlsZGVyIGlzIHByb2Nlc3NpbmcKKyAg ICAgICAgdGVtcGxhdGUgY29udGVudHMsIHNpbmNlIGl0J3Mgbm90IGFjdHVhbGx5IGJsb2NrZWQg b24gYSBzY3JpcHQuCisgICAgICAgIFRoaXMgYXBwcm9hY2ggaXMgbWlzbGVhZGluZywgc2luY2Ug dGhlIHNjcmlwdCB3aWxsIGFjdHVhbGx5IG5vdCBydW4KKyAgICAgICAgd2hlbiBpdCdzIHByZXBh cmVkLCBidXQgdGhhdCBwcmVwYXJhdGlvbiBzdGFnZSBzZWVtcyB0byBiZSByZXF1aXJlZAorICAg ICAgICBmb3IgaXQgdG8gYmUgYWN0aXZhdGVkIGxhdGVyLi4uCisKKyAgICAgICAgKiBodG1sL3Bh cnNlci9IVE1MRG9jdW1lbnRQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTERvY3Vt ZW50UGFyc2VyOjpwdW1wVG9rZW5pemVyKToKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MVHJl ZUJ1aWxkZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6aXNQYXJzaW5n VGVtcGxhdGVDb250ZW50cyk6CisKIDIwMTMtMDEtMjIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gV2ViUHJvY2Vzc1NlcnZpY2UgaXMgbm90IHRl cm1pbmF0ZWQgd2hlbiBwYWdlIGlzIGNsb3NlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv cGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5jcHAKaW5kZXggNzRlNjRiYjZiZjk4ZDM0NjE3NGJl MjcyNTNkNzBlZGRhMWQ1ZmQwYi4uYzk2YzU0NjdkMWJhOTk2YjVlMTVhNTMxMjZjNmI0MGE1MTg0 NjM3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50 UGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MRG9jdW1lbnRQ YXJzZXIuY3BwCkBAIC0zNjIsNyArMzYyLDExIEBAIHZvaWQgSFRNTERvY3VtZW50UGFyc2VyOjpw dW1wVG9rZW5pemVyKFN5bmNocm9ub3VzTW9kZSBtb2RlKQogICAgIGlmIChzZXNzaW9uLm5lZWRz WWllbGQpCiAgICAgICAgIG1fcGFyc2VyU2NoZWR1bGVyLT5zY2hlZHVsZUZvclJlc3VtZSgpOwog CisjaWYgRU5BQkxFKFRFTVBMQVRFX0VMRU1FTlQpCisgICAgaWYgKGlzV2FpdGluZ0ZvclNjcmlw dHMoKSAmJiAhbV90cmVlQnVpbGRlci0+aXNQYXJzaW5nVGVtcGxhdGVDb250ZW50cygpKSB7Cisj ZWxzZQogICAgIGlmIChpc1dhaXRpbmdGb3JTY3JpcHRzKCkpIHsKKyNlbmRpZgogICAgICAgICBB U1NFUlQobV90b2tlbml6ZXItPnN0YXRlKCkgPT0gSFRNTFRva2VuaXplclN0YXRlOjpEYXRhU3Rh dGUpOwogICAgICAgICBpZiAoIW1fcHJlbG9hZFNjYW5uZXIpIHsKICAgICAgICAgICAgIG1fcHJl bG9hZFNjYW5uZXIgPSBhZG9wdFB0cihuZXcgSFRNTFByZWxvYWRTY2FubmVyKGRvY3VtZW50KCks IG1fb3B0aW9ucykpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRN TFRyZWVCdWlsZGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxk ZXIuaAppbmRleCA0N2UxZDgyNWY1ZDU4MzEwNjlhMDcyMWE1MDAyZWYzOTAwOGM2MGM2Li42N2Y5 MGZmMDQ3NDdkMWYwZDRlZTZiNDhlZWI0M2RmYmNmMWU5YWYxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuaApAQCAtNzAsNyArNzAsNyBAQCBwdWJsaWM6 CiAKICAgICBib29sIGlzUGFyc2luZ0ZyYWdtZW50KCkgY29uc3QgeyByZXR1cm4gISFtX2ZyYWdt ZW50Q29udGV4dC5mcmFnbWVudCgpOyB9CiAjaWYgRU5BQkxFKFRFTVBMQVRFX0VMRU1FTlQpCi0g ICAgYm9vbCBpc1BhcnNpbmdUZW1wbGF0ZUNvbnRlbnRzKCkgY29uc3QgeyByZXR1cm4gbV90cmVl Lm9wZW5FbGVtZW50cygpLT5oYXNUZW1wbGF0ZUluSFRNTFNjb3BlKCk7IH0KKyAgICBib29sIGlz UGFyc2luZ1RlbXBsYXRlQ29udGVudHMoKSBjb25zdCB7IHJldHVybiAhbV90ZW1wbGF0ZUluc2Vy dGlvbk1vZGVzLmlzRW1wdHkoKTsgfQogICAgIGJvb2wgaXNQYXJzaW5nRnJhZ21lbnRPclRlbXBs YXRlQ29udGVudHMoKSBjb25zdCB7IHJldHVybiBpc1BhcnNpbmdGcmFnbWVudCgpIHx8IGlzUGFy c2luZ1RlbXBsYXRlQ29udGVudHMoKTsgfQogI2Vsc2UKICAgICBib29sIGlzUGFyc2luZ0ZyYWdt ZW50T3JUZW1wbGF0ZUNvbnRlbnRzKCkgY29uc3QgeyByZXR1cm4gaXNQYXJzaW5nRnJhZ21lbnQo KTsgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCmluZGV4IDQ4MzRlNWQ2ZGEyY2ExNThmNWY0ZDYwZDVhZGFiNjYxMWY4NDBiZTAuLjhj ZWQyNGY2YTJmNzU0MDA0NTgyNzYzNDYyMTZmNjA2NDIzYTE0YjggMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAxMy0wMS0yMyAgQWRhbSBLbGVpbiAgPGFkYW1rQGNocm9taXVtLm9yZz4KKworICAg ICAgICBIVE1MVHJlZUJ1aWxkZXIgc2hvdWxkIG5vdCBibG9jayBvbiA8c2NyaXB0PiB0YWdzIGlu c2lkZSB0ZW1wbGF0ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNzYwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlc3RvcmUgPGltZz4gdG8gdGVzdCBjYXNlIHRvIGV4ZXJjaXNlIHByZWxvYWQgc2Nh bm5lciBsb2dpYy4KKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxUZW1wbGF0ZUVsZW1lbnQvaW5l cnRDb250ZW50cy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9kb20vSFRNTFRlbXBsYXRl RWxlbWVudC9pbmVydENvbnRlbnRzLmh0bWw6CisKIDIwMTMtMDEtMjIgIEp1bGllbiBDaGFmZnJh aXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0NTUyBHcmlkIExheW91dF0g QWRkIGdyaWQuY3NzIHRvIGhvbGQgdGhlIGNvbW1vbiBncmlkIHRlc3RpbmcgY29kZQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFRlbXBsYXRlRWxlbWVudC9pbmVydENvbnRl bnRzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxUZW1wbGF0ZUVsZW1l bnQvaW5lcnRDb250ZW50cy1leHBlY3RlZC50eHQKaW5kZXggOGQ5NTRiMDcyYjRiNmY4M2FmYzNh YmI4Njg1MGU0ZDAyMjMwOGQ1Yi4uODgxM2M1MzY4MWE2ZjZiYzkyYWIxNDQ3Yjk0ZDBiN2NlNWI5 OGNlMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFRlbXBsYXRlRWxlbWVu dC9pbmVydENvbnRlbnRzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9I VE1MVGVtcGxhdGVFbGVtZW50L2luZXJ0Q29udGVudHMtZXhwZWN0ZWQudHh0CkBAIC0xLDExICsx LDcgQEAKLVRoZSB0ZXN0IGFzc2VydHMgdGhhdCBlbGVtZW50cyB3aXRoaW4gdGVtcGxhdGUgY29u dGVudHMgYXJlICJpbmVydCIsIGUuZy4gc2NyaXB0IGRvZXMgbm90IHJ1bi4KK2h0dHA6Ly9mb28u Y29tL3Nob3VsZExvYWQuanBnIC0gd2lsbFNlbmRSZXF1ZXN0IDxOU1VSTFJlcXVlc3QgVVJMIGh0 dHA6Ly9mb28uY29tL3Nob3VsZExvYWQuanBnLCBtYWluIGRvY3VtZW50IFVSTCBpbmVydENvbnRl bnRzLmh0bWwsIGh0dHAgbWV0aG9kIEdFVD4gcmVkaXJlY3RSZXNwb25zZSAobnVsbCkKK0Jsb2Nr ZWQgYWNjZXNzIHRvIGV4dGVybmFsIFVSTCBodHRwOi8vZm9vLmNvbS9zaG91bGRMb2FkLmpwZwor aHR0cDovL2Zvby5jb20vc2hvdWxkTG9hZC5qcGcgLSBkaWRGYWlsTG9hZGluZ1dpdGhFcnJvcjog PE5TRXJyb3IgZG9tYWluIE5TVVJMRXJyb3JEb21haW4sIGNvZGUgLTk5OSwgZmFpbGluZyBVUkwg IihudWxsKSI+CitUaGUgdGVzdCBhc3NlcnRzIHRoYXQgZWxlbWVudHMgd2l0aGluIHRlbXBsYXRl IGNvbnRlbnRzIGFyZSAiaW5lcnQiLCBlLmcuIHJlc291cmNlcyBkbyBub3QgZmV0Y2gsIHNjcmlw dCBkb2VzIG5vdCBydW4uCiAKLU9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAi UEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KLQotCi1QQVNTIHRl c3RWYWwgaXMgInNjcmlwdCBoYXMgbm90IHJ1biIKLVBBU1MgdGVzdFZhbCBpcyAic2NyaXB0IGhh cyBydW4iCi1QQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCi0KLVRFU1QgQ09NUExFVEUK K0JlZm9yZSB0ZW1wbGF0ZSBjb250ZW50IGluc2VydGlvbjogc2NyaXB0IGRpZCBub3QgcnVuLCBh ZnRlciB0ZW1wbGF0ZSBjb250ZW50IGluc2VydGlvbjogc2NyaXB0IGRpZCBydW4uCiAKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxUZW1wbGF0ZUVsZW1lbnQvaW5lcnRDb250 ZW50cy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFRlbXBsYXRlRWxlbWVudC9pbmVy dENvbnRlbnRzLmh0bWwKaW5kZXggNDViZDk1NDMzOWQ1ZmRhNGNlZWUyYWE0MjA4MDZlMTEyMDMx NjM5OC4uODhjYWJmNTI5ODM1MTc1YWYwOTVmNTg2OGNiMWNhZTVlZDFkMmI5MCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFRlbXBsYXRlRWxlbWVudC9pbmVydENvbnRlbnRz Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFRlbXBsYXRlRWxlbWVudC9pbmVy dENvbnRlbnRzLmh0bWwKQEAgLTEsMTcgKzEsMjkgQEAKLTwhRE9DVFlQRSBodG1sPgogPGJvZHk+ Ci08c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Njcmlw dD4KKzxwPlRoZSB0ZXN0IGFzc2VydHMgdGhhdCBlbGVtZW50cyB3aXRoaW4gdGVtcGxhdGUgY29u dGVudHMgYXJlICJpbmVydCIsIGUuZy4gcmVzb3VyY2VzIGRvIG5vdCBmZXRjaCwgc2NyaXB0IGRv ZXMgbm90IHJ1bi48L3A+Cis8dGVtcGxhdGUgaWQ9InRlbXBsYXRlIj48c2NyaXB0PndpbmRvdy50 ZXN0VmFsID0gInNjcmlwdCBkaWQgcnVuIjs8L3NjcmlwdD48aW1nIHNyYz0iaHR0cDovL2Zvby5j b20vc2hvdWxkTm90TG9hZC5qcGciPjwvdGVtcGxhdGU+Cis8ZGl2IGlkPSJvdXRwdXQiPgorPC9k aXY+CisKIDxzY3JpcHQ+Ci12YXIgdGVzdFZhbCA9ICdzY3JpcHQgaGFzIG5vdCBydW4nOwordmFy IHRlc3RWYWwgPSAic2NyaXB0IGRpZCBub3QgcnVuIjsKKword2luZG93Lm9ubG9hZCA9IGZ1bmN0 aW9uKCkgeworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAgICB0ZXN0UnVubmVy LmR1bXBBc1RleHQoKTsKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wUmVzb3VyY2VMb2FkQ2FsbGJh Y2tzKCk7CisgICAgfQorCisgICAgdmFyIG91dHB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdvdXRwdXQnKTsKKyAgICBvdXRwdXQuaW5uZXJIVE1MID0gJ0JlZm9yZSB0ZW1wbGF0ZSBjb250 ZW50IGluc2VydGlvbjogJyArIHRlc3RWYWw7CisgICAgCisgICAgdmFyIHRlbXBsYXRlQ29udGVu dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZW1wbGF0ZScpLmNvbnRlbnQ7CisgICAgdmFy IGltZyA9IHRlbXBsYXRlQ29udGVudC5jaGlsZE5vZGVzWzFdOworICAgIGltZy5zcmMgPSAiaHR0 cDovL2Zvby5jb20vc2hvdWxkTG9hZC5qcGciOworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hp bGQodGVtcGxhdGVDb250ZW50KTsKKworICAgIG91dHB1dC5pbm5lckhUTUwgKz0gJywgYWZ0ZXIg dGVtcGxhdGUgY29udGVudCBpbnNlcnRpb246ICcgKyB0ZXN0VmFsICsgJy4nOworfQogPC9zY3Jp cHQ+Ci08IS0tIEZJWE1FOiBBZGQgbm9uLWZsYWt5IHRlc3QgZm9yIDxpbWc+IHRhZ3MgLS0+Ci08 dGVtcGxhdGU+PHNjcmlwdD53aW5kb3cudGVzdFZhbCA9ICdzY3JpcHQgaGFzIHJ1bic7PC9zY3Jp cHQ+PC90ZW1wbGF0ZT4KLTxzY3JpcHQ+Ci1kZXNjcmlwdGlvbignVGhlIHRlc3QgYXNzZXJ0cyB0 aGF0IGVsZW1lbnRzIHdpdGhpbiB0ZW1wbGF0ZSBjb250ZW50cyBhcmUgImluZXJ0IiwgZS5nLiBz Y3JpcHQgZG9lcyBub3QgcnVuLicpOwotc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCd0ZXN0VmFsJywg J3NjcmlwdCBoYXMgbm90IHJ1bicpOwotdmFyIHRlbXBsYXRlQ29udGVudCA9IGRvY3VtZW50LnF1 ZXJ5U2VsZWN0b3IoJ3RlbXBsYXRlJykuY29udGVudDsKLWRvY3VtZW50LmJvZHkuYXBwZW5kQ2hp bGQodGVtcGxhdGVDb250ZW50KTsKLXNob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdFZhbCcsICdz Y3JpcHQgaGFzIHJ1bicpOwotPC9zY3JpcHQ+Ci08c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3Vy Y2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KIDwvYm9keT4K