107596 2013-01-22 15:36:53 -0800 Fix assertions in make8BitFrom16BitSource() with threaded parser 2013-01-22 16:24:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106127 1 tonyg tonyg ojan.autocc webkit.review.bot oldest_to_newest 813484 0 tonyg 2013-01-22 15:36:53 -0800 Fix assertions in make8BitFrom16BitSource() with threaded parser 813487 1 184062 tonyg 2013-01-22 15:38:06 -0800 Created attachment 184062 Patch 813508 2 184062 abarth 2013-01-22 16:01:17 -0800 Comment on attachment 184062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184062&action=review > Source/WebCore/html/parser/HTMLToken.h:245 > m_externalCharacters = token.data().characters(); > m_externalCharactersLength = token.data().length(); > + m_isAll8BitData = token.isAll8BitData(); This change is fine, but I think we'll need to rethink this "external characters" design as part of this work. 813517 3 184062 webkit.review.bot 2013-01-22 16:08:04 -0800 Comment on attachment 184062 Patch Clearing flags on attachment: 184062 Committed r140485: <http://trac.webkit.org/changeset/140485> 813518 4 webkit.review.bot 2013-01-22 16:08:07 -0800 All reviewed patches have been landed. Closing bug. 813530 5 184062 eric 2013-01-22 16:24:12 -0800 Comment on attachment 184062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184062&action=review >> Source/WebCore/html/parser/HTMLToken.h:245 >> + m_isAll8BitData = token.isAll8BitData(); > > This change is fine, but I think we'll need to rethink this "external characters" design as part of this work. Agreed. 184062 2013-01-22 15:38:06 -0800 2013-01-22 16:24:12 -0800 Patch bug-107596-20130122153500.patch text/plain 4013 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzYxODUxNTk4YzIzN2Zh YmRiMTcxODE5ODA0NjdkNzNhZDI4YmQ5MS4uMDdjOTBjZWJiNDk4ZTQ4ZTA1ZGJlZDE2OWI1Zjlh NjNkNTkwNDM5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAxLTIyICBUb255 IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4IGFzc2VydGlv bnMgaW4gbWFrZThCaXRGcm9tMTZCaXRTb3VyY2UoKSB3aXRoIHRocmVhZGVkIHBhcnNlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NTk2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBmaXhlcyBh biBhc3NlcnRpb24gaW4gc2V2ZXJhbCBmYXN0L3BhcnNlciB0ZXN0cy4gV2UgbmVlZCB0byBrZWVw IHRyYWNrIG9mIHdoZXRoZXIgdGhlIGRhdGEgaXMgYWxsIDhiaXQuCisgICAgICAgIEx1Y2tpbHkg dGhpcyBkb2Vzbid0IGNvc3QgdXMgYW55IHNpemUgb24gQ29tcGFjdEhUTUxUb2tlbiBiZWNhdXNl IHRoZSBiaXRmaWVsZHMgYXJlIGNvbGxhcHNlZCAodmVyaWZpZWQgYnkgQ09NUElMRV9BU1NFUlQp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIGNvdmVyZWQgYnkgZXhpc3RpbmcgZmFz dC9wYXJzZXIgdGVzdHMuCisKKyAgICAgICAgKiBodG1sL3BhcnNlci9Db21wYWN0SFRNTFRva2Vu LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBhY3RIVE1MVG9rZW46OkNvbXBhY3RIVE1MVG9r ZW4pOgorICAgICAgICAqIGh0bWwvcGFyc2VyL0NvbXBhY3RIVE1MVG9rZW4uaDoKKyAgICAgICAg KFdlYkNvcmU6OkNvbXBhY3RIVE1MVG9rZW46OmlzQWxsOEJpdERhdGEpOgorICAgICAgICAoQ29t cGFjdEhUTUxUb2tlbik6CisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTFRva2VuLmg6CisgICAg ICAgIChXZWJDb3JlOjpBdG9taWNIVE1MVG9rZW46OkF0b21pY0hUTUxUb2tlbik6CisKIDIwMTMt MDEtMjIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBUaGUgQmFj a2dyb3VuZEhUTUxQYXJzZXIgc2hvdWxkbid0IHBhdXNlIHdoZW4gd2FpdGluZyBmb3Igc2NyaXB0 cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvQ29tcGFjdEhUTUxUb2tl bi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9Db21wYWN0SFRNTFRva2VuLmNwcApp bmRleCA0Mzc0Yzc4NzE3MGI2NGJiMGUzY2Y4M2Y4MDUzMmVmNDNiYmQ3ZjI5Li5iNWQ2ZmYxYjQ0 OTczZDUyZWZkNzcwYzBlMDZiNjc0ZWM5NmRlNDgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL3BhcnNlci9Db21wYWN0SFRNTFRva2VuLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9Db21wYWN0SFRNTFRva2VuLmNwcApAQCAtNDQsNiArNDQsNyBAQCBDT01QSUxF X0FTU0VSVChzaXplb2YoQ29tcGFjdEhUTUxUb2tlbikgPT0gc2l6ZW9mKFNhbWVTaXplQXNDb21w YWN0SFRNTFRva2VuKSwgQwogCiBDb21wYWN0SFRNTFRva2VuOjpDb21wYWN0SFRNTFRva2VuKGNv bnN0IEhUTUxUb2tlbiYgdG9rZW4sIGNvbnN0IFRleHRQb3NpdGlvbiYgdGV4dFBvc2l0aW9uKQog ICAgIDogbV90eXBlKHRva2VuLnR5cGUoKSkKKyAgICAsIG1faXNBbGw4Qml0RGF0YShmYWxzZSkK ICAgICAsIG1fdGV4dFBvc2l0aW9uKHRleHRQb3NpdGlvbikKIHsKICAgICBzd2l0Y2ggKG1fdHlw ZSkgewpAQCAtNzEsOSArNzIsMTAgQEAgQ29tcGFjdEhUTUxUb2tlbjo6Q29tcGFjdEhUTUxUb2tl bihjb25zdCBIVE1MVG9rZW4mIHRva2VuLCBjb25zdCBUZXh0UG9zaXRpb24mIHQKICAgICAgICAg Ly8gRmFsbCB0aHJvdWdoIQogICAgIGNhc2UgSFRNTFRva2VuVHlwZXM6OkNvbW1lbnQ6CiAgICAg Y2FzZSBIVE1MVG9rZW5UeXBlczo6Q2hhcmFjdGVyOgotICAgICAgICBpZiAodG9rZW4uaXNBbGw4 Qml0RGF0YSgpKQorICAgICAgICBpZiAodG9rZW4uaXNBbGw4Qml0RGF0YSgpKSB7CiAgICAgICAg ICAgICBtX2RhdGEgPSBTdHJpbmc6Om1ha2U4Qml0RnJvbTE2Qml0U291cmNlKHRva2VuLmRhdGEo KS5kYXRhKCksIHRva2VuLmRhdGEoKS5zaXplKCkpOwotICAgICAgICBlbHNlCisgICAgICAgICAg ICBtX2lzQWxsOEJpdERhdGEgPSB0cnVlOworICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIG1f ZGF0YSA9IFN0cmluZyh0b2tlbi5kYXRhKCkuZGF0YSgpLCB0b2tlbi5kYXRhKCkuc2l6ZSgpKTsK ICAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvcGFyc2VyL0NvbXBhY3RIVE1MVG9rZW4uaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFy c2VyL0NvbXBhY3RIVE1MVG9rZW4uaAppbmRleCA0YjY0YWY3OGI3NjRhOGQ3MzRhYmFkYjYxYzBm YTRmNzMzZmVlM2NmLi5jM2VmYzJhOGZiYjMzNzZkZTBmNWEzNzEzMGVlMTk4YzFlZTY3YTg4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9Db21wYWN0SFRNTFRva2VuLmgK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvQ29tcGFjdEhUTUxUb2tlbi5oCkBAIC02 NCw2ICs2NCw3IEBAIHB1YmxpYzoKICAgICBIVE1MVG9rZW5UeXBlczo6VHlwZSB0eXBlKCkgY29u c3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8SFRNTFRva2VuVHlwZXM6OlR5cGU+KG1fdHlwZSk7IH0K ICAgICBjb25zdCBTdHJpbmcmIGRhdGEoKSBjb25zdCB7IHJldHVybiBtX2RhdGE7IH0KICAgICBi b29sIHNlbGZDbG9zaW5nKCkgY29uc3QgeyByZXR1cm4gbV9zZWxmQ2xvc2luZzsgfQorICAgIGJv b2wgaXNBbGw4Qml0RGF0YSgpIGNvbnN0IHsgcmV0dXJuIG1faXNBbGw4Qml0RGF0YTsgfQogICAg IGNvbnN0IFZlY3RvcjxDb21wYWN0QXR0cmlidXRlPiYgYXR0cmlidXRlcygpIGNvbnN0IHsgcmV0 dXJuIG1fYXR0cmlidXRlczsgfQogICAgIGNvbnN0IFRleHRQb3NpdGlvbiYgdGV4dFBvc2l0aW9u KCkgY29uc3QgeyByZXR1cm4gbV90ZXh0UG9zaXRpb247IH0KIApAQCAtNzUsNiArNzYsNyBAQCBw dWJsaWM6CiBwcml2YXRlOgogICAgIHVuc2lnbmVkIG1fdHlwZSA6IDQ7CiAgICAgdW5zaWduZWQg bV9zZWxmQ2xvc2luZyA6IDE7CisgICAgdW5zaWduZWQgbV9pc0FsbDhCaXREYXRhIDogMTsKIAog ICAgIFN0cmluZyBtX2RhdGE7IC8vICJuYW1lIiwgImNoYXJhY3RlcnMiLCBvciAiZGF0YSIgZGVw ZW5kaW5nIG9uIG1fdHlwZQogICAgIFZlY3RvcjxDb21wYWN0QXR0cmlidXRlPiBtX2F0dHJpYnV0 ZXM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVG9rZW4uaCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUb2tlbi5oCmluZGV4IGZiNGE4NWYyY2Zh ODZiOTA5NDAxN2NlODdmYzE5MjYwZGEwNGM2MTcuLjVlMTIyMmVkMjIwOGRmOTM1YWYyZDAwOWQx NjhhYmZkZmU1MmNmOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hU TUxUb2tlbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUb2tlbi5oCkBA IC0yNDIsNiArMjQyLDcgQEAgcHJpdmF0ZToKICAgICAgICAgY2FzZSBIVE1MVG9rZW5UeXBlczo6 Q2hhcmFjdGVyOgogICAgICAgICAgICAgbV9leHRlcm5hbENoYXJhY3RlcnMgPSB0b2tlbi5kYXRh KCkuY2hhcmFjdGVycygpOwogICAgICAgICAgICAgbV9leHRlcm5hbENoYXJhY3RlcnNMZW5ndGgg PSB0b2tlbi5kYXRhKCkubGVuZ3RoKCk7CisgICAgICAgICAgICBtX2lzQWxsOEJpdERhdGEgPSB0 b2tlbi5pc0FsbDhCaXREYXRhKCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgZGVmYXVs dDoKICAgICAgICAgICAgIGJyZWFrOwo=