10759 2006-09-06 12:11:39 -0700 fast/AppleScript/array.html test failing 2006-09-09 03:48:23 -0700 1 1 1 Unclassified WebKit WebKit API 420+ Mac OS X 10.4 RESOLVED FIXED http://build.webkit.org/results/post-commit-powerpc-mac-os-x/3197/fast/AppleScript/array-diffs.txt P2 Normal --- 1 ap ap timothy oldest_to_newest 54911 0 ap 2006-09-06 12:11:39 -0700 I don't understand why, but DRT has started printing a zero array element as " 0e+0" in this test. As stupid as it sounds, it's as if [aeDesc stringValue] has suddenly changed its behavior. I don't have a real explanation. The attached patch works around this by modifying the conversion itself - now integer values are encoded as typeSInt32, rather than typeIEEE64BitFloatingPoint. This has a certain unfortunate "surprise" potential, as the type now depends on the value, but built-in AE type conversion should make this mostly transparent, I hope. 54914 1 10422 ap 2006-09-06 12:14:51 -0700 Created attachment 10422 proposed patch 55063 2 10422 darin 2006-09-08 09:57:11 -0700 Comment on attachment 10422 proposed patch r=me 55103 3 ap 2006-09-09 03:48:23 -0700 Committed revision 16274. (In reply to comment #0) > I don't have a real explanation. I have tried reverting to an older revision, and the behavior was the same. I guess I just made a last-minute change to the DRT output, and didn't re-run the tests (bad!). 10422 2006-09-06 12:14:51 -0700 2006-09-08 09:57:11 -0700 proposed patch 10759r1_patch.txt text/plain 3023 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE2MjUyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDYtMDktMDYgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBueXBvcC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDc1OQorICAgICAgICBmYXN0L0FwcGxlU2NyaXB0L2FycmF5Lmh0bWwgdGVzdCBmYWlsaW5n CisKKyAgICAgICAgKiBmYXN0L0FwcGxlU2NyaXB0LzAwMS1leHBlY3RlZC50eHQ6IFVwZGF0ZWQg cmVzdWx0cy4KKwogMjAwNi0wOS0wNSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9BcHBs ZVNjcmlwdC8wMDEtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv QXBwbGVTY3JpcHQvMDAxLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTYyNTApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L0FwcGxlU2NyaXB0LzAwMS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAg LTEsOCArMSw4IEBACiBFRElUSU5HIERFTEVHQVRFOiBzaG91bGRDaGFuZ2VTZWxlY3RlZERPTVJh bmdlOihudWxsKSB0b0RPTVJhbmdlOnJhbmdlIGZyb20gMSBvZiAjdGV4dCA+IEJPRFkgPiBIVE1M ID4gI2RvY3VtZW50IHRvIDY1IG9mICN0ZXh0ID4gQk9EWSA+IEhUTUwgPiAjZG9jdW1lbnQgYWZm aW5pdHk6TlNTZWxlY3Rpb25BZmZpbml0eURvd25zdHJlYW0gc3RpbGxTZWxlY3Rpbmc6RkFMU0UK IEVESVRJTkcgREVMRUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb246V2ViVmlld0RpZENo YW5nZVNlbGVjdGlvbk5vdGlmaWNhdGlvbgogQW4gYXV0b21hdGVkIHRlc3QgZm9yIGJhc2ljIEFw cGxlU2NyaXB0ICJkbyBKYXZhU2NyaXB0IiBzdXBwb3J0LgotNCAoJ2RvdWInKQotNCAoJ2RvdWIn KQorNCAoJ2xvbmcnKQorNCAoJ2xvbmcnKQogMC42NjY2NjY2NjY2NjY2NjY2ICgnZG91YicpCiAw LjY2NjY2NjY2NjY2NjY2NjYgKCdkb3ViJykKIElORiAoJ2RvdWInKQpJbmRleDogV2ViQ29yZS9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjUy KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAor MjAwNi0wOS0wNiAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQG55cG9wLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGh0dHA6Ly9idWd6aWxs YS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NTkKKyAgICAgICAgICBmYXN0L0Fw cGxlU2NyaXB0L2FycmF5Lmh0bWwgdGVzdCBmYWlsaW5nCisKKyAgICAgICAgKiBicmlkZ2UvbWFj L1dlYkNvcmVGcmFtZUJyaWRnZS5tbToKKyAgICAgICAgKGFlRGVzY0Zyb21KU1ZhbHVlKTogQ29u dmVydCBpbnRlZ2VyIHZhbHVlcyB0byB0eXBlU0ludDMyIEFFIGRlc2NyaXB0b3JzLgorCiAyMDA2 LTA5LTA2ICBEYXZpZCBIYXJyaXNvbiAgPGhhcnJpc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBhbmQgdHdlYWtlZCBieSBUaW0gSC4KSW5kZXg6IFdlYkNvcmUvYnJpZGdlL21hYy9X ZWJDb3JlRnJhbWVCcmlkZ2UubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9icmlkZ2UvbWFjL1dl YkNvcmVGcmFtZUJyaWRnZS5tbQkocmV2aXNpb24gMTYyNTApCisrKyBXZWJDb3JlL2JyaWRnZS9t YWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNzEsOCArMTcxLDEy IEBAIHN0YXRpYyBOU0FwcGxlRXZlbnREZXNjcmlwdG9yKiBhZURlc2NGcm8KICAgICAgICAgICAg IGFlRGVzYyA9IFtOU0FwcGxlRXZlbnREZXNjcmlwdG9yIGRlc2NyaXB0b3JXaXRoU3RyaW5nOlN0 cmluZyhqc1ZhbHVlLT5nZXRTdHJpbmcoKSldOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg IGNhc2UgTnVtYmVyVHlwZTogewotICAgICAgICAgICAgRmxvYXQ2NCB2YWx1ZSA9IGpzVmFsdWUt PmdldE51bWJlcigpOwotICAgICAgICAgICAgYWVEZXNjID0gW05TQXBwbGVFdmVudERlc2NyaXB0 b3IgZGVzY3JpcHRvcldpdGhEZXNjcmlwdG9yVHlwZTp0eXBlSUVFRTY0Qml0RmxvYXRpbmdQb2lu dCBieXRlczomdmFsdWUgbGVuZ3RoOnNpemVvZih2YWx1ZSldOworICAgICAgICAgICAgZG91Ymxl IHZhbHVlID0ganNWYWx1ZS0+Z2V0TnVtYmVyKCk7CisgICAgICAgICAgICBpbnQgaW50VmFsdWUg PSAoaW50KXZhbHVlOworICAgICAgICAgICAgaWYgKHZhbHVlID09IGludFZhbHVlKQorICAgICAg ICAgICAgICAgIGFlRGVzYyA9IFtOU0FwcGxlRXZlbnREZXNjcmlwdG9yIGRlc2NyaXB0b3JXaXRo RGVzY3JpcHRvclR5cGU6dHlwZVNJbnQzMiBieXRlczomaW50VmFsdWUgbGVuZ3RoOnNpemVvZihp bnRWYWx1ZSldOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIGFlRGVzYyA9IFtO U0FwcGxlRXZlbnREZXNjcmlwdG9yIGRlc2NyaXB0b3JXaXRoRGVzY3JpcHRvclR5cGU6dHlwZUlF RUU2NEJpdEZsb2F0aW5nUG9pbnQgYnl0ZXM6JnZhbHVlIGxlbmd0aDpzaXplb2YodmFsdWUpXTsK ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGNhc2UgT2JqZWN0VHlwZTog ewo=