107582 2013-01-22 13:30:56 -0800 IndexedDB: IDBKeyRange::isOnlyKey() does pointer equality comparison 2013-02-01 10:04:35 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jsbell jsbell alecflett dgrogan michael tony webkit.review.bot oldest_to_newest 813370 0 jsbell 2013-01-22 13:30:56 -0800 To simplify the backend API, various methods that can take a key-or-keyrange just accept a keyrange, and we map a script call with just a key to IDBKeyRange::only(key). On the back end, optimized paths can check keyrange->isOnlyKey() IDBKeyRange::isOnlyKey() does pointer equality comparison, so if there are IPC hijinks between the front- and back-end (e.g. in multiprocess ports) that don't pass along this flag, the equality comparison would fail and the unoptimized path would be used. It looks like the only caller is in GetOperation::perform() in IDBDatabaseBackendImpl.cpp A trivial fix would be to replace the equality test with: !m_lower->compare(m_upper) 820563 1 185573 jsbell 2013-01-30 14:25:40 -0800 Created attachment 185573 Patch 820564 2 jsbell 2013-01-30 14:26:02 -0800 alecflett@ - can you take a look? 820568 3 alecflett 2013-01-30 14:28:57 -0800 nice. lgtm 820583 4 jsbell 2013-01-30 14:33:53 -0800 tony@ - r? 820695 5 185573 webkit.review.bot 2013-01-30 15:32:07 -0800 Comment on attachment 185573 Patch Rejecting attachment 185573 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 185573, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13482 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 53>At revision 13482. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/16183937 820705 6 185573 jsbell 2013-01-30 15:34:33 -0800 Comment on attachment 185573 Patch "Merge conflict during commit: Conflict at '/trunk/Source/WebCore/ChangeLog' at /usr/lib/git-core/git-svn line 570" Just giving it another try. 820776 7 185573 webkit.review.bot 2013-01-30 16:27:13 -0800 Comment on attachment 185573 Patch Clearing flags on attachment: 185573 Committed r141338: <http://trac.webkit.org/changeset/141338> 820778 8 webkit.review.bot 2013-01-30 16:27:16 -0800 All reviewed patches have been landed. Closing bug. 822908 9 jsbell 2013-02-01 10:04:35 -0800 And for the record, this graph shows the associated perf boost pretty well: http://build.chromium.org/f/chromium/perf/chromium-rel-win7-dual/idb_perf/report.html?history=150&rev=180143&graph=testReadCache_50_true 185573 2013-01-30 14:25:40 -0800 2013-01-30 16:27:12 -0800 Patch bug-107582-20130130142225.patch text/plain 5611 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODNjZGNhNDg0NDI3MjFl MzAxNTVlMmM3NjgyZjczZTZiODcwZWJhMi4uN2NjYzEyZjNjZGVjYmUwZmYxODA1NmQ3NDk5M2Nk OTRlMzA3NGY2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDEzLTAxLTMwICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBJREJL ZXlSYW5nZTo6aXNPbmx5S2V5KCkgZG9lcyBwb2ludGVyIGVxdWFsaXR5IGNvbXBhcmlzb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzU4MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBlciB0aGUgYnVn IHRpdGxlLCBJREJLZXlSYW5nZTo6aXNPbmx5S2V5KCkgd2FzIHRlc3RpbmcgdGhlIHVwcGVyL2xv d2VyIHBvaW50ZXJzIHRvCisgICAgICAgIGRldGVybWluZSBpZiB0aGlzIHdhcyBhICJ0cml2aWFs IiByYW5nZSwgd2hpY2ggY2FuIGJlIHVzZWQgdG8gZmFzdC1wYXRoIGxvb2t1cHMuIFRoaXMKKyAg ICAgICAgaXMgaW5zdWZmaWNpZW50IGluIG11bHRpLXByb2Nlc3MgcG9ydHMgd2hlcmUgcmFuZ2Ug dmFsdWVzIG1heSBiZSB0aHJvd24gYWNyb3NzIHRoZSB3aXJlLgorICAgICAgICBUaGlzIGlzIGFk ZHJlc3NlZCBieSB1c2luZyB0aGUgZXhpc3Rpbmcga2V5IGVxdWFsaXR5IHRlc3RzLgorCisgICAg ICAgIEluIGFkZGl0aW9uLCB0aGUgYm91bmRzIHR5cGUgY2hlY2sgaW5jb3JyZWN0bHkgY2hlY2tl ZCBtX2xvd2VyVHlwZSA9PSBMb3dlckJvdW5kT3Blbiwgd2hpY2gKKyAgICAgICAgbWVhbnQgdGhl IGZ1bmN0aW9uIGNvdWxkIG5ldmVyIHJldHVybiB0cnVlIChzaW5jZSB1cHBlciA9PSBsb3dlciBp bXBsaWVzIGNsb3NlZCBib3VuZHMpLgorICAgICAgICBUaGVyZWZvcmUsIHRoZSBmYXN0LXBhdGgg Y2FzZSB3YXNuJ3QgdXNlZCBldmVuIGluIHNpbmdsZS1wcm9jZXNzIHBvcnRzIChlLmcuIERSVCku IFRoZQorICAgICAgICBzbG93LXBhdGggY2FzZSBjb250cnVjdGVkIGEgYmFja2luZyBzdG9yZSBj dXJzb3Igb3ZlciB0aGUgcmFuZ2UsIGFuZCBleGl0ZWQgZWFybHkgaWYgdGhlCisgICAgICAgIGN1 cnNvciB5aWVsZGVkIG5vdGhpbmcuIFRoZSBmYXN0LXBhdGggY2FzZSBkb2Vzbid0IG5lZWQgdG8g Y3JlYXRlIGEgY3Vyc29yLCBzbyBuZWVkcyB0bworICAgICAgICBkZWFsIHdpdGggbG9va3VwIG1p c3Nlcy4gVGhpcyByZXZlYWxlZCB0d28gc2ltaWxhciAoYnV0IHRyaXZpYWwpIGx1cmtpbmcgYnVn cyBpbiB0aGUKKyAgICAgICAgZmFzdC1wYXRoLgorCisgICAgICAgIE5vIG5ldyBiZWhhdmlvcjsg Y292ZXJlZCBieSB0ZXN0cyBzdWNoIGFzOiBzdG9yYWdlL2luZGV4ZWRkYi9nZXQta2V5cmFuZ2Uu aHRtbAorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCQmFja2luZ1N0b3JlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OklEQkJhY2tpbmdTdG9yZTo6Z2V0UmVjb3JkKTogSGFuZGxlIGJh Y2tpbmcgc3RvcmUgcmVhZCBtaXNzIGNhc2UuCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIv SURCRGF0YWJhc2VCYWNrZW5kSW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHZXRPcGVyYXRp b246OnBlcmZvcm0pOiBIYW5kbGUgYmFja2luZyBzdG9yZSByZWFkIG1pc3MgY2FzZS4KKyAgICAg ICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJLZXlSYW5nZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpJREJLZXlSYW5nZTo6aXNPbmx5S2V5KTogQ29tcGFyZSBrZXlzIGJ5IHZhbHVlLCBub3QgcG9p bnRlciwgY29ycmVjdAorICAgICAgICB0eXBlIGNoZWNrcywgYWRkIGFzc2VydGlvbnMuCisgICAg ICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5UmFuZ2UuaDoKKyAgICAgICAgKElEQktleVJh bmdlKTogTW92ZSBpbXBsZW1lbnRhdGlvbiB0byBDUFAgZmlsZS4KKwogMjAxMy0wMS0yOSAgSnVz dGluIE5vdm9zYWQgIDxqdW5vdkBnb29nbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIx MzU2MjgtMTM1NjMyKTogRG91YmxlIGJveCBzaGFkb3cgZmFpbHVyZSB0byByZW5kZXIKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkJhY2tpbmdTdG9yZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJCYWNraW5nU3RvcmUuY3Bw CmluZGV4IGRhNDg0OTk3MTgzMTE2N2JmYWNmZTkyZDdhNTAxNjlkZDExNjQyMjEuLjVhMmNlMTQz ZjM4MGRiMzg3ZDM1NGU5NDY3YmI3MTM2OTFmOGMyMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCQmFja2luZ1N0b3JlLmNwcApAQCAtNzkwLDYgKzc5 MCw4IEBAIGJvb2wgSURCQmFja2luZ1N0b3JlOjpnZXRSZWNvcmQoSURCQmFja2luZ1N0b3JlOjpU cmFuc2FjdGlvbiogdHJhbnNhY3Rpb24sIGludDY0CiAgICAgICAgIElOVEVSTkFMX1JFQURfRVJS T1IoR2V0UmVjb3JkKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KKyAgICBpZiAoIWZv dW5kKQorICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIGludDY0X3QgdmVyc2lvbjsKICAgICBj b25zdCBjaGFyKiBwID0gZGVjb2RlVmFySW50KGRhdGEuYmVnaW4oKSwgZGF0YS5lbmQoKSwgdmVy c2lvbik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJE YXRhYmFzZUJhY2tlbmRJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L0lEQkRhdGFiYXNlQmFja2VuZEltcGwuY3BwCmluZGV4IDk5YWIwNTMzNmZlNDM2Y2RhZjliMTBk MjkyNmIzM2M3N2I5NzAyZTcuLmQ1Mzg3YTc3MTkzMTA4YWM2MmYwNGEyOTRkMTZkOWUzMDQ0Njdh YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFi YXNlQmFja2VuZEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L0lEQkRhdGFiYXNlQmFja2VuZEltcGwuY3BwCkBAIC03NTEsNiArNzUxLDEwIEBAIHZvaWQgR2V0 T3BlcmF0aW9uOjpwZXJmb3JtKElEQlRyYW5zYWN0aW9uQmFja2VuZEltcGwqIHRyYW5zYWN0aW9u KQogICAgICAgICBtX2NhbGxiYWNrcy0+b25FcnJvcihJREJEYXRhYmFzZUVycm9yOjpjcmVhdGUo SURCRGF0YWJhc2VFeGNlcHRpb246OlVua25vd25FcnJvciwgIkludGVybmFsIGVycm9yIGluIGdl dFByaW1hcnlLZXlWaWFJbmRleC4iKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CisgICAgaWYg KCFwcmltYXJ5S2V5KSB7CisgICAgICAgIG1fY2FsbGJhY2tzLT5vblN1Y2Nlc3MoKTsKKyAgICAg ICAgcmV0dXJuOworICAgIH0KICAgICBpZiAobV9jdXJzb3JUeXBlID09IElEQkN1cnNvckJhY2tl bmRJbnRlcmZhY2U6OktleU9ubHkpIHsKICAgICAgICAgLy8gSW5kZXggVmFsdWUgUmV0cmlldmFs IE9wZXJhdGlvbgogICAgICAgICBtX2NhbGxiYWNrcy0+b25TdWNjZXNzKHByaW1hcnlLZXkuZ2V0 KCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5 UmFuZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5UmFuZ2Uu Y3BwCmluZGV4IGE2MzViNTM3NDBkYmMzYjlhOWE1NTcyYTE2ZTVlMDE0N2ZmMTE0OWQuLjcyOGY5 NTMyYjg3ZDFlNzNiNjk1MWJjMDg0OWM1MWFhYzE3ZWIxNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQktleVJhbmdlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJLZXlSYW5nZS5jcHAKQEAgLTEzMCw2ICsxMzAsMTYg QEAgUGFzc1JlZlB0cjxJREJLZXlSYW5nZT4gSURCS2V5UmFuZ2U6OmJvdW5kKFNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQqIGNvbnRleHQsIGNvbnMKICAgICByZXR1cm4gSURCS2V5UmFuZ2U6OmNyZWF0 ZShsb3dlciwgdXBwZXIsIGxvd2VyT3BlbiA/IExvd2VyQm91bmRPcGVuIDogTG93ZXJCb3VuZENs b3NlZCwgdXBwZXJPcGVuID8gVXBwZXJCb3VuZE9wZW4gOiBVcHBlckJvdW5kQ2xvc2VkKTsKIH0K IAorYm9vbCBJREJLZXlSYW5nZTo6aXNPbmx5S2V5KCkgY29uc3QKK3sKKyAgICBpZiAobV9sb3dl clR5cGUgIT0gTG93ZXJCb3VuZENsb3NlZCB8fCBtX3VwcGVyVHlwZSAhPSBVcHBlckJvdW5kQ2xv c2VkKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBBU1NFUlQobV9sb3dlcik7CisgICAg QVNTRVJUKG1fdXBwZXIpOworICAgIHJldHVybiBtX2xvd2VyLT5pc0VxdWFsKG1fdXBwZXIuZ2V0 KCkpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBFTkFCTEUoSU5E RVhFRF9EQVRBQkFTRSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhl ZGRiL0lEQktleVJhbmdlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJL ZXlSYW5nZS5oCmluZGV4IDgxODY1ZDBiNTNhOTRmYWZhZjEwNjc3MzdiYWVjYTZiNWNkZDk4YTYu LjU0NzY5NWFjOTk0ODJjZGRmNGE4MzY5ZDliYzA5ZmEyM2EzYmI1NzUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQktleVJhbmdlLmgKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5UmFuZ2UuaApAQCAtNzcsMTAgKzc3LDcg QEAgcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPElEQktleVJhbmdlPiBib3VuZChTY3Jp cHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBjb25zdCBTY3JpcHRWYWx1ZSYgbG93ZXIsIGNv bnN0IFNjcmlwdFZhbHVlJiB1cHBlciwgYm9vbCBsb3dlck9wZW4sIEV4Y2VwdGlvbkNvZGUmIGVj KSB7IHJldHVybiBib3VuZChjb250ZXh0LCBsb3dlciwgdXBwZXIsIGxvd2VyT3BlbiwgZmFsc2Us IGVjKTsgfQogICAgIHN0YXRpYyBQYXNzUmVmUHRyPElEQktleVJhbmdlPiBib3VuZChTY3JpcHRF eGVjdXRpb25Db250ZXh0KiwgY29uc3QgU2NyaXB0VmFsdWUmIGxvd2VyLCBjb25zdCBTY3JpcHRW YWx1ZSYgdXBwZXIsIGJvb2wgbG93ZXJPcGVuLCBib29sIHVwcGVyT3BlbiwgRXhjZXB0aW9uQ29k ZSYpOwogCi0gICAgYm9vbCBpc09ubHlLZXkoKQotICAgIHsKLSAgICAgICAgcmV0dXJuIG1fbG93 ZXIgPT0gbV91cHBlciAmJiBtX2xvd2VyVHlwZSA9PSBMb3dlckJvdW5kT3BlbiAmJiBtX3VwcGVy VHlwZSA9PSBVcHBlckJvdW5kQ2xvc2VkOwotICAgIH0KKyAgICBib29sIGlzT25seUtleSgpIGNv bnN0OwogCiBwcml2YXRlOgogICAgIElEQktleVJhbmdlKFBhc3NSZWZQdHI8SURCS2V5PiBsb3dl ciwgUGFzc1JlZlB0cjxJREJLZXk+IHVwcGVyLCBMb3dlckJvdW5kVHlwZSBsb3dlclR5cGUsIFVw cGVyQm91bmRUeXBlIHVwcGVyVHlwZSk7Cg==