107576 2013-01-22 11:43:44 -0800 REGRESION(r130774): preferred width of tables does not take max-width into account 2013-01-22 16:52:11 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony ojan eric jchaffraix ojan.autocc ojan pravind.2k4 webkit.review.bot oldest_to_newest 813276 0 tony 2013-01-22 11:43:44 -0800 We forgot to update computePreferredLogicalWidth to consider max-width when adding this to tables in bug 98455. This causes us to have lots of extra space when we shrink wrap a table with max-width. Ojan volunteered to put together a fix that we can merge to the release and beta branches. Originally reported in https://code.google.com/p/chromium/issues/detail?id=170642 . 813378 1 184042 ojan 2013-01-22 13:41:00 -0800 Created attachment 184042 Patch 813469 2 184042 jchaffraix 2013-01-22 15:27:45 -0800 Comment on attachment 184042 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184042&action=review > Source/WebCore/rendering/RenderTable.cpp:730 > + // FIXME: This should probably be checking for isSpecified since you should be able to use percentage, calc or viewport relative values for min-width. Why don't we fix that now instead of waiting? > LayoutTests/ChangeLog:9 > + * fast/table/min-max-width-preferred-size.html: Added. It would be nice to have some testing with box-sizing set on the table. > LayoutTests/fast/table/min-max-width-preferred-size.html:1 > +<style> Do we really need a quirksmode test? 813472 3 184042 webkit.review.bot 2013-01-22 15:29:30 -0800 Comment on attachment 184042 Patch Clearing flags on attachment: 184042 Committed r140479: <http://trac.webkit.org/changeset/140479> 813473 4 webkit.review.bot 2013-01-22 15:29:34 -0800 All reviewed patches have been landed. Closing bug. 813566 5 184042 ojan 2013-01-22 16:52:11 -0800 Comment on attachment 184042 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184042&action=review >> Source/WebCore/rendering/RenderTable.cpp:730 >> + // FIXME: This should probably be checking for isSpecified since you should be able to use percentage, calc or viewport relative values for min-width. > > Why don't we fix that now instead of waiting? This is done this way throughout the rendering code. My plan was to get rid of all the copy-paste first and then fix this in the couple of places that remain. >> LayoutTests/ChangeLog:9 >> + * fast/table/min-max-width-preferred-size.html: Added. > > It would be nice to have some testing with box-sizing set on the table. OK. I'll add this in a followup patch. >> LayoutTests/fast/table/min-max-width-preferred-size.html:1 >> +<style> > > Do we really need a quirksmode test? Whoops. That was just a mistake. 184042 2013-01-22 13:41:00 -0800 2013-01-22 16:52:11 -0800 Patch bug-107576-20130122133754.patch text/plain 5146 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE2MmNlNmJkZTcwMjg3 ZjIyZGQ2Y2FkYTU2MjFmNThhMWYzNmNlMi4uNDIxM2Q4ZDI3ODVjN2NhOTcxNzM5ZjFkODA1NmJi ZjllODJiNmM0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTIyICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTSU9OKHIxMzA3NzQp OiBwcmVmZXJyZWQgd2lkdGggb2YgdGFibGVzIGRvZXMgbm90IHRha2UgbWF4LXdpZHRoIGludG8g YWNjb3VudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA3NTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q29uc3RyYWluIHByZWZlcnJlZCB3aWR0aHMgYnkgbWluL21heCB0aGUgd2F5IHdlIGRvIGluIG90 aGVyCisgICAgICAgIFJlbmRlckJsb2NrIHN1YmNsYXNzZXMuIEV2ZW50dWFsbHksIHdlJ2xsIHNo YXJlZCB0aGUgY29kZSB3aXRoCisgICAgICAgIFJlbmRlckJsb2NrLCBidXQgdGhpcyBpcyBhbiBp bmNyZW1lbnRhbCBzdGVwIGluIHRoYXQgZGlyZWN0aW9uCisgICAgICAgIHRoYXQgd2UgY2FuIHNh ZmVseSBtZXJnZSBpbnRvIHJlbGVhc2UgYnJhbmNoZXMuCisKKyAgICAgICAgVGVzdDogZmFzdC90 YWJsZS9taW4tbWF4LXdpZHRoLXByZWZlcnJlZC1zaXplLmh0bWwKKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJUYWJsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZTo6Y29t cHV0ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMpOgorCiAyMDEzLTAxLTIyICBTZXJnaW8gVmlsbGFy IFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTb3VwXSBSYW5kb20gdGhy ZWFkIGNyYXNoZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU YWJsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwCmluZGV4 IGJhZTZjMjVjMjZkMzJhZjMwMzY3Nzg4MzhhNjcyNzBmODkyZGYzM2MuLmIyYTg0MzM0OThkZWUz MGE3OGIwMjBmODgzY2I2ODdhMDUzMTUxMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUYWJsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRhYmxlLmNwcApAQCAtNzI2LDYgKzcyNiwyMSBAQCB2b2lkIFJlbmRlclRhYmxlOjpjb21w dXRlUHJlZmVycmVkTG9naWNhbFdpZHRocygpCiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8 IG1fY2FwdGlvbnMuc2l6ZSgpOyBpKyspCiAgICAgICAgIG1fbWluUHJlZmVycmVkTG9naWNhbFdp ZHRoID0gbWF4KG1fbWluUHJlZmVycmVkTG9naWNhbFdpZHRoLCBtX2NhcHRpb25zW2ldLT5taW5Q cmVmZXJyZWRMb2dpY2FsV2lkdGgoKSk7CiAKKyAgICBSZW5kZXJTdHlsZSogc3R5bGVUb1VzZSA9 IHN0eWxlKCk7CisgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIHByb2JhYmx5IGJlIGNoZWNraW5n IGZvciBpc1NwZWNpZmllZCBzaW5jZSB5b3Ugc2hvdWxkIGJlIGFibGUgdG8gdXNlIHBlcmNlbnRh Z2UsIGNhbGMgb3Igdmlld3BvcnQgcmVsYXRpdmUgdmFsdWVzIGZvciBtaW4td2lkdGguCisgICAg aWYgKHN0eWxlVG9Vc2UtPmxvZ2ljYWxNaW5XaWR0aCgpLmlzRml4ZWQoKSAmJiBzdHlsZVRvVXNl LT5sb2dpY2FsTWluV2lkdGgoKS52YWx1ZSgpID4gMCkgeworICAgICAgICBtX21heFByZWZlcnJl ZExvZ2ljYWxXaWR0aCA9IHN0ZDo6bWF4KG1fbWF4UHJlZmVycmVkTG9naWNhbFdpZHRoLCBhZGp1 c3RDb250ZW50Qm94TG9naWNhbFdpZHRoRm9yQm94U2l6aW5nKHN0eWxlVG9Vc2UtPmxvZ2ljYWxN aW5XaWR0aCgpLnZhbHVlKCkpKTsKKyAgICAgICAgbV9taW5QcmVmZXJyZWRMb2dpY2FsV2lkdGgg PSBzdGQ6Om1heChtX21pblByZWZlcnJlZExvZ2ljYWxXaWR0aCwgYWRqdXN0Q29udGVudEJveExv Z2ljYWxXaWR0aEZvckJveFNpemluZyhzdHlsZVRvVXNlLT5sb2dpY2FsTWluV2lkdGgoKS52YWx1 ZSgpKSk7CisgICAgfQorCisgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIHByb2JhYmx5IGJlIGNo ZWNraW5nIGZvciBpc1NwZWNpZmllZCBzaW5jZSB5b3Ugc2hvdWxkIGJlIGFibGUgdG8gdXNlIHBl cmNlbnRhZ2UsIGNhbGMgb3Igdmlld3BvcnQgcmVsYXRpdmUgdmFsdWVzIGZvciBtYXhXaWR0aC4K KyAgICBpZiAoc3R5bGVUb1VzZS0+bG9naWNhbE1heFdpZHRoKCkuaXNGaXhlZCgpKSB7CisgICAg ICAgIG1fbWF4UHJlZmVycmVkTG9naWNhbFdpZHRoID0gc3RkOjptaW4obV9tYXhQcmVmZXJyZWRM b2dpY2FsV2lkdGgsIGFkanVzdENvbnRlbnRCb3hMb2dpY2FsV2lkdGhGb3JCb3hTaXppbmcoc3R5 bGVUb1VzZS0+bG9naWNhbE1heFdpZHRoKCkudmFsdWUoKSkpOworICAgICAgICBtX21pblByZWZl cnJlZExvZ2ljYWxXaWR0aCA9IHN0ZDo6bWluKG1fbWluUHJlZmVycmVkTG9naWNhbFdpZHRoLCBh ZGp1c3RDb250ZW50Qm94TG9naWNhbFdpZHRoRm9yQm94U2l6aW5nKHN0eWxlVG9Vc2UtPmxvZ2lj YWxNYXhXaWR0aCgpLnZhbHVlKCkpKTsKKyAgICB9CisKKyAgICAvLyBGSVhNRTogV2Ugc2hvdWxk IGJlIGFkZGluZyBib3JkZXJBbmRQYWRkaW5nTG9naWNhbFdpZHRoIGhlcmUsIGJ1dCBtX3RhYmxl TGF5b3V0LT5jb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyBhbHJlYWR5IGRvZXMsCisgICAg Ly8gc28gYSBidW5jaCBvZiB0ZXN0cyBicmVhayBkb2luZyB0aGlzIG5haXZlbHkuCiAgICAgc2V0 UHJlZmVycmVkTG9naWNhbFdpZHRoc0RpcnR5KGZhbHNlKTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg0ODA5NzA2 NDNhZjE3OGRhMmYxYjkwYzZkOTEyYWE3MmU5YzhlNTMuLjBmYTg4NDAwZjlhNThhMmMzNjA5ZDA2 NGJjYzg2ZWQxNjMyY2ZkOWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMS0yMiAgT2ph biBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU0lPTihyMTMwNzc0 KTogcHJlZmVycmVkIHdpZHRoIG9mIHRhYmxlcyBkb2VzIG5vdCB0YWtlIG1heC13aWR0aCBpbnRv IGFjY291bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNzU3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZmFzdC90YWJsZS9taW4tbWF4LXdpZHRoLXByZWZlcnJlZC1zaXplLWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogZmFzdC90YWJsZS9taW4tbWF4LXdpZHRoLXByZWZlcnJlZC1zaXpl Lmh0bWw6IEFkZGVkLgorCiAyMDEzLTAxLTIyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcu Ym90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQwNDM1 LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9taW4tbWF4LXdpZHRoLXByZWZl cnJlZC1zaXplLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvdGFibGUvbWluLW1heC13 aWR0aC1wcmVmZXJyZWQtc2l6ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZGRkNWM5M2ExOTYw NGIzM2M0YTI0NDA4NzA2ZTc5YWY5OWE3MWRmMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvdGFibGUvbWluLW1heC13aWR0aC1wcmVmZXJyZWQtc2l6ZS1leHBlY3RlZC50eHQK QEAgLTAsMCArMSw1IEBACisgCitQQVNTCisKK1BBU1MKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC90YWJsZS9taW4tbWF4LXdpZHRoLXByZWZlcnJlZC1zaXplLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L3RhYmxlL21pbi1tYXgtd2lkdGgtcHJlZmVycmVkLXNpemUuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi5kN2QxODcwYTM3MzQ0ZjUyNmMwYjE1NzMzOWEyMGRhODFkNGQ2NGZkCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9taW4tbWF4LXdpZHRoLXByZWZlcnJlZC1z aXplLmh0bWwKQEAgLTAsMCArMSwzNSBAQAorPHN0eWxlPgorLmNoaWxkIHsKKyAgICB3aWR0aDog NzVweDsKKyAgICBoZWlnaHQ6IDIwcHg7CisgICAgYmFja2dyb3VuZC1jb2xvcjogc2FsbW9uOwor ICAgIGRpc3BsYXk6IGlubGluZS1ibG9jazsKK30KKy5jb250YWluZXIgeworICAgIGRpc3BsYXk6 IGlubGluZS1ibG9jazsKKyAgICBib3JkZXI6IDVweCBzb2xpZCBncmV5OworfQordGFibGUgewor ICAgIGJhY2tncm91bmQtY29sb3I6IHBpbms7Cit9Cis8L3N0eWxlPgorCis8ZGl2IGNsYXNzPSJj b250YWluZXIiIGRhdGEtZXhwZWN0ZWQtd2lkdGg9MjEwPgorICAgIDx0YWJsZSBzdHlsZT0ibWF4 LXdpZHRoOiAyMDBweCI+CisgICAgICAgIDx0ZD4KKyAgICAgICAgICAgIDxkaXYgY2xhc3M9ImNo aWxkIj48L2Rpdj4KKyAgICAgICAgICAgIDxkaXYgY2xhc3M9ImNoaWxkIj48L2Rpdj4KKyAgICAg ICAgICAgIDxkaXYgY2xhc3M9ImNoaWxkIj48L2Rpdj4KKyAgICAgICAgPC90ZD4KKyAgICA8L3Rh YmxlPgorPC9kaXY+Cis8YnI+CisKKzxkaXYgY2xhc3M9ImNvbnRhaW5lciIgZGF0YS1leHBlY3Rl ZC13aWR0aD0yMTA+CisgICAgPHRhYmxlIHN0eWxlPSJ3aWR0aDogMTAwcHg7IG1pbi13aWR0aDog MjAwcHg7IHRhYmxlLWxheW91dDogZml4ZWQiPjx0ZD48ZGl2IGNsYXNzPSJjaGlsZCI+PC9kaXY+ PC90ZD48L3RhYmxlPgorPC9kaXY+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvY2hl Y2stbGF5b3V0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CitjaGVja0xheW91dCgnLmNvbnRhaW5l cicpOworPC9zY3JpcHQ+Cg==