107562 2013-01-22 10:41:59 -0800 REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions(). 2013-01-22 11:15:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble ossy oldest_to_newest 813167 0 jer.noble 2013-01-22 10:41:59 -0800 REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions(). 813170 1 184011 jer.noble 2013-01-22 10:43:54 -0800 Created attachment 184011 Patch 813175 2 184011 ap 2013-01-22 10:46:12 -0800 Comment on attachment 184011 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184011&action=review r=me > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:113 > + bool useTiledDrawing = useTiledDrawingValue ? WKBooleanGetValue(static_cast<WKBooleanRef>(useTiledDrawingValue)) : false; This might read better as: bool useTiledDrawing = useTiledDrawingValue && WKBooleanGetValue(static_cast<WKBooleanRef>(useTiledDrawingValue)); What do you think? 813201 3 jer.noble 2013-01-22 10:54:30 -0800 Nice suggestion actually. :) 813242 4 jer.noble 2013-01-22 11:15:36 -0800 Committed r140442: <http://trac.webkit.org/changeset/140442> 184011 2013-01-22 10:43:54 -0800 2013-01-22 10:46:11 -0800 Patch bug-107562-20130122104048.patch text/plain 2730 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMzYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2NiZDlhMDgzY2NhYTAyYmRmZTY2YTZjMGI5YjlhMmQ4 MGMyMjFlYy4uY2E3OGUwMGVkYjMzMjI0ZDVmYjY0OWJkNjFjYzc5NjQxZTIyMmY4MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTAxLTIyICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjE0MDM0NCk6IFJlcGVhdGVkIGNyYXNoZXMgaW4gV0tUUiBQbGF0Zm9y bVdlYlZpZXc6OnZpZXdTdXBwb3J0c09wdGlvbnMoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzU2MgorCisgICAgICAgIFJ1YmJlci1zdGFtcGVk IGJ5IEFsZXh5IFByb3NrdXJ5YWtvdi4KKworICAgICAgICBUaGUgaW5wdXQgdG8gV0tCb29sZWFu R2V0VmFsdWUoKSBpcyBub3QgTlVMTC1zYWZlLCBzbyBOVUxMIGNoZWNrIGl0cyBpbnB1dHMgYmVm b3JlIGNhbGxpbmcuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdl YlZpZXdNYWMubW06CisgICAgICAgIChXVFI6OlBsYXRmb3JtV2ViVmlldzo6UGxhdGZvcm1XZWJW aWV3KToKKyAgICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3Ojp2aWV3U3VwcG9ydHNPcHRpb25z KToKKwogMjAxMy0wMS0yMSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgTWFjIER1bXBSZW5kZXJUcmVlJ3MgaW5zdGFsbFNpZ25hbEhhbmRsZXJzKCkg aXMgdW5yZWFjaGFibGUgY29kZQpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9t YWMvUGxhdGZvcm1XZWJWaWV3TWFjLm1tIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxh dGZvcm1XZWJWaWV3TWFjLm1tCmluZGV4IDQzMTRiOWFjNDJhZDIwMDc5MDcwMTA5ZTY4NTc5MTE0 NDBmMzI1NjAuLmFjYTFiMGY4OTgyZTk3Mzc0NzllMWI4MGQ0YzM2YzZmMTQyMjgzMTEgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbQor KysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0KQEAg LTEwOSw3ICsxMDksOCBAQCBQbGF0Zm9ybVdlYlZpZXc6OlBsYXRmb3JtV2ViVmlldyhXS0NvbnRl eHRSZWYgY29udGV4dFJlZiwgV0tQYWdlR3JvdXBSZWYgcGFnZUdybwogICAgIDogbV93aW5kb3dJ c0tleSh0cnVlKQogewogICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiB1c2VUaWxlZERyYXdp bmdLZXkoQWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoIlRpbGVkRHJhd2lu ZyIpKTsKLSAgICBib29sIHVzZVRpbGVkRHJhd2luZyA9IG9wdGlvbnMgPyBXS0Jvb2xlYW5HZXRW YWx1ZShzdGF0aWNfY2FzdDxXS0Jvb2xlYW5SZWY+KFdLRGljdGlvbmFyeUdldEl0ZW1Gb3JLZXko b3B0aW9ucywgdXNlVGlsZWREcmF3aW5nS2V5LmdldCgpKSkpIDogZmFsc2U7CisgICAgV0tUeXBl UmVmIHVzZVRpbGVkRHJhd2luZ1ZhbHVlID0gb3B0aW9ucyA/IFdLRGljdGlvbmFyeUdldEl0ZW1G b3JLZXkob3B0aW9ucywgdXNlVGlsZWREcmF3aW5nS2V5LmdldCgpKSA6IE5VTEw7CisgICAgYm9v bCB1c2VUaWxlZERyYXdpbmcgPSB1c2VUaWxlZERyYXdpbmdWYWx1ZSA/IFdLQm9vbGVhbkdldFZh bHVlKHN0YXRpY19jYXN0PFdLQm9vbGVhblJlZj4odXNlVGlsZWREcmF3aW5nVmFsdWUpKSA6IGZh bHNlOwogCiAgICAgTlNSZWN0IHJlY3QgPSBOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKTsKICAg ICBtX3ZpZXcgPSBbW1Rlc3RSdW5uZXJXS1ZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6cmVjdCBj b250ZXh0UmVmOmNvbnRleHRSZWYgcGFnZUdyb3VwUmVmOnBhZ2VHcm91cFJlZiB1c2VUaWxlZERy YXdpbmc6dXNlVGlsZWREcmF3aW5nXTsKQEAgLTIwMiw3ICsyMDMsOCBAQCBXS1JldGFpblB0cjxX S0ltYWdlUmVmPiBQbGF0Zm9ybVdlYlZpZXc6OndpbmRvd1NuYXBzaG90SW1hZ2UoKQogYm9vbCBQ bGF0Zm9ybVdlYlZpZXc6OnZpZXdTdXBwb3J0c09wdGlvbnMoV0tEaWN0aW9uYXJ5UmVmIG9wdGlv bnMpIGNvbnN0CiB7CiAgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHVzZVRpbGVkRHJhd2lu Z0tleShBZG9wdFdLLCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygiVGlsZWREcmF3aW5n IikpOwotICAgIGJvb2wgdXNlVGlsZWREcmF3aW5nID0gV0tCb29sZWFuR2V0VmFsdWUoc3RhdGlj X2Nhc3Q8V0tCb29sZWFuUmVmPihXS0RpY3Rpb25hcnlHZXRJdGVtRm9yS2V5KG9wdGlvbnMsIHVz ZVRpbGVkRHJhd2luZ0tleS5nZXQoKSkpKTsKKyAgICBXS1R5cGVSZWYgdXNlVGlsZWREcmF3aW5n VmFsdWUgPSBXS0RpY3Rpb25hcnlHZXRJdGVtRm9yS2V5KG9wdGlvbnMsIHVzZVRpbGVkRHJhd2lu Z0tleS5nZXQoKSk7CisgICAgYm9vbCB1c2VUaWxlZERyYXdpbmcgPSB1c2VUaWxlZERyYXdpbmdW YWx1ZSA/IFdLQm9vbGVhbkdldFZhbHVlKHN0YXRpY19jYXN0PFdLQm9vbGVhblJlZj4odXNlVGls ZWREcmF3aW5nVmFsdWUpKSA6IGZhbHNlOwogCiAgICAgcmV0dXJuIHVzZVRpbGVkRHJhd2luZyA9 PSBbKFRlc3RSdW5uZXJXS1ZpZXcgKiltX3ZpZXcgdXNlVGlsZWREcmF3aW5nXTsKIH0K