107547 2013-01-22 03:59:12 -0800 [Qt] Box shadows on a transparency layer is very slow 2013-01-31 06:09:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107549 88186 103747 1 allan.jensen allan.jensen noam nowrep webkit.review.bot oldest_to_newest 812897 0 allan.jensen 2013-01-22 03:59:12 -0800 If box shadows are applied on top of a transparency layer, the result is very slow painting. An example is the page http://paste.chakra-project.org/3755/. The issue is that the ShadowBlur layer ends up being the entire size of box element, instead of just the size of the transparency layer. This happens because the clipping set on QPainter is much larger than the area QPainter is painting to. One way to avoid it, is to set an initial clipping to the area QPainter is painting to, so that later clipping (set by intersection), can not end up larger than the layer. 812903 1 183958 allan.jensen 2013-01-22 04:01:36 -0800 Created attachment 183958 Patch 812919 2 nowrep 2013-01-22 04:23:56 -0800 I can confirm that the patch helps the issue. Unfortunately, it's not ideal. Rendering the page provided changed from unusably slow to slow on my machine (i5). 812932 3 allan.jensen 2013-01-22 04:40:18 -0800 Committed r140412: <http://trac.webkit.org/changeset/140412> 812979 4 183976 allan.jensen 2013-01-22 05:54:49 -0800 Created attachment 183976 Patch Do not change clips used by QPainter, instead ensure clipBounds return a clip intersected with the window bounds 821461 5 183976 webkit.review.bot 2013-01-31 06:09:33 -0800 Comment on attachment 183976 Patch Clearing flags on attachment: 183976 Committed r141413: <http://trac.webkit.org/changeset/141413> 821462 6 webkit.review.bot 2013-01-31 06:09:37 -0800 All reviewed patches have been landed. Closing bug. 183958 2013-01-22 04:01:36 -0800 2013-01-22 05:54:45 -0800 Patch bug-107547-20130122125753.patch text/plain 1547 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmRlY2ExZTAyMjAyN2Y3 Mjk2MjQ4MDhjY2Q2OTFkNThiMjdjMTQ3My4uYzBlMTIyNTkzNDExMzA5ZWNmZWM2MDYzZDM5OTg1 M2ZlN2YzYWQxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTIyICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gQm94IHNoYWRvd3Mgb24gYSB0cmFuc3BhcmVuY3kgbGF5ZXIgaXMgdmVyeSBzbG93CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc1NDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXQgYW4gaW5pdGlh bCBjbGlwIG9uIHRoZSB0cmFuc3BhcmVuY3kgbGF5ZXIsIHNvIHRoYXQgdGhlIGNsaXBwaW5nCisg ICAgICAgIGJvdW5kcyB3aWxsIG5ldmVyIGVuZCB1cCBsYXJnZXIgdGhhbiB0aGUgbGF5ZXIuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9UcmFuc3BhcmVuY3lMYXllci5oOgorICAg ICAgICAoV2ViQ29yZTo6VHJhbnNwYXJlbmN5TGF5ZXI6OlRyYW5zcGFyZW5jeUxheWVyKToKKwog MjAxMy0wMS0yMiAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVHVy biBvbiBFTkFCTEVfVEhSRUFERURfSFRNTF9QQVJTRVIgZm9yIENocm9taXVtIChpdCdzIHN0aWxs IGRpc2FibGVkIGF0IHJ1bnRpbWUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9xdC9UcmFuc3BhcmVuY3lMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvVHJhbnNwYXJlbmN5TGF5ZXIuaAppbmRleCBmMTNkZWIwM2I3YTgwN2Qy MjE5ZGRjZDQ5OWYxMzM0YTc4ZTQ0OTFkLi5kZWQwOTA2MzNlMzk0NzdmZjBkOWI3Mjg2NjgxODI3 ZWRmZTlkZmMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9x dC9UcmFuc3BhcmVuY3lMYXllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3F0L1RyYW5zcGFyZW5jeUxheWVyLmgKQEAgLTYxLDYgKzYxLDggQEAgcHVibGljOgogICAg ICAgICBwYWludGVyLnNldFRyYW5zZm9ybShwLT50cmFuc2Zvcm0oKSwgdHJ1ZSk7CiAgICAgICAg IHBhaW50ZXIuc2V0Rm9udChwLT5mb250KCkpOwogICAgICAgICBwYWludGVyLnNldE9wYWNpdHko MSk7CisgICAgICAgIC8vIFNldCBhIGRlZmF1bHQgY2xpcCwgc28gSW50ZXJzZWN0Q2xpcCB3aWxs IHdvcmsgY29ycmVjdGx5IGxhdGVyLgorICAgICAgICBwYWludGVyLnNldENsaXBSZWN0KDAsIDAs IHJlY3Qud2lkdGgoKSwgcmVjdC5oZWlnaHQoKSk7CiAgICAgfQogCiAgICAgVHJhbnNwYXJlbmN5 TGF5ZXIoKQo= 183976 2013-01-22 05:54:49 -0800 2013-01-31 06:09:33 -0800 Patch bug-107547-20130122145105.patch text/plain 1749 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA5OTY3NGIwMDJkZGMy ODM5NDFhMzIyNDcwN2QwNzk1Y2NmNmI3NS4uNTUzZGYyMmQwZDgzZDFlZGM5ZGU5OWFhMTViZTIz NjA1ZjJhYTJiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTIyICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gQm94IHNoYWRvd3Mgb24gYSB0cmFuc3BhcmVuY3kgbGF5ZXIgaXMgdmVyeSBzbG93CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc1NDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmNsdWRlIHRoZSB3 aW5kb3cgYm91bmRhcmllcyBpbiB0aGUgY2xpcCByZXR1cm5lZCBieSBHcmFwaGljc0NvbnRleHQs CisgICAgICAgIHNpbmNlIFFQYWludGVyIG1heSByZW1lbWJlciBjbGlwcyBsYXJnZXIgdGhhbiB0 aGUgZGVzdGluYXRpb24sIGJ1dAorICAgICAgICBTaGFkb3dCbHVyIHVzZXMgdGhlIGNsaXBCb3Vu ZHMgdG8gZGV0ZXJtaW5lIHRoZSBzaXplIG9mIHRoZSBzaGFkb3cgbGF5ZXIuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmNsaXBCb3VuZHMpOgorCiAyMDEzLTAxLTIyICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTQwNDEyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCmluZGV4IDhjZTQ2ZWI0 OTczNWJjYjQ3ZDJkMGU3NTY0MzlhNjUyNTZhYTkwNjkuLjk2NTMyYzgyZWE0OTViODY2ZmZiMjk0 OWE5ODlhMWMyZGQ2MGYxZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKQEAgLTgyMSwxMCArODIxLDEw IEBAIEludFJlY3QgR3JhcGhpY3NDb250ZXh0OjpjbGlwQm91bmRzKCkgY29uc3QKICAgICBRUGFp bnRlciogcCA9IG1fZGF0YS0+cCgpOwogICAgIFFSZWN0RiBjbGlwUmVjdDsKIAorICAgIGNsaXBS ZWN0ID0gcC0+dHJhbnNmb3JtKCkuaW52ZXJ0ZWQoKS5tYXBSZWN0KHAtPndpbmRvdygpKTsKKwog ICAgIGlmIChwLT5oYXNDbGlwcGluZygpKQotICAgICAgICBjbGlwUmVjdCA9IG1fZGF0YS0+Y2xp cEJvdW5kaW5nUmVjdCgpOwotICAgIGVsc2UKLSAgICAgICAgY2xpcFJlY3QgPSBwLT50cmFuc2Zv cm0oKS5pbnZlcnRlZCgpLm1hcFJlY3QocC0+d2luZG93KCkpOworICAgICAgICBjbGlwUmVjdCA9 IGNsaXBSZWN0LmludGVyc2VjdGVkKG1fZGF0YS0+Y2xpcEJvdW5kaW5nUmVjdCgpKTsKIAogICAg IHJldHVybiBlbmNsb3NpbmdJbnRSZWN0KGNsaXBSZWN0KTsKIH0K