107528 2013-01-22 02:00:00 -0800 webkit-patch suggest-reviewers should limit itself to 5 reviewers 2013-02-15 12:47:33 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107525 1 eric zan abarth dpranke webkit.review.bot zan oldest_to_newest 812808 0 eric 2013-01-22 02:00:00 -0800 webkit-patch suggest-reviewers should limit itself to 5 reviewers Right now it will CC an unbounded number, which is bad. Those should also be the 5 most relevant reviewers, ideally. Easy to calculate based on number of annotated lines in the diff attributed to each reviewer. 814159 1 zan 2013-01-23 06:37:55 -0800 (In reply to comment #0) > Those should also be the 5 most relevant reviewers, ideally. Easy to calculate based on number of annotated lines in the diff attributed to each reviewer. How about deciding about relevant reviewers by picking five who most recently reviewed patches around the code? This kind of guarantees that the offered reviewers is up-to-date with the current status of the code that's changed. I think that's also easier to implement than sorting by the sum of reviewed lines. 814198 2 184231 zan 2013-01-23 07:42:37 -0800 Created attachment 184231 Preliminary patch 814202 3 zan 2013-01-23 07:46:55 -0800 (In reply to comment #2) > Created an attachment (id=184231) [details] > Preliminary patch A WIP patch that outlines the 'five-latest-reviewers' approach. No unit test breakage. I believe this keeps the current behavior though it's probably not in line with what bug #107525 would like to accomplish. 814374 4 184231 eric 2013-01-23 10:59:13 -0800 Comment on attachment 184231 Preliminary patch View in context: https://bugs.webkit.org/attachment.cgi?id=184231&action=review > Tools/Scripts/webkitpy/common/checkout/checkout.py:146 > + reviewers = [] > + for info in commit_infos: > + if info.reviewer() and info.reviewer() not in reviewers: > + reviewers.append(info.reviewer()) > + if info.author() and info.author().can_review and info.author() not in reviewers: > + reviewers.append(info.author()) > + return reviewers It seems all you did here was remove the list comprehensions? 814455 5 184231 zan 2013-01-23 12:01:10 -0800 Comment on attachment 184231 Preliminary patch View in context: https://bugs.webkit.org/attachment.cgi?id=184231&action=review >> Tools/Scripts/webkitpy/common/checkout/checkout.py:146 >> + return reviewers > > It seems all you did here was remove the list comprehensions? This ugly piece of code actually just tries to use a list as an ordered set. The returned list contains all the reviewers connected to the changed files but lists them in order of their last activity, from most to least recent. 815267 6 184447 zan 2013-01-24 02:15:15 -0800 Created attachment 184447 Patch 834277 7 184447 eric 2013-02-15 12:38:37 -0800 Comment on attachment 184447 Patch OK. 834289 8 zan 2013-02-15 12:47:33 -0800 Committed r143033: <http://trac.webkit.org/changeset/143033> 184231 2013-01-23 07:42:37 -0800 2013-01-24 02:15:01 -0800 Preliminary patch bug-107528-20130123163931.patch text/plain 5868 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzYyOTk2NTE2ZGIxNDEyYjA4YTkxMGEzY2ZkNjFlY2M5 NmU2YjE3YS4uODJkNzM2NjhlZDJhODg5YzQ3ZDdiMTc3OTMyMzRjMWVmNzVkODMxZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEzLTAxLTIzICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKwor ICAgICAgICB3ZWJraXQtcGF0Y2ggc3VnZ2VzdC1yZXZpZXdlcnMgc2hvdWxkIGxpbWl0IGl0c2Vs ZiB0byA1IHJldmlld2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA3NTI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVja291dC5weToK KyAgICAgICAgKENoZWNrb3V0LnN1Z2dlc3RlZF9yZXZpZXdlcnMpOiBJdGVyYXRlIHRocm91Z2gg dGhlIHNvcnRlZCBjb21taXQgaW5mbyBsaXN0LAorICAgICAgICBvbmx5IHN1Z2dlc3RpbmcgcmV2 aWV3ZXJzIHRoYXQgaGF2ZSBub3QgeWV0IGJlZW4gc3VnZ2VzdGVkLiBXZSB0YWtlIHRoaXMKKyAg ICAgICAgYXBwcm9hY2ggc28gd2UgY2FuIHJldHVybiBhIGxpc3Qgd2l0aCB1bmlxdWUgcmV2aWV3 ZXJzIHRoYXQncyBzb3J0ZWQgZnJvbQorICAgICAgICB0aGUgbGF0ZXN0IHRvIHRoZSBvbGRlc3Qg cmV2aWV3ZXIgd2hvIGhhcyByZXZpZXdlZCBvciB3b3JrZWQgb24gdGhlIGNoYW5nZWQgZmlsZXMu CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXJpZXMucHk6Cisg ICAgICAgIChTdWdnZXN0UmV2aWV3ZXJzKTogVXNlIHRoZSBTdWdnZXN0UmV2aWV3ZXJzIHN0ZXAg aW5zdGVhZCBvZiByZWltcGxlbWVudGluZyBtdWNoIG9mCisgICAgICAgIHRoZSBzYW1lIGxvZ2lj LgorICAgICAgICAoU3VnZ2VzdFJldmlld2Vycy5fcHJlcGFyZV9zdGF0ZSk6IEZvcmNlIHRoZSBy ZXZpZXdlciBzdWdnZXN0aW9uIGFzIHRoZSBvcHRpb24KKyAgICAgICAgZGVmYXVsdHMgdG8gRmFs c2UuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3N1Z2dlc3RyZXZpZXdl cnMucHk6CisgICAgICAgIChTdWdnZXN0UmV2aWV3ZXJzLnJ1bik6IE9ubHkgbGlzdCB0aGUgZmly c3QgZml2ZSBzdWdnZXN0ZWQgcmV2aWV3ZXJzLiBPbmx5IGFzayBmb3IKKyAgICAgICAgQ0MtaW5n IHRoZSBzdWdnZXN0ZWQgcmV2aWV3ZXJzIHRvIHRoZSBidWcgaWYgdGhlIGJ1ZyBJRCBpcyBsb2Nh dGVkIGluIHRoZSBjb21tYW5kJ3Mgc3RhdGUuCisKIDIwMTMtMDEtMjMgIFRpbSAnbWl0aHJvJyBB bnNlbGwgIDxtaXRocm9AbWl0aGlzLmNvbT4KIAogICAgICAgICBSZW1vdmluZyBjb21tYW5kIGxp bmUgc2hvcnRlbmluZyBhcyBpdCBtYWtlcyBpdCBkaWZmaWN1bHQgdG8gc2VlIHRoZSBjb21tYW5k IGR1cmluZyBlcnJvcnMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9jaGVja291dC9jaGVja291dC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2No ZWNrb3V0L2NoZWNrb3V0LnB5CmluZGV4IGZiNjg2ZjRkNmRhODE2MjgxMDQ3NDMzYWZmZTE5NjU1 MzAzODUxMTAuLjU0OGQyMTU3OTNjYmZhZmZkMjc1NjZmNzk1NmMzZjU0OWNlOWZmMjkgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoZWNrb3V0LnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoZWNrb3V0LnB5 CkBAIC0xMzUsMTAgKzEzNSwxNSBAQCBjbGFzcyBDaGVja291dChvYmplY3QpOgogCiAgICAgZGVm IHN1Z2dlc3RlZF9yZXZpZXdlcnMoc2VsZiwgZ2l0X2NvbW1pdCwgY2hhbmdlZF9maWxlcz1Ob25l KToKICAgICAgICAgY2hhbmdlZF9maWxlcyA9IHNlbGYubW9kaWZpZWRfbm9uX2NoYW5nZWxvZ3Mo Z2l0X2NvbW1pdCwgY2hhbmdlZF9maWxlcykKLSAgICAgICAgY29tbWl0X2luZm9zID0gc2VsZi5y ZWNlbnRfY29tbWl0X2luZm9zX2Zvcl9maWxlcyhjaGFuZ2VkX2ZpbGVzKQotICAgICAgICByZXZp ZXdlcnMgPSBbY29tbWl0X2luZm8ucmV2aWV3ZXIoKSBmb3IgY29tbWl0X2luZm8gaW4gY29tbWl0 X2luZm9zIGlmIGNvbW1pdF9pbmZvLnJldmlld2VyKCldCi0gICAgICAgIHJldmlld2Vycy5leHRl bmQoW2NvbW1pdF9pbmZvLmF1dGhvcigpIGZvciBjb21taXRfaW5mbyBpbiBjb21taXRfaW5mb3Mg aWYgY29tbWl0X2luZm8uYXV0aG9yKCkgYW5kIGNvbW1pdF9pbmZvLmF1dGhvcigpLmNhbl9yZXZp ZXddKQotICAgICAgICByZXR1cm4gc29ydGVkKHNldChyZXZpZXdlcnMpKQorICAgICAgICBjb21t aXRfaW5mb3MgPSBzb3J0ZWQoc2VsZi5yZWNlbnRfY29tbWl0X2luZm9zX2Zvcl9maWxlcyhjaGFu Z2VkX2ZpbGVzKSwga2V5PWxhbWJkYSBpbmZvOiBpbmZvLnJldmlzaW9uKCksIHJldmVyc2U9VHJ1 ZSkKKworICAgICAgICByZXZpZXdlcnMgPSBbXQorICAgICAgICBmb3IgaW5mbyBpbiBjb21taXRf aW5mb3M6CisgICAgICAgICAgICBpZiBpbmZvLnJldmlld2VyKCkgYW5kIGluZm8ucmV2aWV3ZXIo KSBub3QgaW4gcmV2aWV3ZXJzOgorICAgICAgICAgICAgICAgIHJldmlld2Vycy5hcHBlbmQoaW5m by5yZXZpZXdlcigpKQorICAgICAgICAgICAgaWYgaW5mby5hdXRob3IoKSBhbmQgaW5mby5hdXRo b3IoKS5jYW5fcmV2aWV3IGFuZCBpbmZvLmF1dGhvcigpIG5vdCBpbiByZXZpZXdlcnM6CisgICAg ICAgICAgICAgICAgcmV2aWV3ZXJzLmFwcGVuZChpbmZvLmF1dGhvcigpKQorICAgICAgICByZXR1 cm4gcmV2aWV3ZXJzCiAKICAgICBkZWYgYnVnX2lkX2Zvcl90aGlzX2NvbW1pdChzZWxmLCBnaXRf Y29tbWl0LCBjaGFuZ2VkX2ZpbGVzPU5vbmUpOgogICAgICAgICB0cnk6CmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWVyaWVzLnB5CmluZGV4IDc5ZmZhOWJkOGRk Y2Q3YzUxODQ3ZGM3ODFmMTc1ZDlmY2RkNGE2YWUuLmVlYjkzYTFiYTBjZjc4YWZiMzZmZjc2MzQ0 ZjVmODAwOWY3OTExMTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9xdWVyaWVzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21t YW5kcy9xdWVyaWVzLnB5CkBAIC00NCw2ICs0NCw3IEBAIGZyb20gd2Via2l0cHkuY29tbW9uLm5l dC5idWlsZGJvdCBpbXBvcnQgQnVpbGRCb3QKIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldC5yZWdy ZXNzaW9ud2luZG93IGltcG9ydCBSZWdyZXNzaW9uV2luZG93CiBmcm9tIHdlYmtpdHB5LmNvbW1v bi5zeXN0ZW0uY3Jhc2hsb2dzIGltcG9ydCBDcmFzaExvZ3MKIGZyb20gd2Via2l0cHkuY29tbW9u LnN5c3RlbS51c2VyIGltcG9ydCBVc2VyCitmcm9tIHdlYmtpdHB5LnRvb2wuY29tbWFuZHMuYWJz dHJhY3RzZXF1ZW5jZWRjb21tYW5kIGltcG9ydCBBYnN0cmFjdFNlcXVlbmNlZENvbW1hbmQKIGZy b20gd2Via2l0cHkudG9vbC5ncmFtbWFyIGltcG9ydCBwbHVyYWxpemUKIGZyb20gd2Via2l0cHku dG9vbC5tdWx0aWNvbW1hbmR0b29sIGltcG9ydCBBYnN0cmFjdERlY2xhcmF0aXZlQ29tbWFuZAog ZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubW9kZWxzLnRlc3RfZXhwZWN0YXRpb25zIGltcG9y dCBUZXN0RXhwZWN0YXRpb25zCkBAIC01MiwxOSArNTMsMTUgQEAgZnJvbSB3ZWJraXRweS5sYXlv dXRfdGVzdHMucG9ydCBpbXBvcnQgcGxhdGZvcm1fb3B0aW9ucywgY29uZmlndXJhdGlvbl9vcHRp b25zCiBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiAKIAotY2xhc3MgU3VnZ2Vz dFJldmlld2VycyhBYnN0cmFjdERlY2xhcmF0aXZlQ29tbWFuZCk6CitjbGFzcyBTdWdnZXN0UmV2 aWV3ZXJzKEFic3RyYWN0U2VxdWVuY2VkQ29tbWFuZCk6CiAgICAgbmFtZSA9ICJzdWdnZXN0LXJl dmlld2VycyIKICAgICBoZWxwX3RleHQgPSAiU3VnZ2VzdCByZXZpZXdlcnMgZm9yIGEgcGF0Y2gg YmFzZWQgb24gcmVjZW50IGNoYW5nZXMgdG8gdGhlIG1vZGlmaWVkIGZpbGVzLiIKKyAgICBzdGVw cyA9IFsKKyAgICAgICAgc3RlcHMuU3VnZ2VzdFJldmlld2VycywKKyAgICBdCiAKLSAgICBkZWYg X19pbml0X18oc2VsZik6Ci0gICAgICAgIG9wdGlvbnMgPSBbCi0gICAgICAgICAgICBzdGVwcy5P cHRpb25zLmdpdF9jb21taXQsCi0gICAgICAgIF0KLSAgICAgICAgQWJzdHJhY3REZWNsYXJhdGl2 ZUNvbW1hbmQuX19pbml0X18oc2VsZiwgb3B0aW9ucz1vcHRpb25zKQotCi0gICAgZGVmIGV4ZWN1 dGUoc2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6Ci0gICAgICAgIHJldmlld2VycyA9IHRvb2wu Y2hlY2tvdXQoKS5zdWdnZXN0ZWRfcmV2aWV3ZXJzKG9wdGlvbnMuZ2l0X2NvbW1pdCkKLSAgICAg ICAgcHJpbnQgIlxuIi5qb2luKFtyZXZpZXdlci5mdWxsX25hbWUgZm9yIHJldmlld2VyIGluIHJl dmlld2Vyc10pCisgICAgZGVmIF9wcmVwYXJlX3N0YXRlKHNlbGYsIG9wdGlvbnMsIGFyZ3MsIHRv b2wpOgorICAgICAgICBvcHRpb25zLnN1Z2dlc3RfcmV2aWV3ZXJzID0gVHJ1ZQogCiAKIGNsYXNz IEJ1Z3NUb0NvbW1pdChBYnN0cmFjdERlY2xhcmF0aXZlQ29tbWFuZCk6CmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvc3VnZ2VzdHJldmlld2Vycy5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9zdWdnZXN0cmV2aWV3ZXJzLnB5CmluZGV4 IDc2YmVmMzVhYzJkMGY5YjE3NjE0MTY1ODA4MjY0NDgzNWI4YWU2ZDguLjhjYjJkYTBlYjVmN2Zj OTg1NWZkMTM4N2YwNDkzOGQ2NTg0NTVlNzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zdGVwcy9zdWdnZXN0cmV2aWV3ZXJzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9zdGVwcy9zdWdnZXN0cmV2aWV3ZXJzLnB5CkBAIC00Miw5ICs0MiwxMiBA QCBjbGFzcyBTdWdnZXN0UmV2aWV3ZXJzKEFic3RyYWN0U3RlcCk6CiAgICAgICAgIGlmIG5vdCBz ZWxmLl9vcHRpb25zLnN1Z2dlc3RfcmV2aWV3ZXJzOgogICAgICAgICAgICAgcmV0dXJuCiAKLSAg ICAgICAgcmV2aWV3ZXJzID0gc2VsZi5fdG9vbC5jaGVja291dCgpLnN1Z2dlc3RlZF9yZXZpZXdl cnMoc2VsZi5fb3B0aW9ucy5naXRfY29tbWl0LCBzZWxmLl9jaGFuZ2VkX2ZpbGVzKHN0YXRlKSkK KyAgICAgICAgcmV2aWV3ZXJzID0gc2VsZi5fdG9vbC5jaGVja291dCgpLnN1Z2dlc3RlZF9yZXZp ZXdlcnMoc2VsZi5fb3B0aW9ucy5naXRfY29tbWl0LCBzZWxmLl9jaGFuZ2VkX2ZpbGVzKHN0YXRl KSlbOjVdCiAgICAgICAgIHByaW50ICJUaGUgZm9sbG93aW5nIHJldmlld2VycyBoYXZlIHJlY2Vu dGx5IG1vZGlmaWVkIGZpbGVzIGluIHlvdXIgcGF0Y2g6IgogICAgICAgICBwcmludCAiXG4iLmpv aW4oW3Jldmlld2VyLmZ1bGxfbmFtZSBmb3IgcmV2aWV3ZXIgaW4gcmV2aWV3ZXJzXSkKKworICAg ICAgICBpZiBub3Qgc3RhdGUuZ2V0KCdidWdfaWQnKToKKyAgICAgICAgICAgIHJldHVybgogICAg ICAgICBpZiBub3Qgc2VsZi5fdG9vbC51c2VyLmNvbmZpcm0oIldvdWxkIHlvdSBsaWtlIHRvIEND IHRoZW0/Iik6CiAgICAgICAgICAgICByZXR1cm4KICAgICAgICAgcmV2aWV3ZXJfZW1haWxzID0g W3Jldmlld2VyLmJ1Z3ppbGxhX2VtYWlsKCkgZm9yIHJldmlld2VyIGluIHJldmlld2Vyc10K 184447 2013-01-24 02:15:15 -0800 2013-02-15 12:38:37 -0800 Patch bug-107528-20130124111207.patch text/plain 5977 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzNmNzI2MjE1N2I1Nzg4MzI2NDQ2MDMwNjhmYTQ0ZmNh Yjc0MjM4NC4uY2QxNjUxYjQ5MDgzM2YzNDM0Yzc4MzQzOTE4MjM3ODBiYjI1NWQ5YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDEzLTAxLTI0ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKwor ICAgICAgICB3ZWJraXQtcGF0Y2ggc3VnZ2VzdC1yZXZpZXdlcnMgc2hvdWxkIGxpbWl0IGl0c2Vs ZiB0byA1IHJldmlld2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA3NTI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVja291dC5weToK KyAgICAgICAgKENoZWNrb3V0LnN1Z2dlc3RlZF9yZXZpZXdlcnMpOiBJdGVyYXRlIHRocm91Z2gg dGhlIHNvcnRlZCBjb21taXQgaW5mbyBsaXN0LAorICAgICAgICBzY3JhcGluZyByZXZpZXdlcnMg ZnJvbSB0aGUgY29tbWl0IGluZm9ybWF0aW9uIGFuZCBpbiB0aGUgZW5kIHByb2R1Y2luZyBhIGxp c3QKKyAgICAgICAgb2YgcmV2aWV3ZXJzIHRoYXQncyBzb3J0ZWQgZnJvbSB0aGUgbW9zdCB0byBs ZWFzdCByZWNlbnQgYWN0aXZpdHkgb2YgYW55IHJldmlld2VyCisgICAgICAgIHRoYXQgaGFzIHJl dmlld2VkIG9yIGF1dGhvcmVkIHBhdGNoZXMgZm9yIHRoZSBjaGFuZ2VkIGZpbGVzLgorICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWVyaWVzLnB5OgorICAgICAgICAo U3VnZ2VzdFJldmlld2Vycyk6IFVzZSB0aGUgU3VnZ2VzdFJldmlld2VycyBzdGVwIGluc3RlYWQg b2YgcmVpbXBsZW1lbnRpbmcgbXVjaCBvZgorICAgICAgICB0aGUgc2FtZSBsb2dpYy4KKyAgICAg ICAgKFN1Z2dlc3RSZXZpZXdlcnMuX3ByZXBhcmVfc3RhdGUpOiBGb3JjZSB0aGUgcmV2aWV3ZXIg c3VnZ2VzdGlvbiBiZWNhdXNlIHRoZSBvcHRpb24KKyAgICAgICAgZGVmYXVsdHMgdG8gRmFsc2Uu CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3N1Z2dlc3RyZXZpZXdlcnMu cHk6CisgICAgICAgIChTdWdnZXN0UmV2aWV3ZXJzLnJ1bik6IE9ubHkgbGlzdCB0aGUgZmlyc3Qg Zml2ZSBzdWdnZXN0ZWQgcmV2aWV3ZXJzLCBub3cgcHJpbnRlZCBvdXQKKyAgICAgICAgb24gYSBz aW5nbGUgbGluZS4gIE9ubHkgYXNrIGZvciBDQy1pbmcgdGhlIHN1Z2dlc3RlZCByZXZpZXdlcnMg dG8gdGhlIGJ1ZyBpZiB0aGUKKyAgICAgICAgYnVnIElEIGlzIGxvY2F0ZWQgaW4gdGhlIGNvbW1h bmQncyBzdGF0ZS4KKwogMjAxMy0wMS0yMyAgTWFyayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBHaXZlIHdlYmtpdF9zdXBwb3J0IGEgY2hhbmNl IHRvIHJlc2V0IHN0YXRlIGJldHdlZW4gbGF5b3V0IHRlc3QgcnVucwpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hlY2tvdXQucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVja291dC5weQppbmRleCBmYjY4NmY0 ZDZkYTgxNjI4MTA0NzQzM2FmZmUxOTY1NTMwMzg1MTEwLi5mNTk5YWNlODIzNjRhZTkyMjY0MDkx MGNkYzhmZDVkMzBmOWQ4YWFjIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jaGVja291dC9jaGVja291dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jaGVja291dC9jaGVja291dC5weQpAQCAtMTM1LDEwICsxMzUsMTAgQEAgY2xhc3MgQ2hl Y2tvdXQob2JqZWN0KToKIAogICAgIGRlZiBzdWdnZXN0ZWRfcmV2aWV3ZXJzKHNlbGYsIGdpdF9j b21taXQsIGNoYW5nZWRfZmlsZXM9Tm9uZSk6CiAgICAgICAgIGNoYW5nZWRfZmlsZXMgPSBzZWxm Lm1vZGlmaWVkX25vbl9jaGFuZ2Vsb2dzKGdpdF9jb21taXQsIGNoYW5nZWRfZmlsZXMpCi0gICAg ICAgIGNvbW1pdF9pbmZvcyA9IHNlbGYucmVjZW50X2NvbW1pdF9pbmZvc19mb3JfZmlsZXMoY2hh bmdlZF9maWxlcykKLSAgICAgICAgcmV2aWV3ZXJzID0gW2NvbW1pdF9pbmZvLnJldmlld2VyKCkg Zm9yIGNvbW1pdF9pbmZvIGluIGNvbW1pdF9pbmZvcyBpZiBjb21taXRfaW5mby5yZXZpZXdlcigp XQotICAgICAgICByZXZpZXdlcnMuZXh0ZW5kKFtjb21taXRfaW5mby5hdXRob3IoKSBmb3IgY29t bWl0X2luZm8gaW4gY29tbWl0X2luZm9zIGlmIGNvbW1pdF9pbmZvLmF1dGhvcigpIGFuZCBjb21t aXRfaW5mby5hdXRob3IoKS5jYW5fcmV2aWV3XSkKLSAgICAgICAgcmV0dXJuIHNvcnRlZChzZXQo cmV2aWV3ZXJzKSkKKyAgICAgICAgY29tbWl0X2luZm9zID0gc29ydGVkKHNlbGYucmVjZW50X2Nv bW1pdF9pbmZvc19mb3JfZmlsZXMoY2hhbmdlZF9maWxlcyksIGtleT1sYW1iZGEgaW5mbzogaW5m by5yZXZpc2lvbigpLCByZXZlcnNlPVRydWUpCisgICAgICAgIHJldmlld2VycyA9IGZpbHRlcihs YW1iZGEgcGVyc29uOiBwZXJzb24gYW5kIHBlcnNvbi5jYW5fcmV2aWV3LCBzdW0obWFwKGxhbWJk YSBpbmZvOiBbaW5mby5yZXZpZXdlcigpLCBpbmZvLmF1dGhvcigpXSwgY29tbWl0X2luZm9zKSwg W10pKQorICAgICAgICB1bmlxdWVfcmV2aWV3ZXJzID0gcmVkdWNlKGxhbWJkYSBzdWdnZXN0aW9u cywgcmV2aWV3ZXI6IHN1Z2dlc3Rpb25zICsgW3Jldmlld2VyIGlmIHJldmlld2VyIG5vdCBpbiBz dWdnZXN0aW9ucyBlbHNlIE5vbmVdLCByZXZpZXdlcnMsIFtdKQorICAgICAgICByZXR1cm4gZmls dGVyKGxhbWJkYSByZXZpZXdlcjogcmV2aWV3ZXIsIHVuaXF1ZV9yZXZpZXdlcnMpCiAKICAgICBk ZWYgYnVnX2lkX2Zvcl90aGlzX2NvbW1pdChzZWxmLCBnaXRfY29tbWl0LCBjaGFuZ2VkX2ZpbGVz PU5vbmUpOgogICAgICAgICB0cnk6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9xdWVyaWVzLnB5CmluZGV4IDc5ZmZhOWJkOGRkY2Q3YzUxODQ3ZGM3ODFmMTc1ZDlm Y2RkNGE2YWUuLmVlYjkzYTFiYTBjZjc4YWZiMzZmZjc2MzQ0ZjVmODAwOWY3OTExMTQgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWVyaWVzLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWVyaWVzLnB5CkBAIC00 NCw2ICs0NCw3IEBAIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldC5idWlsZGJvdCBpbXBvcnQgQnVp bGRCb3QKIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldC5yZWdyZXNzaW9ud2luZG93IGltcG9ydCBS ZWdyZXNzaW9uV2luZG93CiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uY3Jhc2hsb2dzIGlt cG9ydCBDcmFzaExvZ3MKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS51c2VyIGltcG9ydCBV c2VyCitmcm9tIHdlYmtpdHB5LnRvb2wuY29tbWFuZHMuYWJzdHJhY3RzZXF1ZW5jZWRjb21tYW5k IGltcG9ydCBBYnN0cmFjdFNlcXVlbmNlZENvbW1hbmQKIGZyb20gd2Via2l0cHkudG9vbC5ncmFt bWFyIGltcG9ydCBwbHVyYWxpemUKIGZyb20gd2Via2l0cHkudG9vbC5tdWx0aWNvbW1hbmR0b29s IGltcG9ydCBBYnN0cmFjdERlY2xhcmF0aXZlQ29tbWFuZAogZnJvbSB3ZWJraXRweS5sYXlvdXRf dGVzdHMubW9kZWxzLnRlc3RfZXhwZWN0YXRpb25zIGltcG9ydCBUZXN0RXhwZWN0YXRpb25zCkBA IC01MiwxOSArNTMsMTUgQEAgZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydCBpbXBvcnQg cGxhdGZvcm1fb3B0aW9ucywgY29uZmlndXJhdGlvbl9vcHRpb25zCiBfbG9nID0gbG9nZ2luZy5n ZXRMb2dnZXIoX19uYW1lX18pCiAKIAotY2xhc3MgU3VnZ2VzdFJldmlld2VycyhBYnN0cmFjdERl Y2xhcmF0aXZlQ29tbWFuZCk6CitjbGFzcyBTdWdnZXN0UmV2aWV3ZXJzKEFic3RyYWN0U2VxdWVu Y2VkQ29tbWFuZCk6CiAgICAgbmFtZSA9ICJzdWdnZXN0LXJldmlld2VycyIKICAgICBoZWxwX3Rl eHQgPSAiU3VnZ2VzdCByZXZpZXdlcnMgZm9yIGEgcGF0Y2ggYmFzZWQgb24gcmVjZW50IGNoYW5n ZXMgdG8gdGhlIG1vZGlmaWVkIGZpbGVzLiIKKyAgICBzdGVwcyA9IFsKKyAgICAgICAgc3RlcHMu U3VnZ2VzdFJldmlld2VycywKKyAgICBdCiAKLSAgICBkZWYgX19pbml0X18oc2VsZik6Ci0gICAg ICAgIG9wdGlvbnMgPSBbCi0gICAgICAgICAgICBzdGVwcy5PcHRpb25zLmdpdF9jb21taXQsCi0g ICAgICAgIF0KLSAgICAgICAgQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1hbmQuX19pbml0X18oc2Vs Ziwgb3B0aW9ucz1vcHRpb25zKQotCi0gICAgZGVmIGV4ZWN1dGUoc2VsZiwgb3B0aW9ucywgYXJn cywgdG9vbCk6Ci0gICAgICAgIHJldmlld2VycyA9IHRvb2wuY2hlY2tvdXQoKS5zdWdnZXN0ZWRf cmV2aWV3ZXJzKG9wdGlvbnMuZ2l0X2NvbW1pdCkKLSAgICAgICAgcHJpbnQgIlxuIi5qb2luKFty ZXZpZXdlci5mdWxsX25hbWUgZm9yIHJldmlld2VyIGluIHJldmlld2Vyc10pCisgICAgZGVmIF9w cmVwYXJlX3N0YXRlKHNlbGYsIG9wdGlvbnMsIGFyZ3MsIHRvb2wpOgorICAgICAgICBvcHRpb25z LnN1Z2dlc3RfcmV2aWV3ZXJzID0gVHJ1ZQogCiAKIGNsYXNzIEJ1Z3NUb0NvbW1pdChBYnN0cmFj dERlY2xhcmF0aXZlQ29tbWFuZCk6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvc3RlcHMvc3VnZ2VzdHJldmlld2Vycy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9zdGVwcy9zdWdnZXN0cmV2aWV3ZXJzLnB5CmluZGV4IDc2YmVmMzVhYzJkMGY5YjE3NjE0 MTY1ODA4MjY0NDgzNWI4YWU2ZDguLjQwYTI0ODI5YjRmNTRmYjdkNjc5MjZiMWYyMjBmYzg5Mzdj YzdhZjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9zdWdn ZXN0cmV2aWV3ZXJzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9z dWdnZXN0cmV2aWV3ZXJzLnB5CkBAIC00Miw5ICs0MiwxMiBAQCBjbGFzcyBTdWdnZXN0UmV2aWV3 ZXJzKEFic3RyYWN0U3RlcCk6CiAgICAgICAgIGlmIG5vdCBzZWxmLl9vcHRpb25zLnN1Z2dlc3Rf cmV2aWV3ZXJzOgogICAgICAgICAgICAgcmV0dXJuCiAKLSAgICAgICAgcmV2aWV3ZXJzID0gc2Vs Zi5fdG9vbC5jaGVja291dCgpLnN1Z2dlc3RlZF9yZXZpZXdlcnMoc2VsZi5fb3B0aW9ucy5naXRf Y29tbWl0LCBzZWxmLl9jaGFuZ2VkX2ZpbGVzKHN0YXRlKSkKKyAgICAgICAgcmV2aWV3ZXJzID0g c2VsZi5fdG9vbC5jaGVja291dCgpLnN1Z2dlc3RlZF9yZXZpZXdlcnMoc2VsZi5fb3B0aW9ucy5n aXRfY29tbWl0LCBzZWxmLl9jaGFuZ2VkX2ZpbGVzKHN0YXRlKSlbOjVdCiAgICAgICAgIHByaW50 ICJUaGUgZm9sbG93aW5nIHJldmlld2VycyBoYXZlIHJlY2VudGx5IG1vZGlmaWVkIGZpbGVzIGlu IHlvdXIgcGF0Y2g6IgotICAgICAgICBwcmludCAiXG4iLmpvaW4oW3Jldmlld2VyLmZ1bGxfbmFt ZSBmb3IgcmV2aWV3ZXIgaW4gcmV2aWV3ZXJzXSkKKyAgICAgICAgcHJpbnQgIiwgIi5qb2luKFty ZXZpZXdlci5mdWxsX25hbWUgZm9yIHJldmlld2VyIGluIHJldmlld2Vyc10pCisKKyAgICAgICAg aWYgbm90IHN0YXRlLmdldCgnYnVnX2lkJyk6CisgICAgICAgICAgICByZXR1cm4KICAgICAgICAg aWYgbm90IHNlbGYuX3Rvb2wudXNlci5jb25maXJtKCJXb3VsZCB5b3UgbGlrZSB0byBDQyB0aGVt PyIpOgogICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgIHJldmlld2VyX2VtYWlscyA9IFtyZXZp ZXdlci5idWd6aWxsYV9lbWFpbCgpIGZvciByZXZpZXdlciBpbiByZXZpZXdlcnNdCg==