<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>107525</bug_id>
          
          <creation_ts>2013-01-22 01:54:20 -0800</creation_ts>
          <short_desc>sheriff-bot should have a suggest-reviewers command</short_desc>
          <delta_ts>2013-01-23 06:13:33 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>107528</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>alancutter</cc>
    
    <cc>dpranke</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>812803</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-01-22 01:54:20 -0800</bug_when>
    <thetext>sheriff-bot should have a suggest-reviewers command

Just like webkit-patch suggest reviewers, but public in the channel.

It makes it trivial when someone shows up asking for a review to teach them how to get one.

&lt;eseidel&gt; sheriff-bot: suggest-reviewers 12345
&lt;sheriff-bot&gt; eseidel: Analyzing patch 23243 on bug 12353 for the best possible reviewrs
&lt;sheriff-bot&gt; eseidel: Added 5 reviewers to bug 12345: abarth, dpranke, ojan, othermaciej and darin.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>814074</commentid>
    <comment_count>1</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-01-23 03:38:03 -0800</bug_when>
    <thetext>AFAIU, this should apply any attachment up for review in the specified bug, run webkit-patch suggest-reviewers, and then CC the suggestions to the bug?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>814076</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-01-23 03:41:33 -0800</bug_when>
    <thetext>Correct.  As I note in the dependent bug, suggest-reviewers may need a bit of clean-up before it can be made prime-time.  Currently it can be a bit over-zealous with its ccing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>814129</commentid>
    <comment_count>3</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-01-23 05:23:47 -0800</bug_when>
    <thetext>I find suggest-reviewers command to be terribly slow. Is it just my system or is this a common problem? If this is widespread, does it make sense to hog the sheriffbot with executing this command?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>814147</commentid>
    <comment_count>4</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-01-23 06:13:33 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; I find suggest-reviewers command to be terribly slow. Is it just my system or is this a common problem? If this is widespread, does it make sense to hog the sheriffbot with executing this command?

This actually works pretty fast when using a git-svn checkout, so I&apos;m removing this complaint.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>