107524 2013-01-22 01:52:23 -0800 [v8] Convert string conversion calls to one byte versions 2013-01-22 11:42:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dcarney webkit-unassigned abarth haraken japhet webkit.review.bot oldest_to_newest 812801 0 dcarney 2013-01-22 01:52:23 -0800 [v8] Convert string conversion calls to one byte versions 812802 1 183932 dcarney 2013-01-22 01:54:18 -0800 Created attachment 183932 Patch 812823 2 183932 haraken 2013-01-22 02:24:21 -0800 Comment on attachment 183932 Patch Looks OK 812898 3 183932 webkit.review.bot 2013-01-22 04:00:47 -0800 Comment on attachment 183932 Patch Clearing flags on attachment: 183932 Committed r140409: <http://trac.webkit.org/changeset/140409> 812899 4 webkit.review.bot 2013-01-22 04:00:53 -0800 All reviewed patches have been landed. Closing bug. 813101 5 183932 abarth 2013-01-22 09:44:33 -0800 Comment on attachment 183932 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183932&action=review > Source/WebCore/bindings/v8/SerializedScriptValue.cpp:325 > - string->WriteAscii(buffer, 0, length, v8StringWriteOptions()); > + string->WriteOneByte(byteAt(m_position), 0, length, v8StringWriteOptions()); What'st he difference between these two calls? (Just curious.) 813272 6 183932 dcarney 2013-01-22 11:40:40 -0800 Comment on attachment 183932 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183932&action=review >> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:325 >> + string->WriteOneByte(byteAt(m_position), 0, length, v8StringWriteOptions()); > > What'st he difference between these two calls? (Just curious.) WriteAscii is being removed from the v8 api after WebKit and chrome have removed it. WriteOneByte takes a uint8_t* as the first argument to indicate that it writes Latin-1. 813275 7 abarth 2013-01-22 11:42:56 -0800 Makes sense. Thanks! 183932 2013-01-22 01:54:18 -0800 2013-01-22 11:40:40 -0800 Patch bug-107524-20130122105112.patch text/plain 7025 dcarney U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjk4NzFiOGUwYmYxYzg2 MGE2ZjcwM2MwMTBlMzE5ZDU3NTliNTA4Zi4uYjU0NjJmM2Q1YjIxODE1OWRlYTkzNzE0MzAxYTkz ZDE1MjNjNGU2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTIyICBEYW4g Q2FybmV5ICA8ZGNhcm5leUBnb29nbGUuY29tPgorCisgICAgICAgIFt2OF0gQ29udmVydCBzdHJp bmcgY29udmVyc2lvbiBjYWxscyB0byBvbmUgYnl0ZSB2ZXJzaW9ucworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NTI0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2Ug aW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3Jp cHRWYWx1ZS5jcHA6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhTdHJpbmdSZXNvdXJjZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpXZWJDb3JlU3RyaW5nUmVzb3VyY2VCYXNlOjp0b1dlYkNvcmVT dHJpbmdSZXNvdXJjZUJhc2UpOgorICAgICAgICAoU3RyaW5nVHJhaXRzKToKKyAgICAgICAgKFdl YkNvcmU6OnRydWUpOgorICAgICAgICAoV2ViQ29yZTo6djhTdHJpbmdUb1dlYkNvcmVTdHJpbmcp OgorCiAyMDEzLTAxLTIxICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBbVjhdIFNjcmlwdFN0YXRlOjppc29sYXRlKCkgc2hvdWxkIHVzZSBDb250ZXh0OjpH ZXRJc29sYXRlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Nlcmlh bGl6ZWRTY3JpcHRWYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxp emVkU2NyaXB0VmFsdWUuY3BwCmluZGV4IGJlNTRkZjA2NWJhZGY0ODVjZmU1MmU5YWQ3N2U1YzU3 MDk1YTQyYTQuLjg2MjZkN2JkY2U0YjVmODRmMjg3ZGM3ZTQ5MDBiMDhmMjhjZDMyNTUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVl LmNwcApAQCAtMzEzLDcgKzMxMyw3IEBAIHB1YmxpYzoKICAgICAgICAgZG9Xcml0ZVN0cmluZyhk YXRhLCBsZW5ndGgpOwogICAgIH0KIAotICAgIHZvaWQgd3JpdGVBc2NpaVN0cmluZyh2ODo6SGFu ZGxlPHY4OjpTdHJpbmc+JiBzdHJpbmcpCisgICAgdm9pZCB3cml0ZU9uZUJ5dGVTdHJpbmcodjg6 OkhhbmRsZTx2ODo6U3RyaW5nPiYgc3RyaW5nKQogICAgIHsKICAgICAgICAgaW50IGxlbmd0aCA9 IHN0cmluZy0+TGVuZ3RoKCk7CiAgICAgICAgIEFTU0VSVChsZW5ndGggPj0gMCk7CkBAIC0zMjIs OCArMzIyLDcgQEAgcHVibGljOgogICAgICAgICBkb1dyaXRlVWludDMyKHN0YXRpY19jYXN0PHVp bnQzMl90PihsZW5ndGgpKTsKICAgICAgICAgZW5zdXJlU3BhY2UobGVuZ3RoKTsKIAotICAgICAg ICBjaGFyKiBidWZmZXIgPSByZWludGVycHJldF9jYXN0PGNoYXIqPihieXRlQXQobV9wb3NpdGlv bikpOwotICAgICAgICBzdHJpbmctPldyaXRlQXNjaWkoYnVmZmVyLCAwLCBsZW5ndGgsIHY4U3Ry aW5nV3JpdGVPcHRpb25zKCkpOworICAgICAgICBzdHJpbmctPldyaXRlT25lQnl0ZShieXRlQXQo bV9wb3NpdGlvbiksIDAsIGxlbmd0aCwgdjhTdHJpbmdXcml0ZU9wdGlvbnMoKSk7CiAgICAgICAg IG1fcG9zaXRpb24gKz0gbGVuZ3RoOwogICAgIH0KIApAQCAtNjY2LDcgKzY2NSw3IEBAIHByaXZh dGU6CiAKICAgICBpbnQgdjhTdHJpbmdXcml0ZU9wdGlvbnMoKQogICAgIHsKLSAgICAgICAgcmV0 dXJuIHY4OjpTdHJpbmc6Ok5PX05VTExfVEVSTUlOQVRJT04gfCB2ODo6U3RyaW5nOjpQUkVTRVJW RV9BU0NJSV9OVUxMOworICAgICAgICByZXR1cm4gdjg6OlN0cmluZzo6Tk9fTlVMTF9URVJNSU5B VElPTjsKICAgICB9CiAKICAgICBWZWN0b3I8QnVmZmVyVmFsdWVUeXBlPiBtX2J1ZmZlcjsKQEAg LTEwNDgsOCArMTA0Nyw4IEBAIHByaXZhdGU6CiAgICAgdm9pZCB3cml0ZVN0cmluZyh2ODo6SGFu ZGxlPHY4OjpWYWx1ZT4gdmFsdWUpCiAgICAgewogICAgICAgICB2ODo6SGFuZGxlPHY4OjpTdHJp bmc+IHN0cmluZyA9IHZhbHVlLkFzPHY4OjpTdHJpbmc+KCk7Ci0gICAgICAgIGlmICghc3RyaW5n LT5MZW5ndGgoKSB8fCAhc3RyaW5nLT5NYXlDb250YWluTm9uQXNjaWkoKSkKLSAgICAgICAgICAg IG1fd3JpdGVyLndyaXRlQXNjaWlTdHJpbmcoc3RyaW5nKTsKKyAgICAgICAgaWYgKCFzdHJpbmct Pkxlbmd0aCgpIHx8IHN0cmluZy0+SXNPbmVCeXRlKCkpCisgICAgICAgICAgICBtX3dyaXRlci53 cml0ZU9uZUJ5dGVTdHJpbmcoc3RyaW5nKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgbV93 cml0ZXIud3JpdGVVQ2hhclN0cmluZyhzdHJpbmcpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4U3RyaW5nUmVzb3VyY2UuY3BwIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhTdHJpbmdSZXNvdXJjZS5jcHAKaW5kZXggMzcxMzkxZDJiOTU4Yzlj YTc4ZGE3ZmQzNmU4MDRjNTc2MTY4ZjQ5OS4uOGFjNmYwY2VmYjY3ZGY0NDYwM2RmOTE0YjliNjk5 NDhmMDA5NzMxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhTdHJp bmdSZXNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhTdHJpbmdS ZXNvdXJjZS5jcHAKQEAgLTM3LDcgKzM3LDcgQEAgV2ViQ29yZVN0cmluZ1Jlc291cmNlQmFzZSog V2ViQ29yZVN0cmluZ1Jlc291cmNlQmFzZTo6dG9XZWJDb3JlU3RyaW5nUmVzb3VyY2VCYXMKICAg ICB2ODo6U3RyaW5nOjpFeHRlcm5hbFN0cmluZ1Jlc291cmNlQmFzZSogcmVzb3VyY2UgPSBzdHJp bmctPkdldEV4dGVybmFsU3RyaW5nUmVzb3VyY2VCYXNlKCZlbmNvZGluZyk7CiAgICAgaWYgKCFy ZXNvdXJjZSkKICAgICAgICAgcmV0dXJuIDA7Ci0gICAgaWYgKGVuY29kaW5nID09IHY4OjpTdHJp bmc6OkFTQ0lJX0VOQ09ESU5HKQorICAgIGlmIChlbmNvZGluZyA9PSB2ODo6U3RyaW5nOjpPTkVf QllURV9FTkNPRElORykKICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFdlYkNvcmVTdHJpbmdS ZXNvdXJjZTgqPihyZXNvdXJjZSk7CiAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFdlYkNvcmVTdHJp bmdSZXNvdXJjZTE2Kj4ocmVzb3VyY2UpOwogfQpAQCAtNTIsNyArNTIsNyBAQCB2b2lkIFdlYkNv cmVTdHJpbmdSZXNvdXJjZUJhc2U6OnZpc2l0U3RyaW5ncyhFeHRlcm5hbFN0cmluZ1Zpc2l0b3Iq IHZpc2l0b3IpCiB0ZW1wbGF0ZTxjbGFzcyBTdHJpbmdDbGFzcz4gc3RydWN0IFN0cmluZ1RyYWl0 cyB7CiAgICAgc3RhdGljIGNvbnN0IFN0cmluZ0NsYXNzJiBmcm9tU3RyaW5nUmVzb3VyY2UoV2Vi Q29yZVN0cmluZ1Jlc291cmNlQmFzZSopOwogICAgIHN0YXRpYyBib29sIGlzMTZCaXRBdG9taWNT dHJpbmcoU3RyaW5nQ2xhc3MmKTsKLSAgICB0ZW1wbGF0ZTxib29sIGFzY2lpPgorICAgIHRlbXBs YXRlPGJvb2wgb25lQnl0ZT4KICAgICBzdGF0aWMgU3RyaW5nQ2xhc3MgZnJvbVY4U3RyaW5nKHY4 OjpIYW5kbGU8djg6OlN0cmluZz4sIGludCk7CiB9OwogCkBAIC02Niw3ICs2Niw3IEBAIHN0cnVj dCBTdHJpbmdUcmFpdHM8U3RyaW5nPiB7CiAgICAgewogICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgfQotICAgIHRlbXBsYXRlPGJvb2wgYXNjaWk+CisgICAgdGVtcGxhdGU8Ym9vbCBvbmVCeXRl PgogICAgIHN0YXRpYyBTdHJpbmcgZnJvbVY4U3RyaW5nKHY4OjpIYW5kbGU8djg6OlN0cmluZz4s IGludCk7CiB9OwogCkBAIC04MCw3ICs4MCw3IEBAIHN0cnVjdCBTdHJpbmdUcmFpdHM8QXRvbWlj U3RyaW5nPiB7CiAgICAgewogICAgICAgICByZXR1cm4gIXN0cmluZy5zdHJpbmcoKS5pczhCaXQo KTsKICAgICB9Ci0gICAgdGVtcGxhdGU8Ym9vbCBhc2NpaT4KKyAgICB0ZW1wbGF0ZTxib29sIG9u ZUJ5dGU+CiAgICAgc3RhdGljIEF0b21pY1N0cmluZyBmcm9tVjhTdHJpbmcodjg6OkhhbmRsZTx2 ODo6U3RyaW5nPiwgaW50KTsKIH07CiAKQEAgLTExNiw3ICsxMTYsNyBAQCBTdHJpbmcgU3RyaW5n VHJhaXRzPFN0cmluZz46OmZyb21WOFN0cmluZzx0cnVlPih2ODo6SGFuZGxlPHY4OjpTdHJpbmc+ IHY4U3RyaW5nLAogICAgIEFTU0VSVCh2OFN0cmluZy0+TGVuZ3RoKCkgPT0gbGVuZ3RoKTsKICAg ICBMQ2hhciogYnVmZmVyOwogICAgIFN0cmluZyByZXN1bHQgPSBTdHJpbmc6OmNyZWF0ZVVuaW5p dGlhbGl6ZWQobGVuZ3RoLCBidWZmZXIpOwotICAgIHY4U3RyaW5nLT5Xcml0ZUFzY2lpKHJlaW50 ZXJwcmV0X2Nhc3Q8Y2hhcio+KGJ1ZmZlciksIDAsIGxlbmd0aCwgdjg6OlN0cmluZzo6UFJFU0VS VkVfQVNDSUlfTlVMTCk7CisgICAgdjhTdHJpbmctPldyaXRlT25lQnl0ZShidWZmZXIsIDAsIGxl bmd0aCk7CiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIApAQCAtMTI3LDEyICsxMjcsMTIgQEAgQXRv bWljU3RyaW5nIFN0cmluZ1RyYWl0czxBdG9taWNTdHJpbmc+Ojpmcm9tVjhTdHJpbmc8dHJ1ZT4o djg6OkhhbmRsZTx2ODo6U3RyaW4KICAgICBzdGF0aWMgY29uc3QgaW50IGlubGluZUJ1ZmZlclNp emUgPSAzMjsKICAgICBpZiAobGVuZ3RoIDw9IGlubGluZUJ1ZmZlclNpemUpIHsKICAgICAgICAg TENoYXIgaW5saW5lQnVmZmVyW2lubGluZUJ1ZmZlclNpemVdOwotICAgICAgICB2OFN0cmluZy0+ V3JpdGVBc2NpaShyZWludGVycHJldF9jYXN0PGNoYXIqPihpbmxpbmVCdWZmZXIpLCAwLCBsZW5n dGgsIHY4OjpTdHJpbmc6OlBSRVNFUlZFX0FTQ0lJX05VTEwpOworICAgICAgICB2OFN0cmluZy0+ V3JpdGVPbmVCeXRlKGlubGluZUJ1ZmZlciwgMCwgbGVuZ3RoKTsKICAgICAgICAgcmV0dXJuIEF0 b21pY1N0cmluZyhpbmxpbmVCdWZmZXIsIGxlbmd0aCk7CiAgICAgfQogICAgIExDaGFyKiBidWZm ZXI7CiAgICAgU3RyaW5nIHN0cmluZyA9IFN0cmluZzo6Y3JlYXRlVW5pbml0aWFsaXplZChsZW5n dGgsIGJ1ZmZlcik7Ci0gICAgdjhTdHJpbmctPldyaXRlQXNjaWkocmVpbnRlcnByZXRfY2FzdDxj aGFyKj4oYnVmZmVyKSwgMCwgbGVuZ3RoLCB2ODo6U3RyaW5nOjpQUkVTRVJWRV9BU0NJSV9OVUxM KTsKKyAgICB2OFN0cmluZy0+V3JpdGVPbmVCeXRlKGJ1ZmZlciwgMCwgbGVuZ3RoKTsKICAgICBy ZXR1cm4gQXRvbWljU3RyaW5nKHN0cmluZyk7CiB9CiAKQEAgLTE0Niw3ICsxNDYsNyBAQCBTdHJp bmdUeXBlIHY4U3RyaW5nVG9XZWJDb3JlU3RyaW5nKHY4OjpIYW5kbGU8djg6OlN0cmluZz4gdjhT dHJpbmcsIEV4dGVybmFsTW9kZQogICAgICAgICB2ODo6U3RyaW5nOjpFeHRlcm5hbFN0cmluZ1Jl c291cmNlQmFzZSogcmVzb3VyY2UgPSB2OFN0cmluZy0+R2V0RXh0ZXJuYWxTdHJpbmdSZXNvdXJj ZUJhc2UoJmVuY29kaW5nKTsKICAgICAgICAgaWYgKExJS0VMWSghIXJlc291cmNlKSkgewogICAg ICAgICAgICAgV2ViQ29yZVN0cmluZ1Jlc291cmNlQmFzZSogYmFzZTsKLSAgICAgICAgICAgIGlm IChlbmNvZGluZyA9PSB2ODo6U3RyaW5nOjpBU0NJSV9FTkNPRElORykKKyAgICAgICAgICAgIGlm IChlbmNvZGluZyA9PSB2ODo6U3RyaW5nOjpPTkVfQllURV9FTkNPRElORykKICAgICAgICAgICAg ICAgICBiYXNlID0gc3RhdGljX2Nhc3Q8V2ViQ29yZVN0cmluZ1Jlc291cmNlOCo+KHJlc291cmNl KTsKICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICBiYXNlID0gc3RhdGljX2Nhc3Q8 V2ViQ29yZVN0cmluZ1Jlc291cmNlMTYqPihyZXNvdXJjZSk7CkBAIC0xNTgsMTMgKzE1OCwxMyBA QCBTdHJpbmdUeXBlIHY4U3RyaW5nVG9XZWJDb3JlU3RyaW5nKHY4OjpIYW5kbGU8djg6OlN0cmlu Zz4gdjhTdHJpbmcsIEV4dGVybmFsTW9kZQogICAgIGlmIChVTkxJS0VMWSghbGVuZ3RoKSkKICAg ICAgICAgcmV0dXJuIFN0cmluZygiIik7CiAKLSAgICBib29sIG5vbkFzY2lpID0gdjhTdHJpbmct Pk1heUNvbnRhaW5Ob25Bc2NpaSgpOwotICAgIFN0cmluZ1R5cGUgcmVzdWx0KG5vbkFzY2lpID8g U3RyaW5nVHJhaXRzPFN0cmluZ1R5cGU+Ojp0ZW1wbGF0ZSBmcm9tVjhTdHJpbmc8ZmFsc2U+KHY4 U3RyaW5nLCBsZW5ndGgpIDogU3RyaW5nVHJhaXRzPFN0cmluZ1R5cGU+Ojp0ZW1wbGF0ZSBmcm9t VjhTdHJpbmc8dHJ1ZT4odjhTdHJpbmcsIGxlbmd0aCkpOworICAgIGJvb2wgb25lQnl0ZSA9IHY4 U3RyaW5nLT5Jc09uZUJ5dGUoKTsKKyAgICBTdHJpbmdUeXBlIHJlc3VsdChvbmVCeXRlID8gU3Ry aW5nVHJhaXRzPFN0cmluZ1R5cGU+Ojp0ZW1wbGF0ZSBmcm9tVjhTdHJpbmc8dHJ1ZT4odjhTdHJp bmcsIGxlbmd0aCkgOiBTdHJpbmdUcmFpdHM8U3RyaW5nVHlwZT46OnRlbXBsYXRlIGZyb21WOFN0 cmluZzxmYWxzZT4odjhTdHJpbmcsIGxlbmd0aCkpOwogCiAgICAgaWYgKGV4dGVybmFsICE9IEV4 dGVybmFsaXplIHx8ICF2OFN0cmluZy0+Q2FuTWFrZUV4dGVybmFsKCkpCiAgICAgICAgIHJldHVy biByZXN1bHQ7CiAKLSAgICBpZiAoIW5vbkFzY2lpICYmICFTdHJpbmdUcmFpdHM8U3RyaW5nVHlw ZT46OmlzMTZCaXRBdG9taWNTdHJpbmcocmVzdWx0KSkgeworICAgIGlmIChvbmVCeXRlICYmICFT dHJpbmdUcmFpdHM8U3RyaW5nVHlwZT46OmlzMTZCaXRBdG9taWNTdHJpbmcocmVzdWx0KSkgewog ICAgICAgICBXZWJDb3JlU3RyaW5nUmVzb3VyY2U4KiBzdHJpbmdSZXNvdXJjZSA9IG5ldyBXZWJD b3JlU3RyaW5nUmVzb3VyY2U4KHJlc3VsdCk7CiAgICAgICAgIGlmIChVTkxJS0VMWSghdjhTdHJp bmctPk1ha2VFeHRlcm5hbChzdHJpbmdSZXNvdXJjZSkpKQogICAgICAgICAgICAgZGVsZXRlIHN0 cmluZ1Jlc291cmNlOwo=