107517 2013-01-22 00:46:57 -0800 [V8] Pass an Isolate to toV8() of event listeners 2013-01-22 01:07:56 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 812731 0 haraken 2013-01-22 00:46:57 -0800 I think this would be the last patch to pass an Isolate to toV8(). In the next patch, I will make an Isolate parameter mandatory for toV8(). 812734 1 183913 haraken 2013-01-22 00:48:30 -0800 Created attachment 183913 Patch 812748 2 183913 webkit.review.bot 2013-01-22 01:07:52 -0800 Comment on attachment 183913 Patch Clearing flags on attachment: 183913 Committed r140397: <http://trac.webkit.org/changeset/140397> 812749 3 webkit.review.bot 2013-01-22 01:07:56 -0800 All reviewed patches have been landed. Closing bug. 183913 2013-01-22 00:48:30 -0800 2013-01-22 01:07:52 -0800 Patch bug-107517-20130122174524.patch text/plain 7498 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2MzYzNkMTk2ZGI4ODg1 MjUxODVmOTc1NTQyYWRjMjc0Y2I1ZmFhMC4uNmI5ZWUzNDhmZWFiYWE2NzBlNWI4ZjZjMTFmMTJh NjQ3MzVmZGY4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDEzLTAxLTIyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFBhc3MgYW4g SXNvbGF0ZSB0byB0b1Y4KCkgb2YgZXZlbnQgbGlzdGVuZXJzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc1MTcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCeSB1c2luZyBDb250ZXh0OjpHZXRJc29sYXRl KCksIHRoaXMgcGF0Y2ggcGFzc2VzIGFuIElzb2xhdGUgdG8gdG9WOCgpLgorICAgICAgICBJIHRo aW5rIHRoaXMgd291bGQgYmUgdGhlIGxhc3QgcGF0Y2ggdG8gcGFzcyBhbiBJc29sYXRlIHRvIHRv VjgoKS4KKyAgICAgICAgSW4gdGhlIG5leHQgcGF0Y2gsIEkgd2lsbCBtYWtlIGFuIElzb2xhdGUg cGFyYW1ldGVyIG1hbmRhdG9yeSBmb3IgdG9WOCgpLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBj aGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEFic3RyYWN0RXZl bnRMaXN0ZW5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOEFic3RyYWN0RXZlbnRMaXN0ZW5l cjo6Z2V0UmVjZWl2ZXJPYmplY3QpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RF dmVudExpc3RlbmVyLmg6CisgICAgICAgIChWOEFic3RyYWN0RXZlbnRMaXN0ZW5lcik6CisgICAg ICAgICogYmluZGluZ3MvdjgvVjhFdmVudExpc3RlbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlY4RXZlbnRMaXN0ZW5lcjo6Y2FsbExpc3RlbmVyRnVuY3Rpb24pOgorICAgICAgICAqIGJpbmRp bmdzL3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dG9PYmpl Y3RXcmFwcGVyKToKKyAgICAgICAgKFdlYkNvcmU6OlY4TGF6eUV2ZW50TGlzdGVuZXI6OmNhbGxM aXN0ZW5lckZ1bmN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlY4TGF6eUV2ZW50TGlzdGVuZXI6 OnByZXBhcmVMaXN0ZW5lck9iamVjdCk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhXb3JrZXJD b250ZXh0RXZlbnRMaXN0ZW5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFdvcmtlckNvbnRl eHRFdmVudExpc3RlbmVyOjpnZXRSZWNlaXZlck9iamVjdCk6CisKKzIwMTMtMDEtMjIgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFtWOF0gUGFzcyBhbiBJ c29sYXRlIHRvIHRvVjgoKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA3NTEyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVyLmNwcAppbmRleCA1NmQwZTQyOTVlZGRjMDkzMjg4ZTE3 YjYwMzI0NDg5YzIwZjJiZWQ1Li40NjRhMzgxZWI1ODI3NTAwMmY5YjRiZDA5Yzc4Nzk1ZDg5NDMz MDRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEFic3RyYWN0RXZl bnRMaXN0ZW5lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhBYnN0cmFj dEV2ZW50TGlzdGVuZXIuY3BwCkBAIC0xODIsMTMgKzE4MiwxMyBAQCBib29sIFY4QWJzdHJhY3RF dmVudExpc3RlbmVyOjpzaG91bGRQcmV2ZW50RGVmYXVsdCh2ODo6TG9jYWw8djg6OlZhbHVlPiBy ZXR1cm5WYQogICAgIHJldHVybiByZXR1cm5WYWx1ZS0+SXNCb29sZWFuKCkgJiYgIXJldHVyblZh bHVlLT5Cb29sZWFuVmFsdWUoKTsKIH0KIAotdjg6OkxvY2FsPHY4OjpPYmplY3Q+IFY4QWJzdHJh Y3RFdmVudExpc3RlbmVyOjpnZXRSZWNlaXZlck9iamVjdChFdmVudCogZXZlbnQpCit2ODo6TG9j YWw8djg6Ok9iamVjdD4gVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI6OmdldFJlY2VpdmVyT2JqZWN0 KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIEV2ZW50KiBldmVudCkKIHsKICAgICBp ZiAoIW1fbGlzdGVuZXIuaXNFbXB0eSgpICYmICFtX2xpc3RlbmVyLT5Jc0Z1bmN0aW9uKCkpCiAg ICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD46Ok5ldyhtX2xpc3RlbmVyLmdldCgp KTsKIAogICAgIEV2ZW50VGFyZ2V0KiB0YXJnZXQgPSBldmVudC0+Y3VycmVudFRhcmdldCgpOwot ICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSA9IHRvVjgodGFyZ2V0LCB2ODo6SGFuZGxl PHY4OjpPYmplY3Q+KCkpOworICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSA9IHRvVjgo dGFyZ2V0LCB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+KCksIHRvVjhDb250ZXh0KGNvbnRleHQsIHdv cmxkQ29udGV4dCgpKS0+R2V0SXNvbGF0ZSgpKTsKICAgICBpZiAodmFsdWUuSXNFbXB0eSgpKQog ICAgICAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpPYmplY3Q+KCk7CiAgICAgcmV0dXJuIHY4OjpM b2NhbDx2ODo6T2JqZWN0Pjo6TmV3KHY4OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3QodmFsdWUp KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RFdmVu dExpc3RlbmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEFic3RyYWN0RXZlbnRM aXN0ZW5lci5oCmluZGV4IDM4NzA2YzI0ZjBkMTQ5YWFjMTQ0MDZhZGIyNzE3YTYzZWU3NDhlYzAu LjYxYjc5NGY5NWViY2VlY2Y5M2RmMGVlYjZmN2MwY2EzMjA4ZDMwN2MgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVyLmgKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIuaApAQCAt MTE1LDcgKzExNSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCBpbnZva2VF dmVudEhhbmRsZXIoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIEV2ZW50Kiwgdjg6OkhhbmRsZTx2 ODo6VmFsdWU+IGpzRXZlbnQpOwogCiAgICAgICAgIC8vIEdldCB0aGUgcmVjZWl2ZXIgb2JqZWN0 IHRvIHVzZSBmb3IgZXZlbnQgbGlzdGVuZXIgY2FsbC4KLSAgICAgICAgdjg6OkxvY2FsPHY4OjpP YmplY3Q+IGdldFJlY2VpdmVyT2JqZWN0KEV2ZW50Kik7CisgICAgICAgIHY4OjpMb2NhbDx2ODo6 T2JqZWN0PiBnZXRSZWNlaXZlck9iamVjdChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgRXZlbnQq KTsKIAogICAgIHByaXZhdGU6CiAgICAgICAgIHN0YXRpYyB2b2lkIHdlYWtFdmVudExpc3RlbmVy Q2FsbGJhY2sodjg6OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiwgdm9pZCogcGFyYW1ldGVyKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RXZlbnRMaXN0ZW5lci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEV2ZW50TGlzdGVuZXIuY3BwCmluZGV4IGU4 NzJiMTdlODY5Y2I3NDY4ODA1OTE5NjJhMDZlY2FmYjU1ZDA1NzQuLjEyODFmNTk0YjYxYzRmN2Zi NWFkODhhNGY3YTJkMjg4NWY2ZjMyNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4RXZlbnRMaXN0ZW5lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhFdmVudExpc3RlbmVyLmNwcApAQCAtNzIsNyArNzIsNyBAQCB2ODo6TG9jYWw8djg6OlZh bHVlPiBWOEV2ZW50TGlzdGVuZXI6OmNhbGxMaXN0ZW5lckZ1bmN0aW9uKFNjcmlwdEV4ZWN1dGlv bkNvbnRleAogewogCiAgICAgdjg6OkxvY2FsPHY4OjpGdW5jdGlvbj4gaGFuZGxlckZ1bmN0aW9u ID0gZ2V0TGlzdGVuZXJGdW5jdGlvbihjb250ZXh0KTsKLSAgICB2ODo6TG9jYWw8djg6Ok9iamVj dD4gcmVjZWl2ZXIgPSBnZXRSZWNlaXZlck9iamVjdChldmVudCk7CisgICAgdjg6OkxvY2FsPHY4 OjpPYmplY3Q+IHJlY2VpdmVyID0gZ2V0UmVjZWl2ZXJPYmplY3QoY29udGV4dCwgZXZlbnQpOwog ICAgIGlmIChoYW5kbGVyRnVuY3Rpb24uSXNFbXB0eSgpIHx8IHJlY2VpdmVyLklzRW1wdHkoKSkK ICAgICAgICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6VmFsdWU+KCk7CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAKaW5kZXggYjhkZjRk OGVmZDFmOWY2ZTUxOGFmMjFkNWIxNjEwNDViMDE1YmQ5Zi4uNDcxYmEyOTE1Njk4YTM2OWNhMTA1 MjE2ZjU2MDNhY2I3Zjk4MGY2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAKQEAgLTYzLDExICs2MywxMSBAQCBWOExhenlFdmVu dExpc3RlbmVyOjpWOExhenlFdmVudExpc3RlbmVyKGNvbnN0IEF0b21pY1N0cmluZyYgZnVuY3Rp b25OYW1lLCBjb25zdAogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgotdjg6OkhhbmRsZTx2ODo6 T2JqZWN0PiB0b09iamVjdFdyYXBwZXIoVCogZG9tT2JqZWN0KQordjg6OkhhbmRsZTx2ODo6T2Jq ZWN0PiB0b09iamVjdFdyYXBwZXIoVCogZG9tT2JqZWN0LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkK IHsKICAgICBpZiAoIWRvbU9iamVjdCkKICAgICAgICAgcmV0dXJuIHY4OjpPYmplY3Q6Ok5ldygp OwotICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSA9IHRvVjgoZG9tT2JqZWN0LCB2ODo6 SGFuZGxlPHY4OjpPYmplY3Q+KCkpOworICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSA9 IHRvVjgoZG9tT2JqZWN0LCB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+KCksIGlzb2xhdGUpOwogICAg IGlmICh2YWx1ZS5Jc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiB2ODo6T2JqZWN0OjpOZXcoKTsK ICAgICByZXR1cm4gdmFsdWUuQXM8djg6Ok9iamVjdD4oKTsKQEAgLTgwLDcgKzgwLDcgQEAgdjg6 OkxvY2FsPHY4OjpWYWx1ZT4gVjhMYXp5RXZlbnRMaXN0ZW5lcjo6Y2FsbExpc3RlbmVyRnVuY3Rp b24oU2NyaXB0RXhlY3V0aW9uQ28KICAgICAgICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6VmFsdWU+ KCk7CiAKICAgICB2ODo6TG9jYWw8djg6OkZ1bmN0aW9uPiBoYW5kbGVyRnVuY3Rpb24gPSBsaXN0 ZW5lck9iamVjdC5Bczx2ODo6RnVuY3Rpb24+KCk7Ci0gICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+ IHJlY2VpdmVyID0gZ2V0UmVjZWl2ZXJPYmplY3QoZXZlbnQpOworICAgIHY4OjpMb2NhbDx2ODo6 T2JqZWN0PiByZWNlaXZlciA9IGdldFJlY2VpdmVyT2JqZWN0KGNvbnRleHQsIGV2ZW50KTsKICAg ICBpZiAoaGFuZGxlckZ1bmN0aW9uLklzRW1wdHkoKSB8fCByZWNlaXZlci5Jc0VtcHR5KCkpCiAg ICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6OlZhbHVlPigpOwogCkBAIC0xNzgsOSArMTc4LDkg QEAgdm9pZCBWOExhenlFdmVudExpc3RlbmVyOjpwcmVwYXJlTGlzdGVuZXJPYmplY3QoU2NyaXB0 RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCkKICAgICBpZiAobV9ub2RlICYmIG1fbm9kZS0+aXNI VE1MRWxlbWVudCgpKQogICAgICAgICBmb3JtRWxlbWVudCA9IHN0YXRpY19jYXN0PEhUTUxFbGVt ZW50Kj4obV9ub2RlKS0+Zm9ybSgpOwogCi0gICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBub2Rl V3JhcHBlciA9IHRvT2JqZWN0V3JhcHBlcjxOb2RlPihtX25vZGUpOwotICAgIHY4OjpIYW5kbGU8 djg6Ok9iamVjdD4gZm9ybVdyYXBwZXIgPSB0b09iamVjdFdyYXBwZXI8SFRNTEZvcm1FbGVtZW50 Pihmb3JtRWxlbWVudCk7Ci0gICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBkb2N1bWVudFdyYXBw ZXIgPSB0b09iamVjdFdyYXBwZXI8RG9jdW1lbnQ+KG1fbm9kZSA/IG1fbm9kZS0+b3duZXJEb2N1 bWVudCgpIDogMCk7CisgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBub2RlV3JhcHBlciA9IHRv T2JqZWN0V3JhcHBlcjxOb2RlPihtX25vZGUsIHY4Q29udGV4dC0+R2V0SXNvbGF0ZSgpKTsKKyAg ICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGZvcm1XcmFwcGVyID0gdG9PYmplY3RXcmFwcGVyPEhU TUxGb3JtRWxlbWVudD4oZm9ybUVsZW1lbnQsIHY4Q29udGV4dC0+R2V0SXNvbGF0ZSgpKTsKKyAg ICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGRvY3VtZW50V3JhcHBlciA9IHRvT2JqZWN0V3JhcHBl cjxEb2N1bWVudD4obV9ub2RlID8gbV9ub2RlLT5vd25lckRvY3VtZW50KCkgOiAwLCB2OENvbnRl eHQtPkdldElzb2xhdGUoKSk7CiAKICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4gdGhpc09iamVj dCA9IHY4OjpPYmplY3Q6Ok5ldygpOwogICAgIGlmICh0aGlzT2JqZWN0LklzRW1wdHkoKSkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4V29ya2VyQ29udGV4dEV2ZW50 TGlzdGVuZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhXb3JrZXJDb250ZXh0 RXZlbnRMaXN0ZW5lci5jcHAKaW5kZXggMjk1Njk5ODY3NTdjNmM4Mzk4MmExMDJjN2Y2YjhkNjBj ZmIxYWIzYS4uZGFlYTJmZTMxODc0NTkxZjhiMDA5ZWQ4Yjc1YTE4MmQxNTVhMzNlYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0 ZW5lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhXb3JrZXJDb250ZXh0 RXZlbnRMaXN0ZW5lci5jcHAKQEAgLTExOCw3ICsxMTgsNyBAQCB2ODo6TG9jYWw8djg6Ok9iamVj dD4gVjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0ZW5lcjo6Z2V0UmVjZWl2ZXJPYmplY3QoU2NyaXB0 RXhlYwogICAgICAgICByZXR1cm4gbGlzdGVuZXI7CiAKICAgICBFdmVudFRhcmdldCogdGFyZ2V0 ID0gZXZlbnQtPmN1cnJlbnRUYXJnZXQoKTsKLSAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdmFs dWUgPSB0b1Y4KHRhcmdldCwgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PigpKTsKKyAgICB2ODo6SGFu ZGxlPHY4OjpWYWx1ZT4gdmFsdWUgPSB0b1Y4KHRhcmdldCwgdjg6OkhhbmRsZTx2ODo6T2JqZWN0 PigpLCB0b1Y4Q29udGV4dChjb250ZXh0LCB3b3JsZENvbnRleHQoKSktPkdldElzb2xhdGUoKSk7 CiAgICAgaWYgKHZhbHVlLklzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6 T2JqZWN0PigpOwogICAgIHJldHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD46Ok5ldyh2ODo6SGFu ZGxlPHY4OjpPYmplY3Q+OjpDYXN0KHZhbHVlKSk7Cg==