107506 2013-01-21 23:20:22 -0800 [Mac] WK1 MiniBrowser should clear delegates before releasing webview 2013-01-21 23:41:23 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned webkit.review.bot oldest_to_newest 812646 0 joepeck 2013-01-21 23:20:22 -0800 You should always clear delegates before releasing the webview. I encountered a crash when I implemented some other UIDelegate methods for testing. We should just follow proper practice and clear delegates in dealloc. 812648 1 183897 joepeck 2013-01-21 23:22:48 -0800 Created attachment 183897 [PATCH] Clear delegates in dealloc 812659 2 183897 webkit.review.bot 2013-01-21 23:41:20 -0800 Comment on attachment 183897 [PATCH] Clear delegates in dealloc Clearing flags on attachment: 183897 Committed r140388: <http://trac.webkit.org/changeset/140388> 812660 3 webkit.review.bot 2013-01-21 23:41:23 -0800 All reviewed patches have been landed. Closing bug. 183897 2013-01-21 23:22:48 -0800 2013-01-21 23:41:20 -0800 [PATCH] Clear delegates in dealloc mini-fix.patch text/plain 1127 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmNTkx MjU3Li45ODE4MmE3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTMtMDEtMjEgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBbTWFjXSBXSzEgTWluaUJyb3dzZXIgc2hvdWxk IGNsZWFyIGRlbGVnYXRlcyBiZWZvcmUgcmVsZWFzaW5nIHdlYnZpZXcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzUwNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvbWFjL1dLMUJy b3dzZXJXaW5kb3dDb250cm9sbGVyLm06CisgICAgICAgICgtW1dLMUJyb3dzZXJXaW5kb3dDb250 cm9sbGVyIGRlYWxsb2NdKToKKworMjAxMy0wMS0yMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgorCiAgICAgICAgIEltcHJvdmUgUGFnZVZpc2liaWxpdHkgQVBJIHdpdGgg ZW51bXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NzM2NAogCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9tYWMvV0sxQnJvd3NlcldpbmRv d0NvbnRyb2xsZXIubSBiL1Rvb2xzL01pbmlCcm93c2VyL21hYy9XSzFCcm93c2VyV2luZG93Q29u dHJvbGxlci5tCmluZGV4IDI3M2FkYjUuLmJkYzM2MTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlC cm93c2VyL21hYy9XSzFCcm93c2VyV2luZG93Q29udHJvbGxlci5tCisrKyBiL1Rvb2xzL01pbmlC cm93c2VyL21hYy9XSzFCcm93c2VyV2luZG93Q29udHJvbGxlci5tCkBAIC00OCw2ICs0OCw5IEBA IC0gKHZvaWQpYXdha2VGcm9tTmliCiAKIC0gKHZvaWQpZGVhbGxvYwogeworICAgIFtfd2ViVmll dyBzZXRGcmFtZUxvYWREZWxlZ2F0ZTpuaWxdOworICAgIFtfd2ViVmlldyBzZXRVSURlbGVnYXRl Om5pbF07CisgICAgW193ZWJWaWV3IHNldFJlc291cmNlTG9hZERlbGVnYXRlOm5pbF07CiAgICAg W193ZWJWaWV3IHJlbGVhc2VdOwogCiAgICAgW3N1cGVyIGRlYWxsb2NdOwo=