107499 2013-01-21 21:26:24 -0800 [CHROMIUM] Suppress c4267 build warnings for Win64 targets 2013-01-21 22:14:58 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jschuh jschuh inferno webkit.review.bot oldest_to_newest 812580 0 jschuh 2013-01-21 21:26:24 -0800 Just need to suppress some warnings that we're hitting as build errors on Chromium Win64. 812581 1 183882 jschuh 2013-01-21 21:31:59 -0800 Created attachment 183882 Patch @inferno, would you mind rubberstamping these build fixes? 812586 2 183885 jschuh 2013-01-21 21:35:55 -0800 Created attachment 183885 Patch 812607 3 183885 webkit.review.bot 2013-01-21 22:14:55 -0800 Comment on attachment 183885 Patch Clearing flags on attachment: 183885 Committed r140384: <http://trac.webkit.org/changeset/140384> 812608 4 webkit.review.bot 2013-01-21 22:14:58 -0800 All reviewed patches have been landed. Closing bug. 183882 2013-01-21 21:31:59 -0800 2013-01-21 21:35:53 -0800 Patch bug-107499-20130121212854.patch text/plain 3791 jschuh SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQwMzgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEzLTAxLTIxICBKdXN0aW4gU2NodWggIDxqc2NodWhAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFtDSFJPTUlVTV0gU3VwcHJlc3MgYzQyNjcgYnVpbGQgd2FybmluZ3MgZm9yIFdpbjY0IHRh cmdldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NzQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog SmF2YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cDoKKwogMjAxMy0wMS0yMSAgRGly ayBTY2h1bHplICA8ZHNjaHVsemVAYWRvYmUuY29tPgogCiAgICAgICAgIEFkZCBidWlsZCBmbGFn IGZvciBDYW52YXMncyBQYXRoIG9iamVjdCAoZGlzYWJsZWQgYnkgZGVmYXVsdCkKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAv SmF2YVNjcmlwdENvcmUuZ3lwCShyZXZpc2lvbiAxNDAzNDkpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cAkod29ya2luZyBjb3B5 KQpAQCAtODksNiArODksMTIgQEAKICAgICAgICdleHBvcnRfZGVwZW5kZW50X3NldHRpbmdzJzog WwogICAgICAgICAnLi4vLi4vV1RGL1dURi5neXAvV1RGLmd5cDp3dGYnLAogICAgICAgXSwKKyAg ICAgICdjb25kaXRpb25zJzogWworICAgICAgICBbJ09TPT0id2luIicsIHsKKyAgICAgICAgICAj IERpc2FibGUgYzQyNjcgd2FybmluZ3MgdW50aWwgd2UgZml4IHNpemVfdCB0byBpbnQgdHJ1bmNh dGlvbnMuCisgICAgICAgICAgJ21zdnNfZGlzYWJsZWRfd2FybmluZ3MnOiBbNDI2NywgXSwKKyAg ICAgICAgfV0sCisgICAgICBdLAogICAgIH0sCiAgIF0sICMgdGFyZ2V0cwogfQpJbmRleDogU291 cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvUGxhdGZvcm0vQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDAzODIpCisrKyBTb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDEtMjEgIEp1c3RpbiBTY2h1aCAg PGpzY2h1aEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0NIUk9NSVVNXSBTdXBwcmVzcyBjNDI2 NyBidWlsZCB3YXJuaW5ncyBmb3IgV2luNjQgdGFyZ2V0cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NDk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS5neXAvUGxhdGZvcm0uZ3lwOgor CiAyMDEzLTAxLTIxICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAg ICAgICAgIE1lZGlhU3RyZWFtIEFQSTogVXBkYXRlIHRoZSBSVENQZWVyQ29ubmVjdGlvbiBzdGF0 ZXMgdG8gbWF0Y2ggdGhlIGxhdGVzdCBzcGVjaWZpY2F0aW9uCkluZGV4OiBTb3VyY2UvUGxhdGZv cm0vUGxhdGZvcm0uZ3lwL1BsYXRmb3JtLmd5cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvUGxhdGZv cm0vUGxhdGZvcm0uZ3lwL1BsYXRmb3JtLmd5cAkocmV2aXNpb24gMTQwMzQ5KQorKysgU291cmNl L1BsYXRmb3JtL1BsYXRmb3JtLmd5cC9QbGF0Zm9ybS5neXAJKHdvcmtpbmcgY29weSkKQEAgLTg2 LDYgKzg2LDEwIEBACiAgICAgICAgICAgICAgICAgICAgICAgICB9XSwKICAgICAgICAgICAgICAg ICAgICAgXSwKICAgICAgICAgICAgICAgICB9XSwKKyAgICAgICAgICAgICAgICBbJ09TPT0id2lu IicsIHsKKyAgICAgICAgICAgICAgICAgICAgIyBEaXNhYmxlIGM0MjY3IHdhcm5pbmdzIHVudGls IHdlIGZpeCBzaXplX3QgdG8gaW50IHRydW5jYXRpb25zLgorICAgICAgICAgICAgICAgICAgICAn bXN2c19kaXNhYmxlZF93YXJuaW5ncyc6IFs0MjY3LCBdLAorICAgICAgICAgICAgICAgIH1dLAog ICAgICAgICAgICAgXSwKICAgICAgICAgICAgICdjb3BpZXMnOiBbCiAgICAgICAgICAgICAgICAg ewpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQwMzgyKQorKysgU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDEtMjEgIEp1c3Rp biBTY2h1aCAgPGpzY2h1aEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0NIUk9NSVVNXSBTdXBw cmVzcyBjNDI2NyBidWlsZCB3YXJuaW5ncyBmb3IgV2luNjQgdGFyZ2V0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NDk5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISku CisKKyAgICAgICAgKiBXZWJDb3JlLmd5cC9XZWJDb3JlLmd5cDoKKwogMjAxMy0wMS0yMSAgRGlt aXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1vdmUgSFRN TCBBdHRyaWJ1dGUgY2FzZS1zZW5zaXRpdml0eSBsb2dpYyBvdXQgb2YgU2VsZWN0b3JDaGVja2Vy IHRvIEhUTUxEb2N1bWVudC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNv cmUuZ3lwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUu Z3lwCShyZXZpc2lvbiAxNDAzNDkpCisrKyBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJD b3JlLmd5cAkod29ya2luZyBjb3B5KQpAQCAtMTM2NCw3ICsxMzY0LDggQEAKICAgICAgICAgICAg ICdpbmNsdWRlX2RpcnMrKysnOiBbJy4uL2RvbSddLAogICAgICAgICAgIH0sCiAgICAgICAgICAg IyBJbiBnZW5lcmF0ZWQgYmluZGluZ3MgY29kZTogJ3N3aXRjaCBjb250YWlucyBkZWZhdWx0IGJ1 dCBubyBjYXNlJy4KLSAgICAgICAgICAnbXN2c19kaXNhYmxlZF93YXJuaW5ncyc6IFsgNDA2NSBd LAorICAgICAgICAgICMgRGlzYWJsZSBjNDI2NyB3YXJuaW5ncyB1bnRpbCB3ZSBmaXggc2l6ZV90 IHRvIGludCB0cnVuY2F0aW9ucy4KKyAgICAgICAgICAnbXN2c19kaXNhYmxlZF93YXJuaW5ncyc6 IFsgNDA2NSwgNDI2NyBdLAogICAgICAgICB9XSwKICAgICAgICAgWydPUyBpbiAoImxpbnV4Iiwg ImFuZHJvaWQiKSBhbmQgIldURl9VU0VfV0VCQVVESU9fSVBQPTEiIGluIGZlYXR1cmVfZGVmaW5l cycsIHsKICAgICAgICAgICAnY2ZsYWdzJzogWwo= 183885 2013-01-21 21:35:55 -0800 2013-01-21 22:14:55 -0800 Patch bug-107499-20130121213250.patch text/plain 3800 jschuh SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQwMzgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEzLTAxLTIxICBKdXN0aW4gU2NodWggIDxqc2NodWhAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFtDSFJPTUlVTV0gU3VwcHJlc3MgYzQyNjcgYnVpbGQgd2FybmluZ3MgZm9yIFdpbjY0IHRh cmdldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NzQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog SmF2YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cDoKKwogMjAxMy0wMS0yMSAgRGly ayBTY2h1bHplICA8ZHNjaHVsemVAYWRvYmUuY29tPgogCiAgICAgICAgIEFkZCBidWlsZCBmbGFn IGZvciBDYW52YXMncyBQYXRoIG9iamVjdCAoZGlzYWJsZWQgYnkgZGVmYXVsdCkKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAv SmF2YVNjcmlwdENvcmUuZ3lwCShyZXZpc2lvbiAxNDAzNDkpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cAkod29ya2luZyBjb3B5 KQpAQCAtODksNiArODksMTIgQEAKICAgICAgICdleHBvcnRfZGVwZW5kZW50X3NldHRpbmdzJzog WwogICAgICAgICAnLi4vLi4vV1RGL1dURi5neXAvV1RGLmd5cDp3dGYnLAogICAgICAgXSwKKyAg ICAgICdjb25kaXRpb25zJzogWworICAgICAgICBbJ09TPT0id2luIicsIHsKKyAgICAgICAgICAj IERpc2FibGUgYzQyNjcgd2FybmluZ3MgdW50aWwgd2UgZml4IHNpemVfdCB0byBpbnQgdHJ1bmNh dGlvbnMuCisgICAgICAgICAgJ21zdnNfZGlzYWJsZWRfd2FybmluZ3MnOiBbNDI2NywgXSwKKyAg ICAgICAgfV0sCisgICAgICBdLAogICAgIH0sCiAgIF0sICMgdGFyZ2V0cwogfQpJbmRleDogU291 cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvUGxhdGZvcm0vQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDAzODIpCisrKyBTb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDEtMjEgIEp1c3RpbiBTY2h1aCAg PGpzY2h1aEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0NIUk9NSVVNXSBTdXBwcmVzcyBjNDI2 NyBidWlsZCB3YXJuaW5ncyBmb3IgV2luNjQgdGFyZ2V0cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NDk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS5neXAvUGxhdGZvcm0uZ3lwOgor CiAyMDEzLTAxLTIxICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAg ICAgICAgIE1lZGlhU3RyZWFtIEFQSTogVXBkYXRlIHRoZSBSVENQZWVyQ29ubmVjdGlvbiBzdGF0 ZXMgdG8gbWF0Y2ggdGhlIGxhdGVzdCBzcGVjaWZpY2F0aW9uCkluZGV4OiBTb3VyY2UvUGxhdGZv cm0vUGxhdGZvcm0uZ3lwL1BsYXRmb3JtLmd5cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvUGxhdGZv cm0vUGxhdGZvcm0uZ3lwL1BsYXRmb3JtLmd5cAkocmV2aXNpb24gMTQwMzQ5KQorKysgU291cmNl L1BsYXRmb3JtL1BsYXRmb3JtLmd5cC9QbGF0Zm9ybS5neXAJKHdvcmtpbmcgY29weSkKQEAgLTg2 LDYgKzg2LDEwIEBACiAgICAgICAgICAgICAgICAgICAgICAgICB9XSwKICAgICAgICAgICAgICAg ICAgICAgXSwKICAgICAgICAgICAgICAgICB9XSwKKyAgICAgICAgICAgICAgICBbJ09TPT0id2lu IicsIHsKKyAgICAgICAgICAgICAgICAgICAgIyBEaXNhYmxlIGM0MjY3IHdhcm5pbmdzIHVudGls IHdlIGZpeCBzaXplX3QgdG8gaW50IHRydW5jYXRpb25zLgorICAgICAgICAgICAgICAgICAgICAn bXN2c19kaXNhYmxlZF93YXJuaW5ncyc6IFs0MjY3LCBdLAorICAgICAgICAgICAgICAgIH1dLAog ICAgICAgICAgICAgXSwKICAgICAgICAgICAgICdjb3BpZXMnOiBbCiAgICAgICAgICAgICAgICAg ewpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQwMzgyKQorKysgU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDEtMjEgIEp1c3Rp biBTY2h1aCAgPGpzY2h1aEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0NIUk9NSVVNXSBTdXBw cmVzcyBjNDI2NyBidWlsZCB3YXJuaW5ncyBmb3IgV2luNjQgdGFyZ2V0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NDk5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjb2Rl IGNoYW5nZXMuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cC9XZWJDb3JlLmd5cDoKKwogMjAxMy0w MS0yMSAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IE1vdmUgSFRNTCBBdHRyaWJ1dGUgY2FzZS1zZW5zaXRpdml0eSBsb2dpYyBvdXQgb2YgU2VsZWN0 b3JDaGVja2VyIHRvIEhUTUxEb2N1bWVudC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUu Z3lwL1dlYkNvcmUuZ3lwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lw L1dlYkNvcmUuZ3lwCShyZXZpc2lvbiAxNDAzNDkpCisrKyBTb3VyY2UvV2ViQ29yZS9XZWJDb3Jl Lmd5cC9XZWJDb3JlLmd5cAkod29ya2luZyBjb3B5KQpAQCAtMTM2NCw3ICsxMzY0LDggQEAKICAg ICAgICAgICAgICdpbmNsdWRlX2RpcnMrKysnOiBbJy4uL2RvbSddLAogICAgICAgICAgIH0sCiAg ICAgICAgICAgIyBJbiBnZW5lcmF0ZWQgYmluZGluZ3MgY29kZTogJ3N3aXRjaCBjb250YWlucyBk ZWZhdWx0IGJ1dCBubyBjYXNlJy4KLSAgICAgICAgICAnbXN2c19kaXNhYmxlZF93YXJuaW5ncyc6 IFsgNDA2NSBdLAorICAgICAgICAgICMgRGlzYWJsZSBjNDI2NyB3YXJuaW5ncyB1bnRpbCB3ZSBm aXggc2l6ZV90IHRvIGludCB0cnVuY2F0aW9ucy4KKyAgICAgICAgICAnbXN2c19kaXNhYmxlZF93 YXJuaW5ncyc6IFsgNDA2NSwgNDI2NyBdLAogICAgICAgICB9XSwKICAgICAgICAgWydPUyBpbiAo ImxpbnV4IiwgImFuZHJvaWQiKSBhbmQgIldURl9VU0VfV0VCQVVESU9fSVBQPTEiIGluIGZlYXR1 cmVfZGVmaW5lcycsIHsKICAgICAgICAgICAnY2ZsYWdzJzogWwo=