107492 2013-01-21 18:57:21 -0800 [GTK][MAC] Use CoreFoundation 2017-03-11 10:49:06 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 laszlo.gombos webkit-unassigned ap benjamin bugs-noreply gustavo hausmann kevino mrobinson oldest_to_newest 812526 0 laszlo.gombos 2013-01-21 18:57:21 -0800 OS() tests are preferred over a series of PLATFORM() tests for "for low-level services" - see also the discussion at bug 107406. JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT) and PLATFORM(WX), so "PLATFORM(MAC) || PLATFORM(IOS) || (PLATFORM(WX) && OS(DARWIN)) || (PLATFORM(QT) && OS(DARWIN))" can be replaced by OS(DARWIN) which makes the code more readable as well. 812527 1 183868 laszlo.gombos 2013-01-21 19:00:12 -0800 Created attachment 183868 proposed change 812531 2 183868 ap 2013-01-21 19:23:00 -0800 Comment on attachment 183868 proposed change View in context: https://bugs.webkit.org/attachment.cgi?id=183868&action=review > Source/JavaScriptCore/ChangeLog:8 > + JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT) > + and PLATFORM(WX) so "PLATFORM(MAC)||PLATFORM(QT)||PLATFORM(WX)" is > + always true. Can Gtk port be built on Mac? 812537 3 mrobinson 2013-01-21 19:36:01 -0800 (In reply to comment #2) > > Source/JavaScriptCore/ChangeLog:8 > > + JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT) > > + and PLATFORM(WX) so "PLATFORM(MAC)||PLATFORM(QT)||PLATFORM(WX)" is > > + always true. > > Can Gtk port be built on Mac? Yes. 812567 4 laszlo.gombos 2013-01-21 20:44:58 -0800 (In reply to comment #3) > (In reply to comment #2) > > > > Source/JavaScriptCore/ChangeLog:8 > > > + JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT) > > > + and PLATFORM(WX) so "PLATFORM(MAC)||PLATFORM(QT)||PLATFORM(WX)" is > > > + always true. > > > > Can Gtk port be built on Mac? > > Yes. I did not know that it is supported. In that case this is probably a performance optimization for the GTK port on Mac. Would it be possible for someone to verify this change for the GTK port on Mac ? 816592 5 laszlo.gombos 2013-01-25 07:45:11 -0800 Change the title to better reflect the functional change introduced by the patch. I cancel the review until we find someone who can help driving the GTK on MAC discussion. The larger issue here is the GTK's port policy on using CoreFoundation on OS(DARWIN). My sense is that reusing the CoreFoundation support from WebKit will make it easier to maintain the GTK MAC port, but I am not the right person to make this determination. Using CoreFoundation support from WebKit - USE(CF) - is the decision that the Qt and WX and CHROMIUM ports made on OS(DARWIN). 816603 6 mrobinson 2013-01-25 08:04:25 -0800 Okay. Assuming that this doesn't change functionality, it seems pretty harmless. 817296 7 laszlo.gombos 2013-01-26 18:36:37 -0800 (In reply to comment #6) > Okay. Assuming that this doesn't change functionality, it seems pretty harmless. Likely there is a performance benefit for using CF directly. 183868 2013-01-21 19:00:12 -0800 2013-01-25 07:45:19 -0800 proposed change 107492.patch text/plain 2198 laszlo.gombos SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQwMzc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTAxLTIxICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAg ICAgICAgQ29sbGFwc2UgdGVzdGluZyBmb3IgYWxsIERBUldJTiBzdXBwb3J0aW5nIHBsYXRmb3Jt cyB0byBPUyhEQVJXSU4pCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDc0OTIKKworICAgICAgICBKYXZhU2NyaXB0Q29yZSBmb3IgT1MoREFSV0lOKSBp cyB1c2VkIGJ5IFBMQVRGT1JNKE1BQyksIFBMQVRGT1JNKFFUKQorICAgICAgICBhbmQgUExBVEZP Uk0oV1gpIHNvICJQTEFURk9STShNQUMpfHxQTEFURk9STShRVCl8fFBMQVRGT1JNKFdYKSIgaXMK KyAgICAgICAgYWx3YXlzIHRydWUuCisKKyAgICAgICAgKiBydW50aW1lL0RhdGVQcm90b3R5cGUu Y3BwOgorICAgICAgICAoSlNDKToKKwogMjAxMy0wMS0yMSAgRGlyayBTY2h1bHplICA8ZHNjaHVs emVAYWRvYmUuY29tPgogCiAgICAgICAgIEFkZCBidWlsZCBmbGFnIGZvciBDYW52YXMncyBQYXRo IG9iamVjdCAoZGlzYWJsZWQgYnkgZGVmYXVsdCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwCShyZXZpc2lvbiAxNDAyODIpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRlUHJvdG90eXBlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjEsNyArNjEsNyBAQAogI2luY2x1ZGUgPHN5cy90aW1lYi5oPgogI2VuZGlmCiAK LSNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKElPUykgfHwgKFBMQVRGT1JNKFdYKSAmJiBP UyhEQVJXSU4pKSB8fCAoUExBVEZPUk0oUVQpICYmIE9TKERBUldJTikpCisjaWYgT1MoREFSV0lO KQogI2luY2x1ZGUgPENvcmVGb3VuZGF0aW9uL0NvcmVGb3VuZGF0aW9uLmg+CiAjZWxpZiBVU0Uo SUNVX1VOSUNPREUpCiAjaW5jbHVkZSA8dW5pY29kZS91ZGF0Lmg+CkBAIC0xMjUsOSArMTI1LDkg QEAgbmFtZXNwYWNlIEpTQyB7CiAKIGVudW0gTG9jYWxlRGF0ZVRpbWVGb3JtYXQgeyBMb2NhbGVE YXRlQW5kVGltZSwgTG9jYWxlRGF0ZSwgTG9jYWxlVGltZSB9OwogIAotI2lmIFBMQVRGT1JNKE1B QykgfHwgUExBVEZPUk0oSU9TKSB8fCAoUExBVEZPUk0oV1gpICYmIE9TKERBUldJTikpIHx8IChQ TEFURk9STShRVCkgJiYgT1MoREFSV0lOKSkKKyNpZiBPUyhEQVJXSU4pCiAKLS8vIEZJWE1FOiBT aW5jZSB0aGlzIGlzIHN1cGVyaW9yIHRvIHRoZSBzdHJmdGltZS1iYXNlZCB2ZXJzaW9uLCB3aHkg bGltaXQgdGhpcyB0byBQTEFURk9STShNQUMpPworLy8gRklYTUU6IFNpbmNlIHRoaXMgaXMgc3Vw ZXJpb3IgdG8gdGhlIHN0cmZ0aW1lLWJhc2VkIHZlcnNpb24sIHdoeSBsaW1pdCB0aGlzIHRvIE9T KERBUldJTik/CiAvLyBJbnN0ZWFkIHdlIHNob3VsZCBjb25zaWRlciB1c2luZyB0aGlzIHdoZW5l dmVyIFVTRShDRikgaXMgdHJ1ZS4KIAogc3RhdGljIENGRGF0ZUZvcm1hdHRlclN0eWxlIHN0eWxl RnJvbUFyZ1N0cmluZyhjb25zdCBTdHJpbmcmIHN0cmluZywgQ0ZEYXRlRm9ybWF0dGVyU3R5bGUg ZGVmYXVsdFN0eWxlKQpAQCAtMzM3LDcgKzMzNyw3IEBAIHN0YXRpYyBKU0NlbGwqIGZvcm1hdExv Y2FsZURhdGUoRXhlY1N0YXQKICAgICByZXR1cm4gZm9ybWF0TG9jYWxlRGF0ZShleGVjLCAqZ3Jl Z29yaWFuRGF0ZVRpbWUsIGZvcm1hdCk7CiB9CiAKLSNlbmRpZiAvLyAhUExBVEZPUk0oTUFDKSAm JiAhUExBVEZPUk0oSU9TKQorI2VuZGlmIC8vIE9TKERBUldJTikKIAogc3RhdGljIEVuY29kZWRK U1ZhbHVlIGZvcm1hdGVEYXRlSW5zdGFuY2UoRXhlY1N0YXRlKiBleGVjLCBEYXRlVGltZUZvcm1h dCBmb3JtYXQsIGJvb2wgYXNVVENWYXJpYW50KQogewo=