107464 2013-01-21 11:20:58 -0800 [Blackberry] Static code analysis warning fixes 2013-01-22 14:23:47 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 afscian webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 812283 0 afscian 2013-01-21 11:20:58 -0800 Klocwork issues: 1367,2367,4321,4322 812294 1 183811 afscian 2013-01-21 11:42:11 -0800 Created attachment 183811 patch Klocwork issues: 1367, 2367 Dropped 4321+4322 since they applied to source code that hasn't been upstreamed yet. 813408 2 183811 rwlbuis 2013-01-22 14:19:31 -0800 Comment on attachment 183811 patch LGTM. 813413 3 183811 webkit.review.bot 2013-01-22 14:23:44 -0800 Comment on attachment 183811 patch Clearing flags on attachment: 183811 Committed r140470: <http://trac.webkit.org/changeset/140470> 813414 4 webkit.review.bot 2013-01-22 14:23:47 -0800 All reviewed patches have been landed. Closing bug. 183811 2013-01-21 11:42:11 -0800 2013-01-22 14:23:44 -0800 patch 0001-Blackberry-Static-code-analysis-warning-fixes.patch text/plain 3164 afscian RnJvbSBmNjk2ZjlkYjI3OGM0Mjk3NmRjYjVhNjY0ZGVjYmNhZDY1YzVkMWE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob255IFNjaWFuIDxhc2NpYW5AcmltLmNvbT4KRGF0ZTog TW9uLCAyMSBKYW4gMjAxMyAxNDozNzoxMyAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIFtCbGFja2Jl cnJ5XSBTdGF0aWMgY29kZSBhbmFseXNpcyB3YXJuaW5nIGZpeGVzCiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NDY0CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KCktsb2N3b3JrIGlzc3VlczogMTM2NywgMjM2NwotIGFkZCBOVUxMIHBvaW50ZXIgY2hlY2tz IGRldGVjdGVkIGJ5IHN0YXRpYyBjb2RlIGFuYWx5c2lzCgoqIHBsYXRmb3JtL2JsYWNrYmVycnkv V2lkZ2V0QmxhY2tCZXJyeS5jcHA6CihXZWJDb3JlOjpXaWRnZXQ6OnNldEN1cnNvcik6CiogcGx1 Z2lucy9ibGFja2JlcnJ5L1BsdWdpblZpZXdCbGFja0JlcnJ5LmNwcDoKKFdlYkNvcmU6OlBsdWdp blZpZXc6OnVwZGF0ZVBsdWdpbldpZGdldCk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTUgKysrKysrKysrKysrKysrCiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1dpZGdldEJsYWNrQmVycnkuY3BwICAg fCAgNSArKysrLQogLi4uL1dlYkNvcmUvcGx1Z2lucy9ibGFja2JlcnJ5L1BsdWdpblZpZXdCbGFj a0JlcnJ5LmNwcCAgIHwgIDUgKysrKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGIyZDhiMS4uZmFhNDRkYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTIxICBBbnRob255IFNjaWFuICA8YXNjaWFu QHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrYmVycnldIFN0YXRpYyBjb2RlIGFuYWx5c2lzIHdh cm5pbmcgZml4ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNzQ2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEtsb2N3b3JrIGlzc3VlczogMTM2NywgMjM2NworICAgICAgICAtIGFkZCBOVUxMIHBvaW50 ZXIgY2hlY2tzIGRldGVjdGVkIGJ5IHN0YXRpYyBjb2RlIGFuYWx5c2lzCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ibGFja2JlcnJ5L1dpZGdldEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6V2lkZ2V0OjpzZXRDdXJzb3IpOgorICAgICAgICAqIHBsdWdpbnMvYmxhY2tiZXJyeS9QbHVn aW5WaWV3QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3Ojp1cGRh dGVQbHVnaW5XaWRnZXQpOgorCiAyMDEzLTAxLTIxICBWaWF0Y2hlc2xhdiBPc3RhcGVua28gIDxz bC5vc3RhcGVua29Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF1bUXRdW1dlYkdsXSBSYW5k b20gY3Jhc2ggaW4gR3JhcGhpY3NDb250ZXh0M0Q6OmRyYXdBcnJheXMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvV2lkZ2V0QmxhY2tCZXJyeS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1dpZGdldEJsYWNrQmVycnkuY3BwCmlu ZGV4IDJjMTVlYTQuLmM4OTUyMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2JsYWNrYmVycnkvV2lkZ2V0QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYmxhY2tiZXJyeS9XaWRnZXRCbGFja0JlcnJ5LmNwcApAQCAtNDksNyArNDksMTAgQEAg dm9pZCBXaWRnZXQ6OnBhaW50KEdyYXBoaWNzQ29udGV4dCosIEludFJlY3QgY29uc3QmKQogCiB2 b2lkIFdpZGdldDo6c2V0Q3Vyc29yKEN1cnNvciBjb25zdCYgY3Vyc29yKQogewotICAgIFBsYXRm b3JtUGFnZUNsaWVudCBwYWdlQ2xpZW50ID0gcm9vdCgpLT5ob3N0V2luZG93KCktPnBsYXRmb3Jt UGFnZUNsaWVudCgpOworICAgIFNjcm9sbFZpZXcqIHRoZVJvb3QgPSByb290KCk7CisgICAgaWYg KCF0aGVSb290KQorICAgICAgICByZXR1cm47CisgICAgUGxhdGZvcm1QYWdlQ2xpZW50IHBhZ2VD bGllbnQgPSB0aGVSb290LT5ob3N0V2luZG93KCktPnBsYXRmb3JtUGFnZUNsaWVudCgpOwogCiAg ICAgaWYgKHBhZ2VDbGllbnQpCiAgICAgICAgIHBhZ2VDbGllbnQtPnNldEN1cnNvcihjdXJzb3Iu aW1wbCgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvYmxhY2tiZXJyeS9Q bHVnaW5WaWV3QmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2JsYWNrYmVy cnkvUGx1Z2luVmlld0JsYWNrQmVycnkuY3BwCmluZGV4IGE2MDQ5NzYuLmYyZWQzMTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvYmxhY2tiZXJyeS9QbHVnaW5WaWV3QmxhY2tC ZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ibGFja2JlcnJ5L1BsdWdpblZp ZXdCbGFja0JlcnJ5LmNwcApAQCAtMTA4LDggKzEwOCwxMSBAQCB2b2lkIFBsdWdpblZpZXc6OnVw ZGF0ZVBsdWdpbldpZGdldCgpCiAKICAgICBtX3dpbmRvd1JlY3QgPSBJbnRSZWN0KGZyYW1lVmll dy0+Y29udGVudHNUb1dpbmRvdyhmcmFtZVJlY3QoKS5sb2NhdGlvbigpKSwgZnJhbWVSZWN0KCku c2l6ZSgpKTsKIAorICAgIFNjcm9sbFZpZXcqIHRoZVJvb3QgPSByb290KCk7CisgICAgaWYgKCF0 aGVSb290KQorICAgICAgICByZXR1cm47IC8vIEFTU0VSVChwYXJlbnQoKS0+aXNGcmFtZVZpZXco KSkgc2hvdWxkIHByZXZlbnQgdGhpcyBidXQgY2hlY2sganVzdCBpbiBjYXNlCiAgICAgLy8gTWFw IHJlY3QgdG8gY29udGVudCBjb29yZGluYXRlIHNwYWNlIG9mIG1haW4gZnJhbWUuCi0gICAgbV93 aW5kb3dSZWN0Lm1vdmUocm9vdCgpLT5zY3JvbGxPZmZzZXQoKSk7CisgICAgbV93aW5kb3dSZWN0 Lm1vdmUodGhlUm9vdC0+c2Nyb2xsT2Zmc2V0KCkpOwogCiAgICAgbV9jbGlwUmVjdCA9IGNhbGN1 bGF0ZUNsaXBSZWN0KCk7CiAKLS0gCjEuOC4xCgo=