107461 2013-01-21 10:40:19 -0800 [Qt] QtTestBrowser should provide option to enable/disable Javascript 2013-02-07 08:06:02 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vivekg vivek.vg allan.jensen hausmann jturcotte laszlo.gombos noam ossy vivek.vg webkit.review.bot oldest_to_newest 812258 0 vivekg 2013-01-21 10:40:19 -0800 QtTestBrowser should provide option to enable/disable Javascript. Patch to follow. 812259 1 183804 vivek.vg 2013-01-21 10:44:46 -0800 Created attachment 183804 Patch 812596 2 183888 vivek.vg 2013-01-21 21:53:25 -0800 Created attachment 183888 Patch 812655 3 noam 2013-01-21 23:33:31 -0800 You can do this via web inspector; Do you really need this duplicated in the browser settings? 812658 4 vivekg 2013-01-21 23:40:24 -0800 (In reply to comment #3) > You can do this via web inspector; Do you really need this duplicated in the browser settings? yes I agree. But for a quick test for disabling it we need to open the inspector and then navigate it to the "Inspector settings" and then in the "General" tab to actually disable it. I thought for a test browser that would take a little longer hence introduced this quick menu item. Also one thing I am finding different is that on linux the inspector is not shown inside the QtTestBrowser whereas the same is shown on the mac. 812864 5 jturcotte 2013-01-22 03:17:39 -0800 (In reply to comment #4) It feels like you would be the only one using this menu. QtTestBrowser is more a WebKit developer tool then a web developer tool. Do you see a use case where other developers might want to use this menu? 812867 6 vivekg 2013-01-22 03:23:25 -0800 (In reply to comment #5) > (In reply to comment #4) > It feels like you would be the only one using this menu. QtTestBrowser is more a WebKit developer tool then a web developer tool. > > Do you see a use case where other developers might want to use this menu? I agree. The use case is something like: I am working on [1] and wanted a quick way to verify this bug. Hence I wanted it to quickly provide me an option to enable/disable the Javascript and hence prompted me in adding it to the QtTestBrowser. [1] https://bugs.webkit.org/show_bug.cgi?id=103902 824159 7 vivekg 2013-02-04 02:06:12 -0800 (In reply to comment #5) > (In reply to comment #4) > It feels like you would be the only one using this menu. QtTestBrowser is more a WebKit developer tool then a web developer tool. > > Do you see a use case where other developers might want to use this menu? Another use case is that of browsers (almost all the browsers) providing the option to disable JavaScript execution altogether. So this menu would help simulate that behavior as well. In this case, the users usually disable the option via browser settings as such. 827259 8 183888 jturcotte 2013-02-07 03:28:25 -0800 Comment on attachment 183888 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183888&action=review > Tools/QtTestBrowser/launcherwindow.cpp:501 > + toggleJavaScriptEnabled->setChecked(true); This should read: toggleJavaScriptEnabled->setChecked(settings->testAttribute(QWebSettings::JavascriptEnabled)); > Tools/QtTestBrowser/launcherwindow.cpp:933 > + statusBar()->showMessage(QString("Javascript ") + QString(enable ? "enabled" : "disabled"), 5000); This isn't necessary, the checkbox already tells the user if JS is enabled or not. 827294 9 183888 vivekg 2013-02-07 04:13:20 -0800 Comment on attachment 183888 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183888&action=review Thank you for your feedback. >> Tools/QtTestBrowser/launcherwindow.cpp:501 >> + toggleJavaScriptEnabled->setChecked(true); > > This should read: > toggleJavaScriptEnabled->setChecked(settings->testAttribute(QWebSettings::JavascriptEnabled)); Sure, I will correct this. >> Tools/QtTestBrowser/launcherwindow.cpp:933 >> + statusBar()->showMessage(QString("Javascript ") + QString(enable ? "enabled" : "disabled"), 5000); > > This isn't necessary, the checkbox already tells the user if JS is enabled or not. Agreed. 827296 10 187057 vivek.vg 2013-02-07 04:14:49 -0800 Created attachment 187057 Patch 827524 11 187057 webkit.review.bot 2013-02-07 08:05:57 -0800 Comment on attachment 187057 Patch Clearing flags on attachment: 187057 Committed r142125: <http://trac.webkit.org/changeset/142125> 827525 12 webkit.review.bot 2013-02-07 08:06:02 -0800 All reviewed patches have been landed. Closing bug. 183804 2013-01-21 10:44:46 -0800 2013-01-21 21:53:18 -0800 Patch bug-107461-20130122001140.patch text/plain 3116 vivek.vg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMzI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTkxMTg4MWI0NmNiNWExODNhZjhmOTAxMmE5YzkyNDEz NzIzNTk1ZC4uYTY1NDkyY2ZmMjkyMGFkYjdiODQzYTU0MTcwZjcwY2M3MDA4MTA2YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIx IEBACiAyMDEzLTAxLTIxICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgog CisgICAgICAgIFtRdF0gUXRUZXN0QnJvd3NlciBzaG91bGQgcHJvdmlkZSBvcHRpb24gdG8gZW5h YmxlL2Rpc2FibGUgSmF2YXNjcmlwdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA3NDYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgT3B0aW9uIHRvIGVuYWJsZS9kaXNhYmxlIEphdmFzY3JpcHQgd291bGQg YmUgaGFuZHkgb3B0aW9uIHRvIHRlc3QKKyAgICAgICAgY2VydGFpbiBmdW5jdGlvbmFsaXRpZXMg b2Ygd2ViIHBhZ2VzIHdpdGgvd2l0aG91dCBKYXZhc2NyaXB0LgorCisgICAgICAgICogUXRUZXN0 QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHA6CisgICAgICAgIChMYXVuY2hlcldpbmRvdzo6Y3Jl YXRlQ2hyb21lKToKKyAgICAgICAgKExhdW5jaGVyV2luZG93Ojp0b2dnbGVKYXZhU2NyaXB0RW5h YmxlZCk6CisgICAgICAgICogUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oOgorICAgICAg ICAoTGF1bmNoZXJXaW5kb3cpOgorCisyMDEzLTAxLTIxICBWaXZlayBHYWxhdGFnZSAgPHZpdmVr LnZnQHNhbXN1bmcuY29tPgorCiAgICAgICAgIFF0VGVzdEJyb3dzZXIgc2hvdWxkIHByb3ZpZGUg d2F5IHRvIGNsZWFyIHNlbGVjdGVkIGVsZW1lbnRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc0MzcKIApkaWZmIC0tZ2l0IGEvVG9vbHMvUXRUZXN0 QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAgYi9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVy d2luZG93LmNwcAppbmRleCA4NTUxOTBiNzgxNjg3NThhOTE4MmMzN2MyOWYyYTVjODAwYjFiZGQ1 Li5mOTdmZmE4YzdmZjBlMzE2NDg5YmM2NDc2YjgxOGY4MDZjMzIwM2NhIDEwMDY0NAotLS0gYS9U b29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcAorKysgYi9Ub29scy9RdFRlc3RC cm93c2VyL2xhdW5jaGVyd2luZG93LmNwcApAQCAtNDk2LDYgKzQ5NiwxMCBAQCB2b2lkIExhdW5j aGVyV2luZG93OjpjcmVhdGVDaHJvbWUoKQogI2VuZGlmCiAgICAgdG9nZ2xlU2Nyb2xsQW5pbWF0 b3ItPnNldENoZWNrZWQoZmFsc2UpOwogCisgICAgUUFjdGlvbiogdG9nZ2xlSmF2YVNjcmlwdGVF bmFibGVkID0gc2V0dGluZ3NNZW51LT5hZGRBY3Rpb24oIkVuYWJsZSBKYXZhc2NyaXB0IiwgdGhp cywgU0xPVCh0b2dnbGVKYXZhU2NyaXB0RW5hYmxlZChib29sKSkpOworICAgIHRvZ2dsZUphdmFT Y3JpcHRlRW5hYmxlZC0+c2V0Q2hlY2thYmxlKHRydWUpOworICAgIHRvZ2dsZUphdmFTY3JpcHRl RW5hYmxlZC0+c2V0Q2hlY2tlZCh0cnVlKTsKKwogICAgIFFBY3Rpb24qIHRvZ2dsZUludGVycnVw dGluZ0phdmFTY3JpcHRlRW5hYmxlZCA9IHNldHRpbmdzTWVudS0+YWRkQWN0aW9uKCJFbmFibGUg aW50ZXJydXB0aW5nIGpzIHNjcmlwdHMiLCB0aGlzLCBTTE9UKHRvZ2dsZUludGVycnVwdGluZ0ph dmFTY3JpcHRFbmFibGVkKGJvb2wpKSk7CiAgICAgdG9nZ2xlSW50ZXJydXB0aW5nSmF2YVNjcmlw dGVFbmFibGVkLT5zZXRDaGVja2FibGUodHJ1ZSk7CiAgICAgdG9nZ2xlSW50ZXJydXB0aW5nSmF2 YVNjcmlwdGVFbmFibGVkLT5zZXRDaGVja2VkKGZhbHNlKTsKQEAgLTkyMyw2ICs5MjcsMTIgQEAg dm9pZCBMYXVuY2hlcldpbmRvdzo6dG9nZ2xlRnJhbWVGbGF0dGVuaW5nKGJvb2wgdG9nZ2xlKQog ICAgIHBhZ2UoKS0+c2V0dGluZ3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6RnJhbWVG bGF0dGVuaW5nRW5hYmxlZCwgdG9nZ2xlKTsKIH0KIAordm9pZCBMYXVuY2hlcldpbmRvdzo6dG9n Z2xlSmF2YVNjcmlwdEVuYWJsZWQoYm9vbCBlbmFibGUpCit7CisgICAgcGFnZSgpLT5zZXR0aW5n cygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpKYXZhc2NyaXB0RW5hYmxlZCwgZW5hYmxl KTsKKyAgICBzdGF0dXNCYXIoKS0+c2hvd01lc3NhZ2UoUVN0cmluZygiSmF2YXNjcmlwdCAiKSAr IFFTdHJpbmcoZW5hYmxlID8gImVuYWJsZWQiIDogImRpc2FibGVkIiksIDUwMDApOworfQorCiB2 b2lkIExhdW5jaGVyV2luZG93Ojp0b2dnbGVJbnRlcnJ1cHRpbmdKYXZhU2NyaXB0RW5hYmxlZChi b29sIGVuYWJsZSkKIHsKICAgICBwYWdlKCktPnNldEludGVycnVwdGluZ0phdmFTY3JpcHRFbmFi bGVkKGVuYWJsZSk7CmRpZmYgLS1naXQgYS9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2lu ZG93LmggYi9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmgKaW5kZXggZmIzMTM3 ZGFjZmZjNzdlODcwNDc4ODFhMmE5N2ViOGMxZTU2ZjRhYi4uMTg1ZjIxYjc0MGUyNTA4OGFjZTBh MGZmMzA3MDBjMWEwZDYyYjMxYiAxMDA2NDQKLS0tIGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVu Y2hlcndpbmRvdy5oCisrKyBiL1Rvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaApA QCAtMTYwLDYgKzE2MCw3IEBAIHByb3RlY3RlZCBRX1NMT1RTOgogICAgIHZvaWQgdG9nZ2xlU3Bh dGlhbE5hdmlnYXRpb24oYm9vbCBiKTsKICAgICB2b2lkIHRvZ2dsZUZ1bGxTY3JlZW5Nb2RlKGJv b2wgZW5hYmxlKTsKICAgICB2b2lkIHRvZ2dsZUZyYW1lRmxhdHRlbmluZyhib29sIHRvZ2dsZSk7 CisgICAgdm9pZCB0b2dnbGVKYXZhU2NyaXB0RW5hYmxlZChib29sIGVuYWJsZSk7CiAgICAgdm9p ZCB0b2dnbGVJbnRlcnJ1cHRpbmdKYXZhU2NyaXB0RW5hYmxlZChib29sIGVuYWJsZSk7CiAgICAg dm9pZCB0b2dnbGVKYXZhc2NyaXB0Q2FuT3BlbldpbmRvd3MoYm9vbCBlbmFibGUpOwogICAgIHZv aWQgdG9nZ2xlQXV0b0xvYWRJbWFnZXMoYm9vbCBlbmFibGUpOwo= 183888 2013-01-21 21:53:25 -0800 2013-02-07 04:14:44 -0800 Patch bug-107461-20130122112117.patch text/plain 3113 vivek.vg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMDkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjNjNTAxZTNiMTg4ZjRiM2E4NjRmMTQ4ZTU4MDc3Nzhj OGQxZWJkMi4uNmIzOWMyMzRhZmU4YmUxNWE3ZThmZmEwMjIwMjhmMjQxYzc0MjU0NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIx IEBACiAyMDEzLTAxLTIxICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgog CisgICAgICAgIFtRdF0gUXRUZXN0QnJvd3NlciBzaG91bGQgcHJvdmlkZSBvcHRpb24gdG8gZW5h YmxlL2Rpc2FibGUgSmF2YXNjcmlwdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA3NDYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgT3B0aW9uIHRvIGVuYWJsZS9kaXNhYmxlIEphdmFzY3JpcHQgd291bGQg YmUgaGFuZHkgb3B0aW9uIHRvIHRlc3QKKyAgICAgICAgY2VydGFpbiBmdW5jdGlvbmFsaXRpZXMg b2Ygd2ViIHBhZ2VzIHdpdGgvd2l0aG91dCBKYXZhc2NyaXB0LgorCisgICAgICAgICogUXRUZXN0 QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHA6CisgICAgICAgIChMYXVuY2hlcldpbmRvdzo6Y3Jl YXRlQ2hyb21lKToKKyAgICAgICAgKExhdW5jaGVyV2luZG93Ojp0b2dnbGVKYXZhU2NyaXB0RW5h YmxlZCk6CisgICAgICAgICogUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oOgorICAgICAg ICAoTGF1bmNoZXJXaW5kb3cpOgorCisyMDEzLTAxLTIxICBWaXZlayBHYWxhdGFnZSAgPHZpdmVr LnZnQHNhbXN1bmcuY29tPgorCiAgICAgICAgIFF0VGVzdEJyb3dzZXIgc2hvdWxkIHByb3ZpZGUg d2F5IHRvIGNsZWFyIHNlbGVjdGVkIGVsZW1lbnRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc0MzcKIApkaWZmIC0tZ2l0IGEvVG9vbHMvUXRUZXN0 QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAgYi9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVy d2luZG93LmNwcAppbmRleCA4NTUxOTBiNzgxNjg3NThhOTE4MmMzN2MyOWYyYTVjODAwYjFiZGQ1 Li5hODllODRkOTBkMThmMzIwNzYyNWQ4NWE1ZWE3YjUzMzIxNDdlMGNlIDEwMDY0NAotLS0gYS9U b29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcAorKysgYi9Ub29scy9RdFRlc3RC cm93c2VyL2xhdW5jaGVyd2luZG93LmNwcApAQCAtNDk2LDYgKzQ5NiwxMCBAQCB2b2lkIExhdW5j aGVyV2luZG93OjpjcmVhdGVDaHJvbWUoKQogI2VuZGlmCiAgICAgdG9nZ2xlU2Nyb2xsQW5pbWF0 b3ItPnNldENoZWNrZWQoZmFsc2UpOwogCisgICAgUUFjdGlvbiogdG9nZ2xlSmF2YVNjcmlwdEVu YWJsZWQgPSBzZXR0aW5nc01lbnUtPmFkZEFjdGlvbigiRW5hYmxlIEphdmFzY3JpcHQiLCB0aGlz LCBTTE9UKHRvZ2dsZUphdmFTY3JpcHRFbmFibGVkKGJvb2wpKSk7CisgICAgdG9nZ2xlSmF2YVNj cmlwdEVuYWJsZWQtPnNldENoZWNrYWJsZSh0cnVlKTsKKyAgICB0b2dnbGVKYXZhU2NyaXB0RW5h YmxlZC0+c2V0Q2hlY2tlZCh0cnVlKTsKKwogICAgIFFBY3Rpb24qIHRvZ2dsZUludGVycnVwdGlu Z0phdmFTY3JpcHRlRW5hYmxlZCA9IHNldHRpbmdzTWVudS0+YWRkQWN0aW9uKCJFbmFibGUgaW50 ZXJydXB0aW5nIGpzIHNjcmlwdHMiLCB0aGlzLCBTTE9UKHRvZ2dsZUludGVycnVwdGluZ0phdmFT Y3JpcHRFbmFibGVkKGJvb2wpKSk7CiAgICAgdG9nZ2xlSW50ZXJydXB0aW5nSmF2YVNjcmlwdGVF bmFibGVkLT5zZXRDaGVja2FibGUodHJ1ZSk7CiAgICAgdG9nZ2xlSW50ZXJydXB0aW5nSmF2YVNj cmlwdGVFbmFibGVkLT5zZXRDaGVja2VkKGZhbHNlKTsKQEAgLTkyMyw2ICs5MjcsMTIgQEAgdm9p ZCBMYXVuY2hlcldpbmRvdzo6dG9nZ2xlRnJhbWVGbGF0dGVuaW5nKGJvb2wgdG9nZ2xlKQogICAg IHBhZ2UoKS0+c2V0dGluZ3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6RnJhbWVGbGF0 dGVuaW5nRW5hYmxlZCwgdG9nZ2xlKTsKIH0KIAordm9pZCBMYXVuY2hlcldpbmRvdzo6dG9nZ2xl SmF2YVNjcmlwdEVuYWJsZWQoYm9vbCBlbmFibGUpCit7CisgICAgcGFnZSgpLT5zZXR0aW5ncygp LT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpKYXZhc2NyaXB0RW5hYmxlZCwgZW5hYmxlKTsK KyAgICBzdGF0dXNCYXIoKS0+c2hvd01lc3NhZ2UoUVN0cmluZygiSmF2YXNjcmlwdCAiKSArIFFT dHJpbmcoZW5hYmxlID8gImVuYWJsZWQiIDogImRpc2FibGVkIiksIDUwMDApOworfQorCiB2b2lk IExhdW5jaGVyV2luZG93Ojp0b2dnbGVJbnRlcnJ1cHRpbmdKYXZhU2NyaXB0RW5hYmxlZChib29s IGVuYWJsZSkKIHsKICAgICBwYWdlKCktPnNldEludGVycnVwdGluZ0phdmFTY3JpcHRFbmFibGVk KGVuYWJsZSk7CmRpZmYgLS1naXQgYS9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93 LmggYi9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmgKaW5kZXggZmIzMTM3ZGFj ZmZjNzdlODcwNDc4ODFhMmE5N2ViOGMxZTU2ZjRhYi4uMTg1ZjIxYjc0MGUyNTA4OGFjZTBhMGZm MzA3MDBjMWEwZDYyYjMxYiAxMDA2NDQKLS0tIGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hl cndpbmRvdy5oCisrKyBiL1Rvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaApAQCAt MTYwLDYgKzE2MCw3IEBAIHByb3RlY3RlZCBRX1NMT1RTOgogICAgIHZvaWQgdG9nZ2xlU3BhdGlh bE5hdmlnYXRpb24oYm9vbCBiKTsKICAgICB2b2lkIHRvZ2dsZUZ1bGxTY3JlZW5Nb2RlKGJvb2wg ZW5hYmxlKTsKICAgICB2b2lkIHRvZ2dsZUZyYW1lRmxhdHRlbmluZyhib29sIHRvZ2dsZSk7Cisg ICAgdm9pZCB0b2dnbGVKYXZhU2NyaXB0RW5hYmxlZChib29sIGVuYWJsZSk7CiAgICAgdm9pZCB0 b2dnbGVJbnRlcnJ1cHRpbmdKYXZhU2NyaXB0RW5hYmxlZChib29sIGVuYWJsZSk7CiAgICAgdm9p ZCB0b2dnbGVKYXZhc2NyaXB0Q2FuT3BlbldpbmRvd3MoYm9vbCBlbmFibGUpOwogICAgIHZvaWQg dG9nZ2xlQXV0b0xvYWRJbWFnZXMoYm9vbCBlbmFibGUpOwo= 187057 2013-02-07 04:14:49 -0800 2013-02-07 08:05:57 -0800 Patch bug-107461-20130207174226.patch text/plain 3020 vivek.vg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxOTYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGQ1MzJhMmQ2MWEyZWU4NTU3YTgxNDUzZWZmMDJkY2U0 MjJlOGRhMy4uMWFhMGY3Zjk4MzZmZmFjY2U5NzcyZTk4NWFjMzExZWY0MzA4YzRkMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTAyLTA3ICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtRdF0gUXRUZXN0QnJvd3NlciBzaG91bGQgcHJvdmlkZSBvcHRpb24gdG8gZW5h YmxlL2Rpc2FibGUgSmF2YXNjcmlwdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA3NDYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgT3B0aW9uIHRvIGVuYWJsZS9kaXNhYmxlIEphdmFzY3JpcHQgd291bGQg YmUgaGFuZHkgb3B0aW9uIHRvIHRlc3QKKyAgICAgICAgY2VydGFpbiBmdW5jdGlvbmFsaXRpZXMg b2Ygd2ViIHBhZ2VzIHdpdGgvd2l0aG91dCBKYXZhc2NyaXB0LgorCisgICAgICAgICogUXRUZXN0 QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHA6CisgICAgICAgIChMYXVuY2hlcldpbmRvdzo6Y3Jl YXRlQ2hyb21lKToKKyAgICAgICAgKExhdW5jaGVyV2luZG93Ojp0b2dnbGVKYXZhU2NyaXB0RW5h YmxlZCk6CisgICAgICAgICogUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oOgorICAgICAg ICAoTGF1bmNoZXJXaW5kb3cpOgorCiAyMDEzLTAyLTA1ICBHeXV5b3VuZyBLaW0gIDxneXV5b3Vu Zy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0NNYWtlXSBEb24ndCB3YXJuIHVudXNlZCBj bWFrZSB2YXJpYWJsZXMgd2hpY2ggYXJlbid0IHVzZWQgYnkgY21ha2UgcG9ydHMKZGlmZiAtLWdp dCBhL1Rvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuY3BwIGIvVG9vbHMvUXRUZXN0 QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKaW5kZXggODU1MTkwYjc4MTY4NzU4YTkxODJjMzdj MjlmMmE1YzgwMGIxYmRkNS4uYjhlMDgwYjVkNWMzMWYyNWRiMjBmODE4MDFhMTFhMWIzNGRhNTEz YSAxMDA2NDQKLS0tIGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKKysr IGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKQEAgLTQ5Niw2ICs0OTYs MTAgQEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKCkKICNlbmRpZgogICAgIHRv Z2dsZVNjcm9sbEFuaW1hdG9yLT5zZXRDaGVja2VkKGZhbHNlKTsKIAorICAgIFFBY3Rpb24qIHRv Z2dsZUphdmFTY3JpcHRFbmFibGVkID0gc2V0dGluZ3NNZW51LT5hZGRBY3Rpb24oIkVuYWJsZSBK YXZhc2NyaXB0IiwgdGhpcywgU0xPVCh0b2dnbGVKYXZhU2NyaXB0RW5hYmxlZChib29sKSkpOwor ICAgIHRvZ2dsZUphdmFTY3JpcHRFbmFibGVkLT5zZXRDaGVja2FibGUodHJ1ZSk7CisgICAgdG9n Z2xlSmF2YVNjcmlwdEVuYWJsZWQtPnNldENoZWNrZWQoc2V0dGluZ3MtPnRlc3RBdHRyaWJ1dGUo UVdlYlNldHRpbmdzOjpKYXZhc2NyaXB0RW5hYmxlZCkpOworCiAgICAgUUFjdGlvbiogdG9nZ2xl SW50ZXJydXB0aW5nSmF2YVNjcmlwdGVFbmFibGVkID0gc2V0dGluZ3NNZW51LT5hZGRBY3Rpb24o IkVuYWJsZSBpbnRlcnJ1cHRpbmcganMgc2NyaXB0cyIsIHRoaXMsIFNMT1QodG9nZ2xlSW50ZXJy dXB0aW5nSmF2YVNjcmlwdEVuYWJsZWQoYm9vbCkpKTsKICAgICB0b2dnbGVJbnRlcnJ1cHRpbmdK YXZhU2NyaXB0ZUVuYWJsZWQtPnNldENoZWNrYWJsZSh0cnVlKTsKICAgICB0b2dnbGVJbnRlcnJ1 cHRpbmdKYXZhU2NyaXB0ZUVuYWJsZWQtPnNldENoZWNrZWQoZmFsc2UpOwpAQCAtOTIzLDYgKzky NywxMSBAQCB2b2lkIExhdW5jaGVyV2luZG93Ojp0b2dnbGVGcmFtZUZsYXR0ZW5pbmcoYm9vbCB0 b2dnbGUpCiAgICAgcGFnZSgpLT5zZXR0aW5ncygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdz OjpGcmFtZUZsYXR0ZW5pbmdFbmFibGVkLCB0b2dnbGUpOwogfQogCit2b2lkIExhdW5jaGVyV2lu ZG93Ojp0b2dnbGVKYXZhU2NyaXB0RW5hYmxlZChib29sIGVuYWJsZSkKK3sKKyAgICBwYWdlKCkt PnNldHRpbmdzKCktPnNldEF0dHJpYnV0ZShRV2ViU2V0dGluZ3M6OkphdmFzY3JpcHRFbmFibGVk LCBlbmFibGUpOworfQorCiB2b2lkIExhdW5jaGVyV2luZG93Ojp0b2dnbGVJbnRlcnJ1cHRpbmdK YXZhU2NyaXB0RW5hYmxlZChib29sIGVuYWJsZSkKIHsKICAgICBwYWdlKCktPnNldEludGVycnVw dGluZ0phdmFTY3JpcHRFbmFibGVkKGVuYWJsZSk7CmRpZmYgLS1naXQgYS9Ub29scy9RdFRlc3RC cm93c2VyL2xhdW5jaGVyd2luZG93LmggYi9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2lu ZG93LmgKaW5kZXggZmIzMTM3ZGFjZmZjNzdlODcwNDc4ODFhMmE5N2ViOGMxZTU2ZjRhYi4uMTg1 ZjIxYjc0MGUyNTA4OGFjZTBhMGZmMzA3MDBjMWEwZDYyYjMxYiAxMDA2NDQKLS0tIGEvVG9vbHMv UXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oCisrKyBiL1Rvb2xzL1F0VGVzdEJyb3dzZXIv bGF1bmNoZXJ3aW5kb3cuaApAQCAtMTYwLDYgKzE2MCw3IEBAIHByb3RlY3RlZCBRX1NMT1RTOgog ICAgIHZvaWQgdG9nZ2xlU3BhdGlhbE5hdmlnYXRpb24oYm9vbCBiKTsKICAgICB2b2lkIHRvZ2ds ZUZ1bGxTY3JlZW5Nb2RlKGJvb2wgZW5hYmxlKTsKICAgICB2b2lkIHRvZ2dsZUZyYW1lRmxhdHRl bmluZyhib29sIHRvZ2dsZSk7CisgICAgdm9pZCB0b2dnbGVKYXZhU2NyaXB0RW5hYmxlZChib29s IGVuYWJsZSk7CiAgICAgdm9pZCB0b2dnbGVJbnRlcnJ1cHRpbmdKYXZhU2NyaXB0RW5hYmxlZChi b29sIGVuYWJsZSk7CiAgICAgdm9pZCB0b2dnbGVKYXZhc2NyaXB0Q2FuT3BlbldpbmRvd3MoYm9v bCBlbmFibGUpOwogICAgIHZvaWQgdG9nZ2xlQXV0b0xvYWRJbWFnZXMoYm9vbCBlbmFibGUpOwo=