107453 2013-01-21 08:02:51 -0800 PostMessageTimer in DOMWindow.cpp should be suspendable 2014-02-05 11:10:21 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 yong.li.webkit webkit-unassigned darin oldest_to_newest 812158 0 yong.li.webkit 2013-01-21 08:02:51 -0800 I just noticed that PostMessageTimer defined in DOMWindow.cpp is not ActiveDOMObject, so it can fire (and execute JS) while all ActiveDOMObjects are supposed to be suspended. 812183 1 183791 yong.li.webkit 2013-01-21 08:21:58 -0800 Created attachment 183791 the patch 812249 2 183791 yong.li.webkit 2013-01-21 10:28:17 -0800 Comment on attachment 183791 the patch the delete might be dangerous... it could end up with double delete if the context is destroyed while event is being dispatched. will update the patch 812264 3 183805 yong.li.webkit 2013-01-21 10:47:28 -0800 Created attachment 183805 Safer delete 976936 4 183805 kling 2014-02-05 11:10:21 -0800 Comment on attachment 183805 Safer delete Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 183791 2013-01-21 08:21:58 -0800 2013-01-21 10:28:16 -0800 the patch 107453.diff text/plain 3050 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYjJkNmEwLi4yZmQyNDZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTMtMDEtMjEgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAgICAgUG9zdE1l c3NhZ2VUaW1lciBpbiBET01XaW5kb3cuY3BwIHNob3VsZCBiZSBzdXNwZW5kYWJsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NDUzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgMS4gTWFrZSBQb3N0TWVz c2FnZVRpbWVyIGFuIFN1c3BlbmRhYmxlVGltZXIuCisgICAgICAgIDIuIExldCBpdCBzdXNwZW5k IGF0IHRoZSBzdGFydCBpZiBuZWVkZWQuIChBY3RpdmVET01PYmplY3QgYXNzdW1lcyB0aGF0Cisg ICAgICAgIG11c3QgYmUgZG9uZSkKKyAgICAgICAgMy4gRGVsZXRlIGl0c2VsZiB3aGVuIHRoZSBj b250ZXh0IGlzIGRlc3Ryb3llZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgSSBoYXZlbid0 IHNlZW4gYW4gaXNzdWUgaW4gcmVhbCB3b3JsZCBjYXVzZWQgYnkgdGhpcyBidXQKKyAgICAgICAg aXQganVzdCBzaG91bGQgYmUgZG9uZSBpbiB0aGlzIHdheS4KKworICAgICAgICAqIHBhZ2UvRE9N V2luZG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvc3RNZXNzYWdlVGltZXI6OlBvc3RNZXNz YWdlVGltZXIpOgorICAgICAgICAoV2ViQ29yZTo6UG9zdE1lc3NhZ2VUaW1lcjo6Y29udGV4dERl c3Ryb3llZCk6CisgICAgICAgIChQb3N0TWVzc2FnZVRpbWVyKToKKyAgICAgICAgKFdlYkNvcmU6 OkRPTVdpbmRvdzo6cG9zdE1lc3NhZ2UpOgorCiAyMDEzLTAxLTIxICBWbGFkaXNsYXYgS2F6bmFj aGVldiAgPGthem5hY2hlZXZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtJbnNwZWN0b3JdIExh eW91dCBFbGVtZW50cyBwYW5lbCBpbiBhIHNpbmdsZSBjb2x1bW4gd2hlbiBkb2NrZWQgcmlnaHQu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKaW5kZXggMmY1MWE4MS4uNTE3MWQ2MCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NV2luZG93LmNwcApAQCAtMTA5LDEwICsxMDksMTEgQEAgdXNpbmcgc3RkOjpt YXg7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3MgUG9zdE1lc3NhZ2VUaW1lciA6IHB1 YmxpYyBUaW1lckJhc2UgeworY2xhc3MgUG9zdE1lc3NhZ2VUaW1lciA6IHB1YmxpYyBTdXNwZW5k YWJsZVRpbWVyIHsKIHB1YmxpYzoKICAgICBQb3N0TWVzc2FnZVRpbWVyKERPTVdpbmRvdyogd2lu ZG93LCBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gbWVzc2FnZSwgY29uc3QgU3Ry aW5nJiBzb3VyY2VPcmlnaW4sIFBhc3NSZWZQdHI8RE9NV2luZG93PiBzb3VyY2UsIFBhc3NPd25Q dHI8TWVzc2FnZVBvcnRDaGFubmVsQXJyYXk+IGNoYW5uZWxzLCBTZWN1cml0eU9yaWdpbiogdGFy Z2V0T3JpZ2luLCBQYXNzUmVmUHRyPFNjcmlwdENhbGxTdGFjaz4gc3RhY2tUcmFjZSkKLSAgICAg ICAgOiBtX3dpbmRvdyh3aW5kb3cpCisgICAgICAgIDogU3VzcGVuZGFibGVUaW1lcih3aW5kb3ct PnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkKKyAgICAgICAgLCBtX3dpbmRvdyh3aW5kb3cpCiAg ICAgICAgICwgbV9tZXNzYWdlKG1lc3NhZ2UpCiAgICAgICAgICwgbV9vcmlnaW4oc291cmNlT3Jp Z2luKQogICAgICAgICAsIG1fc291cmNlKHNvdXJjZSkKQEAgLTEyMCw2ICsxMjEsOCBAQCBwdWJs aWM6CiAgICAgICAgICwgbV90YXJnZXRPcmlnaW4odGFyZ2V0T3JpZ2luKQogICAgICAgICAsIG1f c3RhY2tUcmFjZShzdGFja1RyYWNlKQogICAgIHsKKyAgICAgICAgc3RhcnRPbmVTaG90KDApOwor ICAgICAgICBzdXNwZW5kSWZOZWVkZWQoKTsKICAgICB9CiAKICAgICBQYXNzUmVmUHRyPE1lc3Nh Z2VFdmVudD4gZXZlbnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCkKQEAgLTEzNyw2 ICsxNDAsMTIgQEAgcHJpdmF0ZToKICAgICAgICAgLy8gVGhpcyBvYmplY3QgaXMgZGVsZXRlZCBu b3cuCiAgICAgfQogCisgICAgdm9pZCBjb250ZXh0RGVzdHJveWVkKCkKKyAgICB7CisgICAgICAg IFN1c3BlbmRhYmxlVGltZXI6OmNvbnRleHREZXN0cm95ZWQoKTsKKyAgICAgICAgZGVsZXRlIHRo aXM7CisgICAgfQorCiAgICAgUmVmUHRyPERPTVdpbmRvdz4gbV93aW5kb3c7CiAgICAgUmVmUHRy PFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gbV9tZXNzYWdlOwogICAgIFN0cmluZyBtX29yaWdpbjsK QEAgLTg1Niw4ICs4NjUsNyBAQCB2b2lkIERPTVdpbmRvdzo6cG9zdE1lc3NhZ2UoUGFzc1JlZlB0 cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IG1lc3NhZ2UsIGNvbnN0IE1lcwogICAgICAgICBzdGFj a1RyYWNlID0gY3JlYXRlU2NyaXB0Q2FsbFN0YWNrKFNjcmlwdENhbGxTdGFjazo6bWF4Q2FsbFN0 YWNrU2l6ZVRvQ2FwdHVyZSwgdHJ1ZSk7CiAKICAgICAvLyBTY2hlZHVsZSB0aGUgbWVzc2FnZS4K LSAgICBQb3N0TWVzc2FnZVRpbWVyKiB0aW1lciA9IG5ldyBQb3N0TWVzc2FnZVRpbWVyKHRoaXMs IG1lc3NhZ2UsIHNvdXJjZU9yaWdpbiwgc291cmNlLCBjaGFubmVscy5yZWxlYXNlKCksIHRhcmdl dC5nZXQoKSwgc3RhY2tUcmFjZS5yZWxlYXNlKCkpOwotICAgIHRpbWVyLT5zdGFydE9uZVNob3Qo MCk7CisgICAgbmV3IFBvc3RNZXNzYWdlVGltZXIodGhpcywgbWVzc2FnZSwgc291cmNlT3JpZ2lu LCBzb3VyY2UsIGNoYW5uZWxzLnJlbGVhc2UoKSwgdGFyZ2V0LmdldCgpLCBzdGFja1RyYWNlLnJl bGVhc2UoKSk7CiB9CiAKIHZvaWQgRE9NV2luZG93Ojpwb3N0TWVzc2FnZVRpbWVyRmlyZWQoUGFz c093blB0cjxQb3N0TWVzc2FnZVRpbWVyPiB0KQo= 183805 2013-01-21 10:47:28 -0800 2014-02-05 11:10:20 -0800 Safer delete 107453.diff text/plain 3619 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYjJkNmEwLi4xZTc1ZmYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTMtMDEtMjEgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAgICAgUG9zdE1l c3NhZ2VUaW1lciBpbiBET01XaW5kb3cuY3BwIHNob3VsZCBiZSBzdXNwZW5kYWJsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NDUzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgMS4gTWFrZSBQb3N0TWVz c2FnZVRpbWVyIGFuIFN1c3BlbmRhYmxlVGltZXIuCisgICAgICAgIDIuIExldCBpdCBzdXNwZW5k IGF0IHRoZSBzdGFydCBpZiBuZWVkZWQuIChBY3RpdmVET01PYmplY3QgYXNzdW1lcyB0aGF0Cisg ICAgICAgIG11c3QgYmUgZG9uZSkKKyAgICAgICAgMy4gRGVsZXRlIGl0c2VsZiB3aGVuIHRoZSBj b250ZXh0IGlzIGRlc3Ryb3llZCBhbmQgdGhlIHRpbWVyIGhhc24ndCBiZWVuIGZpcmVkIHlldC4K KworICAgICAgICBObyBuZXcgdGVzdHMgYXMgSSBoYXZlbid0IHNlZW4gYW4gaXNzdWUgaW4gcmVh bCB3b3JsZCBjYXVzZWQgYnkgdGhpcyBidXQKKyAgICAgICAgaXQganVzdCBzaG91bGQgYmUgZG9u ZSBpbiB0aGlzIHdheS4KKworICAgICAgICAqIHBhZ2UvRE9NV2luZG93LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlBvc3RNZXNzYWdlVGltZXI6OlBvc3RNZXNzYWdlVGltZXIpOgorICAgICAgICAo V2ViQ29yZTo6UG9zdE1lc3NhZ2VUaW1lcjo6Y29udGV4dERlc3Ryb3llZCk6CisgICAgICAgIChQ b3N0TWVzc2FnZVRpbWVyKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdpbmRvdzo6cG9zdE1lc3Nh Z2UpOgorCiAyMDEzLTAxLTIxICBWbGFkaXNsYXYgS2F6bmFjaGVldiAgPGthem5hY2hlZXZAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtJbnNwZWN0b3JdIExheW91dCBFbGVtZW50cyBwYW5lbCBp biBhIHNpbmdsZSBjb2x1bW4gd2hlbiBkb2NrZWQgcmlnaHQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRv dy5jcHAKaW5kZXggMmY1MWE4MS4uZWU1ZjNkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9ET01XaW5kb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNw cApAQCAtMTA5LDE3ICsxMDksMjEgQEAgdXNpbmcgc3RkOjptYXg7CiAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKIAotY2xhc3MgUG9zdE1lc3NhZ2VUaW1lciA6IHB1YmxpYyBUaW1lckJhc2UgeworY2xh c3MgUG9zdE1lc3NhZ2VUaW1lciA6IHB1YmxpYyBTdXNwZW5kYWJsZVRpbWVyIHsKIHB1YmxpYzoK ICAgICBQb3N0TWVzc2FnZVRpbWVyKERPTVdpbmRvdyogd2luZG93LCBQYXNzUmVmUHRyPFNlcmlh bGl6ZWRTY3JpcHRWYWx1ZT4gbWVzc2FnZSwgY29uc3QgU3RyaW5nJiBzb3VyY2VPcmlnaW4sIFBh c3NSZWZQdHI8RE9NV2luZG93PiBzb3VyY2UsIFBhc3NPd25QdHI8TWVzc2FnZVBvcnRDaGFubmVs QXJyYXk+IGNoYW5uZWxzLCBTZWN1cml0eU9yaWdpbiogdGFyZ2V0T3JpZ2luLCBQYXNzUmVmUHRy PFNjcmlwdENhbGxTdGFjaz4gc3RhY2tUcmFjZSkKLSAgICAgICAgOiBtX3dpbmRvdyh3aW5kb3cp CisgICAgICAgIDogU3VzcGVuZGFibGVUaW1lcih3aW5kb3ctPnNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQoKSkKKyAgICAgICAgLCBtX3dpbmRvdyh3aW5kb3cpCiAgICAgICAgICwgbV9tZXNzYWdlKG1l c3NhZ2UpCiAgICAgICAgICwgbV9vcmlnaW4oc291cmNlT3JpZ2luKQogICAgICAgICAsIG1fc291 cmNlKHNvdXJjZSkKICAgICAgICAgLCBtX2NoYW5uZWxzKGNoYW5uZWxzKQogICAgICAgICAsIG1f dGFyZ2V0T3JpZ2luKHRhcmdldE9yaWdpbikKICAgICAgICAgLCBtX3N0YWNrVHJhY2Uoc3RhY2tU cmFjZSkKKyAgICAgICAgLCBtX2lzRmlyaW5nKGZhbHNlKQogICAgIHsKKyAgICAgICAgc3RhcnRP bmVTaG90KDApOworICAgICAgICBzdXNwZW5kSWZOZWVkZWQoKTsKICAgICB9CiAKICAgICBQYXNz UmVmUHRyPE1lc3NhZ2VFdmVudD4gZXZlbnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4 dCkKQEAgLTEzMywxMCArMTM3LDIwIEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgdmlydHVhbCB2 b2lkIGZpcmVkKCkKICAgICB7CisgICAgICAgIG1faXNGaXJpbmcgPSB0cnVlOwogICAgICAgICBt X3dpbmRvdy0+cG9zdE1lc3NhZ2VUaW1lckZpcmVkKGFkb3B0UHRyKHRoaXMpKTsKICAgICAgICAg Ly8gVGhpcyBvYmplY3QgaXMgZGVsZXRlZCBub3cuCiAgICAgfQogCisgICAgdm9pZCBjb250ZXh0 RGVzdHJveWVkKCkKKyAgICB7CisgICAgICAgIFN1c3BlbmRhYmxlVGltZXI6OmNvbnRleHREZXN0 cm95ZWQoKTsKKworICAgICAgICAvLyBJZiBpdCBpcyBmaXJpbmcsIHRoZSBvd25lcnNoaXAgaGFz IGJlZW4gcGFzc2VkIHRvIERPTVdpbmRvdzo6cG9zdE1lc3NhZ2VUaW1lckZpcmVkLgorICAgICAg ICBpZiAoIW1faXNGaXJpbmcpCisgICAgICAgICAgICBkZWxldGUgdGhpczsKKyAgICB9CisKICAg ICBSZWZQdHI8RE9NV2luZG93PiBtX3dpbmRvdzsKICAgICBSZWZQdHI8U2VyaWFsaXplZFNjcmlw dFZhbHVlPiBtX21lc3NhZ2U7CiAgICAgU3RyaW5nIG1fb3JpZ2luOwpAQCAtMTQ0LDYgKzE1OCw3 IEBAIHByaXZhdGU6CiAgICAgT3duUHRyPE1lc3NhZ2VQb3J0Q2hhbm5lbEFycmF5PiBtX2NoYW5u ZWxzOwogICAgIFJlZlB0cjxTZWN1cml0eU9yaWdpbj4gbV90YXJnZXRPcmlnaW47CiAgICAgUmVm UHRyPFNjcmlwdENhbGxTdGFjaz4gbV9zdGFja1RyYWNlOworICAgIGJvb2wgbV9pc0ZpcmluZzsK IH07CiAKIHR5cGVkZWYgSGFzaENvdW50ZWRTZXQ8RE9NV2luZG93Kj4gRE9NV2luZG93U2V0OwpA QCAtODU2LDggKzg3MSw3IEBAIHZvaWQgRE9NV2luZG93Ojpwb3N0TWVzc2FnZShQYXNzUmVmUHRy PFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gbWVzc2FnZSwgY29uc3QgTWVzCiAgICAgICAgIHN0YWNr VHJhY2UgPSBjcmVhdGVTY3JpcHRDYWxsU3RhY2soU2NyaXB0Q2FsbFN0YWNrOjptYXhDYWxsU3Rh Y2tTaXplVG9DYXB0dXJlLCB0cnVlKTsKIAogICAgIC8vIFNjaGVkdWxlIHRoZSBtZXNzYWdlLgot ICAgIFBvc3RNZXNzYWdlVGltZXIqIHRpbWVyID0gbmV3IFBvc3RNZXNzYWdlVGltZXIodGhpcywg bWVzc2FnZSwgc291cmNlT3JpZ2luLCBzb3VyY2UsIGNoYW5uZWxzLnJlbGVhc2UoKSwgdGFyZ2V0 LmdldCgpLCBzdGFja1RyYWNlLnJlbGVhc2UoKSk7Ci0gICAgdGltZXItPnN0YXJ0T25lU2hvdCgw KTsKKyAgICBuZXcgUG9zdE1lc3NhZ2VUaW1lcih0aGlzLCBtZXNzYWdlLCBzb3VyY2VPcmlnaW4s IHNvdXJjZSwgY2hhbm5lbHMucmVsZWFzZSgpLCB0YXJnZXQuZ2V0KCksIHN0YWNrVHJhY2UucmVs ZWFzZSgpKTsKIH0KIAogdm9pZCBET01XaW5kb3c6OnBvc3RNZXNzYWdlVGltZXJGaXJlZChQYXNz T3duUHRyPFBvc3RNZXNzYWdlVGltZXI+IHQpCg==